This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.
Differential Revision: https://phabricator.services.mozilla.com/D229767
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.
Differential Revision: https://phabricator.services.mozilla.com/D229767
The simplification of browser.css in bug 1844242 caused the close-button
to be hidden in tablet mode alongside the window-resizing buttons.
Revert that change's effect, and add documentation.
Differential Revision: https://phabricator.services.mozilla.com/D228205
Check for Windows 11 tablet mode when setting the UI density. (In
particular, have the UI-density object listen for the signal change,
rather than filtering it through `TabletModeUpdater`.)
This includes a change to the semantics of "tablet-mode-change": it now
signals Win11 tablet mode as distinct from Win10 tablet mode.
Differential Revision: https://phabricator.services.mozilla.com/D224245
Win11's tablet mode is different from Win10's tablet mode in ways both
subtle and gross. Avoid unifying them implicitly, and make it clear that
they should not be unified _explicitly_ without testing.
Unfortunately, Windows 11's API for checking whether the device is in
tablet mode is broken -- it requires one to know whether the device is a
tablet to interpret the return value, but there is no documented API
providing that information. We use a heuristic partly borrowed from
Chromium and partly based on independent investigation.
As all of the code using WindowsUIUtils effectively only checked for
Win10's tablet mode, this commit technically has no functional
changes.
Differential Revision: https://phabricator.services.mozilla.com/D224244
Check for Windows 11 tablet mode when setting the UI density. (In
particular, have the UI-density object listen for the signal change,
rather than filtering it through `TabletModeUpdater`.)
This includes a change to the semantics of "tablet-mode-change": it now
signals Win11 tablet mode as distinct from Win10 tablet mode.
Differential Revision: https://phabricator.services.mozilla.com/D224245
Win11's tablet mode is different from Win10's tablet mode in ways both
subtle and gross. Avoid unifying them implicitly, and make it clear that
they should not be unified _explicitly_ without testing.
Unfortunately, Windows 11's API for checking whether the device is in
tablet mode is broken -- it requires one to know whether the device is a
tablet to interpret the return value, but there is no documented API
providing that information. We use a heuristic partly borrowed from
Chromium and partly based on independent investigation.
As all of the code using WindowsUIUtils effectively only checked for
Win10's tablet mode, this commit technically has no functional
changes.
Differential Revision: https://phabricator.services.mozilla.com/D224244
We also update the browser_private_browsing_window.js test.
The previous test was limited because it was referring to non-existent
"appmenu_newNavigator" and "appmenu_newPrivateWindow".
Differential Revision: https://phabricator.services.mozilla.com/D222507
This removes the security information cache from the lock icon.
Basic testing of how often the cache is used showed that it was only
used rarly (2%-3% of the function calls).
The alternative approach would be to also check whether the cert changed
using `gBrowser.securityUI.secInfo.serverCert`. However, caching the
security information doesn't seem worth the effort here. The cache only
gets used when url is exactly the same (uri.spec). And checking
whether the cert is exactly the same looks more expensive to do each
time vs the slim benefit of rarely not needing to update the UI.
Differential Revision: https://phabricator.services.mozilla.com/D214549
After the previous patch, we don't jank all remote tabs when resizing
the browser, so this can go. This should also make general window
resizing faster.
Differential Revision: https://phabricator.services.mozilla.com/D221996
After the previous patch, we don't jank all remote tabs when resizing
the browser, so this can go. This should also make general window
resizing faster.
Differential Revision: https://phabricator.services.mozilla.com/D221996
Unfortunately the addition in browser-siteProtections.js still makes this a
variable on the browser window, but refactoring the contents of that file to
be module-based is a separate effort.
Differential Revision: https://phabricator.services.mozilla.com/D210434