Marco Bonardo
7abd9bf710
Bug 1388123 - Make autocomplete handle Enter on keydown. r=MattN
...
Some pages, like the Google login form, submit information on keydown, that
causes us to not autocomplete, because we handle keypress instead.
The patch changes autocomplete to happen on keydown.
Unfortunately formautofill also uses keydown and tries to access popup data too
late, thus it needs some hacks to work properly.
In general the formautofill code has too many indirections due to e10s, and that
makes the fix more fragile than we'd want. Ideally content autocomplete should
have its own codebase, rather than sharing the same controller as chrome code.
MozReview-Commit-ID: oAyASmDFm1
2018-06-22 12:37:09 +02:00
Jeff Gilbert
70a22b2878
Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
...
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Boris Zbarsky
a0e4948ccd
Bug 1465875 part 5. Eliminate nsIDOMNSEditableElement. r=qdot
2018-06-01 22:35:23 -04:00
Boris Zbarsky
da0b0353d7
Bug 1465875 part 3. Eliminate C++ use of nsIDOMNSEditableElement. r=qdot
2018-06-01 22:35:22 -04:00
Adrian Wielgosik
929be0f567
Bug 1418078 - Convert XPIDL, C++ users of nsIDOMHTMLInputElement. r=bz
...
MozReview-Commit-ID: 9K5wL93cZ4j
2018-04-18 22:35:09 +02:00
Boris Zbarsky
4038e1d23f
Bug 1455674 part 17. Remove use of nsIDOMElement in non-dom non-JS code. r=qdot
2018-04-26 23:37:34 -04:00
Boris Zbarsky
6fb00d932f
Bug 1457155. Rename various focus manager variables to make it clearer that they're Elements. r=mccr8
2018-04-26 15:28:31 -04:00
shindli
55275cebc3
Backed out 2 changesets (bug 1457155, bug 1457156) for B failures in builds/worker/workspace/build/src/dom/html/HTMLObjectElement.cpp on a CLOSED TREE
...
Backed out changeset 8b2a6b54336c (bug 1457155)
Backed out changeset 4e267d999797 (bug 1457156)
2018-04-27 01:34:37 +03:00
Boris Zbarsky
6764622e9f
Bug 1457155. Rename various focus manager variables to make it clearer that they're Elements. r=mccr8
2018-04-26 15:28:31 -04:00
Boris Zbarsky
00c784322e
Bug 1455052 part 4. Stop using nsIDOMEvent in xpidl interfaces. r=masayuki
...
MozReview-Commit-ID: GIs8DVfduKe
2018-04-20 12:53:17 -04:00
Boris Zbarsky
ced355935b
Bug 1455055 part 7. Clean up remaining HandleEvent implementations. r=masayuki
...
MozReview-Commit-ID: LezJYKK74H5
2018-04-20 00:49:30 -04:00
Boris Zbarsky
65759d684b
Bug 1455055 part 1. Convert nsIDOMEventListener to taking an Event, not an nsIDOMEvent. r=masayuki
...
This does no cleanup other than what's needed to compile. Cleanup coming up in
later patches.
MozReview-Commit-ID: 3sOnkj71n09
2018-04-20 00:49:29 -04:00
Boris Zbarsky
d54406240d
Bug 1449631 part 6. Remove nsIDOMEventTarget::DispatchEvent. r=smaug
...
MozReview-Commit-ID: 8YMgmMwZkAL
2018-04-05 13:42:41 -04:00
Boris Zbarsky
152cd3ba6e
Bug 1447098 part 1. Rename FromContent on various DOM classes to FromNode. r=mystor
...
MozReview-Commit-ID: 202nkbmkwfR
2018-03-21 17:39:04 -04:00
Boris Zbarsky
3352976d14
Bug 1446711 part 5. Get rid of nsIDOMMouseEvent::GetButton. r=qdot
...
MozReview-Commit-ID: AZWzObh01uI
2018-03-20 00:16:06 -04:00
Emilio Cobos Álvarez
0ff849122a
Bug 1442207: Remove unneeded arguments to nsIMutationObserver. r=smaug
...
aDocument is always content->OwnerDoc().
aContainer is always content->GetParent().
Differential Revision: https://phabricator.services.mozilla.com/D664
MozReview-Commit-ID: 4xwPCOnhyIL
2018-03-01 22:45:17 +01:00
Emilio Cobos Álvarez
7a79ccba52
Bug 1441547: Make character data change notifications use a const reference for the info parameter. r=smaug
...
It's not intended to be mutated.
MozReview-Commit-ID: 5nkD1YkidlV
2018-02-27 15:30:27 +01:00
Adrian Wielgosik
b3471f9af4
Bug 1440741 - Remove all members from nsIDOMHTMLFormElement. r=qdot
...
MozReview-Commit-ID: 2UcUy4MkVsM
2018-02-23 19:28:08 +01:00
Masayuki Nakano
46555c3338
Bug 1434837 - Make autocomplete and satchel listen to keypress event at the system event group r=mak
...
The autocomplete module listens to keypress event for both printable keys and
non-printable keys a lot. However, we'll stop dispatching keypress event for
non-printable keys in the default event group of web content. So, autocomplete
should listen to keypress events at the system event group.
Note that it's difficult to change keypress event listeners to keydown event
listeners because if we stop keypress events at preceding keydown event in
autocomplete or satchel module, some other modules fail to handle keydown or
keypress event before autocomplete and it's not easy to investigate which
module's which keypress event listener should be changed to keydown event
listener. Therefore, this patch doesn't do it at least for now.
MozReview-Commit-ID: 7e3aklmKrXu
2018-02-08 22:42:29 +09:00
Boris Zbarsky
d81bb35cf8
Bug 1436508 part 11. Remove the use of the nsIDOMKeyEvent::DOM_VK* constants in C++. r=masayuki
...
MozReview-Commit-ID: Honw0NrVMuV
2018-02-09 11:17:09 -05:00
Boris Zbarsky
5a2494fba7
Bug 1436508 part 7. Remove nsIDOMKeyEvent usage from formfill and spellcheck. r=masayuki
...
The various event header changes are to avoid forcing random places to include nsGlobalWindowInner.h
MozReview-Commit-ID: 4THIjj6kIXv
2018-02-09 11:17:09 -05:00
Josh Matthews
d169301c59
Bug 1436743 - Dispatch events via the docgroup rather than the tabgroup when possible. r=mystor
2018-02-08 15:54:00 -05:00
Paolo Amadini
aa9592d486
Bug 1427364 - Remove showCommentColumn and showImageColumn. r=mak
...
MozReview-Commit-ID: 8RNVaLvZkrY
2018-01-10 15:22:23 +00:00
Boris Zbarsky
b46cdaa78d
Bug 1434318 part 13. Remove nsIDOMDocument::CreateEvent. r=mystor
...
MozReview-Commit-ID: EaUjTLeaQ0n
2018-01-31 15:18:11 -05:00
Boris Zbarsky
95a5e42c52
Bug 1434318 part 2. Stop using nsIContentViewer::GetDOMDocument in C++. r=mystor
...
MozReview-Commit-ID: FoMoVgCngGR
2018-01-31 15:18:09 -05:00
Boris Zbarsky
e924590fac
Bug 1418085 part 3. Stop using nsIDOMHTMLElement in form fill. r=mystor
...
MozReview-Commit-ID: Ax7RUZQCosr
2018-01-30 00:25:36 -05:00
Boris Zbarsky
2e39082c0d
Bug 1432186 part 16. Remove nsIDOMNode's ownerDocument attribute. r=mccr8
...
MozReview-Commit-ID: JqfAFxPBz41
2018-01-29 23:10:52 -05:00
DimiL
8b6d0c4a38
Bug 1407879 - Check password field url against the local whitelist. r=francois
...
MozReview-Commit-ID: 1OqpeWeU1s1
2017-12-19 14:16:23 +08:00
DimiL
ea3c40a569
Bug 1425625 - Fix getting reputation service with wrong interface name. r=francois
...
Fix get service with wrong interface name and a double init issue.
MozReview-Commit-ID: BA0wex06eWb
2017-12-19 09:46:28 +08:00
DimiL
cb870a0cdd
Bug 1407878 - P1. Check URLs against the login reputation service when a password field is focused. r=francois
2017-12-14 10:11:45 +08:00
Sean Lee
66f562ece2
Bug 1398101 - Allow the FormAutofill fields with autocomplete="off" to proceed startSearch. r=MattN
...
MozReview-Commit-ID: 6pZUPY1Fray
2017-09-11 12:11:12 +08:00
Nicholas Nethercote
7dbfdaf890
Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.
...
(Path is actually r=froydnj.)
Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.
MozReview-Commit-ID: 91U22X2NydP
2017-10-03 09:05:19 +11:00
Catalin Badea
fc6ab5f0ea
Bug 651120 - Remove index argument from content removed/appended/inserted notifications. r=peterv
2017-10-03 11:09:08 +01:00
Matthew Noorenberghe
80e800c67b
Bug 1378754 - Don't clear marked fields in nsFormFillController upon a persisted pagehide. r=smaug
...
While moving to a new window (using SwapDocShells), a pagehide event[1] is dispatched causing nsFormFillController to clean up mPwmgrInputs and mAutofillInputs for the document. This commit changes the pagehide handler to not clear the hash tables or mutation observers with persisted=true (which would also fix the same bug in password manager autocomplete).
This approach comes at the cost of increased memory (hash table entries for fields in session history) but would reduce CPU usage compared to the alternative of re-marking password manager and autofill fields upon every pageshow event. This approach also solves the issue of autofill and password manager autocomplete not working after session history navigation.
[1] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/SwapDocShells
MozReview-Commit-ID: 8DFWuFynDex
2017-07-21 13:32:48 -07:00
Matthew Noorenberghe
2d3e8270ae
Bug 1378754 - Add MOZ_LOG logging to nsFormFillController.cpp. r=steveck
...
MozReview-Commit-ID: KJ7TnnlzrGC
2017-07-21 15:32:18 -07:00
Bill McCloskey
ce42826bdf
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Ehsan Akhgari
2b4811fa0d
Bug 1374887 - Remove nsIFormAutoComplete::StopControllingInput() from the C++ side; r=MattN
...
This currently only incurs some XPConnect and exception creation
overhead, as the method has no implementation.
2017-06-21 23:43:37 -04:00
Ehsan Akhgari
b9bffa40b9
Bug 1374893 - Don't handle the input event for inputs that aren't text controls; r=MattN
2017-06-21 23:29:15 -04:00
Carsten "Tomcat" Book
238bf154d5
Backed out changeset 4f6302a98ae4 (bug 1372405)
2017-06-21 13:59:26 +02:00
Bill McCloskey
67e8af4720
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
bbe9441993
Backed out changeset 9846de3bd954 (bug 1372405)
2017-06-20 08:27:02 +02:00
Bill McCloskey
f69608368b
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Ehsan Akhgari
c6aa106d58
Bug 1373063 - Make nsFormFillController::HandleEvent() a bit faster by avoiding some string comparisons; r=MattN
2017-06-15 09:39:30 -04:00
Ehsan Akhgari
8ddf0fb7cd
Bug 1372794 - Cache the form autocomplete service instead of repeatedly getting it in the form fill controller; r=MattN
2017-06-14 08:24:16 -04:00
Jonathan Guillotte-Blouin
e813613649
Bug 1365068 - Added missing brackets & refactored some conditional statements. r=MattN
...
MozReview-Commit-ID: 1eOkjI06RCJ
2017-05-16 15:56:28 -07:00
Ray Lin
d37849aaa3
Bug 1340483 - Part 3. Enable preview function only when input is marked as autofill field. r=heycam
...
MozReview-Commit-ID: FFqYJ3icRd7
2017-03-22 16:55:56 +08:00
Mike Conley
dbab8e7198
Bug 1350243 - Combine e10s and non-e10s code paths when reacting to datalist updates. r=MattN
...
MozReview-Commit-ID: 1O3wAzzwWAR
2017-04-06 16:39:08 -04:00
Johann Hofmann
2852b063d7
Bug 1337772 - Part 1 - Use mousedown instead of contextmenu to avoid showing the password autocomplete. r=MattN
...
MozReview-Commit-ID: EUZ1f6Qdm0c
2017-04-07 00:01:31 +02:00
Olli Pettay
45822311b7
Bug 1351860 - Move mType from HTMLInputElement to nsIFormControl and make GetType non-virtual inlined, r=jessica
2017-03-31 22:49:00 -04:00
Olli Pettay
694b05ce02
Backout Bug 1351860, r=backout
2017-03-31 16:55:32 -04:00