Alexandre Poirot
59fe57c052
Bug 1793396 - [devtools] Use absolute URLs in all usages of loader.lazyRequireGetter. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D158489
2022-10-03 18:57:13 +00:00
Alexandre Poirot
ed5a84b6f8
Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/accessibility. r=jdescottes,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D158369
2022-09-30 15:17:34 +00:00
Mark Banner
3387a89bc7
Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for devtools. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D155167
2022-08-26 13:39:34 +00:00
Nicolas Chevobbe
93119e1e6a
Bug 1688007 - [devtools] Add localized inspectIconTitle prop in Accessible.js . r=jdescottes.
...
This will add proper titles to the icons we display in the accessibility
panel to select a node in the Accessibility Tree or in the inspector (if it's
a dom node).
Assertions are added in tests to ensure we don't regress.
Differential Revision: https://phabricator.services.mozilla.com/D154406
2022-08-12 13:10:04 +00:00
Tetsuharu Ohzeki
505955d0fa
Bug 1508688 - Add UNSAFE_ prefix to React deprecated lifecycle methods in devtools/client/accessibility/. r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D149477
2022-06-16 10:03:09 +00:00
Nicolas Chevobbe
2368685396
Bug 1673882 - [devtools] Fix DOMNode icon in a11y panel sidebar. r=yzen.
...
The panel was using the `highlighterFront` property of the nodeFront, but it was
removed in Bug 1623667, and as a result, highlighting was broken.
To be consistent with the other panels having such capabilities (console, debugger, …),
we now use the toolbox `getHighlighter` function.
This wasn't caught because there wasn't any test covering this behavior; this patch
adds one, that was failing without the fix in Accessible.
Differential Revision: https://phabricator.services.mozilla.com/D95030
2020-10-29 14:52:11 +00:00
Nicolas Chevobbe
45e20cc0c1
Bug 1669956 - [devtools] Update require paths to reps modules. r=jdescottes.
...
Differential Revision: https://phabricator.services.mozilla.com/D93354
2020-10-14 11:24:17 +00:00
Julian Descottes
96670683c4
Bug 1629890 - Use Front/Actor::isDestroyed to replace actorID checks r=nchevobbe
...
Depends on D86325
Differential Revision: https://phabricator.services.mozilla.com/D86356
2020-08-12 11:33:44 +00:00
Yura Zenevich
232c1169be
Bug 1602054 - add cold open DAMP test for the accessibility panel. r=perftest-reviewers,jdescottes,Bebe
...
This is a brand new (and first) DAMP talos test for accessibility panel. "accessibility.cold-open" is similar to other cold open tests such as inspector one. It opens accessibility panel, waits for its UI to render and then closes the toolbox.
Differential Revision: https://phabricator.services.mozilla.com/D80512
2020-06-30 10:26:19 +00:00
Yura Zenevich
bc677ffe34
Bug 1638427 - pass highlight/unhilight props to accessibility panel components instead of using the accessibility walker directly. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D75961
2020-05-20 16:42:06 +00:00
Nicolas Chevobbe
8648a90536
Bug 1620288 - Rename Pool#parent to getParent. r=ochameau.
...
This makes it more obvious that it's a function, and not
a property.
Differential Revision: https://phabricator.services.mozilla.com/D66603
2020-03-16 17:34:32 +00:00
Yura Zenevich
25f0cff70f
Bug 1604594 - make accessibility walker front naming consistent across client. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D58033
2020-02-21 04:35:37 +00:00
Yura Zenevich
8bb7cd89d3
Bug 1604594 - do not pass accessibility walker front to accessible selection/highlighing redux actions. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D58029
2020-02-21 04:35:12 +00:00
Noemi Erli
b5f5402557
Backed out 8 changesets (bug 1599806, bug 1604594, bug 1605435) for causing devtools failures CLOSED TREE
...
Backed out changeset b3b92ce56bbd (bug 1605435)
Backed out changeset 1a125601a5d0 (bug 1604594)
Backed out changeset 9ed06bf20923 (bug 1604594)
Backed out changeset 2125bbef0588 (bug 1604594)
Backed out changeset e9dd08e86da5 (bug 1604594)
Backed out changeset 1ec5fbe50915 (bug 1604594)
Backed out changeset 36b679985b1d (bug 1604594)
Backed out changeset 7563b0c41886 (bug 1599806)
2020-02-10 21:18:49 +02:00
Yura Zenevich
d9841ebb07
Bug 1604594 - make accessibility walker front naming consistent across client. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D58033
2020-02-10 18:12:32 +00:00
Yura Zenevich
1b0a8cb0bd
Bug 1604594 - do not pass accessibility walker front to accessible selection/highlighing redux actions. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D58029
2020-02-10 18:12:13 +00:00
Yura Zenevich
1a845a59ef
Bug 1605404 - Resolve DOM walker inside updateDetails action. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D58013
2020-01-06 14:42:17 +00:00
Julian Descottes
150349d1c5
Bug 1596686 - Use absolute paths for require calls r=gl
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D58243
2019-12-27 12:23:47 +00:00
Razvan Maries
0f5ce38e4c
Backed out changeset 14698fa06ab8 (bug 1596686) for causing perma fails on browser_json_refresh.js.
2019-12-27 14:01:24 +02:00
Julian Descottes
3fa1b45876
Bug 1596686 - Use absolute paths for require calls r=gl
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D58243
2019-12-27 09:09:51 +00:00
Yura Zenevich
54082ee556
Bug 1602516 - ensure that the key for a DOM node property in the sidebar is always DOMNode. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D56420
2019-12-09 19:56:14 +00:00
Yura Zenevich
da973e1bc9
Bug 1592300 - remove all uses of gToolbox from a11y panel. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D54843
2019-11-28 15:37:25 +00:00
Yura Zenevich
e15be16e4a
Bug 1590493 - remove unnecessary calls to actorHasMethod and update supports state across the panel. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D54569
2019-11-28 15:37:18 +00:00
Noemi Erli
0c06b25cea
Backed out 2 changesets (bug 1590493, bug 1592300) for causing ES Lint failure in test_accessible_row_context_menu.html CLOSED TREE
...
Backed out changeset 1a5752d4bceb (bug 1592300)
Backed out changeset 51eac37a4bbf (bug 1590493)
2019-11-28 02:39:42 +02:00
Yura Zenevich
3bff5fec11
Bug 1592300 - remove all uses of gToolbox from a11y panel. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D54843
2019-11-27 15:35:51 +00:00
Yura Zenevich
a0d7fa9a2b
Bug 1590493 - remove unnecessary calls to actorHasMethod and update supports state across the panel. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D54569
2019-11-27 23:04:21 +00:00
Yura Zenevich
fb4527f30f
Bug 1598060 - access accessibility walker front through accessible front wherever possible. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D54528
2019-11-26 19:03:11 +00:00
Gabriel Luong
8bbec40020
Bug 1568157 - Part 4: Replace toolbox.walker with the contextual WalkerFront. r=yulia
...
Differential Revision: https://phabricator.services.mozilla.com/D40317
2019-08-28 11:54:42 +00:00
Gabriel Luong
20052248e9
Bug 1568157 - Part 3: Replace toolbox.highlighter with the contextual HighlighterFront. r=yulia
...
Differential Revision: https://phabricator.services.mozilla.com/D40316
2019-08-27 19:13:45 +00:00
Yura Zenevich
556888b697
Bug 1565460 - add scroll into view preference to the accessibility panel. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D39119
2019-08-12 00:21:56 +00:00
Victor Porof
b7732ae890
Bug 1561435 - Format devtools/client/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D35884
2019-07-05 11:24:38 +02:00
Yura Zenevich
bd3f1140e3
Bug 1541666 - ensure that actors are alive when calling async API to the server. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D26459
2019-04-10 18:36:04 +00:00
Brindusan Cristian
47ab5aded0
Backed out 4 changesets (bug 1541666, bug 1541446, bug 1540904, bug 1540601) for dt failures at browser_accessibility_node_audit.js
...
Backed out changeset 7bcd00bbcb71 (bug 1541666)
Backed out changeset a27b2d203885 (bug 1540904)
Backed out changeset 9f43419c7b40 (bug 1541446)
Backed out changeset e3294a1be947 (bug 1540601)
2019-04-10 07:13:57 +03:00
Yura Zenevich
234d6356e0
Bug 1541666 - ensure that actors are alive when calling async API to the server. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D26459
2019-04-10 00:58:44 +00:00
Michael Ratcliffe
89a6aa6015
Bug 1531845 - Silence various React warnings to help clear up debug mode test logs r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D23115
2019-03-19 15:29:37 +00:00
Patrick Brosset
fb33e924f3
Bug 1527826 - Reflect our github org name change in the m-c code; r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D19748
2019-02-15 09:38:53 +00:00
Yura Zenevich
489af50f29
Bug 1424159 - make virtualized tree nodes tabbable similar to how the inspector markup tree works. r=nchevobbe
...
MozReview-Commit-ID: LfSppQgpI0O
Differential Revision: https://phabricator.services.mozilla.com/D18591
2019-02-13 13:08:14 +00:00
Yura Zenevich
575f52781d
Bug 1518487 - adding new checks section in the accessibility panel's sidebar. r=pbro
...
MozReview-Commit-ID: AAKt7zDvom8
Differential Revision: https://phabricator.services.mozilla.com/D19055
2019-02-12 19:40:24 +00:00
Csoregi Natalia
845ccf6e5f
Backed out 7 changesets (bug 1518487) for failures on devtools/client/accessibility/test/browser/browser_accessibility_sidebar_checks.js. CLOSED TREE
...
Backed out changeset 7a4f96a4d71c (bug 1518487)
Backed out changeset 8031278b4a17 (bug 1518487)
Backed out changeset d55e9ed92676 (bug 1518487)
Backed out changeset fc1687cc488d (bug 1518487)
Backed out changeset 0d2800976a32 (bug 1518487)
Backed out changeset 62f78c63d9f1 (bug 1518487)
Backed out changeset bc6cc126a9b4 (bug 1518487)
2019-02-12 00:33:42 +02:00
Yura Zenevich
379412b976
Bug 1518487 - adding new checks section in the accessibility panel's sidebar. r=pbro
...
MozReview-Commit-ID: AAKt7zDvom8
Differential Revision: https://phabricator.services.mozilla.com/D19055
2019-02-11 20:46:45 +00:00
yulia
595fd05e97
Bug 1508655 - BoxModel highlighter move nodeHighlighter to highlighterFront; r=ochameau
...
Depends on D12319
Differential Revision: https://phabricator.services.mozilla.com/D12320
2018-11-23 10:50:21 +00:00
Mark Banner
3d6aaad3f5
Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D8389
2018-10-19 12:55:39 +00:00
Yura Zenevich
85875eca92
Bug 1492866 - add accessible relations to accessibility panel sidebar. r=pbro
...
MozReview-Commit-ID: 5u8SRnlnFyN
Differential Revision: https://phabricator.services.mozilla.com/D7208
2018-10-11 14:51:35 +00:00
Ciure Andrei
80116c980d
Backed out changeset 2084a929ec4c (bug 1492866) for browser_accessibility_walker.js faiures CLOSED TREE
2018-10-10 23:46:13 +03:00
Yura Zenevich
41a027c596
Bug 1492866 - add accessible relations to accessibility panel sidebar. r=pbro
...
MozReview-Commit-ID: 5u8SRnlnFyN
Differential Revision: https://phabricator.services.mozilla.com/D7208
2018-10-10 19:18:03 +00:00
Yura Zenevich
2c9f96c313
Bug 1490776 - fix noGrip array rendering in a11y panel sidebar. r=gl
...
MozReview-Commit-ID: 4QAPbUBYiCW
Differential Revision: https://phabricator.services.mozilla.com/D5697
2018-09-12 19:31:31 +00:00
J. Ryan Stinnett
969d6f83ae
Bug 1466534 - Centralize DevTools link handling. r=jdescottes
...
This adds a `openContentLink` helper meant for any link controlled by web
content. If there is an associated toolbox open, the toolbox's tab is used to
supply a triggering principal for the link.
MozReview-Commit-ID: 45l5yAPGpZr
2018-06-11 23:42:19 -07:00
Julian Descottes
82711b9a8f
Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
...
MozReview-Commit-ID: F6xUXCgdRE4
2018-06-01 12:36:09 +02:00
Yura Zenevich
54a4538ba8
Bug 1455276 - ensure links in strings can open in Accessible properties. r=nchevobbe
...
MozReview-Commit-ID: 1kjUI8tny0X
2018-05-31 00:08:06 -04:00
Michael Ratcliffe
84b2422f95
Bug 1458206 - telemetry.js: Cleanup toolOpened/toolClosed r=jdescottes
...
The methods have been improved and now live in telemetry.js again.
We use these methods for tools that at least require timing.
MozReview-Commit-ID: 2CqBCA9j3XU
2018-05-04 18:00:04 +01:00