corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
552,954 Commits 1 Branch 0 Tags
57a54029409f70041f5b409f289b0828dbeaf416
Commit Graph

76 Commits

Author SHA1 Message Date
Paolo Amadini
57a5402940 Bug 1481813 - Part 4 - Remove support for adding generic DOM attributes to page actions. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D3011
 2018-08-09 13:22:20 +01:00
Brian Grinstead
1c86f46ecd Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo 
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw
 2018-08-08 15:22:53 -07:00
Dave Townsend
7c2cace29b Bug 1479050: Migrate a number of call-sites to use document.createXULElement. r=bgrins 
Differential Revision: https://phabricator.services.mozilla.com/D2489
 2018-07-31 19:13:38 +00:00
Boris Zbarsky
e98236cf07 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Dale Harvey
8dd42feb6f Bug 1471877 - Add link to share menu to configuration. r=Gijs,mstange 
MozReview-Commit-ID: CCTO9SJJMY6
 2018-06-30 18:35:46 +01:00
Noemi Erli
63c21484c5 Backed out changeset 68859b04588d (bug 1471877) for failures in browser/content/browser-pageActions.js on a CLOSED TREE 2018-07-18 13:32:50 +03:00
Dale Harvey
91d294f3ca Bug 1471877 - Add link to share menu to configuration. r=Gijs,mstange 
MozReview-Commit-ID: CCTO9SJJMY6
 2018-06-30 18:35:46 +01:00
Dão Gottwald
3e1a255f0a Bug 1459907 - Implement new bookmark confirmation. r=mak 
MozReview-Commit-ID: DsTXTKgX72y
 2018-06-23 15:28:47 +02:00
Dale Harvey
3ba334360f Bug 1455310 - Add title data and activity to sharing. r=mstange 
MozReview-Commit-ID: IL4sqvRwSwu
 2018-04-25 08:23:32 +01:00
Cosmin Sabou
40eac17933 Backed out changeset 48b66743b97b (bug 1455310) for xpcshell failures on widget/tests/unit/test_macsharingservice.js. CLOSED TREE 2018-04-27 19:12:07 +03:00
Dale Harvey
6ab60a164b Bug 1455310 - Add title data and activity to sharing. r=mstange 
MozReview-Commit-ID: IL4sqvRwSwu
 2018-04-25 08:23:32 +01:00
Dale Harvey
958a404410 Bug 1454705 - Fix display of share panel in Address bar. r=Gijs 
MozReview-Commit-ID: 9lxU0plGqYa
 2018-04-18 15:48:31 +01:00
Dale Harvey
ceaa136f37 Bug 1363168 - Add support for OSX Share feature. r=Gijs,mstange 
MozReview-Commit-ID: sJXl2If9Ou
 2018-03-12 09:16:51 +00:00
Drew Willcoxon
d63aedcf6c Bug 1450294 - Change the title of the add-search-engine page action. r=Gijs 
MozReview-Commit-ID: GHDXbmkSXfM
 2018-04-11 10:06:01 -07:00
Drew Willcoxon
c74d0af0ad Bug 1449947 - The "Add Search Engine" page action button doesn't respond to clicks when it's in the urlbar. r=Gijs 
MozReview-Commit-ID: 5H9XfRXq8eO
 2018-03-30 09:34:47 -07:00
Drew Willcoxon
bd8f7faa4e Bug 1221539 - Add search engine discovery to the page action menu. Part 2: Add the new action. r=Gijs 
MozReview-Commit-ID: DEEZBwmV0JD
 2018-03-28 11:28:20 -07:00
Drew Willcoxon
0a460e67a4 Bug 1221539 - Add search engine discovery to the page action menu. Part 1: Page action changes. r=Gijs 
MozReview-Commit-ID: DGy3sBibpRW
 2018-03-28 11:28:13 -07:00
Kris Maglione
f8fdf2a409 Bug 1446250: Part 1 - Optimize Photon PageAction update performance. r=Gijs 
The amount of computational complexity and garbage array/string/object
generation for each update to a pageAction property went up astronomically
with the migration of WebExtension page actions to the Photon API. This
resulted in non-trivial talos regression when Screenshots attempted to switch
back to the built-in pageAction API.

These changes fix most of the garbage generation, and reduce a lot of the
duplicated work for each update.

MozReview-Commit-ID: 4uPLnAesdU2
 2018-03-15 21:34:01 -07:00
Paolo Amadini
2721462de9 Bug 1437512 - Part 2 - Remove the "panelmultiview" binding. r=Gijs 
MozReview-Commit-ID: H9R7ahkCr2U
 2018-02-25 18:43:55 +00:00
Paolo Amadini
ff1ddd6adf Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs 
MozReview-Commit-ID: 3VzoxJ3Ociy
 2018-02-06 09:02:27 +00:00
Cosmin Sabou
27ede269b6 Backed out 3 changesets (bug 1434883) for frequent leaks in AbstractThread, AnimationTimeline, Annotators, Array, AsyncFreeSnowWhite, ... on a CLOSED TREE 
Backed out changeset c8115e90ffa8 (bug 1434883)
Backed out changeset 22c83b1d417d (bug 1434883)
Backed out changeset 085796417462 (bug 1434883)
 2018-02-06 16:30:56 +02:00
Paolo Amadini
ea8006dd5d Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs 
MozReview-Commit-ID: 3VzoxJ3Ociy
 2018-02-06 09:02:27 +00:00
Paolo Amadini
f6b0b3a5cf Bug 1432015 - Part 3 - Ensure that views passed to showSubView are added to the list of known views without having to reset the internal _panelViews variable. r=Gijs 
MozReview-Commit-ID: Hld45ghdduv
 2018-01-17 15:04:18 +00:00
Paolo Amadini
01051cc093 Bug 1432015 - Part 2 - Remove the setMainView methods. r=Gijs 
The setMainView method of PanelMultiView controls the "mainview" attribute, which is already set or removed later in the showSubView method. When called at construction time, it changes the mainViewId if there is at least one child in the "panelmultiview" element and the original mainViewId does not already reference the first child. This would be incorrect, but in practice it never happens for either ephemeral or static panels, and can be avoided for the throw-away activated page action panel.

The setMainView method of PanelUI is never called, and this makes the corresponding PanelMultiView method removable.

MozReview-Commit-ID: 5bNidHfKFTA
 2018-01-21 15:59:41 +00:00
Paolo Amadini
f8ef353e81 Bug 1432015 - Part 1 - Fix anchor handling for the action feedback panel. r=Gijs 
Commands started from an activated action panel should not be anchored to the main button, and regression tests should simulate the case where both the main action panel and the individual action button are visible and the action is invoked from the main action panel.

MozReview-Commit-ID: Eg1wP2rRe2d
 2018-01-21 17:01:59 +00:00
Paolo Amadini
a5de33f591 Bug 1417042 - Remove the "panelview" binding. r=Gijs 
MozReview-Commit-ID: 26uQb3pteQd
 2017-12-06 10:37:25 +00:00
Edouard Oger
a1ad9ef027 Bug 1417597 - Show a different feedback message in send tab when we're offline. r=jaws 
MozReview-Commit-ID: Emsx0LwFAE1
 2017-11-16 16:11:46 -05:00
Paolo Amadini
192bb221a0 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs 
MozReview-Commit-ID: IjvSZZUHUMt
 2017-11-21 14:21:32 +00:00
Drew Willcoxon
ca57d75e25 Bug 1417272 - The "Send Tab to Device" page action can be disabled in the page action menu but enabled in the urlbar. r=Gijs 
MozReview-Commit-ID: BZ4CAqG0kkH
 2017-11-15 11:25:45 -08:00
Drew Willcoxon
058e41bcb5 Bug 1417036 - "Save to Pocket" drop down menu glitches. r=Gijs 
MozReview-Commit-ID: 1JPOmQNLn26
 2017-11-15 10:44:47 -08:00
Edouard Oger
63712d8b1c Bug 1304898 - Include why in sync ping. r=tcsc 
MozReview-Commit-ID: G9WnHhuWD7Z
 2017-11-15 17:10:45 -05:00
Drew Willcoxon
7708c2f9fb Bug 1413574 - Hide disabled page actions and offer a "Manage Extension" command for actions in extensions. r=Gijs 
MozReview-Commit-ID: HJpu9Jfi2bB
 2017-11-10 11:06:02 -05:00
Drew Willcoxon
d41c2d5435 Bug 1412170 - Integrate WebExtension page action context menus with the Photon page action context menu: Photon page action changes. r=jaws 
MozReview-Commit-ID: BOEhQEJbUNO
 2017-10-30 17:47:54 -04:00
Phil Ringnalda
c8ae0986f8 Backed out 2 changesets (bug 1412170) for eslint bustage 
Backed out changeset a9a646fe54ec (bug 1412170)
Backed out changeset 8b46ed411edf (bug 1412170)

MozReview-Commit-ID: Et3MnX3ieBe
 2017-10-30 14:21:45 -07:00
Drew Willcoxon
23a3b0cc04 Bug 1412170 - Integrate WebExtension page action context menus with the Photon page action context menu: Photon page action changes. r=jaws 
MozReview-Commit-ID: BOEhQEJbUNO
 2017-10-30 16:53:21 -04:00
Drew Willcoxon
30d6fb86b3 Bug 1395387 - Reconcile WebExtension page actions and Photon page actions: Photon page actions changes. r=Gijs 
MozReview-Commit-ID: 5NOc9N2idRE
 2017-10-27 17:39:38 -04:00
Mark Banner
e47ccbfec3 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop 
MozReview-Commit-ID: H5YVp3rnzGo
 2017-10-26 11:47:01 +01:00
Jared Wein
6b69a645ce Bug 1408135 - Copy URL confirmation message should appear where user selects it. r=mikedeboer 
MozReview-Commit-ID: 99hEGe7Dtgf
 2017-10-19 11:58:53 -04:00
Henrik Adolfsson
5710371885 Bug 1392536 - Add last sync date as tooltip to send to device tab 
MozReview-Commit-ID: BsCoBJXm10B
 2017-10-10 13:50:28 -04:00
Drew Willcoxon
530f991093 Bug 1387141 - Pocket button does not stay red after URL pocketed and animation has finished. r=Gijs 
MozReview-Commit-ID: KQVOUJUOfrx
 2017-10-05 13:03:44 -07:00
Drew Willcoxon
ac48455938 Bug 1385882 - Intermittent browser/base/content/test/urlbar/browser_page_action_menu.js | Test timed out. r=Gijs 
MozReview-Commit-ID: H6BtvGNtMmQ
 2017-10-05 12:45:15 -07:00
Gijs Kruitbosch
8030db146a Bug 1389721 - fix page action menu to deal with not being passed an event, so the 'save link to pocket' context menu works, r=jaws 
This also removes the now-obsolete onBeforeCommand method from the pocket code.

MozReview-Commit-ID: EjrMoAIv3xw
 2017-10-02 20:34:01 +01:00
Gijs Kruitbosch
514cadc9cc Bug 1393843 - add telemetry for page action items and the context menu that enables/disables them, data-review=rweiss, r=adw,rweiss+418169 
MozReview-Commit-ID: E52TGDLgjCC
 2017-09-20 17:32:11 +01:00
Drew Willcoxon
e3b9b7a9a0 Bug 1402721 - Add/edit bookmark panel should open anchored on the page action (ellipsis) button instead of on the identity block (left side of the address bar) when the bookmarks star action is not pinned/visible. r=Gijs 
MozReview-Commit-ID: JMviXx5ov7F
 2017-09-25 13:30:08 -07:00
Gijs Kruitbosch
cbee9f0379 Bug 1397790 - add 'open' active state to urlbar buttons, use a more distinct background colour for it, r=abenson+572682,adw 
MozReview-Commit-ID: 7QrhAB79yNw
 2017-09-19 15:13:25 +01:00
Zibi Braniecki
424682e3b6 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs 
MozReview-Commit-ID: Ie2Xgasg2eN
 2017-09-09 22:17:19 -07:00
Sebastian Hengst
3a807c09ee Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
8c25be70ea Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs 
MozReview-Commit-ID: Ie2Xgasg2eN
 2017-09-09 22:17:19 -07:00
Drew Willcoxon
4ee0451f04 Bug 1397501 - Page actions added to the urlbar should always come before the bookmark star. r=Gijs 
MozReview-Commit-ID: 6pVlr9d0crn
 2017-09-07 16:44:34 -07:00
Drew Willcoxon
a2aa0d2017 Bug 1396053 - Page action urlbar button ordering can get messed up for new windows. r=Gijs 
MozReview-Commit-ID: 1KwrS6tsnhO
 2017-09-04 23:58:27 -07:00