Commit Graph

2728 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
54f1c009a9 Bug 1384542: Move GetParent and IsLinkContext to GeckoStyleContext. r=heycam
MozReview-Commit-ID: C19yGcphixX
2017-07-31 14:32:59 +02:00
Emilio Cobos Álvarez
7477ae9039 Bug 1384542: Remove usage of GetParentAllowServo in the frame constructor. r=bz
MozReview-Commit-ID: HPMzM8p3GSO
2017-07-31 14:29:18 +02:00
Kyle Machulis
ecd34ff2a2 Bug 1279218 - Remove Applet tag; r=bz
Removes applet tag interfaces, and changes HTML5 parser to output
HTMLUnknownElement when tag is found. Removes tag process from various
places in the browser.

MozReview-Commit-ID: 2zHhK2U2esX
2017-07-10 16:00:30 -07:00
Sebastian Hengst
8bbc2381f5 merge mozilla-central to autoland. r=merge a=merge 2017-07-29 11:48:40 +02:00
Sebastian Hengst
a1115605ac Backed out changeset 9a7b90cf8a63 (bug 1361618) for frequently failing accessible/tests/browser/states/browser_test_link.js (bug 1385498). r=backout a=backout
MozReview-Commit-ID: DK2CuaYBPbj
2017-07-29 11:42:39 +02:00
Boris Zbarsky
eeb76a5458 Bug 1324619 part 1. Skip reparenting style contexts in the frame constructor when it's not needed. r=emilio
We don't need to reparent when moving things in/out of anonymous boxes and using the stylo backend.

MozReview-Commit-ID: 8C6ScqTuR9z
2017-07-28 21:11:18 -04:00
J. Ryan Stinnett
d36571b5e6 Bug 1361618 - Remove unnecessary calls to FlushPendingLinkUpdates. r=dbaron
This removes the two calls to `FlushPendingLinkUpdates` in nsCSSFrameConstructor
and GeckoRestyleManager, which appear to have no effect.

Looking through what the pending link code is attempting to do:

* When a new anchor is bound in `BindToTree` we do:
  1. Link::ResetLinkState(false, Link::ElementHasHref());
    * Set link's mLinkState to default (either unvisited or not link)
    * Set element's link mState bits to default (either unvisited or not link)
  2. doc->RegisterPendingLinkUpdate(this);
    * Schedules idle dispatch to run `FlushPendingLinkUpdates` within 1 sec
* In `FlushPendingLinkUpdates`:
  * For each pending link, call element->UpdateLinkState(link->LinkState());
    1. Register link for async history update to get potential future visited
       state
    2. mLinkState is still unvisited / not link until we hear from history, so
       element state is unchanged

Thus, there seems to be no need to call `FlushPendingLinkUpdates` outside of
`BindToTree`, since visited state is always applied async anyway (so it doesn't
work as an optimization to avoid restyling if visited, since that will trigger
later).

MozReview-Commit-ID: KbFuKve1KUi
2017-06-29 11:31:52 -07:00
Bobby Holley
9b25ccada2 Bug 1384769 - Pass TraversalFlags from C++ into Rust. r=emilio
MozReview-Commit-ID: EVUzgnL5coN
2017-07-27 17:49:38 -07:00
Emilio Cobos Álvarez
4b6d7fc287 Bug 1381844: Be more explicit about the kind of style context we handle all the time. r=bholley
MozReview-Commit-ID: E0mdkhU3XBz
2017-07-22 18:02:57 +02:00
Manish Goregaokar
836931eee3 Bug 1382017 part 2 Gecko piece - Remove usage of ServoComputedValues from binding functions; r=xidorn
MozReview-Commit-ID: 3KygTIIMVvF
2017-07-18 23:17:34 -07:00
Wes Kocher
cf25042a64 Backed out changeset 14868b3c13e3 (bug 1373767) for android reftest failures in font-inflation-1.html a=backout CLOSED TREE
MozReview-Commit-ID: 5cpCdxuXNin
2017-07-18 22:40:00 -07:00
Wes Kocher
12432754ec Merge m-c to autoland, a=merge CLOSED TREE
MozReview-Commit-ID: 1XYfqTZv3GF
2017-07-18 18:24:49 -07:00
Manish Goregaokar
25a79e6eaa Bug 1382019 - stylo: Don't crash on null parent contexts in nsCSSFrameConstructor::AddFrameConstructionItemsInternal ; r=emilio a=crashfix CLOSED TREE
MozReview-Commit-ID: 93fXjEnLVLI
2017-07-18 15:14:21 -07:00
Manish Goregaokar
86e90da5c3 Bug 1367904 - Part 10: stylo: Switch Gecko over to ServoStyleContext; r=bholley
MozReview-Commit-ID: EmopKVjEzlz
2017-07-17 21:00:46 -07:00
Ting-Yu Lin
bc3d15a323 Bug 1381017 - Set NODE_DESCENDANTS_NEED_FRAMES from flatten tree parent. r=emilio,tnikkel
MozReview-Commit-ID: 3CBP8vc6OxB
2017-07-17 11:31:31 +08:00
Daniel Holbert
7d9e5f789f Bug 1373767: Always make nsMathMLmathBlockFrame a block formatting context. r=bz
(This makes it behave a bit more like a normal CSS block, and it ensures that
it can provide a float manager to its descendants.)

MozReview-Commit-ID: FmnQYjzD2eD
2017-07-13 15:34:20 -07:00
Emilio Cobos Álvarez
0f56a3a5f4 Bug 1379505: Less fishyness when resolving the style of the document element. r=heycam
Previous to these patches, the style resolution happening on [1] made the style
data stick on the element, so we'd never think it was the initial style, even if
it was.

This was wallpapering the fact that, if that was the initial style, we'd never
have another chance of traversing the document when [2] kicked in.

This somehow just happened to work, but is a very fishy way to get it to work.
Instead, call StyleDocument() properly _before_, and rely on the fact that it
will stop when it has a non-null binding, and only if it fails explicitly style
the children.

This fixes the few XBL test-cases with this patch series that exercise
-moz-bindings on the root element without the root being styled, and makes the
-moz-binding code more consistent in both places of the frame constructor.

[1]: http://searchfox.org/mozilla-central/rev/5dadcbe55b4ddd1e448c06c77390ff6483aa009b/layout/base/nsCSSFrameConstructor.cpp#2526
[2]: 3330653dc8/components/style/traversal.rs (L439)

MozReview-Commit-ID: HbjsD6nYsvX
2017-07-10 14:32:39 +02:00
Emilio Cobos Álvarez
68b703b35f Bug 1377902: Trivially cleanup a bit of the FC code. r=mats
MozReview-Commit-ID: HJKVk7lWp4p
2017-07-05 16:30:24 +02:00
Carsten "Tomcat" Book
27ca4a0973 Backed out changeset 9b2f0f827468 (bug 1377902) for bustage 2017-07-05 16:56:22 +02:00
Emilio Cobos Álvarez
95a7e0dfd1 Bug 1377902: Trivially cleanup a bit of the FC code. r=mats
MozReview-Commit-ID: HJKVk7lWp4p
2017-07-05 16:30:24 +02:00
Hiroyuki Ikezoe
ec24d5e55b Bug 1377648 - Check summary frame instead of summary element on removing the summary. r=heycam
In case of removing summary element, we need to check details *frame* children
instead of details *element* children since the summary element has been
already removed from details element children list.

MozReview-Commit-ID: GEzDId9CYf9
2017-07-05 15:52:37 +09:00
Hiroyuki Ikezoe
ffa2a1877e Bug 1377648 - Use inFlowFrame to check the target frame is summary and its parent is details. r=heycam
Considering the case where the summary element has position:absolute, we need
to use inFlowFrame and its parent instead of aFrame itself.

MozReview-Commit-ID: Ds8xxyBuyO5
2017-07-05 12:39:32 +09:00
Boris Zbarsky
6cfed605fc Bug 1376640. Fix dynamic updates when an inline that sits between a first-letter and its block changes style. r=heycam
MozReview-Commit-ID: 8osMUpYVRvR
2017-06-28 22:19:35 -07:00
Carsten "Tomcat" Book
1370c74581 Backed out changeset 2992d5af6251 (bug 1376640) for assertion failures like Assertion failure: mOwner == ExpectedOwnerForChild(aFrame) (Missed some frame in the hierarchy?) 2017-06-29 08:22:08 +02:00
Boris Zbarsky
2bc0e8180b Bug 1376640. Fix dynamic updates when an inline that sits between a first-letter and its block changes style. r=heycam
MozReview-Commit-ID: 8osMUpYVRvR
2017-06-28 22:19:35 -07:00
Bobby Holley
5affdda532 Bug 1376245 - Hand the already-resolved style directly to servo when creating generated content. r=emilio,r=birtles
This avoids a lot of expensive machinery when we've already computed the style.
2017-06-27 11:39:53 -07:00
Boris Zbarsky
2474e7a108 Bug 1324618 part 8. Implement restyling for first-letter frames. r=emilio
MozReview-Commit-ID: IPUDD1Q6AFq
2017-06-26 23:35:08 -07:00
Boris Zbarsky
9865161718 Bug 1324618 part 4. Implement a way to get the first-letter frame, if any, for a block. r=heycam
MozReview-Commit-ID: 1o0d5ugJ1hj
2017-06-26 23:35:07 -07:00
Carsten "Tomcat" Book
262f4a9ad8 Backed out changeset 049b20a12429 (bug 1324618) for bustage 2017-06-27 10:39:58 +02:00
Carsten "Tomcat" Book
0509f7a5a3 Backed out changeset 169cafc2d5f9 (bug 1324618) 2017-06-27 10:39:39 +02:00
Boris Zbarsky
ba777885f3 Bug 1324618 part 8. Implement restyling for first-letter frames. r=emilio
MozReview-Commit-ID: IPUDD1Q6AFq
2017-06-26 23:35:08 -07:00
Boris Zbarsky
db6e83cd61 Bug 1324618 part 4. Implement a way to get the first-letter frame, if any, for a block. r=heycam
MozReview-Commit-ID: 1o0d5ugJ1hj
2017-06-26 23:35:07 -07:00
Boris Zbarsky
13bbef5402 Bug 1374761 part 2. Properly restyle the various paginated-presentation anonymous boxes. r=heycam
MozReview-Commit-ID: LJqWbyRKp3b
2017-06-21 11:45:14 -04:00
Boris Zbarsky
b5761d0213 Bug 1374761 part 1. Properly restyle the viewport and its child anonymous box when we do a restyle. r=heycam
The child anon box may be an nsHTMLScrollFrame, a nsRootBoxFrame, or a
nsSimplePageSequenceFrame.   nsHTMLScrollFrame already knows how to deal with
its anonymous box kids, nsRootBoxFrame doesn't have any, and the next changeset
will deal with anon box kids of nsSimplePageSequenceFrame.

MozReview-Commit-ID: 2ZV061EhRmc
2017-06-21 11:45:12 -04:00
cku
5384d74c65 Bug 265894 - Part 6. Create symbol frame in nsCSSFrameConstructor. r=heycam
MozReview-Commit-ID: LgO1WKo46Pu
2017-06-14 21:53:34 +08:00
Manish Goregaokar
e8a3c268a8 Bug 1373018 - Part 8: stylo: Move nsStyleContext::SetStyle to GeckoStyleContext; r=bholley
MozReview-Commit-ID: ycXu95whnG
2017-06-10 22:27:45 -07:00
Ting-Yu Lin
d5c5fac26b Bug 1290276 Part 7 - Restyle element and its descendant after loading XBL bindings. r=heycam
MozReview-Commit-ID: 1WiioW3xxMX
2017-06-05 14:21:32 +08:00
Ting-Yu Lin
6599358fae Bug 1290276 Part 3 - Move nsStyleSet's call to SetBindingManager to PresShell::Init(). r=heycam
Delete the NS_WARNING because it's not needed once this bug is fixed.

MozReview-Commit-ID: Ht3ayjSvYW8
2017-06-05 14:33:30 +08:00
L. David Baron
03d37750a7 Bug 1369260 - Remove use of MOZ_ASSERT_IF in layout. r=heycam
As I've said before, as module owner I prefer that MOZ_ASSERT_IF not be
used in the module because I consider it to be unreadable.  However, a
few uses have crept in, and this patch removes them.

I consider it to be unreadable because the name looks like a name that
uses smalltalk-ish naming conventions, i.e., with a part of the name
corresponding to each parameter, in order.  However, the parameters are
in the order opposite the name.

This was written primarily with the vim commands:
:%s/MOZ_ASSERT_IF(\([^,]*\),/MOZ_ASSERT(!\1 ||/
:wn
followed by manual cleanup for indentation and removal of !!.

MozReview-Commit-ID: G6rLbOn7k8d
2017-06-06 22:27:17 -07:00
Mats Palmgren
3009528973 Bug 1367209 part 3 - Add a generic frame state bit, NS_FRAME_HAS_CSS_COUNTERS, to indicate that a frame maybe has some counter styles and thus be known by nsCounterManager. r=jfkthame
If a frame doesn't have that bit then skip mCounterManager.DestroyNodesFor()
when the frame is destroyed because it's definitely not known by
the CounterManager.

MozReview-Commit-ID: Ky3575QvZME
2017-06-04 16:45:15 +02:00
John Schoenick
56fdf7a699 Bug 558184 - Part 4.3 - Load fake plugin handlers as eType_FakePlugin in nsObjectLoadingContent. r=peterv. 2015-05-20 15:30:05 +02:00
Mats Palmgren
49057b2c0a Bug 1369037 - Make the assertions about NS_FRAME_PART_OF_IBSPLIT stricter and update the associated frame properties in nsContainerFrame::DestroyFrom instead of nsFrame::DestroyFrom. r=jfkthame
MozReview-Commit-ID: G8NQ70xzkQU
2017-05-31 21:29:49 +02:00
Mats Palmgren
f53a6843c6 bug 1368547 part 2 - Remove nsFrameManager/PresShell methods dealing with placeholders and introduce a nsIFrame::GetPlaceholderFrame() convenience method. r=jfkthame
MozReview-Commit-ID: GBUiUBqJxhQ
2017-05-31 21:29:49 +02:00
Jonathan Kew
7b40682ff5 Bug 1368249 - Create nsIFrame::AddProperty API for use when the property is known to not already exist, and use to optimize some call sites. r=mats 2017-05-28 13:16:55 +01:00
Sebastian Hengst
99cc01f206 Backed out changeset 59c0589220ec (bug 1368249) unused function GetNormalPosition at nsIFrame.h:1073. r=backout 2017-05-28 15:38:15 +02:00
Jonathan Kew
3a49043e3f Bug 1368249 - Create nsIFrame::AddProperty API for use when the property is known to not already exist, and use to optimize some call sites. r=mats 2017-05-28 13:16:55 +01:00
Jonathan Kew
4dcf0fe444 Bug 1365982 - Attach frame properties to each frame instead of looking them up in a hashtable on the prescontext. r=mats 2017-05-27 12:36:00 +01:00
Xidorn Quan
9c6c25ce2c Bug 1366735 part 3 - Remove SetCounterStyleDirty. r=heycam
When the counter style in the style struct changes, CalcDifference
would return ReconstructFrame, which should cause corresponding use
node to be reconstructed. That means a use node with retired counter
style should always be destroyed in the next flush, so it makes no
sense to reset them anymore.

However, we would still need to mark counter lists dirty because
otherwise their content may not get update when there are changes to
counter styles which are still valid.

MozReview-Commit-ID: FnBPx81StzG
2017-05-23 10:08:50 +10:00
Xidorn Quan
b47214dcef Bug 1366735 part 1 - Change counter functions to use struct rather than nsCSSValue::Array. r=heycam
MozReview-Commit-ID: 4FiOxCOsjtD
2017-05-22 22:51:20 +10:00
Mats Palmgren
bd90393cc1 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz
MozReview-Commit-ID: IbwWM0FL6HF
2017-05-21 17:15:00 +08:00