- different sidebar button icons for expanded, collapsed sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning
- add hover animation to button
Differential Revision: https://phabricator.services.mozilla.com/D223406
- different sidebar button icons for expanded, collapsed and hidden sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning
Differential Revision: https://phabricator.services.mozilla.com/D223406
Since the keyboar navigation is handled in a custom way on toolbars, it is automatically includes any element with `role="button"` in the custom focus order, overwriting the default behavior. But since we have a limited number of controls that function as a submit buttons for the URL and Search bars and this functionality is redundant for keyboard users (who could press `Enter` instead of navigating to this control and pressing an `Enter`), we want to reduce the strain of navigation and exclude those elements from the focus order - even from the custom focus handling. At the same time, we want to keep the interactive role to allow assistive technology to interact with these element, should their users choose to do so.
In this patch, we are adding new `keyNav` attribute to a programmatic button and ensuring the `browser_toolbarKeyNav.js` handler does not include this element in the custom focus order. This would remove a keyboard trap created by the regressor bug 1871596 and would allow for better handling of these exceptions in the future.
Differential Revision: https://phabricator.services.mozilla.com/D199309
This patch removes the use of the "unified extensions" pref and adjust
the existing tests. More clean-ups will be done in follow-ups, e.g. the
removal of `gUnifiedExtensions.isEnabled` and some test-only changes to
no longer create a new window in each test file.
Differential Revision: https://phabricator.services.mozilla.com/D166908
The existing check didn't work for visibility: collapse items.
Before switching to modern flexbox, we were saved by the width==0 check, but
modern flexbox preserves the padding of collapsed items (even though they take
no space and aren't painted).
checkVisibility() is the right thing to check for this, and should also handle
visibility: hidden properly as a bonus.
Differential Revision: https://phabricator.services.mozilla.com/D161501
With the addition of the Firefox View button/tabstrip, there is a new
tabstop that is present at the start of the TabsToolbar. When the
Firefox View button is not present, this new tabstop causes tab
navigation to skip over the selected tab and instead focus the new-tab
button. Then, when trying to navigate backwards from the selected tab,
this tabstop at the front of the TabsToolbar forces us to re-focus the
new-tab button. This is because the tabbrowser-arrowscrollbox-periphery
container has zero width/height which causes the tabstop inside of this
container to be skipped over, which then focuses the new-tab button
instead of the selected tab.
This patch allows zero width nodes to be skipped instead of rejected.
This allows the tabstop within the zero width periphery container to be
the first valid element when navigating forward from the tabstrip,
instead of the new-tab-button that is outside of the <tabs> element.
This restores the previous behavior of a selected tab being the first
focusable item when navigating forward from the end of web content, if
there are no items in the tabstrip.
Differential Revision: https://phabricator.services.mozilla.com/D157351
To resolve this bug, we need page action icons and semantic page action nodes to be separate. That way, we can apply filters to the icons without also filtering the nodes' outlines. This means the semantic meaning of the page action button must move up a level, to the enclosing hbox. This means reverting bug 1482025, so I'd like a11y review on this patch.
Differential Revision: https://phabricator.services.mozilla.com/D114131
To resolve this bug, we need page action icons and semantic page action nodes to be separate. That way, we can apply filters to the icons without also filtering the nodes' outlines. This means the semantic meaning of the page action button must move up a level, to the enclosing hbox. This means reverting bug 1482025, so I'd like a11y review on this patch.
Differential Revision: https://phabricator.services.mozilla.com/D114131
