Simon Friedberger
466ee18416
Bug 1877935 - Enable HTTPS-First for non-default ports r=maltejur,necko-reviewers,devtools-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D225241
2024-10-16 14:55:21 +00:00
Valentin Gosu
9ba80ac078
Bug 1913692 - Write test for mode3 TRR with captive portal login r=necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D220549
2024-09-03 13:07:59 +00:00
Dave Townsend
ab57b0fdc1
Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D202949
2024-03-19 14:59:20 +00:00
Valentin Gosu
7212b60dc1
Bug 1824218 - Close captive portal page even if it navigated to support.mozilla.org r=mconley
...
In bug 1433500 we made the canonical URI be a meta refresh to a SUMO page in
order to show the user useful information if they happen to unlock the captive
portal just as the page is loading.
The portal watcher will close the tab if its location is
http://detectportal.firefox.com/canonical.html , but since the page will do a
meta refresh, its URL might be support.mozilla.org at that point, so we
make sure to also close it if it's already refreshed so it doesn't stick
around and urge the user to file a bug about it :)
Differential Revision: https://phabricator.services.mozilla.com/D200928
2024-02-09 20:12:07 +00:00
Gijs Kruitbosch
532c3bc439
Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Erik Nordin
87592ba425
Bug 1875090 - Rename ContentTaskUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,sgalich
...
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198831
2024-01-19 02:15:34 +00:00
Hanna Jones
7ff3077e75
Bug 1845150 - Update notificationbox usage for captive portal notification r=reusable-components-reviewers,tgiles
...
Can be tested locally by running this code in the browser toolbox:
```js
gBrowser.selectedBrowser.ownerGlobal.CaptivePortalWatcher._showNotification();
```
Depends on D194313
Differential Revision: https://phabricator.services.mozilla.com/D194314
2024-01-10 18:55:31 +00:00
Norisz Fay
0847da64fd
Backed out 7 changesets (bug 1845150) for causing failures on browser_datachoices_notification.js CLOSED TREE
...
Backed out changeset a07c835a4bf7 (bug 1845150)
Backed out changeset 0016d7f4e556 (bug 1845150)
Backed out changeset 46cfe5fe6e6a (bug 1845150)
Backed out changeset 83190b8a08d0 (bug 1845150)
Backed out changeset ada948351267 (bug 1845150)
Backed out changeset 7aa4340bfd96 (bug 1845150)
Backed out changeset 683745289588 (bug 1845150)
2024-01-05 18:52:01 +02:00
Hanna Jones
587032607b
Bug 1845150 - Update notificationbox usage for captive portal notification r=reusable-components-reviewers,tgiles
...
Can be tested locally by running this code in the browser toolbox:
```js
gBrowser.selectedBrowser.ownerGlobal.CaptivePortalWatcher._showNotification();
```
Differential Revision: https://phabricator.services.mozilla.com/D194314
2024-01-05 15:04:19 +00:00
Cosmin Sabou
5d4c4c0f9b
Backed out 7 changesets (bug 1845150) for causing dt failures on browser_screenshot_button_warning. CLOSED TREE
...
Backed out changeset fdc3f1b5e5ae (bug 1845150)
Backed out changeset ba7789c89bdd (bug 1845150)
Backed out changeset 6c405863be54 (bug 1845150)
Backed out changeset f66e8bb15e18 (bug 1845150)
Backed out changeset a75fe63bd39f (bug 1845150)
Backed out changeset 91365291f80f (bug 1845150)
Backed out changeset 7477fd1c48fa (bug 1845150)
2024-01-04 18:53:25 +02:00
Hanna Jones
a754bf45ea
Bug 1845150 - Update notificationbox usage for captive portal notification r=reusable-components-reviewers,tgiles
...
Can be tested locally by running this code in the browser toolbox:
```js
gBrowser.selectedBrowser.ownerGlobal.CaptivePortalWatcher._showNotification();
```
Differential Revision: https://phabricator.services.mozilla.com/D194314
2024-01-04 15:31:13 +00:00
Sylvestre Ledru
2e0e132821
Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Tom Marble
ad50861ef9
Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Marco Bonardo
6874dffc71
Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
...
This should make a bit clearer that it is only starting the load, not waiting
for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Sandor Molnar
5d8dd001ad
Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
...
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
c5fb3dbb49
Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
...
This should make a bit clearer that it is only starting the load, not waiting
for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
Mark Banner
544ecba3af
Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D181159
2023-07-12 13:38:34 +00:00
Mark Banner
91fde42f7b
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Kelsey Gilbert
fcd06bbb82
Bug 1695986 - Fix test to adapt to new behavior. r=Gijs
...
Frustratingly, this test was previously silently malfunctioning. The
test attempts to test that clicking on add-exception causes navigation
to the real page from the cert error page, but these pages have the same
url, so this was silently always passing.
Differential Revision: https://phabricator.services.mozilla.com/D176343
2023-04-26 21:56:47 +00:00
Mark Banner
85d8bc064f
Bug 1826702 - Convert PermissionTestUtils to an ES module. r=permissions-reviewers,settings-reviewers,media-playback-reviewers,pbz,padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D174846
2023-04-06 15:07:56 +00:00
Mike Conley
6fcfbd32fa
Bug 1817320 - Put mochitest manifest files under browser/base/content/test into alphabetical order. r=kcochrane
...
Differential Revision: https://phabricator.services.mozilla.com/D170244
2023-02-17 21:44:52 +00:00
Gijs Kruitbosch
b965c4660a
Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D166179
2023-01-31 11:48:41 +00:00
lyavor
807dece3ac
Bug 1811278 - Add disable next line for all browser/base PART 1 r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D167279
2023-01-25 14:27:43 +00:00
Norisz Fay
a0b145e9b4
Backed out 5 changesets (bug 1811278) for causing lint failures on browser_bug435325.js CLOSED TREE
...
Backed out changeset 715821104ffa (bug 1811278)
Backed out changeset 6f116715687d (bug 1811278)
Backed out changeset 16e69d940e3f (bug 1811278)
Backed out changeset 9dc0451ca213 (bug 1811278)
Backed out changeset 9f60a414e711 (bug 1811278)
2023-01-25 12:46:52 +02:00
lyavor
1975d48e7c
Bug 1811278 - Add disable next line for all browser/base PART 1 r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D167279
2023-01-25 10:15:37 +00:00
Gijs Kruitbosch
5a903703c5
Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D167153
2023-01-19 20:16:42 +00:00
Eemeli Aro
255747caa7
Bug 1734217 - Clean up neterror element display logic and tests. r=prathiksha
...
The neterror page serves a number of different use cases, which effectivly pick and choose elements from the page's DOM to display. Previously this logic was partly defined in the HTML, partly in the CSS, and partly in JS, using a couple of different methods. This change normalises all of that such that:
- All optional elements are initially hidden.
- Hiding is always controlled by an element's `hidden` attribute.
- Setting a CSS `display` style does not override the `hidden` attribute.
In addition to making the page easier to reason about, this allows for the CSS styles of the page to not be considered essential for its display, which means that they (and their dependencies) do not need to be included in `toolkit/themes/shared/minimal-toolkit.jar.inc.mn`.
The HTML and CSS of the page are also somewhat simplified, leaving out unused or unnecessary elements and styles.
Some tests affected by these changes are cleaned up to be slightly less flaky. Some are set to be skipped in verify mode under OS X, as they have a tendency to time out in chaos mode.
Differential Revision: https://phabricator.services.mozilla.com/D157726
2022-10-07 18:40:29 +00:00
Mark Banner
1e3410cbdd
Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
cmastro
7ebb09f349
Bug 1777146 - Removed extraneous CaptivePortalWatcher reference r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D151561
2022-07-20 18:34:01 +00:00
Gijs Kruitbosch
edda40141b
Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 16:16:42 +00:00
Norisz Fay
e1d7571cc8
Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE
...
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
1214ac636b
Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 08:18:51 +00:00
lyavor
ab203bb5ae
Bug 1730920 - Https only mode shouldn't be triggered by the wifi portal code. r=nhnt11,ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D131125
2021-12-13 13:32:11 +00:00
Nihanth Subramanya
37cb986729
Bug 1743148 - Call ensureCaptivePortalTab() directly from NetErrorParent instead of firing an obs notification. r=lyavor,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D132254
2021-12-04 01:49:43 +00:00
Butkovits Atila
a9e6e32d54
Backed out changeset dbd90d486efd (bug 1743148) for causing failures at browser_captivePortal_certErrorUI.js. CLOSED TREE
2021-12-04 01:07:26 +02:00
Nihanth Subramanya
b7500d4b6a
Bug 1743148 - Call ensureCaptivePortalTab() directly from NetErrorParent instead of firing an obs notification. r=lyavor,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D132254
2021-12-03 21:52:41 +00:00
criss
8fae75b99c
Backed out changeset f03fa07c78df (bug 1743148) for causing failures on browser_captivePortal_certErrorUI.js. CLOSED TREE
2021-12-03 22:15:36 +02:00
Nihanth Subramanya
2eda6231db
Bug 1743148 - Call ensureCaptivePortalTab() directly from NetErrorParent instead of firing an obs notification. r=lyavor,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D132254
2021-12-03 19:16:48 +00:00
Butkovits Atila
70c4b4cf6a
Backed out 3 changesets (bug 1724108) as requested by Dan. CLOSED TREE
...
Backed out changeset 0bdbea37f84f (bug 1724108)
Backed out changeset 91aa3dd65624 (bug 1724108)
Backed out changeset 5e57386eae33 (bug 1724108)
2021-08-21 01:06:14 +03:00
Dan Mosedale
1d60ceae2f
Bug 1724108 - Don't send captive-portal-login-success-after-button-pressed in some cases, r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D121936
2021-08-11 22:07:43 +00:00
Dan Mosedale
077962f7de
Bug 1724108 - Only show captive portal VPN promo after button press, r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D121935
2021-08-11 21:22:18 +00:00
Neil Deakin
734124e0f9
Bug 1714337, remove separate high and non-high notification box references, r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D121083
2021-07-28 18:24:42 +00:00
R. Martinho Fernandes
de4f66ca1a
Bug 1597600 - make certificate overrides depend on origin attributes r=keeler,geckoview-reviewers,smaug,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D91962
2021-06-01 06:55:07 +00:00
Dorel Luca
d5c3a7bd8e
Backed out changeset 089c88b9657b (bug 1597600) for XPCshell failures in toolkit/components/cleardata/tests/unit/test_certs.js. CLOSED TREE
2021-05-29 23:31:00 +03:00
R. Martinho Fernandes
a855765213
Bug 1597600 - make certificate overrides depend on origin attributes r=keeler,geckoview-reviewers,smaug,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D91962
2021-05-29 19:34:35 +00:00
Mike Conley
81b37a519c
Bug 1709050 - Suppress the focus ring in the upgrade dialog and some about: pages when they first load. r=Mardak,Gijs
...
Using autofocus="true" or programmatically calling .focus() when there is no pre-existing focused
element causes the :focus-visible to match.
This patch avoids using autofocus="true" on some of our about: pages, and uses
Element.focus({ preventFocusRing: true }) to avoid that when these pages and dialog
first load. Note that this doesn't prevent the focus ring from _ever_ appear, it just
stops it from appearing on first load.
Differential Revision: https://phabricator.services.mozilla.com/D115062
2021-05-21 18:13:29 +00:00
Mark Striemer
b77300e380
Bug 1702327 - Fix captive portal tests r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D110626
2021-04-06 04:26:33 +00:00
Claudia
6648089368
Bug 1625651 - Clean up captive portal tests. r=prathiksha
...
Differential Revision: https://phabricator.services.mozilla.com/D110532
2021-04-05 22:58:33 +00:00
Bogdan Tara
70e86098f5
Backed out changeset 98c3e6255c58 (bug 1597600) for browser_installssl.js failures CLOSED TREE
2020-12-07 21:01:50 +02:00
R. Martinho Fernandes
79ef0b5391
Bug 1597600 - make certificate overrides depend on origin attributes r=keeler,geckoview-reviewers,smaug,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D91962
2020-12-07 17:10:52 +00:00