Commit Graph

47 Commits

Author SHA1 Message Date
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Mark Banner
58280be44c Bug 1312277 - Enable no-unused-vars eslint rule for browser/experiments. r=mossop
MozReview-Commit-ID: FUcMgWy8Vv7
2016-10-17 22:17:05 +01:00
Kris Maglione
47312ecab3 Bug 1294811: Fix external tests that import head_addons.js. r=rhelmer
MozReview-Commit-ID: EWo7Gv9oSsz
2016-08-16 17:02:44 -07:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Benjamin Smedberg
531c5fdb30 Bug 1151086 - Fix experiment filter functions to use the new telemetry environment, r=gfritzsche 2015-06-23 14:56:11 -04:00
Shu-yu Guo
40c62f33a5 Bug 1001090 - Part 5: Fix errors in tests throughout the tree. (r=robcee,gavin) 2014-09-15 16:30:47 -07:00
Georg Fritzsche
40d78cb9d8 Bug 1048793 - Remove Experiments CertUtils usage as PublicKeyPinningService already provides the same functionality. r=mmc 2014-08-08 14:14:22 +02:00
Qeole
046c2fa897 Bug 1032970 - Stopping maxStartTime from incorrectly disabling experiments which have already started. r=gfritzsche 2014-07-18 16:53:20 +02:00
Georg Fritzsche
45eb231580 Bug 1012466 - Test cleanups. r=bsmedberg 2014-07-09 15:17:36 +02:00
Georg Fritzsche
370339b3c5 Bug 1012466 - Properly synchronize experiments shutdown with the AddonManager by using its shutdown barrier. r=bsmedberg 2014-07-08 17:36:24 +02:00
Benjamin Smedberg
1adca680f9 Bug 1017806 - Record and report on optional branches of experiments, so that each experiment doesn't have to re-invent data collection. r=gfritzsche 2014-06-25 15:16:13 -04:00
Georg Fritzsche
803b5d6763 Bug 1021002 - Fix telemetry experiments jsfilter evaluation. r=bsmedberg 2014-06-13 14:50:10 +02:00
Carsten "Tomcat" Book
38549e84bc Merge mozilla-central to fx-team 2014-05-16 14:33:31 +02:00
Georg Fritzsche
a43214f2af Bug 1005270 - Trigger experiments initialization on opening the addon manager UI. r=bsmedberg 2014-05-16 12:56:25 +02:00
David Rajchenbach-Teller
c7714dfe5e Bug 1010289 - Experiments.jsm should now handle its errors. r=bsmedberg 2014-05-15 03:12:00 +02:00
Benjamin Smedberg
ccbf61ff47 Bug 1007710 - Add information about the currently-active experiment to the telemetry ping, r=gfritzsche+vladan 2014-05-15 09:11:01 -04:00
Georg Fritzsche
695df6be84 Bug 1001787 - Add test for foreign experiment addon uninstalls keeping the state properly over restarts. r=bsmedberg 2014-04-29 18:20:45 +02:00
Georg Fritzsche
e2f3027ee4 Bug 989137 - Part 14: Rename functions for associating with Add-on Manager. r=gfritzsche 2014-04-17 15:47:37 +02:00
Georg Fritzsche
73e94d84e4 Bug 989137 - Part 12: Refactor experiment and add-on state management. r=gfritzsche 2014-04-17 15:47:36 +02:00
Georg Fritzsche
f3e4b91157 Bug 989137 - Backout re-ordered patches that conflict with a known-good patch stack: 1ab6bbd62c76, 5c3a195a107e, 73da7e611e92, 2c1a0b0551fb. r=me 2014-04-17 15:47:36 +02:00
Gregory Szorc
943444a11f Bug 989137 - Part 13: Rename functions for associating with Add-on Manager; r=gfritzsche
The previous experiment feature expands the scope of these functions. A
rename was in order.
2014-04-10 13:27:36 -07:00
Georg Fritzsche
b43b05c956 Bug 993084 - Consolidate pref name constants for experiment tests. r=bsmedberg 2014-04-15 18:12:26 +02:00
Gregory Szorc
4fba72f1fb Bug 989137 - Part 10: Add a testing-only JSM for common AddonManager operations; r=Unfocused, r=gfritzsche
There is a lot of boilerplate testing code that performs common
AddonManager operations. Some common operations used for testing
Experiments have been refactored into a testing-only JSM that lives as
part of the Add-ons Manager.
2014-04-04 15:58:29 -07:00
Gregory Szorc
7d5c3ab379 Bug 989137 - Part 9: Ensure add-ons are enabled when they should be; r=Unfocused, r=gfritzsche
Experiment add-ons are disabled by default in the Addon Manager. This
patch will manually enable them if necessary.
2014-04-04 15:58:27 -07:00
Gregory Szorc
7e3c378566 Bug 989137 - Part 8: Prevent unknown experiments from being installed; r=Unfocused
The experiments service insists on being in control of experiments.
Before, it wasn't being as assertive as it needed to be: other browser
components could install experiments behind its back. This patch
reasserts the experiments service as king of experiments add-on
management.
2014-04-04 15:58:26 -07:00
Phil Ringnalda
e77a3a02b3 Backed out 3 changesets (bug 989137) for a sudden influx of xpcshell failures
CLOSED TREE

Backed out changeset 831a3ccce100 (bug 989137)
Backed out changeset d3053c4e4c51 (bug 989137)
Backed out changeset 7e410c1d61e6 (bug 989137)
2014-04-05 20:30:24 -07:00
Gregory Szorc
d0ea1efab2 Bug 989137 - Part 10: Add a testing-only JSM for common AddonManager operations; r=Unfocused, r=gfritzsche
There is a lot of boilerplate testing code that performs common
AddonManager operations. Some common operations used for testing
Experiments have been refactored into a testing-only JSM that lives as
part of the Add-ons Manager.
2014-04-04 15:58:29 -07:00
Gregory Szorc
92b7511b40 Bug 989137 - Part 9: Ensure add-ons are enabled when they should be; r=Unfocused, r=gfritzsche
Experiment add-ons are disabled by default in the Addon Manager. This
patch will manually enable them if necessary.
2014-04-04 15:58:27 -07:00
Gregory Szorc
cdfa651283 Bug 989137 - Part 8: Prevent unknown experiments from being installed; r=Unfocused
The experiments service insists on being in control of experiments.
Before, it wasn't being as assertive as it needed to be: other browser
components could install experiments behind its back. This patch
reasserts the experiments service as king of experiments add-on
management.
2014-04-04 15:58:26 -07:00
Benjamin Smedberg
58278a2cdd Bug 992208 - Add Telemetry Experiments to the package so that they are actually used. Also a basic test that the service exists and can be created. r=gfritzsche 2014-04-04 13:03:29 -04:00
Gregory Szorc
66a1b56284 Bug 989137 - Part 1: Uninstall unknown experiments; r=Unfocused
Before this patch, experiment add-ons may have existed in the Addons
Manager without the Experiments service knowing about them. This detects
these unknown add-ons and uninstalls them. See the in-line comment on
the rationale behind this decision.

The added unit test fails without the Experiments.jsm change.
2014-03-26 22:20:23 -07:00
Georg Fritzsche
05042e7668 Bug 986040 - Telemetry experiments: Assure that no experiment addon is running yet before starting an experiment. r=Unfocused 2014-03-27 14:26:59 -07:00
Georg Fritzsche
fa565ea435 Bug 986261 - Telemetry experiments unit tests hang when they fail. r=felipe 2014-03-27 14:55:36 +01:00
Georg Fritzsche
a336a5bb08 Bug 987207 - Telemetry experiments - Assure proper saving & loading from the cache. r=felipe 2014-03-25 17:50:24 +01:00
Benjamin Smedberg
1ca53d56af Bug 987225 - Combine the various tasks in Experiments.jsm to a single serial task. r=gfritzsche (delegated from felipe). Also fixes:
* no need to pass an addon/experiment ID to .disableExperiment()
* fix multiple-logging when multiple Experiments() objects are created as in tests
* ensures that all dirty writes actually get written
2014-03-25 13:50:34 -04:00
Georg Fritzsche
128f183671 Bug 985670 - Telemetry experiments: Decouple experiment and addon ids. r=felipe 2014-03-24 09:58:57 +01:00
Georg Fritzsche
48f8d0b008 Bug 985670 - Telemetry experiments: Don't schedule incorrect timer when there is no pending experiment. r=felipe 2014-03-24 09:58:57 +01:00
Georg Fritzsche
b203565edc Bug 984387 - Telemetry experiments: test coverage for disabling and removal of experiments via manifest. r=felipe 2014-03-24 09:58:56 +01:00
Gregory Szorc
49ac0afc11 Bug 974024 - Add FHR recording of Telemetry Experiments activity; r=bsmedberg 2014-03-20 14:16:00 -07:00
Georg Fritzsche
a0d9f076c3 Bug 984014 - Telemetry experiments - Test experiment update. r=felipe 2014-03-18 22:52:30 +01:00
Georg Fritzsche
61a6fabe2d Bug 979474 - Disable certificate checks for telemetry experiment checks. r=felipe 2014-03-18 22:52:30 +01:00
Georg Fritzsche
fd19428b8f Bug 974009 - Telemetry experiments - Tests 4 - Experiments API. r=felipe 2014-03-18 22:52:29 +01:00