Commit Graph

704 Commits

Author SHA1 Message Date
Florian Quèze
017f2d4b15 Bug 1383749 - One-off buttons should be cached the first time, r=mak. 2017-07-24 22:54:48 +02:00
Evan Tseng
f7fbbb5f30 Bug 1365133 - Reorganize Preferences sections and regroup <xul:groupbox> elements by new categories - Part 1. r=jaws
MozReview-Commit-ID: Lh8iduzVoad
2017-06-16 16:24:33 +08:00
Sebastian Hengst
047261c505 Backed out changeset fb02b6e36ae3 (bug 1365133) 2017-07-14 11:34:48 +02:00
Evan Tseng
5ad0610898 Bug 1365133 - Update tests - Part 2. r=jaws
MozReview-Commit-ID: GoOXdJ4RfY9
2017-06-20 15:11:46 +08:00
Florian Quèze
801f7b2eea Bug 1104325 - [Windows HiDPI] expand the awesomebar panel workaround to also apply to the searchbar so that one-off buttons are laid out correctly even when there are rounding issues, r=adw. 2017-07-11 23:29:58 +02:00
Florian Quèze
113bf2dde7 Bug 1361195 - round the searchbar min-width to ensure one-off buttons are correctly sized on HiDPI, r=past. 2017-06-23 16:25:45 +02:00
Florian Quèze
c0468168f5 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Mark Banner
5a0103e537 Bug 1320230 - When monitoring for the search popup hiding on click, use dispatchToMainThread to reset the status rather than setTimeout as it is more reliable. r=florian
MozReview-Commit-ID: Gjr0UXr1Mf7
2017-06-13 23:05:15 +01:00
Ricky Chien
a57bffe5b7 Bug 1372528 - Change search settings redirects to General section of about:preferences r=jaws
MozReview-Commit-ID: J5biFoOjsXX
2017-06-15 16:22:43 +08:00
Florian Quèze
bb81e740de Bug 1371860 - The 'Search' placeholder should appear immediately on about:home and about:newtab, r=nhnt11. 2017-06-13 08:39:39 +02:00
Wes Kocher
68f16e8419 Merge inbound to central, a=merge
MozReview-Commit-ID: IrZXJHbiqpa
2017-06-09 15:28:10 -07:00
Florian Quèze
7f1db90400 Bug 1369705 - avoid starting the search service or calling the search-one-offs XBL constructor before first paint, r=adw. 2017-06-09 15:11:03 +02:00
Ed Lee
f62a4cebdc Bug 1371479 - Update search behavior about:newtab tests to work with activity-stream.enabled true and false. r=ursula
Update tests to select the search input for either about:newtab with a querySelector instead of specific id. Also removes gSearch checks that are always false anyway with the move to e10s contentSearch.

MozReview-Commit-ID: 8knCvfzA6yk
2017-06-08 16:44:38 -07:00
Drew Willcoxon
4047e6f5e7 Bug 1357800 - The One-Off search buttons not visible in the search bar. r=florian
Rebuild the one-off search buttons when the theme changes.  See bug 1357800 for details.  Summary: On Linux, switching between themes can cause a row of buttons to disappear.

MozReview-Commit-ID: 8lfsUO00jYP
2017-05-17 15:58:56 -07:00
Panos Astithas
3095a325b8 Bug 1359056 - Don't open the search panel when entering customization mode. r=Gijs
MozReview-Commit-ID: XmNZMrizET
2017-05-12 21:40:54 -04:00
Carsten "Tomcat" Book
d4006b93b2 merge mozilla-inbound to mozilla-central a=merge 2017-05-16 15:04:38 +02:00
Christoph Kerschbaumer
5452a95b49 Bug 1362993 - Rewrite gBrowser.addTab() to use BrowserTestUtils.addTab(). r=florian 2017-05-15 21:49:50 +02:00
Fischer.json
b2508dd4e6 Bug 1330315 - Add a telemetry probe to track how the Preferences are opened, r=mconley
MozReview-Commit-ID: GfuGF4v30pI
2017-05-09 10:43:48 -04:00
Florian Quèze
38c24463e4 Bug 1353542 - Cleanup the script output and fix tests, r=Mossop. 2017-05-12 14:54:05 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Wes Kocher
01722415ae Backed out changeset 75a14f02f6f7 (bug 1330315) for build failures in TelemetryHistogramData.inc a=backout
MozReview-Commit-ID: KKnLXDjgmqC
2017-05-10 10:45:18 -07:00
Fischer.json
fb54da55cf Bug 1330315 - Add a telemetry probe to track how the Preferences are opened, r=mconley
MozReview-Commit-ID: GfuGF4v30pI
2017-05-09 10:43:48 -04:00
Johann Hofmann
2065f19b08 Bug 1352364 - Disable browser_oneOffHeader.js on OSX. rs=dao
This test went intermittent through bug 1352364 but we can't
reproduce it locally and opened bug 1361276 to not block progress.

MozReview-Commit-ID: 60NG4j17279
2017-05-02 09:31:42 +02:00
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Sebastian Hengst
ef04a097f2 merge mozilla-central to autoland. r=merge a=merge 2017-04-22 10:49:35 +02:00
Marco Bonardo
55d86141b2 Bug 1358503 - memoize anon elements in the oneoffs binding. r=florian
MozReview-Commit-ID: JKmfd7cUfRx
2017-04-21 16:05:46 +02:00
Wes Kocher
a76c3859c5 Merge m-c to inbound, a=merge
MozReview-Commit-ID: Cb0b59wJ0vy
2017-04-21 17:35:24 -07:00
Florian Queze
ca04360b3c Bug 1358382 - Compute the searchbar panel size and position without sync reflow, r=adw. 2017-04-22 02:09:05 +02:00
Drew Willcoxon
3ab648855f Bug 1357458 - After Customization - typed text in the Awesome bar doesn't correspond with the text from One-Off-Searches bar. r=florian
MozReview-Commit-ID: KHAoxS1CsWj
2017-04-20 19:00:26 -07:00
Carsten "Tomcat" Book
5c743100d6 merge mozilla-inbound to mozilla-central a=merge 2017-04-19 10:32:48 +02:00
Florian Queze
60af5678ae Bug 1312999 - Cache one-off buttons instead of regenerating them at every popupopen, r=adw. 2017-04-19 00:04:07 +02:00
Drew Willcoxon
8756a9f45b Bug 1295460 - Update the background color of the one-off search buttons. r=florian
MozReview-Commit-ID: 3iKLQcb59aT
2017-04-10 19:07:57 -07:00
Zibi Braniecki
8c433fc56a Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
2017-03-11 18:43:11 -08:00
Sebastian Hengst
017c2ee2bf Backed out changeset 60d72c2dd49d (bug 1346616) for eslint failure in DirectoryLinksProvider.jsm. r=backout on a CLOSED TREE 2017-04-18 00:48:16 +02:00
Zibi Braniecki
64bae2dccf Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
2017-03-11 18:43:11 -08:00
Sebastian Hengst
a1e759a614 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JpAhOPjgvkF
2017-04-15 19:59:24 +02:00
Florian Queze
ddf0cda8da Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Drew Willcoxon
853b58abfd Bug 1353831 - OneOff block in search bar doesn't update text if Customize was opened at least once. r=florian
MozReview-Commit-ID: Iu7xhCbCh6B
2017-04-14 16:34:41 -07:00
Drew Willcoxon
01cf26a2ce Bug 1334615 - Add a probe to determine whether the keyboard or the mouse was used to select an action. r=bsmedberg,mak
MozReview-Commit-ID: G3K2l6jnCR8
2017-04-14 17:27:51 -07:00
Sebastian Hengst
e8fb081f5e Backed out changeset 3742522c4533 (bug 1353831) for failing at least test_focus_autocomplete.xul in a11y suite on OSX 10.10 debug. r=backout 2017-04-15 00:00:29 +02:00
Drew Willcoxon
089e1e6318 Bug 1353831 - OneOff block in search bar doesn't update text if Customize was opened at least once. r=florian
MozReview-Commit-ID: Iu7xhCbCh6B
2017-04-11 07:17:27 -07:00
RyanBRiley
bb3ea0d914 Bug 1353711 - Changing reference to this.AppConstants to parent AppConstants, removing local AppConstants field r=dao
MozReview-Commit-ID: Hgo4FjreOos
2017-04-13 18:45:00 -06:00
Sebastian Hengst
5122250f11 Bug 1352161 - Fix search engine installation from searchbar. r=florian
MozReview-Commit-ID: B9JbHknJLC5
2017-03-31 00:27:05 +02:00
Drew Willcoxon
3099774257 Bug 1295458 - Rework key and mouse handling for the one-off search buttons. r=florian
MozReview-Commit-ID: DKbU8r2BrA8
2017-04-11 08:40:11 -07:00
Jared Wein
b09cc0f2c3 Bug 1353808 - Only show the 'Search' preferences when the Manage Search Engines button is clicked. r=mconley
MozReview-Commit-ID: 2sVbayD6tPf
2017-04-05 23:38:30 -04:00
Zack Herrick
50c0d3d538 Bug 1335907 - Reorganize the preferences based on feedback from user research. r=mconley
The FX_PREFERENCES_CATEGORY_OPENED probe must be extended to version 59 to support the fallback "forked" preference implementation (in-content-old).

The switchToAdvancedSubPane within utilityOverlay's openPreferences must also remain until the fallback has been removed (bug 1349689).

Patch co-authored by Zack Herrick <herrickz@msu.edu> and Ziyan Long <lzylong@gmail.com>.

MozReview-Commit-ID: 1sx0Wj15yM7
2017-03-29 11:52:08 -04:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6
2017-03-20 12:36:37 +01:00
CactusTribe
f43e104f1d Bug 1214284 - Adding engine title and line separator in tooltip of button add search engine, r=florian. 2017-03-11 12:51:18 +01:00