Commit Graph

117 Commits

Author SHA1 Message Date
Alessio Placitelli
fb1215c209 Bug 1312182 - Consolidate the uses of MOZ_TELEMETRY_REPORTING in the code. r=flod,gfritzsche,jaws
The MOZ_TELEMETRY_REPORTING define does not control whether or not Telemetry is enabled
but rather if it will send the gathered data to Mozilla servers. We still want to
display the about:preferences options and let developers know about this behaviour.
Please note that this patch is not changing any behaviour: it's only making it explicit
by showing the options as disabled rather than hiding them.

MozReview-Commit-ID: 7A0y0E0hm0Q
2017-05-30 10:42:42 +02:00
Sebastian Hengst
ef0c39fb4c Backed out changeset 7f1e5af6138b (bug 1312182) for failing e.g. browser-chrome's browser_storagePressure_notification.js because of entity parsing error for healthReportingDisabled.label. r=backout 2017-06-14 18:46:10 +02:00
Alessio Placitelli
db8dffaf60 Bug 1312182 - Consolidate the uses of MOZ_TELEMETRY_REPORTING in the code. r=flod,gfritzsche,jaws
The MOZ_TELEMETRY_REPORTING define does not control whether or not Telemetry is enabled
but rather if it will send the gathered data to Mozilla servers. We still want to
display the about:preferences options and let developers know about this behaviour.
Please note that this patch is not changing any behaviour: it's only making it explicit
by showing the options as disabled rather than hiding them.

MozReview-Commit-ID: 7A0y0E0hm0Q
2017-05-30 10:42:42 +02:00
Timothy Guan-tin Chien
07e1c956ed Bug 1363850 - Part II, Move old about:preferences from in-content-old/ to in-content/, r=jaws,mconley
MozReview-Commit-ID: DPLJT1adO1c
2017-05-31 08:20:26 +08:00
Timothy Guan-tin Chien
3a021a04eb Bug 1363850 - Part I, Move new about:preferences from in-content/ to in-content-new/, r=jaws,mconley
MozReview-Commit-ID: ButUfsGP7lS
2017-05-25 18:31:41 +08:00
Timothy Guan-tin Chien
e0d28a9253 Bug 1356507 - Show version and updater in the preferences update pane. r=jaws
This change includes unmodified aboutDialog-appUpdater.js into
preferences.xul, so we could enable the updater UI there. Also,
copied code on version/distribution strings from aboutDialog.js.

MozReview-Commit-ID: 7o24az7Tn28
2017-04-27 19:59:14 +08:00
Sebastian Hengst
cdcf8145fd Backed out changeset 2768a8779068 (bug 1356507) for eslint failure at advanced.js:72. r=backout 2017-05-03 11:10:26 +02:00
Timothy Guan-tin Chien
b77d22d101 Bug 1356507 - Show version and updater in the preferences update pane. r=jaws
This change includes unmodified aboutDialog-appUpdater.js into
preferences.xul, so we could enable the updater UI there. Also,
copied code on version/distribution strings from aboutDialog.js.

MozReview-Commit-ID: 7o24az7Tn28
2017-04-27 19:59:14 +08:00
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Sebastian Hengst
a1e759a614 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JpAhOPjgvkF
2017-04-15 19:59:24 +02:00
Jared Wein
a94d8d94c2 Bug 1355522 - Move scripts for spell-checking, hardware acceleration, and on-screen keyboards to main.js since the prefs moved to the main category. r=florian
MozReview-Commit-ID: ExZDYWx92XD
2017-04-12 11:08:46 -04:00
Jared Wein
c29576b077 Bug 1355522 - Move Telemetry and Health Report prefs to Privacy & Security section. r=florian
MozReview-Commit-ID: 1Ybpr68SKC0
2017-04-12 10:14:51 -04:00
Fischer.json
afe9fdf262 Bug 1352374 - Part 2: Move a few sections of code that were missed when rebasing bug 1335907. r=jaws
MozReview-Commit-ID: 1IEQcUUgqms
2017-04-03 00:40:21 +08:00
Zack Herrick
50c0d3d538 Bug 1335907 - Reorganize the preferences based on feedback from user research. r=mconley
The FX_PREFERENCES_CATEGORY_OPENED probe must be extended to version 59 to support the fallback "forked" preference implementation (in-content-old).

The switchToAdvancedSubPane within utilityOverlay's openPreferences must also remain until the fallback has been removed (bug 1349689).

Patch co-authored by Zack Herrick <herrickz@msu.edu> and Ziyan Long <lzylong@gmail.com>.

MozReview-Commit-ID: 1sx0Wj15yM7
2017-03-29 11:52:08 -04:00
Fischer.json
e8ea897479 Bug 1312349 - Hide the section of Offline Web Content and User Data in about:preferences r=jaws
MozReview-Commit-ID: 6K3PigI3wEf
2017-03-08 19:34:21 +08:00
Sebastian Hengst
73c0729e22 Backed out changeset 9ef667136bbe (bug 1335907) for failing browser_datachoices_notification.js. r=backout 2017-03-28 23:43:11 +02:00
Zack Herrick
11d8b74c55 Bug 1335907 - Reorganize the preferences based on feedback from user research. r=mconley
The FX_PREFERENCES_CATEGORY_OPENED probe must be extended to version 59 to support the fallback "forked" preference implementation (in-content-old).

The switchToAdvancedSubPane within utilityOverlay's openPreferences must also remain until the fallback has been removed (bug 1349689).

Patch co-authored by Zack Herrick <herrickz@msu.edu> and Ziyan Long <lzylong@gmail.com>.

MozReview-Commit-ID: 1sx0Wj15yM7
2017-03-28 14:32:54 -04:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Florian Quèze
b15de4893d Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Mark Banner
e21fc78563 Bug 1344027 - Change the import-global-from option for eslint to allow circular references and resolve most of the no-undef issues in browser/components/preferences. r=mossop
MozReview-Commit-ID: BERAbtYkxsF
2017-02-22 10:19:11 +00:00
Fischer.json
1256ed6c44 Bug 1331318 - Add learn more link in the Site Data section r=Gijs
MozReview-Commit-ID: 1PdUr7q1sYk
2017-01-16 14:59:38 +08:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Florian Quèze
45647c4570 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
35d323045c Bug 1328805 - Enable the no-cond-assign rule for eslint and fix the six resulting errors mostly by wrapping the assignment with parentheses to explicitly state that the assignment is intentional with exception for advanced.js where assignment was not intended. r=mossop
MozReview-Commit-ID: EZytfzGoMLR
2017-01-05 01:03:08 -05:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
2de0319338 Bug 1325464 - Use ES6 method syntax for preferences. r=MattN
MozReview-Commit-ID: k3Bkm39TtT
2016-12-22 15:57:40 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
f64a7da705 Bug 1325464 - Use ES6 method syntax for preferences. r=MattN
MozReview-Commit-ID: k3Bkm39TtT
2016-12-22 15:57:40 -05:00
Fischer.json
cc7372c774 Bug 1325136 - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_advanced_siteData.js | leaked 2 window(s) until shutdown [url = about:preferences#advanced], r=Gijs
MozReview-Commit-ID: 9Ysy9UzAnue
2016-12-22 12:46:38 +08:00
Jared Wein
57794b5943 Bug 1324167 - Create telemetry probes to track which preference categories are opened. r=Gijs privacy-review=bsmedberg
MozReview-Commit-ID: 39UhphnkKkC
2016-12-20 16:37:04 -05:00
Fischer.json
f5f37b0b6d Bug 1312372 - List sites using storage in Settings of Site Data, r=jaws
MozReview-Commit-ID: HqaiLW5R8Qv
2016-11-25 17:35:25 +08:00
Fischer.json
405942b008 Bug 1312361 - Clear all sites data from the Site Data section, r=Gijs
MozReview-Commit-ID: 7JbzO7TQaeX
2016-11-15 14:49:18 +08:00
Fischer.json
f76dfacb39 Bug 1313003 - Add Site Data section into Network of Advanced of about:preferences, r=jaws
MozReview-Commit-ID: KVUs8FTftxY
2016-11-03 17:34:39 +08:00
Iris Hsiao
6a74d9c088 Backed out changeset 502977d27c28 (bug 1313003) for eslint failure 2016-11-21 13:23:25 +08:00
Fischer.json
88b440ddd4 Bug 1313003 - Add Site Data section into Network of Advanced of about:preferences, r=jaws
MozReview-Commit-ID: KVUs8FTftxY
2016-11-03 17:34:39 +08:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Carsten "Tomcat" Book
72d88f75cc merge autoland to mozilla-central a=merge 2016-09-14 12:07:02 +02:00
Joseph Yeh
4169ca5b3d Bug 1049001 - Convert the certManager dialog to in-content; r=MattN
MozReview-Commit-ID: GKkbxlWboPO
2016-09-13 14:27:13 -07:00
Mike Conley
ad8740c76f Bug 1287178 - Replace erroneous Enable Crash Reporter pref with one that lets users opt-in to sending backlogged reports. r=jaws
The "Enable Crash Reporter" pref is erroneous because what it actually controls is
whether or not the "Submit crash report" checkbox is checked by default when the
crash report dialog comes up.

MozReview-Commit-ID: Ud6SLKXvxw
2016-09-07 16:50:11 -04:00
Sebastian Hengst
722f6acb17 Bug 1280775 - null check in removePermission to prevent crash: permission manager change. r=mystor
MozReview-Commit-ID: 1E67oEULEcs
2016-06-22 21:07:14 +02:00
Wes Kocher
a2747fb628 Merge m-c to fx-team, a=merge 2016-08-18 16:33:20 -07:00
Joseph Yeh
68ad02d3d8 Bug 1036815 - Convert Advanced pane dialogs to be in-content. r=MattN
MozReview-Commit-ID: BXeCOryk4kE
2016-08-17 02:08:00 -04:00
Jared Wein
7b4c22ac1c Bug 1294989 - Enable eslint for browser/components/preferences. r=Gijs
MozReview-Commit-ID: 62ymdZhluHx
2016-08-13 21:58:42 -04:00
Fischer.json
9bb9ad0cdc Bug 1037166 - Convert the "Show Update History" dialog on advanced pane to be in-content.r=jaws
MozReview-Commit-ID: kmgB4Sv9KM
2016-07-29 17:03:05 +08:00
Wes Kocher
f5030d6e24 Merge m-c to fx-team a=merge
MozReview-Commit-ID: 3H9BxQQQnNI
2016-04-29 16:05:30 -07:00
Robert Strong
952ddb0383 Bug 1262880 - browser preferences changes - Remove add-on compatibility check from application update. r=felipc 2016-04-29 10:01:04 -07:00