corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
494,784 Commits 1 Branch 0 Tags
53064b6aa0d7cd569038e85791d95f95b51ccbbf
Commit Graph

484 Commits

Author SHA1 Message Date
Doug Thayer
4631fa32d0 Bug 1357917 - Only hide doorhanger when navtoolbox autohides r=Gijs 
On OSX we want to show doorhangers when in fullscreen, since OSX
fullscreen doesn't hide the nav toolbox. This makes that change,
and also adds flip="slide" to the panel so that the arrow adjusts
correctly. Unfortunately there still seems to be a bit of a
problem with this where the doorhanger adjusts its position when
entering fullscreen but then waits a little bit (not sure what
triggers it) before updating the anchor arrow. This is tracked by
Bug 1368094.

MozReview-Commit-ID: 3dRLwgMjxIb
 2017-05-24 12:52:56 -07:00
Gijs Kruitbosch
ce62942c89 Bug 1354078 - update panel/toolbar context menus to move items to the right place, with tests, r=bgrins 
MozReview-Commit-ID: DpQdvE25iqU
 2017-05-19 17:27:11 +01:00
Mike de Boer
d0a5e82c22 Bug 1366205 - add a browser mochitest with full coverage of the new menu panel keyboard navigation feature. r=Gijs 
This also fixes two issues I found whilst writing the tests:
1. Exclude hidden items from the set of navigable buttons and
2. Exclude disabled items from the set of navigable buttons whilst navigating,
because they may get disabled in the meantime (like with the edit controls).

MozReview-Commit-ID: 5WThVoTZjbV
 2017-05-26 13:44:55 +02:00
Gijs Kruitbosch
b6620c9af2 Bug 1354126 - use checkbox for titlebar toggle in customize mode, r=mikedeboer 
MozReview-Commit-ID: 9bdf8uAlWCM
 2017-05-22 11:17:11 +01:00
Doug Thayer
573cb35085 Bug 1359733 - Move menu notification state to jsm r=Gijs 
Right now, app menu doorhangers/badges have their state managed
directly inside panelUI.js. This is problematic because these
doorhangers and badges usually have to do with Firefox itself,
and not the specific window that's showing them. Accordingly, the
simplest solution was to move panelUI.js's notification state out
into a jsm file, which will fire notifications that all panelUI
instances can listen to.

MozReview-Commit-ID: 7b8w1WsQ29p
 2017-05-18 13:22:27 -07:00
Mike Conley
6ead29b658 Bug 1362866 - Rearrange tab focusing behaviour to avoid extra potential reflows. r=Felipe 
MozReview-Commit-ID: F1S179A1GH6
 2017-05-23 13:08:11 -04:00
Christoph Kerschbaumer
5452a95b49 Bug 1362993 - Rewrite gBrowser.addTab() to use BrowserTestUtils.addTab(). r=florian 2017-05-15 21:49:50 +02:00
Florian Quèze
15feaa278a Bug 1362882 - script-generated patch to switch from Promise.defer() to new Promise() where it's straightforward, rs=Mossop. 2017-05-12 14:55:27 +02:00
Florian Quèze
b2499a4c57 Bug 1353542 - smaller script-generated patch converting remaining generators that are likely tasks (actual generators were identified by hand and whitelisted), r=Mossop. 2017-05-12 14:45:01 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Mark Banner
44d0568f41 Bug 1362947 - Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support. r=jaws 
MozReview-Commit-ID: 5fVG7akPnGM
 2017-05-08 10:29:47 +01:00
Sebastian Hengst
c8bd0b3620 Backed out changeset e0f9c56c15f0 (bug 1362947) for linting failures, e.g. at accessible/tests/mochitest/jsat/doc_content_text.html:15. r=backout 2017-05-11 10:15:55 +02:00
Mark Banner
dae8146427 Bug 1362947 - Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support. r=jaws 
MozReview-Commit-ID: 5fVG7akPnGM
 2017-05-08 10:29:47 +01:00
Doug Thayer
71bdb9abf4 Bug 1358363 - Show PanelUI notifications when window focused r=rstrong 
Right now notifications displayed in non-focused windows are
causing that window to be focused. This is annoying. We could work
to make the doorhangers not focus the other windows, but a simpler
solution is to just not show the doorhanger until the window is
focused. This has the added benefit of ensuring that the doorhangers
entry animation is seen by the user, increasing the likelihood that
they will notice it.

Additionally, some existing tests involving extra windows were
refactored. I stripped the old tests of their extra windows and
created new tests specifically to test the behavior of background
windows. These tests were modeled off of the background window
tests of PopupNotifications.jsm, which create a new window knowing
that this will cause the existing window to be the background,
rather than explicitly manipulating the focus of the two windows.

MozReview-Commit-ID: 1fjrDOhEKCw
 2017-04-21 08:57:28 -07:00
Gijs
32ea3bc037 Bug 1354082 - rm space because it's 'async function()' but 'function* ()', rs=bustage on a CLOSED TREE 2017-05-10 14:17:50 -04:00
Gijs
eebe44069b Bug 1354082 - part 0: set prefs in all the tests that need it, r=mikedeboer 
MozReview-Commit-ID: D1YDY5NvdYJ
 2017-05-10 06:54:44 -04:00
Gijs Kruitbosch
f28cdbf3e9 Bug 1355020 - part 1: disentangle update notifications from 'PanelUI' and hardcoded IDs, r=dthayer 
MozReview-Commit-ID: EqLtDuRC8EH
 2017-05-04 12:56:11 +01:00
Edouard Oger
bf97626bd8 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh 
MozReview-Commit-ID: K790Ag8WZgv
 2017-04-18 14:15:43 -04:00
Sebastian Hengst
6471972ae8 Backed out changeset 0a0138825fb5 (bug 1353571) 2017-05-03 21:56:44 +02:00
Edouard Oger
c9a99ae676 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh 
MozReview-Commit-ID: K790Ag8WZgv
 2017-04-18 14:15:43 -04:00
Neil Deakin
5dae15d035 Bug 1356587, update the gEditUIVisible flag when the panelUI is opened and closed so that the command updating optimization actually applies. Currently it never applies once the panel has been opened at least once, r=gijs 2017-05-01 10:42:33 -04:00
Jared Wein
06db750c9d Bug 1347413 - Remove the unused browser-fullZoom:zoomReset and browser-fullZoom:zoomChange notifications. r=dao,mccr8 
MozReview-Commit-ID: GeqfVngo9QT
 2017-03-15 11:26:57 -04:00
Doug Thayer
14995dba7c Bug 1348396 - Only show a badge on PanelUI while in fullscreen r=enndeakin+6102,rstrong 
Previously we were showing a doorhanger when the user moused to the
top of the screen while in fullscreen mode. However, the doorhanger
would disappear before the user had a chance to interact with it.
We decided it's best anyway to simply display a badge when the user
is in fullscreen, and to reshow the doorhanger when the user exits
fullscreen.

MozReview-Commit-ID: ENRtXC4wqvZ
 2017-04-10 11:11:45 -07:00
Gijs Kruitbosch
af0d1ac03b Bug 1354071 - test that using subviews in the overflow panel works, and that non-subview panels also work, r=mikedeboer 
MozReview-Commit-ID: 4mzMQ2BBYLs
 2017-04-19 11:50:21 +01:00
Jeff Walden
8d8bc5ba9a Bug 1350613 - Don't repeatedly create DateTimeFormat instances for the exact same set of options, but instead use cached formatters. r=markh 
MozReview-Commit-ID: 6FteRerCH2x
 2017-04-14 13:29:02 -07:00
Florian Queze
451928e614 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
f75839c723 Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Doug Thayer
a5b27a8e9b Bug 893505 - Simplify the application update UI r=chmanchester,enndeakin+6102,Gijs,rstrong 
There's quite a few changes in here. At a high level, all we're trying to do
is to replace the old update popup with a less intrusive and more modern
doorhanger (set of doorhangers) for various update failure conditions.

MozReview-Commit-ID: 24sESMTosNX
 2017-03-21 13:50:09 -07:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws 
MozReview-Commit-ID: LH0CQOPfoe6
 2017-03-20 12:36:37 +01:00
Mike Conley
5b86bcd5c6 Bug 1347514 - Regression test. r=dao 
MozReview-Commit-ID: 98EE9BUsVtz
 2017-03-20 12:00:33 -04:00
Dão Gottwald
9da2276d04 Bug 1348122 - Share code between the customizable zoom control and the location bar's zoom indicator. r=Gijs 
MozReview-Commit-ID: 7iRRr1gF9R5
 2017-03-21 09:23:24 +01:00
Jim Porter
8c24212591 Bug 1346671 - Enable the no-useless-concat eslint rule in toolkit/ r=jaws 
MozReview-Commit-ID: 1a422BiLEhK
 2017-03-13 17:34:24 -05:00
Florian Quèze
c7eae86054 Bug 1344711 - script-generated patch to remove try blocks around get*Pref calls, r=jaws. 2017-03-07 15:29:48 +01:00
Edouard Oger
1fa2484c6f Bug 1244622 - Add "Show More/All" (tabs) buttons in the Synced Tabs menu. r=markh 
MozReview-Commit-ID: 7z9fTVCDGgF
 2017-02-06 16:31:31 -05:00
Florian Quèze
91f7a2ef3a Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Gijs Kruitbosch
e39c529c29 Bug 1333305 - fix perma-orange by only removing buttons if they're present (splice(-1, 1) removes the last element of an array), r=mikedeboer 
MozReview-Commit-ID: INCwigBboL1
 2017-01-24 09:55:51 +00:00
Mike Taylor
c4a8befbf0 Bug 1324062. Part 2 - Fix CustomizableUI test failures due to NIGHTLY-only Report Site Issue button. r=Gijs 
MozReview-Commit-ID: 8fZMVz05X6n
 2017-01-17 14:28:25 -06:00
Wes Kocher
552366bcf7 Backed out 3 changesets (bug 1324062) for frequent Win7VM bc2 failures a=backout 
Backed out changeset d01f82be01f1 (bug 1324062)
Backed out changeset 054cfcf60c75 (bug 1324062)
Backed out changeset 1658b20cb69c (bug 1324062)

MozReview-Commit-ID: LTl7fJ8zrp9
 2017-01-20 11:53:36 -08:00
Mike Taylor
c3490153e6 Bug 1324062. Part 2 - Fix CustomizableUI test failures due to NIGHTLY-only Report Site Issue button. r=Gijs 
MozReview-Commit-ID: 8fZMVz05X6n
 2017-01-17 14:28:25 -06:00
Blake Kaplan
878180e703 Bug 1330822 - Remove CPOWs from customizableui/head.js. r=Gijs 
MozReview-Commit-ID: eycB4S9ANq
 2017-01-12 15:33:43 -08:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs 
MozReview-Commit-ID: 6tv0Z06CO4a
 2017-01-17 09:48:17 -06:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Phil Ringnalda
9fd9d27b8c Backed out 2 changesets (bug 1324062) for unexpected file access errors in webcompat-reporter@mozilla.org.xpi on Win7 PGO xperf 
Backed out changeset 1df935d51464 (bug 1324062)
Backed out changeset 028db619f166 (bug 1324062)
 2017-01-12 07:34:18 -08:00
Mike Taylor
ef03c07df0 Bug 1324062. Part 2 - Fix CustomizableUI test failures due to NIGHTLY-only Report Site Issue button. r=Gijs 
MozReview-Commit-ID: 8fZMVz05X6n
 2017-01-05 22:28:36 -06:00
Florian Quèze
b36a8b8f42 Bug 1330147 - automatic removal of the third boolean parameter in removeObserver calls, r=jaws. 2017-01-11 22:27:42 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe
 2016-12-30 21:47:25 -05:00