Commit Graph

1429 Commits

Author SHA1 Message Date
Sebastian Hengst
31742f9ca2 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
a220eeb86a Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao
MozReview-Commit-ID: CoHv9mKpAe
2017-08-05 20:37:40 +02:00
Dão Gottwald
421fc16fa5 Bug 1387602 - Update customize mode favicon. r=Gijs
MozReview-Commit-ID: 7gin0zuJTN0
2017-08-04 23:00:00 +02:00
Sam Foster
05040037c0 Bug 1352075 - Implement new animation for opening/closing the arrow panels. r=dao,mossop
* Use new panel animation when opening arrow-panels (including bookmarks menu) to fade in and drop into position
* Linux/GTK is (still) excluded
* New animation is non-directional (i.e. LTR vs. RTL)

This was landed then backed out due to test failures. New since last review:

* Make opacity & transform transition durations equal - ensuring popup is not still moving when popupshown is fired
* Fix missing comma in transition-duration values
* Add animating attribute to the arrowpanel binding to disable pointer-events during the opening transition (via :jaws)
* Wait for popupshown rather than transitionend in bookmark reparenting test
* Fix specificity of CSS rules for panels/bookmarks-menu on edges other than the top (via :jaws)

MozReview-Commit-ID: DTnvyMryf5Y
2017-07-27 11:07:23 -07:00
Gijs Kruitbosch
4639ca807b Bug 1354117 - stop relying on gPhotonStructure in bookmarks/history code, r=adw
MozReview-Commit-ID: FqUFNrSufvQ
2017-08-01 19:55:41 +01:00
Gijs Kruitbosch
3a2a3f1870 Bug 1354117 - remove old panel code from panelUI and CSS, r=jaws
MozReview-Commit-ID: G6a9ybDxqki
2017-08-01 19:59:38 +01:00
Gijs Kruitbosch
4f5a9c34e6 Bug 1354117 - remove old panel code from customize mode and update related CSS, r=jaws
MozReview-Commit-ID: IwKUWMTagCK
2017-08-02 11:51:58 +01:00
Gijs Kruitbosch
a659b10191 Bug 1354117 - remove old panel code from CustomizableUI, add migration, r=jaws
MozReview-Commit-ID: 8kTETHR1P7X
2017-08-01 12:56:48 +01:00
Gijs Kruitbosch
1dde1ca8d5 Bug 1354117 - fix telemetry and a number of tests that flip photon prefs, r=johannh
MozReview-Commit-ID: 7ynaIQm22eS
2017-08-01 20:15:48 +01:00
Gijs Kruitbosch
5a6c52f6a7 Bug 1354117 - only dispatch view events once, and fix synced tabs button test, r=jaws
Prior to this patch, both CustomizableUI itself and the PanelMultiView module
tried to ensure that onViewShowing/Shown/Hiding/Hidden listeners were invoked
when the relevant DOM events fired.

PanelMultiView was doing this manually because CUI was only adding listeners
once the corresponding widget was created. Now that the relevant views can be
accessed without the corresponding widgets (via the fixed appMenu), there was
no guarantee that the listeners would be attached, and this caused empty
subviews.

Unfortunately, if the widget *was* present, it caused events to fire more than
once, which understandably broke consumers like the sync remote tabs widget,
which broke the test we're fixing up here. For other views, even if they were
not completely broken it at least did busy-work.

This patch removes the manual event invocation, and delegates the event
listener work to CUI from the PanelMultiView side. This ensures events fire,
and fire only once.

MozReview-Commit-ID: 94GhcrdcBuB
2017-08-01 12:45:55 +01:00
Gijs Kruitbosch
083671c400 Bug 1354117 - Update various other customizableui tests for photon, r=adw
There are no more help/quit buttons in the panel that shows up in customize mode,
and there are no more hyphenation quirks in items in the panel, so those tests
have been removed. The remaining tests are updated to test the correct panels.

MozReview-Commit-ID: LiUWejjZC7c
2017-08-01 15:46:58 +01:00
Gijs Kruitbosch
865d6f5756 Bug 1354117 - fix or remove tests that drag items to the panel, r=adw
The new panel doesn't have placeholders, or a distinction between wide and
narrow widgets, so those tests can just be removed.

MozReview-Commit-ID: D61AjwMbabG
2017-07-31 18:26:38 +01:00
Gijs Kruitbosch
80565d2e85 Bug 1354117 - update panel button tests for photon, r=adw
MozReview-Commit-ID: 94mIvlOenCg
2017-08-01 11:33:26 +01:00
Gijs Kruitbosch
fcc4f4817a Bug 1354117 - update customize mode button state test, r=johannh
Again, this test is mostly useless now, so I would also be fine with just removing it.

MozReview-Commit-ID: BwOGQ5pwSQd
2017-07-31 21:10:14 +01:00
Gijs Kruitbosch
d485cb5fac Bug 1354117 - remove wrap handling for the bookmarks toolbar button and tests verifying it, r=johannh
MozReview-Commit-ID: CeSGIQrDPpw
2017-07-31 21:52:06 +01:00
Gijs Kruitbosch
1bc740f04e Bug 1354117 - remove panel-specific styling and associated code, include closemenu in styling in overflow panel, r=johannh
MozReview-Commit-ID: 4EgZP0Huo80
2017-07-27 16:27:05 +01:00
Julian Descottes
e4c5c61d18 Bug 1387023 - initialize devtools before asserting menu items in browser_989751_subviewbutton_class.js;r=Gijs
MozReview-Commit-ID: 9piucVkS0Y9
2017-08-03 14:04:54 +02:00
UK992
890c6e6ae5 Bug 1363485 - Update tests r=dao
MozReview-Commit-ID: 4epuVQVCJPH
2017-07-30 20:39:55 +02:00
UK992
4725c98c0b Bug 1363485 - Add migration to new navbar layout r=Gijs
MozReview-Commit-ID: HIPq5rKgtlA
2017-06-29 19:09:43 +02:00
UK992
d474ac2448 Bug 1363485 - Move the Back, Forward, Reload and Stop buttons outside of the location bar container to the start of the toolbar along with the Home button r=Gijs
MozReview-Commit-ID: 2GxcXMxdbjW
2017-06-29 01:09:05 +02:00
Erica Wright
056e3d8dba Bug 1378016 - Fix keyboard navigation and selection on 'recent bookmarks'. r=Gijs
MozReview-Commit-ID: GJ7vRPz8zuo
2017-07-31 09:47:19 -04:00
Sebastian Hengst
6415681153 Backed out changeset 1e6aea26ec16 (bug 1363485) for failing browser_urlbar_search_reflows.js on OSX debug with e10s and Windows. r=backout 2017-08-02 16:26:03 +02:00
Sebastian Hengst
4f8c56e473 Backed out changeset 69063acda8eb (bug 1363485) 2017-08-02 16:25:05 +02:00
Sebastian Hengst
6b72dd3d4c Backed out changeset f3e224764ca8 (bug 1363485) 2017-08-02 16:24:54 +02:00
Rajesh Kathiriya
fefc455410 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
UK992
ddaf4b64ea Bug 1363485 - Update tests r=dao
MozReview-Commit-ID: 4epuVQVCJPH
2017-07-30 20:39:55 +02:00
UK992
0f28719c58 Bug 1363485 - Add migration to new navbar layout r=Gijs
MozReview-Commit-ID: HIPq5rKgtlA
2017-06-29 19:09:43 +02:00
UK992
40f81da018 Bug 1363485 - Move the Back, Forward, Reload and Stop buttons outside of the location bar container to the start of the toolbar along with the Home button r=Gijs
MozReview-Commit-ID: 2GxcXMxdbjW
2017-06-29 01:09:05 +02:00
Jared Wein
dc5a2c6671 Bug 1383689 - Remove uninterruptible reflow at setToolbarButtonHeightProperty@resource://gre/modules/BrowserUtils.jsm. r=Gijs
MozReview-Commit-ID: 9WoXQ1nMWTZ
2017-08-01 15:33:01 -04:00
Sebastian Hengst
1326418a49 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
0d920ece6a Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Drew Willcoxon
fa08c7c97c Bug 1374477 - Add a new test for Photon page actions, along with some related code changes. r=Gijs
MozReview-Commit-ID: ADaEnEiGFvX
2017-07-29 20:25:14 -07:00
Gijs Kruitbosch
dd3befde03 Bug 1380274 - add an anchor to the definition of the overflow panel area, r=jaws
MozReview-Commit-ID: EezQr2JP1JH
2017-07-27 14:16:08 +01:00
Gijs Kruitbosch
9c6984405e Bug 1378807 - make search bar shortcut work in the permanent overflow panel, r=bwinton
MozReview-Commit-ID: HLdegoy2525
2017-07-27 15:00:38 +01:00
Carsten "Tomcat" Book
3113a020d8 Backed out changeset 0ee0458b1452 (bug 1351148) 2017-07-28 09:20:08 +02:00
Gijs Kruitbosch
e46e8d77d3 Bug 1383458 - disable pin to overflow / move to panel for flexible spacers (and other special items), r=jaws
MozReview-Commit-ID: 4eeKLsjPi6I
2017-07-26 17:28:47 +01:00
Blake Winton
379d636c58 Bug 1354097 - Style and add a customize button to the overflow panel. r=Gijs, ui-r=shorlander.
MozReview-Commit-ID: 7bNQcVgb7wf
2017-07-17 10:18:40 -04:00
Mike de Boer
4ca08790fb Bug 1354533 - Update the History panelview when it's shown inside the new Library panel. r=mak
This patch changes the history-panelmenu widget with the following:
 - Move the Recently Closed Tabs and Recently Closed Windows lists into their own
   respective (nested) subview,
 - Add a Recent History header to list of history items,
 - Extend the list of Recent History items to be max 42 items long,
 - Share more code with Bookmarks panel,
 - Generalizes panelview event dispatching to always support customizable widgets.

MozReview-Commit-ID: 4sBR6llIvxG
2017-07-21 15:07:23 +02:00
Sebastian Hengst
f0dd4f92de merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: Lanp1XedkmZ
2017-07-23 11:27:03 +02:00
Florian Quèze
297c9e8335 Bug 1381853 - lazy load panelUI.js into the browser window, r=mconley. 2017-07-23 00:17:56 +02:00
Jared Wein
6b1f4aab47 Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r=sfoster
MozReview-Commit-ID: ERE1FnTuIWF
2017-07-20 12:31:06 -04:00
Wes Kocher
5b00ab80b8 Merge m-c to autoland, a=merge CLOSED TREE
MozReview-Commit-ID: 9pPsy8McMun
2017-07-21 18:18:35 -07:00
Wes Kocher
c21f63d3ed Merge inbound to central, a=merge CLOSED TREE
MozReview-Commit-ID: GYc8r8gnS0j
2017-07-21 18:12:55 -07:00
Dão Gottwald
1abbce4ae7 Bug 1383031 - Rename customization-uidensity-menu-button* classes and ids since these are menuitems. r=johannh
MozReview-Commit-ID: 72S5zENy1gX
2017-07-21 14:11:15 +02:00
Stone Shih
dfa43a2151 Bug 1351148 Part8: Revise browser_1008559_anchor_undo_restore.js to continue the test after processing the mouse event. r=smaug.
MozReview-Commit-ID: BYF94RsKhR6
2017-07-16 12:38:13 +08:00
Johann Hofmann
0bc53a79e8 Bug 1371219 - Increase margin of main menu items when accessed through touch. r=mikedeboer
MozReview-Commit-ID: 9gjxxc6O5YS
2017-07-20 16:45:02 +02:00
Johann Hofmann
3fca548c18 Bug 1371219 - Add an inputSource attribute to XULCommandEvent. r=smaug
In the frontend we need to know if XUL buttons in the toolbar were
triggered by a touch event, so we're passing on the inputSource
in the command event.

MozReview-Commit-ID: DMvgZULk9hT
2017-07-20 17:45:56 +02:00
Wes Kocher
a5e872bb1a Backed out changeset 320f9642bcef (bug 1381991) because it blocks backing out 1355922 a=backout
MozReview-Commit-ID: 7gM0DJkbVwW
2017-07-21 00:36:04 -07:00
Jared Wein
12d1295b43 Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r=sfoster
MozReview-Commit-ID: ERE1FnTuIWF
2017-07-20 12:31:06 -04:00
Jared Wein
9fa4afa5b6 Bug 1380815 - Fade overflow menu icon to grey after item is pinned. r=sfoster
MozReview-Commit-ID: 2LQrWDxrTny
2017-07-20 10:53:45 -04:00