Commit Graph

78 Commits

Author SHA1 Message Date
Dão Gottwald
b736efa05b Bug 1914779 - Clean up getting the last tab in tabs.js. r=jswinarton,dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D220076
2024-08-26 14:39:43 +00:00
Dão Gottwald
399c2311b3 Bug 1914703 - Fix up scrolled to end check. r=emilio
I first tried to fix the disabled property, but this turned into a rabbit hole that seems a bit too risky at this stage. With some luck, this may be the only place accessing these buttons' disabled property. Medium-term we still need to fix the property, ideally by making the disabled attribute a standard boolean one.

Differential Revision: https://phabricator.services.mozilla.com/D220122
2024-08-26 13:06:21 +00:00
Dão Gottwald
21ba6a69e4 Bug 1914519 - Consolidate vertical mode and rtl checks in tab bar code. r=jswinarton,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D219933
2024-08-23 20:17:39 +00:00
Emilio Cobos Álvarez
0cfa35c631 Bug 1914544 - Make sure we don't open a new tab for doubleclick on the overflow buttons.
MANUAL PUSH: Fixes browser_overflowScroll.js on Linux CLOSED TREE.
2024-08-23 18:47:10 +01:00
Emilio Cobos Álvarez
9cd0c34bd2 Bug 1914544 - Fix tab bar doubleclick check. r=dao,tabbrowser-reviewers
Make sure that we actually hit our arrowscrollbox (not any random
scrollbox).

Differential Revision: https://phabricator.services.mozilla.com/D219972
2024-08-23 14:55:27 +00:00
DJ
bfb53ac9de Bug 1908405 - accept optional list of tabs in addTabGroup. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D219941
2024-08-23 09:44:53 +00:00
Emilio Cobos Álvarez
b5cc0dcae9 Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-21 12:23:34 +00:00
Cristian Tuns
8914d54c72 Backed out changeset 6fb2cecebdd8 (bug 1913322) for causing multiple failures. CLOSED TREE 2024-08-20 21:01:50 -04:00
Emilio Cobos Álvarez
02bec8c38e Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-20 22:31:22 +00:00
Iulian Moraru
cd76550840 Backed out changeset 1658290c1b95 (bug 1913322) for causing overflow related failures. CLOSED TREE 2024-08-20 17:54:54 +03:00
Emilio Cobos Álvarez
cb06f25a7a Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-20 12:58:16 +00:00
Florian Quèze
65bf72cdca Bug 1913624 - Remove expired telemetry histogram HOVER_UNTIL_UNSELECTED_TAB_OPENED, r=chutten,tabbrowser-reviewers,dao.
Depends on D219440

Differential Revision: https://phabricator.services.mozilla.com/D219441
2024-08-20 10:26:51 +00:00
Florian Quèze
171499434e Bug 1913624 - Remove expired telemetry histogram TAB_AUDIO_INDICATOR_USED, r=chutten,tabbrowser-reviewers,dao.
Depends on D219439

Differential Revision: https://phabricator.services.mozilla.com/D219440
2024-08-20 10:26:51 +00:00
Jan-Niklas Jaeschke
de1c63ce2a Bug 1911339 - Text Fragments: Preserve user activation when opening a link in a new tab or window. r=dom-core,tabbrowser-reviewers,dao,farre
Differential Revision: https://phabricator.services.mozilla.com/D218655
2024-08-20 08:47:49 +00:00
Jeremy Swinarton
1ca50f8860 Bug 1912275: Collapsing tab group changes selected tab r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218888
2024-08-14 13:56:29 +00:00
DJ
324236fba0 Bug 1911924 - don't show tab preview thumbnail placeholder when thumbnails are disabled. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D219031
2024-08-14 07:58:20 +00:00
Jeremy Swinarton
0d521d1f2b Bug 1908416: gBrowser.visibleTabs handles tab groups r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218796
2024-08-08 16:23:24 +00:00
Sam Foster
f64b68c78d Bug 1899580 - Exclude collapsed vertical tabs from indicator-replaces-favicon behavior. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
- Ensure everything that sets .expanded on sidebar-main uses the toggleExpanded method

Differential Revision: https://phabricator.services.mozilla.com/D217507
2024-08-07 18:51:26 +00:00
Jeremy Swinarton
cd95d6d498 Bug 1908404: Click to expand/collapse tab group r=dao,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218434
2024-08-07 14:59:36 +00:00
Anna Yeddi
f351d96411 Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.

Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.

Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-08-06 13:51:06 +00:00
Stefan Richter
551e400b7c Bug 1409262 - Notify when openerTabId changed via tabs.update() r=robwu,dao
Differential Revision: https://phabricator.services.mozilla.com/D164982
2024-08-05 17:49:06 +00:00
Dão Gottwald
5cc15d0779 Bug 1908412 - add API for adding tabs to a group. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218204
2024-08-05 09:25:19 +00:00
DJ
89ad94eb74 Bug 1902619 - Hold space for pending screenshots and fade in when ready. r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218101
2024-07-31 18:47:41 +00:00
DJ
a96bf7ac85 Bug 1906123 - use a fixed AR for tab preview while preserving scroll position. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218085
2024-07-31 18:47:40 +00:00
Sandor Molnar
2e5df25263 Backed out 2 changesets (bug 1906123, bug 1902619) for causing bc failures @ @ browser_thumbnails_bg_basic.js CLOSED TREE
Backed out changeset d64bfab9a514 (bug 1902619)
Backed out changeset 5bbb9dd95c0e (bug 1906123)
2024-07-31 21:29:58 +03:00
DJ
7ae78e601d Bug 1902619 - Hold space for pending screenshots and fade in when ready. r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218101
2024-07-31 17:30:23 +00:00
DJ
db52857c68 Bug 1906123 - use a fixed AR for tab preview while preserving scroll position. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218085
2024-07-31 17:30:22 +00:00
Dão Gottwald
95d5536b2f Bug 1910576 - tabbrowser.js needs to check tabContainer.verticalMode rather than tabContainer.inVerticalTabsMode. r=tabbrowser-reviewers,dwalker
Borrowed from https://phabricator.services.mozilla.com/D218052

Differential Revision: https://phabricator.services.mozilla.com/D218185
2024-07-31 15:18:09 +00:00
Dão Gottwald
0ca3183451 Bug 1910601 - Remove _verticalTabs property and use verticalMode instead. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D218063
2024-07-31 09:12:40 +00:00
Butkovits Atila
81e0c9fdb0 Backed out changeset a99be1c64226 (bug 1910601) for causing failures at browser_multiselect_tabs_reorder.jS. 2024-07-30 23:29:04 +03:00
Dão Gottwald
ccbd151e5e Bug 1910601 - Remove _verticalTabs property and use verticalMode instead. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D218063
2024-07-30 17:19:04 +00:00
Dão Gottwald
57b3a833e4 Bug 1908162 - Basic Tab Group custom element. r=dwalker,desktop-theme-reviewers,tabbrowser-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217980
2024-07-30 14:57:41 +00:00
Jeremy Swinarton
416bd4c2b9 Bug 1879103: Update THP on tab change r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217829
2024-07-30 14:47:24 +00:00
Stuart Colville
a6dc7c69d9 Bug 1880138 - Filter Fx View from AllTabs hidden tabs UI. r=fxview-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D217809
2024-07-29 12:13:55 +00:00
Sarah Clements
7ea40f53e4 Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D215482
2024-07-29 11:30:37 +00:00
Sammy Khamis
994493e803 Bug 1909783: Synced tabs list should de-dupe r=markh,fxview-reviewers,sync-reviewers,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao
Differential Revision: https://phabricator.services.mozilla.com/D217700
2024-07-26 20:31:03 +00:00
Jeremy Swinarton
088315a50d Bug 1902252: Screenshot size respects devicePixelRatio r=dwalker,desktop-theme-reviewers,tabbrowser-reviewers,cmkm
Differential Revision: https://phabricator.services.mozilla.com/D217459
2024-07-25 15:03:13 +00:00
Jeremy Swinarton
0fef333b99 Bug 1908666: Prevent THP from opening when other panel is animating r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217168
2024-07-23 18:39:43 +00:00
timw-dev
139987ebda Bug 1804166 - favicon not reseting when changing tab to about:newtab with newtab to Blank Page.r=tgiles,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D216357
2024-07-23 17:07:39 +00:00
Jeremy Swinarton
cd42d69cab Bug 1889880: temporarily cancel tab hover UI delay when leaving tabstrip r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D209167
2024-07-18 17:01:32 +00:00
Jeremy Swinarton
5215ca95dd Bug 1903042: THP popups show immediately after closing other panels r=dwalker,mconley
Differential Revision: https://phabricator.services.mozilla.com/D215809
2024-07-17 19:00:24 +00:00
Jeremy Swinarton
93f2268504 Bug 1899556: Disable THP when app in background r=dwalker,tabbrowser-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D216205
2024-07-12 21:39:42 +00:00
jlvivero
1cc313284f Bug 1882655 cache startup time value by calling it in the initialize function, update remove intermediate variable and fix typo, move getting startuptime to tabs.js r=tabbrowser-reviewers,sfoster,dao
Differential Revision: https://phabricator.services.mozilla.com/D215032
2024-07-10 15:55:06 +00:00
Nikki Sharpley
db8bc399ee Bug 1893656 - Fix vertical tabs drag and drop r=sidebar-reviewers,tabbrowser-reviewers,dao,Gijs
- fix animation of drag and drop
- fix dragging to new window
- add tests for vertical tabs drag and drop

Differential Revision: https://phabricator.services.mozilla.com/D213237
2024-07-09 13:22:55 +00:00
Jeremy Swinarton
5b1962c93d Bug 1900749: THP shows correct URL in reader mode r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215545
2024-07-03 13:52:34 +00:00
Amy Lee
0be4c4335f Bug 1902430 - Update strings for close duplicate tabs in tab overview menu. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D214455
2024-07-02 18:56:44 +00:00
DJ
8a72f7671e Bug 1900867 - dismiss tab preview when tab select occurs. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D215506
2024-07-02 15:23:08 +00:00
DJ
c65aeb08e6 Bug 1899566 - only rollup tab preview on wheel if tabs overflow. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D215260
2024-07-02 13:59:45 +00:00
Tom Schuster
b558a0cc09 Bug 1900381 - Remove (direct) mainPopupset onpopupshowing inline event handlers. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D213940
2024-07-01 08:10:00 +00:00
Cristian Tuns
49bd8e8edd Backed out changeset 6ac47dbd939c (bug 1884970) for causing bc failures in browser_tab_tooltips.js CLOSED TREE 2024-06-28 15:23:44 -04:00