Commit Graph

110 Commits

Author SHA1 Message Date
Dana Keeler
b9949a06fe Bug 1686814 - remove unnecessary es6 modules inclusions in aboutNetError.xhtml r=johannh
These modules were included in bug 1685552, but they weren't necessary.

Differential Revision: https://phabricator.services.mozilla.com/D102345
2021-01-21 19:06:44 +00:00
Dana Keeler
aa81f21079 Bug 1685552 - move certificate subject alternative name processing for error pages from backend to frontend r=bbeurdouche,johannh,baku
This removes nsIX509Cert.subjectAltNames and reduces potential attack surface
by avoiding parsing subject alternative names in C/C++. It also reduces PSM
reliance on NSS types.

Differential Revision: https://phabricator.services.mozilla.com/D101418
2021-01-14 09:58:03 +00:00
Dana Keeler
ba298e32e2 Bug 1681839 - remove nsISecurityReporter and implementation r=johannh,necko-reviewers,dragana
TLS error report sending was disabled by default in bug 1579906. The server
that ingested these reports has been decommissioned as well, so this patch
removes this dead code.

Differential Revision: https://phabricator.services.mozilla.com/D99405
2021-01-07 17:47:47 +00:00
Noemi Erli
9042129fd2 Backed out changeset a96912059b4c (bug 1644719) for causing failures in browser_all_files_referenced.js CLOSED TREE 2020-09-30 19:18:42 +03:00
prathiksha
c89b964b95 Bug 1644719 - Add basic functionality to display offline support pages when SUMO is unreachable from certerror pages. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D91451
2020-09-30 12:45:10 +00:00
Tim Huang
84aff40d04 Bug 1647825 - Part 1: Add the UI for enable reporting XFO and CSP:frame-ancestors error. r=ckerschb,nhnt11
This patch adds the UI for allowing users to enable reporting XFO error.
The reporting UI will be displayed in the error page if the error is a
XFO error.

Differential Revision: https://phabricator.services.mozilla.com/D82331
2020-07-22 15:12:38 +00:00
Gijs Kruitbosch
23769a50de Bug 1642725 - use sets of known message identifiers to limit possible error titles and messages instead of consulting fluent, r=zbraniecki,prathiksha,fluent-reviewers,Pike
Differential Revision: https://phabricator.services.mozilla.com/D82135
2020-07-06 11:12:08 +00:00
Ingrid Buh twigle_ingrid
cedf40d9c0 Bug 1461195 - CSP/XFO error pages should offer an option to visit the page directly r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D69703
2020-05-26 10:17:50 +00:00
Johann Hofmann
436da43689 Bug 1629826 - Re-enable event telemetry probes for certificate error pages. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D72514
2020-04-25 18:12:32 +00:00
sourab
ecac6797d5 Bug 1622269 - Use fluent to display cert error titles. r=flod,prathiksha,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D66968
2020-03-26 14:35:50 +00:00
Christoph Kerschbaumer
9545b113fa Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D50588
2019-10-31 08:28:35 +00:00
Razvan Maries
29f5ebb20d Backed out changeset 5f185a11889b (bug 1584998) for perma fails on browser_bug593387.js. CLOSED TREE 2019-10-30 23:26:01 +02:00
Christoph Kerschbaumer
e153436cc8 Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh
Differential Revision: https://phabricator.services.mozilla.com/D50588
2019-10-30 17:54:36 +00:00
Daniel Varga
5ad67b3c4d Backed out changeset ac8f6632f7e0 (bug 1584998) on request by dev. On a CLOSED TREE 2019-10-30 19:33:29 +02:00
Christoph Kerschbaumer
bf3d7aada0 Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh
Differential Revision: https://phabricator.services.mozilla.com/D50588
2019-10-30 14:47:19 +00:00
Martin Thomson
ff059987d6 Bug 1579285 - Offer to enable TLS 1.0 on neterror page r=johannh
As we roll out the TLS 1.0 and 1.1 deprecation, sites that don't support TLS 1.2
will show the neterror page.  This adds a box to that page that shows in this
specific case.  That box explains what is going on and gives an option to
re-enable TLS 1.0.

As mentioned, this will show alongside an option to reset TLS-related
preferences if any overrides are active.

Hitting the button will set the new pref to 'true' and reload the page.

Once the override is engaged, the option won't show, but that option to reset
preferences will show (as this is a TLS-related preference).

The intent is to remove this affordance in March 2020 as we formally move to
having TLS 1.2 the minimum version.  All going to plan, this will only affect
prerelease channels, though anyone who has tweaked security.tls.version.* could
also see this.

Differential Revision: https://phabricator.services.mozilla.com/D45799
2019-09-27 01:26:06 +00:00
Coroiu Cristina
ceeec89ab1 Backed out 4 changesets (bug 1579285, bug 1579270) for browser-chrome failures at browser/base/content/test/siteIdentity/browser_deprecatedTLSVersions.js on a CLOSED TREE
Backed out changeset 36d7cc55bd16 (bug 1579285)
Backed out changeset 26e3ed3c1592 (bug 1579285)
Backed out changeset 913652258fe6 (bug 1579285)
Backed out changeset 0781e60dd54c (bug 1579270)
2019-09-27 04:19:59 +03:00
Martin Thomson
f34a2ef4fb Bug 1579285 - Offer to enable TLS 1.0 on neterror page r=johannh
As we roll out the TLS 1.0 and 1.1 deprecation, sites that don't support TLS 1.2
will show the neterror page.  This adds a box to that page that shows in this
specific case.  That box explains what is going on and gives an option to
re-enable TLS 1.0.

As mentioned, this will show alongside an option to reset TLS-related
preferences if any overrides are active.

Hitting the button will set the new pref to 'true' and reload the page.

Once the override is engaged, the option won't show, but that option to reset
preferences will show (as this is a TLS-related preference).

The intent is to remove this affordance in March 2020 as we formally move to
having TLS 1.2 the minimum version.  All going to plan, this will only affect
prerelease channels, though anyone who has tweaked security.tls.version.* could
also see this.

Differential Revision: https://phabricator.services.mozilla.com/D45799
2019-09-27 00:18:11 +00:00
Christoph Kerschbaumer
6dec8a1a75 Bug 1499354: Add object-src 'none' to the CSP of all about: pages. r=freddyb
Differential Revision: https://phabricator.services.mozilla.com/D46950
2019-09-26 16:22:41 +00:00
prathiksha
5200f9c04c Bug 1578239 - Remove security.ui.certerror telemetry. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D46115
2019-09-18 10:53:46 +00:00
prathiksha
cc93a1dfac Bug 1561443 - Move _getErrorMessageFromCode from NetErrorChild.jsm to aboutNetError.js. r=fluent-reviewers,flod,johannh
Differential Revision: https://phabricator.services.mozilla.com/D36542
2019-09-17 09:49:59 +00:00
prathiksha
8809c8360e Bug 1553342 - Have Browser:CertExceptionError message exchanges happen over RPM. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D34581
2019-09-05 20:04:03 +00:00
prathiksha
18844e7cd2 Bug 1549561 - Move _setTechDetails from NetErrorChild.jsm to aboutNetError.js. r=johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D30852
2019-05-30 06:43:14 +00:00
Johann Hofmann
6e266b599b Bug 1550209 - Clean up remnants of old clock skew error code in NetErrorChild.jsm. r=prathiksha
Differential Revision: https://phabricator.services.mozilla.com/D30432
2019-05-15 17:29:35 +00:00
Johann Hofmann
eb9e199b6b Bug 1547695 - De-dupe #errorTryAgain on about:neterror/certerror. r=prathiksha
We were using the same ID on two elements, which kind of messed up things everywhere
our code reasonably expected only one element of the kind to exist. We just use a
class name now.

This also cleans up #advancedPanelErrorTryAgain which worked around this issue
by using a different ID.

Differential Revision: https://phabricator.services.mozilla.com/D30298
2019-05-13 19:38:03 +00:00
Brian Grinstead
3dd68e7775 Bug 1546501 - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags r=mossop
This is an autogenerated commit, generated with https://bug1546501.bmoattachments.org/attachment.cgi?id=9060222

Differential Revision: https://phabricator.services.mozilla.com/D28559
2019-04-24 19:43:57 +00:00
Johann Hofmann
68e7b1e3db Bug 1530348 - Unfork aboutNetError.{xhtml,css}. r=nhnt11
The larger changesets in this patch are simply moving code from one file into the other with hg mv.

A short summary of the changes:

- I removed the forked redirection from AboutRedirector.cpp
- I deleted the original aboutNetError.xhtml and aboutNetError.css files
  and moved aboutNetError-new.xhtml and aboutNetError-new.css in their place instead.
- I removed the browser.security.newcerterrorpage.enabled pref and all its usages.
- I removed some localization strings and resources that went unused because of the above changes.

Differential Revision: https://phabricator.services.mozilla.com/D25232
2019-03-29 09:33:58 +00:00
Mellina Yonashiro
e33017de4b Bug 1534629 Non-bypassable cert error pages should use Advanced instead of More information r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D23316
2019-03-18 17:11:50 +00:00
Srestha
8a14be2cdb Bug 1523679 - Remove autocomplete=off from <button> elements in aboutNetError.xhtml and aboutNetError-new.xhtml. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18212
2019-01-31 13:52:10 +00:00
Nicholas Hurley
ae88624519 Bug 1050329 - part 2 - Add error page for h2 goaway. r=dragana,bzbarsky
This is kind of like the previous patch (where we had a not-very-friendly user experience shutting down misbehaving h2 sessions), but in this case the server has proven to us that it can speak a minimum of h2, so we don't want to just fallback. Instead, when we send a GOAWAY frame because we have detected some error on the part of the server, if it's a top-level page load, we'll show an error page explaining that the server spoke bad http/2, and the site admin(s) need to be contacted. We already did this for INADEQUATE_SECURITY (which is its own special case still), but that didn't cover all the cases.

Differential Revision: https://phabricator.services.mozilla.com/D8436
2018-10-25 20:46:46 +00:00
Johann Hofmann
bd1813f9f4 Bug 1484255 - Add Telemetry Events for the certificate error pages. r=nhnt11,keeler
Differential Revision: https://phabricator.services.mozilla.com/D8281
2018-10-17 13:10:26 +00:00
Ciure Andrei
aa65696252 Backed out changeset 1119f9458b5d (bug 1484255) for browser_aboutCertError_telemetry.js failures CLOSED TREE 2018-10-16 03:33:42 +03:00
Johann Hofmann
89d3e9b226 Bug 1484255 - Add Telemetry Events for the certificate error pages. r=nhnt11,keeler
Differential Revision: https://phabricator.services.mozilla.com/D8281
2018-10-15 23:00:08 +00:00
Arshad Kazmi
a4a87a4243 Bug 1457784 - Replace warning-16.png with warning.svg. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D5973
2018-09-17 09:55:12 +00:00
Johann Hofmann
43f8222510 Bug 1484246 - Part 1 - Add more explanation to certificate errors caused by Symantec distrust. r=Gijs,keeler
Differential Revision: https://phabricator.services.mozilla.com/D3877
2018-08-21 15:04:02 +02:00
trisha
276f6f397f Bug 1476509 - Implement a new clock skew error page r=flod,johannh
MozReview-Commit-ID: 5WmgrxUcSZ6
2018-08-02 22:59:04 +05:30
Andreea Pavel
b414d7b427 Backed out changeset ef30529d43dd (bug 1476509) for breaking localization a=backout 2018-08-11 13:45:07 +03:00
trisha
b637a1908a Bug 1476509 - Implement a new clock skew error page r=johannh
MozReview-Commit-ID: BUR0hCnh5gb
2018-08-02 22:59:04 +05:30
vinoth
f0f5253fbf Bug 1453560 - Apply Meta CSP to Content Privileged about:certerror and about:neterror. r=ckerschb, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D918
2018-04-26 04:07:07 -04:00
Felipe Gomes
a2584d04ff Bug 1450761 - Add pref to disable the Add Exception button on certificate error pages. r=jaws 2018-04-04 15:56:15 -03:00
Franziskus Kiefer
bf83b05857 Bug 1415279 - Move error strings for certError and netError pages to frontend, r=johannh,keeler,Honza,snorp
This patch moves all TLS error string handling to the frontend.
Dev-tools doesn't show the same error code as the page does anymore but only the error code as string.
All logging of these error messages has been removed.

Bug #: 1415279

Differential Revision: https://phabricator.services.mozilla.com/D607
2018-03-27 13:31:52 +02:00
Kirk Steuber
f19b39c2a8 Bug 1438243 - Improve the UI for pages blocked by policy r=Felipe
Improves the UI for pages blocked by the enterprise policy manager. These improvements include a new image instead of the generic "info" image and updated, approved strings for the page.

MozReview-Commit-ID: 9d6V9onHGGg
2018-02-22 15:41:12 -08:00
Kirk Steuber
cc11c81ff1 Bug 1421707 - Implement a system for disabling about: pages via Policy r=bz,Felipe
Additionally adds the enterprise policy for disabling about:config.

MozReview-Commit-ID: 7bT8eV3tRnN
2018-02-06 10:00:56 -08:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Johann Hofmann
a84b188686 Bug 1394451 - Add an illustration to net errors. r=ewright
MozReview-Commit-ID: LSfyFYEgUMS
2017-09-20 18:29:20 +02:00
Johann Hofmann
385718ba1c Bug 1394462 - Update dnsNotFound error copy and illustration. r=nhnt11
MozReview-Commit-ID: KFp3JhkCDJJ
2017-09-19 21:54:29 +02:00
Erica Wright
b6e6a1c5e5 Bug 1394460 - Update illustration and copy for error: invalid URL. ui-r=shorlander r=johannh
MozReview-Commit-ID: 8mMUvlOzygj
2017-08-29 16:55:31 -04:00
Zibi Braniecki
3713212f30 Bug 1389798 - Load browser version of netError.dtd from browser aboutNetError.xhtml. r=gandalf
MozReview-Commit-ID: 4nF2XKgWXxn
2017-08-12 16:53:04 -07:00
Frederik Braun
96b2642639 Bug 1351608 - Disable warnings for existing violations to no-unsanitize rule r=Standard8.
MozReview-Commit-ID: 7cTNL5jMtRw
2017-07-03 20:07:02 +01:00
Johann Hofmann
cb00ead7a2 Bug 1363046 - Update neterror/certerror page design for Photon. r=dao
MozReview-Commit-ID: 5RakjD72FwV
2017-05-09 16:43:15 -04:00