corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
906,145 Commits 1 Branch 0 Tags
50daf5cb15c6df6ffcf8368be624c5dc500400de
Commit Graph

4038 Commits

Author SHA1 Message Date
Luca Greco
3db97e7f16 Bug 1925291 - Tweak themed icons css rules. r=willdurand,desktop-theme-reviewers,dao 
This patches applied tweaks to the CSS rules that are meant to choose the right browserAction
theme icon based on the theme colors.

In addition to that this patch includes a tweak (unrelated to the changes applied to the CSS rules)
to the test that would be hitting a failure if the CSS rules are not applied to the browserAction
toolbar-button as the test cases from this test file expects.

This is currently split out from the parent patch including the rest of the frontend changes
because these rules seems worth an additional close look.

Differential Revision: https://phabricator.services.mozilla.com/D229993
 2024-12-04 18:42:21 +00:00
Luca Greco
38a13671ae Bug 1925291 - Add Extensions Button panel a new per-item messagebar. r=willdurand,fluent-reviewers,desktop-theme-reviewers,dao,flod,devtools-reviewers,ochameau 
Depends on D229902

Differential Revision: https://phabricator.services.mozilla.com/D229904
 2024-12-04 18:42:21 +00:00
Goloman Adrian
90701c4927 Backed out 3 changesets (bug 1925291) for causing dt failures @browser_aboutdebugging_addons_debug_console.js. CLOSED TREE 
Backed out changeset 540773496872 (bug 1925291)
Backed out changeset 46bd418a9e54 (bug 1925291)
Backed out changeset ac2a87182d6a (bug 1925291)
 2024-12-04 14:37:29 +02:00
Goloman Adrian
f4fc1d24ee Backed out changeset 2a6ce904c3f5 (bug 1925291) for causing dt failures @browser_aboutdebugging_addons_debug_console.js. 2024-12-04 14:36:51 +02:00
pstanciu
e7d1234b88 Bug 1925291 - Fix lint failure r=fix CLOSED TREE 2024-12-04 13:50:29 +02:00
Luca Greco
d434b4c61c Bug 1925291 - Tweak themed icons css rules. r=willdurand,desktop-theme-reviewers,dao 
This patches applied tweaks to the CSS rules that are meant to choose the right browserAction
theme icon based on the theme colors.

In addition to that this patch includes a tweak (unrelated to the changes applied to the CSS rules)
to the test that would be hitting a failure if the CSS rules are not applied to the browserAction
toolbar-button as the test cases from this test file expects.

This is currently split out from the parent patch including the rest of the frontend changes
because these rules seems worth an additional close look.

Differential Revision: https://phabricator.services.mozilla.com/D229993
 2024-12-04 10:43:19 +00:00
Luca Greco
762933f39d Bug 1925291 - Add Extensions Button panel a new per-item messagebar. r=willdurand,fluent-reviewers,desktop-theme-reviewers,dao,flod 
Depends on D229902

Differential Revision: https://phabricator.services.mozilla.com/D229904
 2024-12-04 10:43:19 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
 2024-11-29 15:18:25 +00:00
Luca Greco
5123d0ecd3 Bug 1924542 - Add test coverage for WebExtensions commands shortcuts using F1-F19 keys. r=willdurand 
Depends on D230108

Differential Revision: https://phabricator.services.mozilla.com/D229813
 2024-11-28 14:28:03 +00:00
Luca Greco
99f4949a56 Bug 1931889 - Add test case for blocklist and quarantined domains messagebars being both shown. r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D229489
 2024-11-20 17:03:16 +00:00
Luca Greco
5c78a8cdcd Bug 1931889 - Add a new string for the extensions button tooltip on addons disabled through the add-ons blocklist. r=willdurand,fluent-reviewers 
Depends on D229617

Differential Revision: https://phabricator.services.mozilla.com/D229393
 2024-11-20 17:03:16 +00:00
Luca Greco
70d20c5caf Bug 1917848 - Show blocklist attention dot and blocklist messagebar message on new hard/soft blocked extensions (Extensions Button frontend changes). r=fluent-reviewers,willdurand,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D228677
 2024-11-20 17:03:15 +00:00
Sebastian Hengst
8424c52dc1 Bug 1922355 - macOS 14.70: adjust expectations for mochitests and xpcshell tests. r=jmaher,necko-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D228118
 2024-11-19 17:19:24 +00:00
Moritz Beier
2b92ce5826 Bug 1655066 - Search Engine icons should be indexed by width only. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D226921
 2024-11-11 09:09:18 +00:00
Moritz Beier
b5c5b45a52 Bug 1924071 - Remove the purpose option from search URLs. r=Standard8,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D226165
 2024-11-08 09:20:19 +00:00
Rob Wu
93a46af209 Bug 1929002 - Correct extension-specific globals in eslintrc r=geckoview-reviewers,frontend-codestyle-reviewers,Standard8 
- Add all current globals from _createExtGlobal in .eslintrc.js.

- Remove non-existing globals.

- State the sources of the extension-specific globals in .eslintrc.js.

- Move extension-specific globals from common mobile/shared/ to a deeper
  level at mobile/shared/components/extensions/.

- Remove obsolete globals/exported/import-globals-from comments from
  various ext-*.js files.

- Fix linting errors in some tests due to use of non-global globals,
  that have become apparent due to the corrected linter definitions.

Differential Revision: https://phabricator.services.mozilla.com/D228308
 2024-11-07 18:34:00 +00:00
Emilio Cobos Álvarez
fa9120c5f7 Bug 1927967 - Make sure nsDocumentViewer::GetContentSize doesn't leave layout and visual viewports in inconsistent states. r=hiro,extension-reviewers,robwu 
This getContentSize API is rather hairy:

 * Web extension popups use getContentSize to measure the document in https://searchfox.org/mozilla-central/rev/fcf53e1685bfb990b5abc7312ac1daf617f0991f/toolkit/components/extensions/ext-browser-content.js#253
 * That leaves the returned size as the layout viewport (so innerHeight and innerWidth are the "right" size): https://searchfox.org/mozilla-central/rev/fcf53e1685bfb990b5abc7312ac1daf617f0991f/layout/base/nsDocumentViewer.cpp#2634
 * However the visual viewport is not updated, and that's what we scroll into view into. That's only updated way later, via:

```
MobileViewportManager::RefreshViewportSize
in nsDocumentViewer::SetBoundsWithFlags
in nsDocShell::SetPositionAndSize
in nsWebBrowser::SetPositionAndSize
in mozilla::dom::BrowserChild::RecvUpdateDimensions
in mozilla::dom::PBrowserChild::OnMessageReceived
[snip]
```

Make sure we leave the layout and visual viewport in a consistent state.

Differential Revision: https://phabricator.services.mozilla.com/D228119
 2024-11-06 12:22:36 +00:00
Rebecca King
9616f2715c Bug 1926373 - Calling window.close from a Web Extension-registered devtools panel shouldn't close the browser chrome window r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D227129
 2024-11-05 11:52:11 +00:00
Rebecca King
4383ed7e3d Bug 1921631 - window.close does not close sidebar - r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D224365
 2024-10-22 19:31:59 +00:00
Dão Gottwald
f049ccd8d8 Bug 1925842 - Rename _numPinnedTabs to pinnedTabCount. r=tabbrowser-reviewers,jswinarton,dwalker 
Also move getDuplicateTabsToClose and getAllDuplicateTabsToClose away from essentials at the top, closer to related methods.

Differential Revision: https://phabricator.services.mozilla.com/D226279
 2024-10-21 14:35:06 +00:00
Dão Gottwald
ef8141753b Bug 1923367 - Go back to using the dropdown icon for all-tabs button when it's in the tabs toolbar. r=desktop-theme-reviewers,tabbrowser-reviewers,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D224961
 2024-10-11 13:45:58 +00:00
Gregory Pappas
ece8e2c351 Bug 1923739 - Stop using MochiKit directory in browser_ext_tabs_query.js r=extension-reviewers,willdurand 
It will be removed in bug 1920857

Differential Revision: https://phabricator.services.mozilla.com/D225136
 2024-10-10 15:04:41 +00:00
Gregory Pappas
8c7823746a Bug 1918681 - part 2: Ensure the list-all-tabs button is visible the first time an extension hides a tab r=extension-reviewers,mconley,dao,willdurand 
Depends on D224623

Differential Revision: https://phabricator.services.mozilla.com/D224624
 2024-10-09 15:17:13 +00:00
Luca Greco
ed2fd2f4ac Bug 1911163 - Add full domains list in addon-webext-permissions-notification permissions list. r=desktop-theme-reviewers,fluent-reviewers,willdurand,bolsson,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D218593
 2024-10-03 16:36:18 +00:00
Sam Foster
58c1f20705 Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements 
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
 2024-10-02 22:14:13 +00:00
Sandor Molnar
ae6fa0e167 Backed out changeset bcfd93872dad (bug 1911163) for causing perma bc failures @ browser_permissions_dismiss.js CLOSED TREE 2024-10-02 20:17:52 +03:00
Luca Greco
c43da85082 Bug 1911163 - Add full domains list in addon-webext-permissions-notification permissions list. r=desktop-theme-reviewers,fluent-reviewers,willdurand,bolsson,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D218593
 2024-10-02 13:56:31 +00:00
Iulian Moraru
4a9432209c Backed out changeset 98b6ddc6deed (bug 1899598) for causing marionette failures on test_initialize_vertical_tabs.py. CLOSED TREE 2024-10-02 07:49:47 +03:00
Sam Foster
15a36fe751 Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements 
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
 2024-10-01 23:37:37 +00:00
Butkovits Atila
07292bcac1 Backed out changeset a31d48c96789 (bug 1911163) for causing failures at browser_parsable_css.js. CLOSED TREE 2024-10-01 19:07:07 +03:00
Luca Greco
b3c444ad3e Bug 1911163 - Add full domains list in addon-webext-permissions-notification permissions list. r=desktop-theme-reviewers,fluent-reviewers,willdurand,bolsson,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D218593
 2024-10-01 12:47:47 +00:00
Stanca Serban
24647acde4 Backed out changeset 0b970f2cd8fd (bug 1899598) for causing devtools failures in browser_aboutdebugging_devtoolstoolbox_tooltip_markupview.js. CLOSED TREE 2024-10-01 01:54:25 +03:00
Florian Quèze
dc117303c1 Bug 1920723 - remove search.engine legacy telemetry event that has been replaced by a Glean event, r=Standard8,settings-reviewers. 
Differential Revision: https://phabricator.services.mozilla.com/D223501
 2024-09-30 18:26:04 +00:00
Sam Foster
ef30ebaf5c Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements 
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
 2024-09-30 18:10:42 +00:00
Dão Gottwald
b05aac4958 Bug 1919790 - Stop returning hidden tabs or tabs from collpased groups in _findTabToBlurTo. r=dwalker,tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D223292
 2024-09-25 05:08:37 +00:00
William Durand
79188dd075 Bug 1920706 - Anchor "all-tabs" popup to the extensions button. r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D223318
 2024-09-24 17:49:39 +00:00
Luca Greco
8235fdaa61 Bug 1920720 - testBrowserActionWithVerticalTabs pushPrefEnv should include sidebar.revamp pref along with sidebar.verticalTabs. r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D223344
 2024-09-24 15:11:23 +00:00
Luca Greco
a743945aa9 Bug 1919306 - Fix browser_ext_tabs_query.js failure hit on asserting tabs.query tab's width and height values. r=willdurand 
I've hit this failure in one of my push to try (which included changes unrelated to this test), and I was able to reproduce
it consistently on Windows builds locally (and so at least locally it seems to be a perma-failure and not an intermittent).

Waiting for the chrome window document to be flushed before retrieving the clientWidth and clientHeight from the currently
selected browser element was consistently preventing the failure from being hit locally on a windows VM (and it did also
pass a run with --verify).

Differential Revision: https://phabricator.services.mozilla.com/D222844
 2024-09-20 15:04:52 +00:00
Florian Quèze
96ab8a3106 Bug 1918702 - Migrate telemetry events to use Glean APIs for homepage.preference events, r=chutten,extension-reviewers,robwu. 
Differential Revision: https://phabricator.services.mozilla.com/D222167
 2024-09-20 13:58:14 +00:00
Joel Maher
1217ef421e Bug 1919776 - part 1, adjust browser/base and browser/components osx skip-if conditions to be more specific. r=sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D222841
 2024-09-20 13:15:23 +00:00
Joel Maher
beccd9e33d Bug 1917222 - remove skip-if statements when the tests pass for browser-chrome browser/components/a-pref. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,robwu,mconley,dimi,nsharpley,thecount,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D221307
 2024-09-19 02:52:04 +00:00
William Durand
78219a3fdc Bug 1910202 - Ensure extension widgets cannot be placed in a hidden area. r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D222105
 2024-09-17 12:36:57 +00:00
Mark Banner
1cff4ca2d1 Bug 1918386 - browser.search.get() should be returning data URIs for application provided search engines. r=extension-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D222264
 2024-09-16 14:50:58 +00:00
Joel Maher
02bf7c92f9 Bug 1917073 - adjust skip-if -> run-if for browser/components/.../browser.toml. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,places-reviewers,mtigley,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D221247
 2024-09-16 06:12:31 +00:00
Mark Banner
fe5b823483 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 21:08:44 +00:00
Sandor Molnar
b59809ee6a Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE 
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
 2024-09-12 20:45:28 +03:00
Mark Banner
4b68d25082 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 16:41:59 +00:00
Dão Gottwald
58fefccb92 Bug 1910203 - Update all-tabs button icon so we can move the button into the nav bar when vertical tabs are enabled. r=mconley,rpl,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220592
 2024-09-09 06:10:21 +00:00
Luca Greco
9ac44bcdcd Bug 1915606 - Fix ExtensionControlledPopups dialogs SUMO learn more link position. r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D220562
 2024-09-05 19:53:04 +00:00
Dão Gottwald
47916b2da7 Bug 1916622 - Remove the browser.tabs.tabmanager.enabled pref. r=tabbrowser-reviewers,extension-reviewers,desktop-theme-reviewers,emilio,robwu,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D221005
 2024-09-05 13:37:09 +00:00