Commit Graph

88 Commits

Author SHA1 Message Date
Beth Rennie
39035fa485 Bug 1961036 - Remove ExperimentAPI.getExperiment r=relud,mconley,nimbus-reviewers,omc-reviewers,home-newtab-reviewers,aminomancer,chumphreys
All the callers of this function in tree can be replaced with
`get{Experiment,Rollout}MetaData`.

Differential Revision: https://phabricator.services.mozilla.com/D245985
2025-04-23 00:13:37 +00:00
Florian Quèze
2ea57560fd Bug 1950710 - Migrate histograms to use Glean APIs for MS_MESSAGE_REQUEST_TIME_MS, r=chutten,omc-reviewers,mviar.
Differential Revision: https://phabricator.services.mozilla.com/D242518
2025-03-26 14:41:10 +00:00
Shane Hughes
e7f24e223a Bug 1948423 - Skip targeting and trigger listener creation for messages with skip_in_tests. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D238374
2025-03-07 04:36:57 +00:00
Gregory Pappas
2300895022 Bug 1750304 - Move isChinaRepack out of AppConstants r=settings-reviewers,home-newtab-reviewers,Gijs,pdahiya,omc-reviewers,mossop,mconley
AppConstants seems like the wrong place for this method

Differential Revision: https://phabricator.services.mozilla.com/D239276
2025-02-25 20:46:37 +00:00
Goloman Adrian
3624802d33 Backed out changeset 8b98d8d87760 (bug 1948423) for causing bc failures @browser_foxdoodle_set_default.js. CLOSED TREE 2025-02-20 06:56:38 +02:00
Shane Hughes
378d8ec5e5 Bug 1948423 - Skip targeting and trigger listener creation for messages with skip_in_tests. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D238374
2025-02-20 03:03:45 +00:00
Mike Conley
0cab9e0390 Bug 1938452 - Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount
This doesn't move test_AboutNewTab.js, as this test exercises the AboutNewTab
module under browser/modules/ and the AboutNewTabService component under
browser/components/newtab.

Differential Revision: https://phabricator.services.mozilla.com/D233873
2025-02-03 16:45:33 +00:00
Alexandru Marc
88e7c19d5c Backed out 10 changesets (bug 1938452) for causing node failures CLOSED TREE
Backed out changeset f6a771e83261 (bug 1938452)
Backed out changeset 69f385bc90ce (bug 1938452)
Backed out changeset 9c8837fc4805 (bug 1938452)
Backed out changeset c9737e213e42 (bug 1938452)
Backed out changeset ac0a50aaf347 (bug 1938452)
Backed out changeset f1f41e902e36 (bug 1938452)
Backed out changeset aef74a3d077d (bug 1938452)
Backed out changeset 8ca1a633192a (bug 1938452)
Backed out changeset 88df910fa038 (bug 1938452)
Backed out changeset cd4fdafb2594 (bug 1938452)
2025-02-03 18:28:59 +02:00
Mike Conley
5cc1e5190e Bug 1938452 - Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount
This doesn't move test_AboutNewTab.js, as this test exercises the AboutNewTab
module under browser/modules/ and the AboutNewTabService component under
browser/components/newtab.

Differential Revision: https://phabricator.services.mozilla.com/D233873
2025-02-03 15:07:10 +00:00
Punam Dahiya
a7b627a8a4 Bug 1942895 - Move FilterAdult into shared browser/modules folder r=home-newtab-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D235259
2025-01-23 23:07:57 +00:00
Tooru Fujisawa
8084bcd8ca Bug 1881888 - Part 10: Remove ChromeUtils.import. r=Standard8,mccr8,profiler-reviewers,omc-reviewers,home-newtab-reviewers,julienw,mconley,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D233722
2025-01-23 05:21:58 +00:00
Tooru Fujisawa
ac7fdd6102 Bug 1881888 - Part 9: Remove ChromeUtils.defineModuleGetter. r=Standard8,mccr8,profiler-reviewers,omc-reviewers,home-newtab-reviewers,julienw,mconley,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D233721
2025-01-23 05:21:58 +00:00
Tooru Fujisawa
6de3931fde Bug 1940422 - Remove XPCOMUtils.defineLazyModuleGetters. r=mccr8,credential-management-reviewers,omc-reviewers,home-newtab-reviewers,mconley,pdahiya,dimi
Differential Revision: https://phabricator.services.mozilla.com/D233379
2025-01-23 05:21:54 +00:00
Punam Dahiya
4f67dc494e Bug 1937170 - Transfer ownership of ActivityStreamStorage to ASRouter r=backup-reviewers,home-newtab-reviewers,omc-reviewers,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D234113
2025-01-22 05:59:40 +00:00
Punam Dahiya
8050d3e240 Bug 1939918 - Remove newtab utils dependancy in aboutwelcome and asrouter karma unit tests r=omc-reviewers,mconley,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D233428
2025-01-13 17:52:42 +00:00
Punam Dahiya
f52a594a1a Bug 1866170 - Give about:welcome and asrouter their own try-runner.js test job runner scripts r=home-newtab-reviewers,omc-reviewers,mviar,mconley,ahal
Differential Revision: https://phabricator.services.mozilla.com/D233111
2025-01-09 22:20:59 +00:00
Mike Conley
4647ce1c30 Bug 1937234 - Add signed out avatar variants. r=skhamis,emilio,omc-reviewers,pdahiya
These variants are controlled via the avatarIconVariant variable of the
fxaButtonVisibility feature.

Differential Revision: https://phabricator.services.mozilla.com/D232128
2024-12-20 16:07:56 +00:00
Sammy Khamis
6a8f7f80ad Bug 1936922: Cache response from listAttachedOAuthClients to prevent unnecessary network calls r=markh,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D232006
2024-12-17 23:09:53 +00:00
Florian Quèze
a41844c552 Bug 1931901 - remove leftover test references to legacy scalar APIs, r=chutten,geckoview-reviewers,extension-reviewers,home-newtab-reviewers,robwu,ohall,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D229929
2024-12-10 10:31:58 +00:00
Tooru Fujisawa
0f29352379 Bug 1934048 - Update obsoleve comments about JSM in browser/components/asrouter/tests/unit/ASRouter.test.js. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D230566
2024-12-05 00:04:59 +00:00
Chris H-C
724b00c304 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-08 20:14:42 +00:00
Sandor Molnar
92076e16a7 Backed out 5 changesets (bug 1920562) for causing xpc assertion failures. CLOSED TREE
Backed out changeset 8f085ab589a8 (bug 1920562)
Backed out changeset 4405387ae770 (bug 1920562)
Backed out changeset a68fd13a33ae (bug 1920562)
Backed out changeset cd3672fc08ed (bug 1920562)
Backed out changeset 62ab18879eea (bug 1920562)
2024-10-08 00:16:13 +03:00
Chris H-C
e944bfe7a2 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-07 17:29:57 +00:00
Florian Quèze
93b33a0974 Bug 1922217 - Migrate telemetry events to use Glean APIs for messaging_experiments, r=chutten,omc-reviewers,pdahiya.
Differential Revision: https://phabricator.services.mozilla.com/D223291
2024-10-03 11:45:27 +00:00
Julian Descottes
fba56f38cc Bug 1917003 - [eslint] Fix violations for reject-multiple-await r=perftest-reviewers,credential-management-reviewers,places-reviewers,issammani,daisuke,sparky
Depends on D221187

Differential Revision: https://phabricator.services.mozilla.com/D221306
2024-09-16 09:13:30 +00:00
Nipun Shukla
415fe6c69b Bug 1905090 - Update strings to reflect MSIX pin to start functionality r=fluent-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mak,mviar
Differential Revision: https://phabricator.services.mozilla.com/D216709
2024-07-24 21:13:36 +00:00
Moritz Beier
9d7c26eff8 Bug 1903247 - Remove SearchEngine.searchForm. r=Standard8,omc-reviewers,home-newtab-reviewers,aminomancer,urlbar-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D214240
2024-06-26 16:03:23 +00:00
Shane Hughes
259507acf6 Bug 1861248 - Overhaul ASRouter admin and remove its dependency on newtab. r=omc-reviewers,emcminn
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.

Differential Revision: https://phabricator.services.mozilla.com/D213865
2024-06-19 19:45:03 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
2024-06-19 19:45:01 +00:00
Shane Hughes
b7111cb1ca Bug 1899439 - Flatten experiment-translated messages in local providers so they can be rendered. r=negin,omc-reviewers,emcminn,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D211946
2024-06-18 10:42:27 +00:00
Stanca Serban
47ba18b7d7 Backed out changeset f6ca02568bef (bug 1899439) for causing xcpshell failures in xpcshell/test_PanelTestProvider.js. CLOSED TREE 2024-06-18 05:14:28 +03:00
Shane Hughes
91acd11433 Bug 1899439 - Flatten experiment-translated messages in local providers so they can be rendered. r=negin,omc-reviewers,emcminn,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D211946
2024-06-17 17:52:59 +00:00
Shane Hughes
039ba4cf7a Bug 1899757 - Allow targeting the trigger tab for feature callouts. r=hanna_a,omc-reviewers
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Differential Revision: https://phabricator.services.mozilla.com/D212494
2024-06-16 23:05:10 +00:00
Aron Cseh
f28964fa3c Backed out changeset 98c3d77b4330 (bug 1899757) for causing multiple failures CLOSED TREE 2024-06-16 23:21:14 +03:00
Shane Hughes
6ef1ca7a31 Bug 1899757 - Allow targeting the trigger tab for feature callouts. r=hanna_a,omc-reviewers
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Differential Revision: https://phabricator.services.mozilla.com/D212494
2024-06-16 19:11:41 +00:00
Shane Hughes
8dd336f8c5 Bug 1893671 - Add Fx113 facebook container experiment message in CFRMessageProvider. r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D208941
2024-05-02 20:54:51 +00:00
dschomburg
9f03a40c4f Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Emily McMinn
17efb5e7e2 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D205344
2024-03-28 16:26:14 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Mark Banner
1ad86cf71a Bug 1881816 - Rename ActorConstants.sys.mjs to ActorConstants.mjs. r=amy,omc-reviewers,aminomancer
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203401
2024-03-19 17:01:38 +00:00
Dave Townsend
35c104ff31 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-03 09:09:08 +00:00
Punam Dahiya
d3035fa703 Bug 1879638 - Update Old references to asrouter and aboutwelcome files r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D203330
2024-03-02 02:36:24 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
20b5d8c60f Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 15:20:17 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
d5beece355 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 10:10:08 +00:00
Shane Hughes
37f30cffbd Bug 1881106 - Move ModalOverlay.test.jsx to newtab directory. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D202255
2024-02-27 18:52:20 +00:00
Mark Banner
55dda230bd Bug 1881817 - Move all asrouter/content-src/*.js files which are modules to use .mjs extensions. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D202622
2024-02-24 10:00:59 +00:00
Mike Conley
6227d37b2c Bug 1878731 - Convert ASRouter to an ESM. r=emcminn,pip-reviewers,fxview-reviewers,omc-reviewers,sfoster,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D201138
2024-02-12 18:49:38 +00:00
Mike Conley
c22c73b7ab Bug 1878731 - Convert ASRouterPreferences to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201134
2024-02-12 18:49:37 +00:00