1. Fix these Settings links to open in a new tab like Settings' other "Learn more" links:
* The "Learn more" link for "Suggest Firefox Relay email masks to protect your email address"
* The Privacy Notice link for "Firefox Data Collection and Use"
* The "Learn more" link for "Allow Firefox to send technical and interaction data to Mozilla"
* The "View Firefox Studies" (about:studies) link for "Allow Firefox to install and run studies"
2. Also remove a redundant `target="_blank"` in searchResults.inc.xhtml because the link's `is="moz-support-link"` attribute will cause the link to open in a new tab.
Differential Revision: https://phabricator.services.mozilla.com/D223080
This makes `browser_search_firefoxSuggest.js` more realistic by installing a
Nimbus experiment to change the Suggest scenario instead of manually setting the
scenario via the helper function. (The "scenario" just means whether Suggest is
enabled or not, basically. "history" means it's not enabled; "offline" and
"online" mean it's enabled. The difference between the latter two is that in
"online" the user has opted in to the Merino server, and that only means one of
the Suggest prefs is true instead of false.)
I noticed `browser_privacy_firefoxSuggest.js` does not check the visibility of
its Suggest section at all, so I added similar tasks to it and factored out the
common helpers into `head.js`.
Depends on D221097
Differential Revision: https://phabricator.services.mozilla.com/D221099
In addition to addressing the bug, this also adds some exposure tests to make
sure that they can be triggered in non-Suggest locales and that non-exposure
suggestions are not triggered.
Depends on D220501
Differential Revision: https://phabricator.services.mozilla.com/D221097
I'm not able to reproduce the error locally, but presumably it's due to occasional long delays encountered with Fluent formatting in chaos mode.
Differential Revision: https://phabricator.services.mozilla.com/D219633
Disabling `MOZ_DATA_REPORTING` results in the `PREF_UPLOAD_ENABLED` pref not
being loaded with `Preferences.add`. This means
`Preferences.get(PREF_UPLOAD_ENABLED)` can possibly be `null`, which was
previously not handled and resulted in an error for the whole privacy.js file.
So only call `dataCollectionCheckboxHandler` for the `privateAttribution`
checkbox if `MOZ_DATA_REPORTING` is enabled (otherwise the `privateAttribution`
checkbox also just doesn't exist). Also move the call into separate
`initPrivateAttributionCheckbox` function to be more consistent with previous
code.
Differential Revision: https://phabricator.services.mozilla.com/D218265
Move featuregate title to features.ftl used by about:preferences and about:support; and other strings to genai.ftl. Allow prompts to use l10nId to get fluent attributes. Convert inline strings for menu and shortcuts to fluent. Update simplify, add explain prompts.
Differential Revision: https://phabricator.services.mozilla.com/D218279
Switch default shortcuts enabled with labs checkbox to disable and labs visibility. Add metric and event telemetry for shortcuts pref and usage. Bump pip labs ordering up one.
Differential Revision: https://phabricator.services.mozilla.com/D217782
Switch default shortcuts enabled with labs checkbox to disable and labs visibility. Add metric and event telemetry for shortcuts pref and usage. Bump pip labs ordering up one.
Differential Revision: https://phabricator.services.mozilla.com/D217782
Went with adding margin-block-end to achieve the ~4px spacing between
label and select, and between select and description.
Also adds the "input-space-block" token.
Differential Revision: https://phabricator.services.mozilla.com/D216336
This patch includes:
- A new UrlbarProviderRestrictKeywords class
- Showing localized Search with Bookmarks, Search with History, Search with Tabs results after the user types @
- Add search restrict keywords to preferences UI Search Shortcuts table
- Hiding search restrict keyword behind browser.urlbar.searchRestrictKeywords.featureGate pref
Differential Revision: https://phabricator.services.mozilla.com/D213697
This was the feature flag behind which the settings page's 'search' functionality was written.
It's been there for years now, and it is high time to clean this up.
Differential Revision: https://phabricator.services.mozilla.com/D217034
