Commit Graph

64 Commits

Author SHA1 Message Date
Julian Descottes
fba56f38cc Bug 1917003 - [eslint] Fix violations for reject-multiple-await r=perftest-reviewers,credential-management-reviewers,places-reviewers,issammani,daisuke,sparky
Depends on D221187

Differential Revision: https://phabricator.services.mozilla.com/D221306
2024-09-16 09:13:30 +00:00
Nipun Shukla
415fe6c69b Bug 1905090 - Update strings to reflect MSIX pin to start functionality r=fluent-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mak,mviar
Differential Revision: https://phabricator.services.mozilla.com/D216709
2024-07-24 21:13:36 +00:00
Moritz Beier
9d7c26eff8 Bug 1903247 - Remove SearchEngine.searchForm. r=Standard8,omc-reviewers,home-newtab-reviewers,aminomancer,urlbar-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D214240
2024-06-26 16:03:23 +00:00
Shane Hughes
259507acf6 Bug 1861248 - Overhaul ASRouter admin and remove its dependency on newtab. r=omc-reviewers,emcminn
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.

Differential Revision: https://phabricator.services.mozilla.com/D213865
2024-06-19 19:45:03 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
2024-06-19 19:45:01 +00:00
Shane Hughes
b7111cb1ca Bug 1899439 - Flatten experiment-translated messages in local providers so they can be rendered. r=negin,omc-reviewers,emcminn,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D211946
2024-06-18 10:42:27 +00:00
Stanca Serban
47ba18b7d7 Backed out changeset f6ca02568bef (bug 1899439) for causing xcpshell failures in xpcshell/test_PanelTestProvider.js. CLOSED TREE 2024-06-18 05:14:28 +03:00
Shane Hughes
91acd11433 Bug 1899439 - Flatten experiment-translated messages in local providers so they can be rendered. r=negin,omc-reviewers,emcminn,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D211946
2024-06-17 17:52:59 +00:00
Shane Hughes
039ba4cf7a Bug 1899757 - Allow targeting the trigger tab for feature callouts. r=hanna_a,omc-reviewers
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Differential Revision: https://phabricator.services.mozilla.com/D212494
2024-06-16 23:05:10 +00:00
Aron Cseh
f28964fa3c Backed out changeset 98c3d77b4330 (bug 1899757) for causing multiple failures CLOSED TREE 2024-06-16 23:21:14 +03:00
Shane Hughes
6ef1ca7a31 Bug 1899757 - Allow targeting the trigger tab for feature callouts. r=hanna_a,omc-reviewers
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Differential Revision: https://phabricator.services.mozilla.com/D212494
2024-06-16 19:11:41 +00:00
Shane Hughes
8dd336f8c5 Bug 1893671 - Add Fx113 facebook container experiment message in CFRMessageProvider. r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D208941
2024-05-02 20:54:51 +00:00
dschomburg
9f03a40c4f Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Emily McMinn
17efb5e7e2 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D205344
2024-03-28 16:26:14 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Mark Banner
1ad86cf71a Bug 1881816 - Rename ActorConstants.sys.mjs to ActorConstants.mjs. r=amy,omc-reviewers,aminomancer
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203401
2024-03-19 17:01:38 +00:00
Dave Townsend
35c104ff31 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-03 09:09:08 +00:00
Punam Dahiya
d3035fa703 Bug 1879638 - Update Old references to asrouter and aboutwelcome files r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D203330
2024-03-02 02:36:24 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
20b5d8c60f Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 15:20:17 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
d5beece355 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 10:10:08 +00:00
Shane Hughes
37f30cffbd Bug 1881106 - Move ModalOverlay.test.jsx to newtab directory. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D202255
2024-02-27 18:52:20 +00:00
Mark Banner
55dda230bd Bug 1881817 - Move all asrouter/content-src/*.js files which are modules to use .mjs extensions. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D202622
2024-02-24 10:00:59 +00:00
Mike Conley
6227d37b2c Bug 1878731 - Convert ASRouter to an ESM. r=emcminn,pip-reviewers,fxview-reviewers,omc-reviewers,sfoster,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D201138
2024-02-12 18:49:38 +00:00
Mike Conley
c22c73b7ab Bug 1878731 - Convert ASRouterPreferences to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201134
2024-02-12 18:49:37 +00:00
Mike Conley
419fa8c4b8 Bug 1878731 - Convert ASRouterTargeting to an ESM. r=emcminn,application-update-reviewers,omc-reviewers,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D201133
2024-02-12 18:49:37 +00:00
Mike Conley
bac643012b Bug 1878731 - Convert ASRouterTriggerListeners to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201129
2024-02-12 18:49:36 +00:00
Mike Conley
2f152b878f Bug 1878731 - Convert ASRouterParentProcessMessageHandler to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201127
2024-02-12 18:49:36 +00:00
Mike Conley
0cd6316b40 Bug 1878731 - Convert CFRPageActions to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201126
2024-02-12 18:49:35 +00:00
Mike Conley
d322adbf27 Bug 1878731 - Convert OnboardingMessageProvider to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201125
2024-02-12 18:49:35 +00:00
Mike Conley
4c988cb8f1 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201124
2024-02-12 18:49:34 +00:00
Mike Conley
af147ef4b2 Bug 1878731 - Convert ToolbarBadgeHub to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201123
2024-02-12 18:49:34 +00:00
Mike Conley
cbeae19a3b Bug 1878281 - Stub out NEWTAB_MESSAGE_REQUEST handling for legacy privileged addons. r=mkaply,omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D201094
2024-02-09 21:29:46 +00:00
Mark Banner
b3b56aa2eb Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200591
2024-02-07 08:55:33 +00:00
Mark Banner
12a8012f22 Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200590
2024-02-07 08:55:32 +00:00
Cristian Tuns
8829a8d6c5 Backed out 11 changesets (bug 1878554, bug 1878553, bug 1878556) for causing node failures in aboutwelcome CLOSED TREE
Backed out changeset 425f70fa7e5a (bug 1878556)
Backed out changeset 2ab3a28f5c04 (bug 1878556)
Backed out changeset fb2e02682c8c (bug 1878556)
Backed out changeset 2fc5e630568e (bug 1878554)
Backed out changeset 78839d5841b4 (bug 1878554)
Backed out changeset e0ab31d2de1b (bug 1878554)
Backed out changeset 4eb59e4ebafa (bug 1878554)
Backed out changeset ab1e077d3f84 (bug 1878554)
Backed out changeset ef999f293e3e (bug 1878553)
Backed out changeset cf49920cb1ad (bug 1878553)
Backed out changeset 95f0fce63726 (bug 1878553)
2024-02-07 01:26:39 -05:00
Mark Banner
f15c9c508b Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200591
2024-02-06 22:32:55 +00:00
Mark Banner
ed1bb292be Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200590
2024-02-06 22:32:54 +00:00
Mike Conley
02fbf941fd Bug 1877196 - Move ActorConstants.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
We import the ActorConstants into the ASRouter unit-entry.js script because
ASRouterChild.sys.mjs loads ActorConstants.sys.mjs, and the ResourceUriPlugin
that does the rewriting for the Karma tests doesn't understand how to do
remapping outside of the newtab folder.

So instead of trying to hack that capability into ResourceUriPlugin, we
just import the ActorConstants into the Karma global scope.

Differential Revision: https://phabricator.services.mozilla.com/D200087
2024-02-05 22:03:15 +00:00
Mike Conley
00c7162ee1 Bug 1877196 - Move MomentsPageHub.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200083
2024-02-05 22:03:14 +00:00
Mike Conley
19a6e40b11 Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200082
2024-02-05 22:03:13 +00:00
Mike Conley
6779808f9c Bug 1877196 - Move ToolbarBadgeHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200081
2024-02-05 22:03:13 +00:00
Mike Conley
378c760146 Bug 1868838 - Move PanelTestProvider to browser/components/asrouter/modules. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D198999
2024-01-29 18:52:28 +00:00
Mike Conley
ab18bd7d99 Bug 1868838 - Move OnboardingMessageProvider to browser/components/asrouter/modules. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D198997
2024-01-29 18:52:28 +00:00
Mike Conley
c7eea981cf Bug 1868838 - Move ASRouter unit test constants to browser/components/asrouter. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D198956
2024-01-29 18:52:27 +00:00
Mike Conley
523d9e2457 Bug 1868838 - Move messaging schemas into browser/components/asrouter. r=pdahiya,barret
Differential Revision: https://phabricator.services.mozilla.com/D198955
2024-01-29 18:52:27 +00:00
Mike Conley
d7120d9f2d Bug 1868838 - Move ASRouter docs into browser/components/asrouter. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D198891
2024-01-29 18:52:25 +00:00
Mike Conley
7fc079d515 Bug 1868838 - Move template-utils into browser/components/asrouter. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D198890
2024-01-29 18:52:24 +00:00
Mike Conley
ef3fd292cf Bug 1868838 - Move asrouter-utils into browser/components/asrouter. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D198883
2024-01-29 18:52:23 +00:00