corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
621,865 Commits 1 Branch 0 Tags
502b80b17b85a7ed3a679b39b730ec194f07c246
Commit Graph

111 Commits

Author SHA1 Message Date
Tom Schuster
0700472892 Bug 1558915 - Use infallible nsIURI::SchemeIs in toolkit/ r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D40323
 2019-08-02 16:31:54 +00:00
Mihai Alexandru Michis
5a74ddfbef Backed out 2 changesets (bug 1558915) for causing bustages. CLOSED TREE 
Backed out changeset e44c9fd81e5b (bug 1558915)
Backed out changeset 3da6e9e86be4 (bug 1558915)
 2019-08-02 12:17:42 +03:00
Tom Schuster
b637c03f89 Bug 1558915 - Use infallible nsIURI::SchemeIs in toolkit/ r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D40323
 2019-08-02 08:54:18 +00:00
Sylvestre Ledru
ad31adba4c Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956
 2019-05-01 08:47:10 +00:00
dlee
456f351169 Bug 1522412 - P4. Use LOAD_BYPASS_URL_CLASSIFIER flag for SafeBrowsing update/lookup r=Ehsan 
We want to ensure SafeBrowsing update request is never classified so we
can recover from a bad SafeBrowsing database.

SafeBrowsing lookup request is also critical because if it is blocked,
it means SafeBrowsing is out of function.

Differential Revision: https://phabricator.services.mozilla.com/D22113
 2019-03-25 12:49:00 +00:00
Gurzau Raul
8cd94b1658 Backed out 7 changesets (bug 1522412) for xpcshell failures at test_shouldclassify.js on a CLOSED TREE. 
Backed out changeset 7c998456e1fd (bug 1522412)
Backed out changeset ebb581ddf1d1 (bug 1522412)
Backed out changeset 850e1c68d978 (bug 1522412)
Backed out changeset fe288a48cecb (bug 1522412)
Backed out changeset 5399bca472b1 (bug 1522412)
Backed out changeset 91e5b339fe11 (bug 1522412)
Backed out changeset b80098d0a5c4 (bug 1522412)
 2019-03-21 11:02:09 +02:00
Dimi Lee
c8b2433ea0 Bug 1522412 - P4. Use LOAD_BYPASS_URL_CLASSIFIER flag for SafeBrowsing update/lookup r=Ehsan 
We want to ensure SafeBrowsing update request is never classified so we
can recover from a bad SafeBrowsing database.

SafeBrowsing lookup request is also critical because if it is blocked,
it means SafeBrowsing is out of function.

Differential Revision: https://phabricator.services.mozilla.com/D22113
 2019-03-21 07:33:34 +00:00
Andrea Marchesini
3ce93fb8e0 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538
 2019-03-08 09:04:11 +00:00
Ciure Andrei
899292bc3f Backed out 16 changesets (bug 1525245) for perma failing test_document_cookie.html CLOSED TREE 
Backed out changeset 3fd27215698f (bug 1525245)
Backed out changeset d9a9e8e77873 (bug 1525245)
Backed out changeset 0e6f7be92e3f (bug 1525245)
Backed out changeset 6790802e2fa5 (bug 1525245)
Backed out changeset a5a9e01116ed (bug 1525245)
Backed out changeset 66e19a0c38dd (bug 1525245)
Backed out changeset fb90d51ba853 (bug 1525245)
Backed out changeset 4772db3625b3 (bug 1525245)
Backed out changeset 9affaf0cb998 (bug 1525245)
Backed out changeset a91b7ebe8bdd (bug 1525245)
Backed out changeset c2a13a7480e1 (bug 1525245)
Backed out changeset abe4482fa137 (bug 1525245)
Backed out changeset b3920c0bcf84 (bug 1525245)
Backed out changeset 0821b81f2724 (bug 1525245)
Backed out changeset 70bed2ad7899 (bug 1525245)
Backed out changeset 5f72ba232cc8 (bug 1525245)
 2019-03-07 17:54:18 +02:00
Andrea Marchesini
83054c5a7a Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538
 2019-03-07 10:21:15 +00:00
Dorel Luca
9a275b4283 Backed out 16 changesets (bug 1525245) for Android failures. CLOSED TREE 
Backed out changeset 9f8a1b410320 (bug 1525245)
Backed out changeset 0ef284a9a1d5 (bug 1525245)
Backed out changeset 835e5f642a03 (bug 1525245)
Backed out changeset 362f5a8d033c (bug 1525245)
Backed out changeset 9da3ab33cf67 (bug 1525245)
Backed out changeset 6aacd2d6e835 (bug 1525245)
Backed out changeset 8ff9e8f45e02 (bug 1525245)
Backed out changeset 2020227181cc (bug 1525245)
Backed out changeset fc3c64c330b9 (bug 1525245)
Backed out changeset 2762bf88e050 (bug 1525245)
Backed out changeset ffc10fdc50a6 (bug 1525245)
Backed out changeset bb6ade1207d7 (bug 1525245)
Backed out changeset 1875eb5085e4 (bug 1525245)
Backed out changeset 7e4f67a6d6f1 (bug 1525245)
Backed out changeset e671fc9581eb (bug 1525245)
Backed out changeset b89f5def8d0d (bug 1525245)
 2019-03-06 21:07:49 +02:00
Andrea Marchesini
88186754be Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538
 2019-03-06 17:04:06 +00:00
Jonathan Kingston
8397774fdf Bug 1525319 - Removing context from OnDataAvailable r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20881
 2019-02-27 23:42:27 +00:00
Jonathan Kingston
3ef1df37e1 Bug 1525319 - Removing context from OnStopRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20770
 2019-02-27 23:41:31 +00:00
Jonathan Kingston
649c453cbd Bug 1525319 - Removing context from OnStartRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20769
 2019-02-27 23:41:04 +00:00
Dorel Luca
2dfae9a24a Backed out 4 changesets (bug 1525319) for Android failures in dom/base/test/test_progress_events_for_gzip_data.html 
Backed out changeset b73f033efb41 (bug 1525319)
Backed out changeset 1d318d5c6b98 (bug 1525319)
Backed out changeset 6d73418988d4 (bug 1525319)
Backed out changeset 84ca79bd2dc3 (bug 1525319)
 2019-02-25 04:06:11 +02:00
Jonathan Kingston
b6e28d0b8e Bug 1525319 - Removing context from OnDataAvailable r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20881
 2019-02-24 20:27:55 +00:00
Jonathan Kingston
4334f239c3 Bug 1525319 - Removing context from OnStopRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20770
 2019-02-24 20:26:59 +00:00
Jonathan Kingston
d6fffaf979 Bug 1525319 - Removing context from OnStartRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20769
 2019-02-24 20:26:16 +00:00
Christoph Kerschbaumer
1a72eb2a6b Bug 1528677: Remove nullchecks for loadinfo since we have loadinfo on all channels. r=baku 2019-02-20 13:27:25 +01:00
Andrea Marchesini
0fd63f6e02 Bug 1528596 - Devirtualize accesses to nsUrlClassifierUtils, r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D20086
 2019-02-19 14:35:57 +00:00
Jonathan Kingston
58708e007c Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin 
Replacing js and text occurences of asyncOpen2
Replacing open2 with open

Differential Revision: https://phabricator.services.mozilla.com/D16885
 2019-02-12 16:08:25 +00:00
Kris Maglione
4b169665d2 Bug 1478124: Part 8a - Update toolkit module to use a static component manifest. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D15039
 2018-12-16 16:03:00 -08:00
arthur.iakab
127fb281ff Backed out 16 changesets (bug 1478124) for failing android geckoview-junit CLOSED TREE 
Backed out changeset fce62c77a56b (bug 1478124)
Backed out changeset eb2fa3b5edf7 (bug 1478124)
Backed out changeset 8dacce59fcc0 (bug 1478124)
Backed out changeset 012fd0107204 (bug 1478124)
Backed out changeset 496aaf774697 (bug 1478124)
Backed out changeset 21f4fda03159 (bug 1478124)
Backed out changeset b0444e0bc801 (bug 1478124)
Backed out changeset d94039b19943 (bug 1478124)
Backed out changeset 5d85deac61c2 (bug 1478124)
Backed out changeset 929fd654c9df (bug 1478124)
Backed out changeset 1ddd80d9e91a (bug 1478124)
Backed out changeset b8d2dfdfc324 (bug 1478124)
Backed out changeset f500020a273a (bug 1478124)
Backed out changeset dd00365ebb55 (bug 1478124)
Backed out changeset 538e40c5ee13 (bug 1478124)
Backed out changeset bedaa9c437ad (bug 1478124)
 2019-01-29 10:03:06 +02:00
Kris Maglione
3c9b881f84 Bug 1478124: Part 8a - Update toolkit module to use a static component manifest. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D15039
 2018-12-16 16:03:00 -08:00
Sylvestre Ledru
e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 
# ignore-this-changeset
 2018-11-30 11:46:48 +01:00
Francois Marier
6d04e45e4a Bug 1439455 - Display error names instead of codes in about:url-classifier. r=gcp 
This also changes a few MOZ_LOG() messages to use the error name
instead of the raw numerical nsresult value.

MozReview-Commit-ID: Jcngd0S9j2z
 2018-02-22 17:37:53 -08:00
Andrea Marchesini
3faaf5a84b Bug 1425458 - Resource timing entries Workers - part 0 - NS_NewChannel, r=smaug 
* * *
Bug 1425458 - Resource timing entries Workers - part 10 - Correct parameters in NS_NewChannel in nsDataObj.cpp, r=me
 2018-01-24 17:17:31 +01:00
Brindusan Cristian
1153f2c09e Backed out 12 changesets (bug 1425458) for mochitest failures on WorkerPrivate.cpp on a CLOSED TREE 
Backed out changeset 11997de13778 (bug 1425458)
Backed out changeset 100b9d4f36bc (bug 1425458)
Backed out changeset a29e9dbb8c42 (bug 1425458)
Backed out changeset b96d58fd945c (bug 1425458)
Backed out changeset f140da44ba68 (bug 1425458)
Backed out changeset af56400233d9 (bug 1425458)
Backed out changeset 7034af4332e4 (bug 1425458)
Backed out changeset f70500179140 (bug 1425458)
Backed out changeset 793bbfc23257 (bug 1425458)
Backed out changeset 2efb375a8ffc (bug 1425458)
Backed out changeset 07e781e37451 (bug 1425458)
Backed out changeset e875f3702a5f (bug 1425458)
 2018-01-24 20:47:48 +02:00
Andrea Marchesini
b434804b93 Bug 1425458 - Resource timing entries Workers - part 0 - NS_NewChannel, r=smaug 2018-01-24 17:17:31 +01:00
Kris Maglione
60872d7b31 Bug 1404198: Part 2f - Switch to NS_NewTimer* in toolkit. r=njn 
MozReview-Commit-ID: 185rZ99R6zV
 2017-10-15 23:14:00 -07:00
DimiL
86a5503774 Bug 1384405 - Dump request payload for V2 400 responses. r=francois 
Refactor SafeBrowsing code so we can get the payload of gethash/update request when
updates fail.

MozReview-Commit-ID: NB1oacd185
 2017-10-05 08:37:29 +08:00
Thomas Nguyen
da894bb42f Bug 1351147 - Support ThreatHit requests in SafeBrowsing V4 r=francois 
MozReview-Commit-ID: 3ifQtdOTulE
 2017-08-24 11:13:12 +08:00
Francois Marier
d33e0251eb Bug 1386013 - Log an error when Safe Browsing times out. r=hchang 
MozReview-Commit-ID: A99ov9T7rtm
 2017-07-31 20:29:25 -07:00
Wes Kocher
6b1bdab609 Merge m-c to inbound, a=merge 
MozReview-Commit-ID: LhiAcCiFBus
 2017-07-26 18:33:18 -07:00
Thomas Nguyen
edc3d1fb65 Bug 1381718 : Dump request when receiving 400 error r=hchang 
MozReview-Commit-ID: 1ZFOIRTryiV
 2017-07-25 14:43:11 +08:00
Thomas Nguyen
41442f215a Bug 1378680 - Refactor usage fallible alloc in url-classifier r=francois 
MozReview-Commit-ID: HHG1ByeIwZv
 2017-07-20 16:20:27 +08:00
Bevis Tseng
59627df038 Bug 1382172 - Name nsITimerCallback instances in native implementation. r=billm 2017-07-27 02:18:20 +08:00
DimiL
611d1430b5 Bug 1366965 - Remove telemetry that compare SafeBrowsing V2 & V4. r=francois 
MozReview-Commit-ID: 7vudFBK3rdp
 2017-06-12 11:27:19 +08:00
Francois Marier
e4dd8ef38f Bug 1366394 - Bump the Safe Browsing update timeout to 15s. r=hchang 
Based on the telemetry that landed as part of bug 1336904, Safe Browsing
updates are failing too often: https://mzl.la/2qGkOPS

This should enable browsers on slower networks to reach the update
servers while still putting a reasonable bound on how long the update
thread can be blocked.

MozReview-Commit-ID: 6puVtpMT87K
 2017-05-19 14:25:11 -07:00
Thomas Nguyen
1f65cb8c7a Bug 1336904 - Add timeouts for Safe Browsing updates r=francois 
These timeouts will ensure that we don't block the Safe Browsing update thread
for too long when we encounter slow or bad network conditions.

MozReview-Commit-ID: AJfR193cTf8
 2017-04-24 17:51:06 +08:00
Henry Chang
259a763c10 Bug 1338638 - Fix race condition for DBService APIs to avoid long delayed initial download. r=francois 
When starting up, SafeBrowsing.jsm will try to use DBService to add testing entries. Meanwhile,
listmanager will request StreamUpdater to download lists with a random initial delay.

The requests that listmanager issue to StreamUpdater will be queued up
if DBserve is busy and will be retried when StreamUpdater is notified that
the previous update is complete. However, in some edge cases,
the queued requests may not be processed until the next update request from listmanager.
For example, SafeBrowsing.jsm calls DBService.beginUpdate at t0 and the update is
complete at t1. If listmanager sends all requests via StreamUpdate between t0 and t1,
they will all be queued up and no further request can trigger the queued ones.

So in this patch I add a timer to re-trigger FetchNextRequest() in case StreamUpdater is not
notified the previous update is complete.

MozReview-Commit-ID: 3hHsS5N7WRI
 2017-04-11 17:13:01 +08:00
Thomas Nguyen
75c7b4139d Bug 1336903 - Add telemetry probes to track Safe Browsing server response time r=francois 
The probes keep track of V2 and V4 server response to update and getHash
request. The probes are keyed by provider

MozReview-Commit-ID: 3Uxjm6H77lE
 2017-03-24 15:41:23 +08:00
dimi
2039871388 Bug 1346196 - URLCLASSIFIER_UPDATE_REMOTE_STATUS2 records values using empty keys. r=francois 
mTelemetryProvider might be empty if |CancelUpdate| is called during update.
In that scenario, the call flow will look like:
CancelUpdate -> UpdateError -> DownloadDone -> set mTelemetryProvider to empty ->
OnStartRequest -> record telemetry with empty key.

So in this patch, move mTelemetryProvider.Truncate() to OnStopRequest.

MozReview-Commit-ID: JDgNUqR4SKa
 2017-03-16 14:42:46 +08:00
Henry Chang
c3c42fecfb Bug 1347657 - Use array entry as value instead of reference to avoid being invalidated by realloc. r=francois 
nsTArray::AppendElement may cause memory reallocation if out of capacity.
In nsUrlClassifierStreamUpdater::FetchNextRequest(), we take the reference of
the first element of mPendingRequests and pass its member as reference to
DownloadUpdate(), where mPendingRequests.AppendElement will be called.
If the AppendElement in DownloadUpdate() causes realloc, the reference
becomes dangling.

The most efficient fix is to "move" the reference's (i.e. request)
member variables to DownloadUpdate() but I think in this case we can just
take the value from the array and pass it around with no given that the
array element contains simply a couple of strings and pointers.

MozReview-Commit-ID: KEZ5d3l3HoI
 2017-03-16 15:19:45 +08:00
Henry Chang
b1b06f3fe9 Bug 1346757 - Change the downloadError callback timing. r=francois 
MozReview-Commit-ID: JleLPltEBOw
 2017-03-13 21:16:07 +08:00
Dimi Lee
9792f44648 Bug 1332780 - Add telemetry to record network error while SafeBrowsing update. r=francois 
MozReview-Commit-ID: 7Yqxs0XHmNP
 2017-02-24 09:54:49 +08:00
Tom Tromey
e90d95a3f9 Bug 1060419 - make AppendPrintf and nsPrintfCString use Printf.h, r=froydnj 
MozReview-Commit-ID: 2E8FoiNxU8L
 2016-12-14 09:32:21 -07:00
Tom Tromey
a4b717ab39 Bug 1060419 - make log_print use Printf.h, r=froydnj 
MozReview-Commit-ID: BIZ1GQEZ1vs
 2016-12-15 20:16:31 -07:00
Tim Huang
b3fb2c8458 Bug 1336802 - Part 2: Updating the whole code base to make sure nsILoadInfo get null check. r=smaug 2017-02-07 11:49:34 +08:00