corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
621,865 Commits 1 Branch 0 Tags
502b80b17b85a7ed3a679b39b730ec194f07c246
Commit Graph

340 Commits

Author SHA1 Message Date
dlee
6aec2a81df Bug 1562822 - P2. Reset corrupted Safe Browsing database before triggering an update. r=gcp 
Patch P2 & P3 refine how Safe Browsing handles Safe Browsing database
loading failure.

Safe Browsing databases are read in 3 scenarios:
1. |GetLookupCache| is called on startup. Safe Browsing reads prefix
files in this case. Metadata for updates(.sbstore, .metadata) are not
read in this scenario.

2. |TableRequest| is called before applying an update, Safe Browsing
reads update metadata to apply a partial update.

3. During an update, Safe Browsing reads both prefix files and metadata
in order to merge the update result.

For Case 1, we reset a table's database only when it returns FILE_CORRUPTED
while loading prefixes from the prefix file(.vlpset).

For Case 2, we reset a table's database when the table fails to load its
metadata file or prefix file. This is because we need to make sure both
files are complete so we can correctly perform a partial update.
Note that in this case, we don't just reset the database when "FILE_CORRUPTED"
is detected, we reset the database as long as an error occurs while loading the
database.

For Case 3, For all the tables failing to load their database during an
updating process, the databases of those tables will be reset.

Case 1 and Case 2 are done in Patch P2; Case 3 is done in Patch P3

Differential Revision: https://phabricator.services.mozilla.com/D42614
 2019-08-21 12:08:03 +00:00
dlee
6efea46955 Bug 1553951 - Safe Browsing doesn't call the lookup callback when an error occurs in DoLocalLookup. r=baku 
Firefox cannot open any URL when Safe Browsing database is corrupted.
This is because when Necko asks URL Classifier to classify an URL, it
first suspends the channel, and then wait for a callback to see if the
channel should be canceled or resumed.

In this bug, DoLocalLookup returns an error because Safe Browsing is not
able to read its database(database is corrupted), but we don't call the
callback to resume loading channel, so users cannot load any website.

This patch adds a scope exit handler to make sure the callback will
always be invoked.

Differential Revision: https://phabricator.services.mozilla.com/D36456
 2019-07-01 13:26:44 +00:00
shindli
1ca14e50c0 Backed out changeset b308a5b128aa (bug 1553951) for causing bustages in builds/worker/workspace/build/src/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp CLOSED TREE 2019-07-01 14:45:59 +03:00
dlee
98dc7e8300 Bug 1553951 - Safe Browsing doesn't call the lookup callback when an error occurs in DoLocalLookup. r=baku 
Firefox cannot open any URL when Safe Browsing database is corrupted.
This is because when Necko asks URL Classifier to classify an URL, it
first suspends the channel, and then wait for a callback to see if the
channel should be canceled or resumed.

In this bug, DoLocalLookup returns an error because Safe Browsing is not
able to read its database(database is corrupted), but we don't call the
callback to resume loading channel, so users cannot load any website.

This patch adds a scope exit handler to make sure the callback will
always be invoked.

Differential Revision: https://phabricator.services.mozilla.com/D36456
 2019-07-01 11:26:11 +00:00
dlee
f59bb40e5d Bug 1531354 - P5. Safe Browsing test entries are directly stored in LookupCache. r=gcp 
Create test entries via update introduces performance overhead.
We can store them directly in LookupCache and do not save test entries
to disk.

Differential Revision: https://phabricator.services.mozilla.com/D34576
 2019-06-29 19:05:41 +00:00
Sylvestre Ledru
b31009da86 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D22514
 2019-03-13 10:19:06 +01:00
Andrea Marchesini
3ce93fb8e0 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538
 2019-03-08 09:04:11 +00:00
Ciure Andrei
899292bc3f Backed out 16 changesets (bug 1525245) for perma failing test_document_cookie.html CLOSED TREE 
Backed out changeset 3fd27215698f (bug 1525245)
Backed out changeset d9a9e8e77873 (bug 1525245)
Backed out changeset 0e6f7be92e3f (bug 1525245)
Backed out changeset 6790802e2fa5 (bug 1525245)
Backed out changeset a5a9e01116ed (bug 1525245)
Backed out changeset 66e19a0c38dd (bug 1525245)
Backed out changeset fb90d51ba853 (bug 1525245)
Backed out changeset 4772db3625b3 (bug 1525245)
Backed out changeset 9affaf0cb998 (bug 1525245)
Backed out changeset a91b7ebe8bdd (bug 1525245)
Backed out changeset c2a13a7480e1 (bug 1525245)
Backed out changeset abe4482fa137 (bug 1525245)
Backed out changeset b3920c0bcf84 (bug 1525245)
Backed out changeset 0821b81f2724 (bug 1525245)
Backed out changeset 70bed2ad7899 (bug 1525245)
Backed out changeset 5f72ba232cc8 (bug 1525245)
 2019-03-07 17:54:18 +02:00
Andrea Marchesini
83054c5a7a Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538
 2019-03-07 10:21:15 +00:00
Dorel Luca
9a275b4283 Backed out 16 changesets (bug 1525245) for Android failures. CLOSED TREE 
Backed out changeset 9f8a1b410320 (bug 1525245)
Backed out changeset 0ef284a9a1d5 (bug 1525245)
Backed out changeset 835e5f642a03 (bug 1525245)
Backed out changeset 362f5a8d033c (bug 1525245)
Backed out changeset 9da3ab33cf67 (bug 1525245)
Backed out changeset 6aacd2d6e835 (bug 1525245)
Backed out changeset 8ff9e8f45e02 (bug 1525245)
Backed out changeset 2020227181cc (bug 1525245)
Backed out changeset fc3c64c330b9 (bug 1525245)
Backed out changeset 2762bf88e050 (bug 1525245)
Backed out changeset ffc10fdc50a6 (bug 1525245)
Backed out changeset bb6ade1207d7 (bug 1525245)
Backed out changeset 1875eb5085e4 (bug 1525245)
Backed out changeset 7e4f67a6d6f1 (bug 1525245)
Backed out changeset e671fc9581eb (bug 1525245)
Backed out changeset b89f5def8d0d (bug 1525245)
 2019-03-06 21:07:49 +02:00
Andrea Marchesini
88186754be Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538
 2019-03-06 17:04:06 +00:00
Ryan Hunt
743a2a46fe Bug 1523969 part 23 - Move method definition inline comments to new line in 'toolkit/'. r=ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21124
 2019-02-25 16:12:51 -06:00
Jonathan Kingston
8397774fdf Bug 1525319 - Removing context from OnDataAvailable r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20881
 2019-02-27 23:42:27 +00:00
Jonathan Kingston
3ef1df37e1 Bug 1525319 - Removing context from OnStopRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20770
 2019-02-27 23:41:31 +00:00
Jonathan Kingston
649c453cbd Bug 1525319 - Removing context from OnStartRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20769
 2019-02-27 23:41:04 +00:00
Dorel Luca
2dfae9a24a Backed out 4 changesets (bug 1525319) for Android failures in dom/base/test/test_progress_events_for_gzip_data.html 
Backed out changeset b73f033efb41 (bug 1525319)
Backed out changeset 1d318d5c6b98 (bug 1525319)
Backed out changeset 6d73418988d4 (bug 1525319)
Backed out changeset 84ca79bd2dc3 (bug 1525319)
 2019-02-25 04:06:11 +02:00
Jonathan Kingston
b6e28d0b8e Bug 1525319 - Removing context from OnDataAvailable r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20881
 2019-02-24 20:27:55 +00:00
Jonathan Kingston
4334f239c3 Bug 1525319 - Removing context from OnStopRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20770
 2019-02-24 20:26:59 +00:00
Jonathan Kingston
d6fffaf979 Bug 1525319 - Removing context from OnStartRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20769
 2019-02-24 20:26:16 +00:00
Ehsan Akhgari
6bcfe664eb Bug 1527505 - Part 9: Make nsIPermissionManager accept ACString arguments for permission types instead of raw C strings; r=nika 
This will mean that in places like the tight loop in GetTypeIndex()
we would no longer require calling strlen() on the input type argument
once per loop iteration.

Depends on D20236

Differential Revision: https://phabricator.services.mozilla.com/D20237
 2019-02-21 22:54:28 +00:00
Christoph Kerschbaumer
1a72eb2a6b Bug 1528677: Remove nullchecks for loadinfo since we have loadinfo on all channels. r=baku 2019-02-20 13:27:25 +01:00
Andrea Marchesini
0fd63f6e02 Bug 1528596 - Devirtualize accesses to nsUrlClassifierUtils, r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D20086
 2019-02-19 14:35:57 +00:00
Jonathan Kingston
58708e007c Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin 
Replacing js and text occurences of asyncOpen2
Replacing open2 with open

Differential Revision: https://phabricator.services.mozilla.com/D16885
 2019-02-12 16:08:25 +00:00
Kris Maglione
1dad1ad235 Bug 1478124: Follow-up: Fix merge conflict. r=bustage CLOSED TREE 2019-01-29 13:13:00 -08:00
Kris Maglione
4b169665d2 Bug 1478124: Part 8a - Update toolkit module to use a static component manifest. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D15039
 2018-12-16 16:03:00 -08:00
Andrea Marchesini
766206546d Bug 1522265 - Moving malware, phishing and blocked URIs to features - part 5 - Fix a method name call, r=me CLOSED TREE 2019-01-29 15:21:43 +01:00
Andrea Marchesini
9acb35ab86 Bug 1522265 - Moving malware, phishing and blocked URIs to features - part 4 - Phishing Protection, r=dimi 2019-01-29 10:11:34 +01:00
Andrea Marchesini
416f469b5c Bug 1522265 - Moving malware, phishing and blocked URIs to features - part 3 - DBService updated, r=dimi 2019-01-29 10:11:34 +01:00
arthur.iakab
e2d46fcd9f Backed out 4 changesets (bug 1522265) for mochitest assertion failures on extensions/cookie/nsPermissionManager.cpp CLOSED TREE 
Backed out changeset 38b4179568c7 (bug 1522265)
Backed out changeset 38b824df9d02 (bug 1522265)
Backed out changeset 6085d51681f8 (bug 1522265)
Backed out changeset e6a0832f3b11 (bug 1522265)
 2019-01-29 14:25:00 +02:00
Andrea Marchesini
d093c9582c Bug 1522265 - Moving malware, phishing and blocked URIs to features - part 4 - Phishing Protection, r=dimi 2019-01-29 10:11:34 +01:00
Andrea Marchesini
6ea43382ea Bug 1522265 - Moving malware, phishing and blocked URIs to features - part 3 - DBService updated, r=dimi 2019-01-29 10:11:34 +01:00
arthur.iakab
127fb281ff Backed out 16 changesets (bug 1478124) for failing android geckoview-junit CLOSED TREE 
Backed out changeset fce62c77a56b (bug 1478124)
Backed out changeset eb2fa3b5edf7 (bug 1478124)
Backed out changeset 8dacce59fcc0 (bug 1478124)
Backed out changeset 012fd0107204 (bug 1478124)
Backed out changeset 496aaf774697 (bug 1478124)
Backed out changeset 21f4fda03159 (bug 1478124)
Backed out changeset b0444e0bc801 (bug 1478124)
Backed out changeset d94039b19943 (bug 1478124)
Backed out changeset 5d85deac61c2 (bug 1478124)
Backed out changeset 929fd654c9df (bug 1478124)
Backed out changeset 1ddd80d9e91a (bug 1478124)
Backed out changeset b8d2dfdfc324 (bug 1478124)
Backed out changeset f500020a273a (bug 1478124)
Backed out changeset dd00365ebb55 (bug 1478124)
Backed out changeset 538e40c5ee13 (bug 1478124)
Backed out changeset bedaa9c437ad (bug 1478124)
 2019-01-29 10:03:06 +02:00
Kris Maglione
3c9b881f84 Bug 1478124: Part 8a - Update toolkit module to use a static component manifest. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D15039
 2018-12-16 16:03:00 -08:00
Andrea Marchesini
99ecfbd803 Bug 1516133 - Avoid extra main-thread jumps during the URL-classification, r=dimi 2019-01-17 09:33:25 +01:00
Coroiu Cristina
0310205bb2 Backed out changeset e310a6576d51 (bug 1516133) for service-workers failures with crashes on MOZ_CrashOOL 2019-01-23 13:43:15 +02:00
Andrea Marchesini
86a1985ac9 Bug 1516133 - Avoid extra main-thread jumps during the URL-classification, r=dimi 2019-01-17 09:33:25 +01:00
Csoregi Natalia
d6589b4873 Backed out changeset fef99cfead16 (bug 1516133) for service-workers failures with crashes on MOZ_CrashOOL. CLOSED TREE 2019-01-23 02:08:39 +02:00
Andrea Marchesini
b1825fc96e Bug 1516133 - Avoid extra main-thread jumps during the URL-classification, r=dimi 2019-01-17 09:33:25 +01:00
Sylvestre Ledru
717842459d Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D17063
 2019-01-21 14:49:22 +00:00
Margareta Eliza Balazs
7fe3543679 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-01-18 12:31:59 +02:00
Ehsan Akhgari
53c197e13a Bug 1521000 - Part 1: Reformat the tree to ensure everything is formatted correctly with clang-format r=sylvestre 
Summary: # ignore-this-changeset

Reviewers: sylvestre

Reviewed By: sylvestre

Subscribers: reviewbot, emilio, jandem, bbouvier, karlt, jya

Bug #: 1521000

Differential Revision: https://phabricator.services.mozilla.com/D16936
 2019-01-18 10:12:56 +01:00
Dimi Lee
4046527798 Bug 1501458 - Remove unused tracking protection code from nsUrlClassifierDBService. r=baku 
No one is using the aUseTrackingProtection parameter and also tracking
protection related preference in Classify API. And we shouldn't use it
that way in the future.

Differential Revision: https://phabricator.services.mozilla.com/D16798
 2019-01-17 21:24:43 +00:00
Andrea Marchesini
e7e8e3b087 Bug 1516133 - Avoid extra main-thread jumps during the URL-classification, r=dimi 2019-01-17 12:30:27 +01:00
Brindusan Cristian
b7950beba6 Backed out changeset cf370ec3969a (bug 1516133) for mochitest assertion failures. CLOSED TREE 2019-01-17 12:51:13 +02:00
Andrea Marchesini
1ea9c8ea98 Bug 1516133 - Avoid extra main-thread jumps during the URL-classification, r=dimi 2019-01-17 09:33:25 +01:00
Andrea Marchesini
bcbe09b344 Bug 1520519 - Cleanup nsUrlClassifierDBService::Lookup method, r=dimi 2019-01-16 22:49:26 +01:00
Andrea Marchesini
a45e910940 Bug 1517308 - Add a search field in about:url-classifier - part 1 - nsIUrlClassifier.getFeatureNames(), r=dimi 2019-01-08 23:05:40 +01:00
Andrea Marchesini
518057c967 Bug 1515286 - Get rid of nsIURIClassifier.asyncClassifyLocalWithTables, r=dimi 2019-01-05 09:10:56 +01:00
Andrea Marchesini
d5625220f1 Bug 1515286 - Introduce nsIURIClassifier.getFeatureByName() and nsIURIClassifier.createFeatureWithTables(), r=dimi 2019-01-05 09:10:45 +01:00
Andrea Marchesini
b24a2262ea Bug Bug 1515272 - Get rid of nsIURIClassifier.classifyLocal(), r=dimi, r=froydnj 2019-01-04 14:46:30 +01:00