Commit Graph

118 Commits

Author SHA1 Message Date
dlee
46a1c768ae Bug 1573176 - Fix SafeBrowsing doesn't use correct preference name for social tracking and cryptoming. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41645
2019-08-13 07:51:50 +00:00
Andrea Marchesini
214a46202a Bug 1570971 - Enable all the annotation URL-Classifier features and remove their prefs, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D40420
2019-08-05 11:34:24 +00:00
dlee
86a94ce235 Bug 1560597 - Safe Browsing supports downloading social tracking list. r=baku
This patches only allows Safe Browsing to download the list, but the feature
is still default disabled and the lists will not be downloaded.

Turn on social tracking by setting:
"privacy.trackingprotection.socialtracking.enabled"
"privacy.trackingprotection.socialtracking.annotate.enabled"

Differential Revision: https://phabricator.services.mozilla.com/D37410
2019-07-11 08:04:05 +00:00
Victor Porof
5d695e0b7f Bug 1561435 - Format toolkit/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36052
2019-07-05 11:14:05 +02:00
dlee
f59bb40e5d Bug 1531354 - P5. Safe Browsing test entries are directly stored in LookupCache. r=gcp
Create test entries via update introduces performance overhead.
We can store them directly in LookupCache and do not save test entries
to disk.

Differential Revision: https://phabricator.services.mozilla.com/D34576
2019-06-29 19:05:41 +00:00
Michael Kaply
26c3c38490 Bug 1456140 - Remove unnecessary size args for getChildList. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D31631
2019-05-21 06:20:40 +00:00
Andrea Marchesini
0424acc84e Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 3 - Cryptomining-annotation, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D22344
2019-03-14 17:48:33 +00:00
Dorel Luca
16206f7e66 Backed out 5 changesets (bug 1533074) for eslint failure
Backed out changeset 36c6a7178a5c (bug 1533074)
Backed out changeset 7e6a8fadff5b (bug 1533074)
Backed out changeset 2a0494fed543 (bug 1533074)
Backed out changeset 38470d2dd98c (bug 1533074)
Backed out changeset af4e03d1f5c8 (bug 1533074)
2019-03-14 09:14:15 +02:00
Andrea Marchesini
ec9efbcc4d Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 3 - Cryptomining-annotation, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D22344
2019-03-14 06:32:38 +00:00
Sylvestre Ledru
e24f1ec1e1 Bug 1531176 - Split the Google key management between gls and safe browsing r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D21459
2019-03-10 15:29:41 +00:00
Brindusan Cristian
1ad5d5ff94 Backed out changeset e908fbc7b930 (bug 1531176) for bc failures at browser_Troubleshoot.js. CLOSED TREE 2019-03-08 00:07:56 +02:00
Sylvestre Ledru
acb1b96014 Bug 1531176 - Split the Google key management between gls and safe browsing r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D21459
2019-03-07 21:05:32 +00:00
Ciure Andrei
1ee28bb982 Backed out changeset 3fb6c01dd2b0 (bug 1531176) for causing gradle toolchain bustage CLOSED TREE 2019-03-07 14:23:03 +02:00
Sylvestre Ledru
abe9ef2691 Bug 1531176 - Split the Google key management between gls and safe browsing r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D21459
2019-03-07 12:04:53 +00:00
Ciure Andrei
3c926ea22f Backed out changeset 0f2b9b0bf9b9 (bug 1531176) for google-geolocation-api-keyfile build bustages CLOSED TREE 2019-03-07 13:58:33 +02:00
Sylvestre Ledru
cb15c544b5 Bug 1531176 - Split the Google key management between gls and safe browsing r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D21459
2019-03-07 11:31:18 +00:00
Ciure Andrei
d4b3b08047 Backed out changeset 6c2e00bcd2bb (bug 1531176) due to google-location-api-keyfile build busatges CLOSED TREE 2019-03-07 10:49:26 +02:00
Sylvestre Ledru
c07450d96f Bug 1531176 - Split the Google key management between gls and safe browsing r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D21459
2019-03-06 23:06:10 +00:00
Eugen Sawin
ec698cd716 Bug 1525388 - [1.0] Set URL classifier update prefs to enable list updates and remove previous workaround. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D18736
2019-02-06 07:23:39 +00:00
Dimi Lee
01a82811a6 Bug 1513535 - Support the ability to separate feature toggle and list update in URL classifier. r=gcp
Add preferences "browser.safebrowsing.features.[feature name].update".

Normally these preferences won't be set so the SafeBrowsing uses features's
enable/disable preferences to decide if it should update the list or
not.

If an update preference is present, then it has higher priority then the
enable/disable one.

This provides a way for the SafeBrowsing consumer to be able to separate
feature toggle and upodate.

Differential Revision: https://phabricator.services.mozilla.com/D17233
2019-01-22 16:13:41 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
dlee
ca7fb73fc7 Bug 1513490 - Support update cryptomining and fingerprinting list in SafeBrowsing. r=gcp
Add the fingerprinting and cryptomining tables to the SafeBrowsing
update list.
Leave the preference of blacklist/whitelist tables empty until the
shavar server is ready.

Differential Revision: https://phabricator.services.mozilla.com/D16533
2019-01-15 19:29:49 +00:00
Dimi Lee
a220bdd62c Bug 1513490 - Refactor SafeBrowsing.jsm with feature list. r=gcp
When we add a table to SafeBrowsing.jsm we need to add related code in
various places. This patch simplify the work by providing a FEATURE
table which defines the data required.

Differential Revision: https://phabricator.services.mozilla.com/D16532
2019-01-15 20:04:40 +00:00
Dimi Lee
1d8fec5566 Bug 1519660 - Remove flash info bar from SafeBrowsing list. r=gcp
Differential Revision: https://phabricator.services.mozilla.com/D16397
2019-01-14 15:47:23 +00:00
Eugen Sawin
e54716978d Bug 1503560 - [1.2] Override tracking protection pref on GeckoView to re-enable blocklist updates. r=francois 2018-11-12 18:47:17 +01:00
Ehsan Akhgari
5e975a4a5f Bug 1501978 - Part 1: Stop honouring the browser.contentblocking.enabled pref in Gecko r=baku
Differential Revision: https://phabricator.services.mozilla.com/D10074
2018-10-30 14:30:15 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Francois Marier
7c07227930 Bug 1482306 - Ensure that tables are enabled when shared between features. r=dimi!
The enable/disable logic of the list manager was wrong. If multiple features
shared a given table (e.g. tracking protection and tracking annotations)
and only one of them was enabled, then updates could either be disabled
or enabled depending on which feature was checked first.

By disabling everything at the beginning and selectively re-enabling tables,
we can ensure that no table gets both enabled and disabled by different
feature toggles.

Differential Revision: https://phabricator.services.mozilla.com/D3259
2018-08-15 12:13:16 +00:00
Francois Marier
941b742abf Bug 1480450 - Honor browser.contentblocking.enabled in tracking protection. r=dimi!
Depends on D3131

Differential Revision: https://phabricator.services.mozilla.com/D3132
2018-08-13 23:20:40 +00:00
Ciure Andrei
99e15da229 Backed out 1 changesets (bug 1480450) for mochitest/test_trackingprotection_bug1157081.html failures CLOSED TREE
Backed out changeset 34d3b10c54eb (bug 1480450)
2018-08-13 22:45:37 +03:00
Francois Marier
e425b78d45 Bug 1480450 - Honor browser.contentblocking.enabled in tracking protection. r=dimi!
Depends on D3131

Differential Revision: https://phabricator.services.mozilla.com/D3132
2018-08-13 14:54:10 +00:00
Francois Marier
6d9c2d145e Bug 1461515 - Split tracking annotations from tracking protection. r=dimi
This makes it possible to use different lists for tracking protection
and for the features that rely on tracking annotations.

Differential Revision: https://phabricator.services.mozilla.com/D2484
2018-08-01 20:45:41 +00:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Francois Marier
f890efb3fa Bug 1436213 - Make test_bug1274685_unowned_list.js work on pver2 and pver4. r=gcp
This test is supposed to verify that Safe Browsing providers can
be initialized correctly even when a table is not configured
properly.

By removing a table from both google and google4, we ensure that
the test will be meaningful regardless of the stack in use.

Also filter out the console noise triggered by looking for the
update and gethash URLs of the "test" dummy provider.

MozReview-Commit-ID: KjWqSqA4FxJ
2018-02-06 15:36:48 -08:00
Francois Marier
83e8a582ff Bug 1435098 - Gate flashinfobar list on the plugins.show_infobar. r=bytesized,gcp
The list of sites to suppress flash infobars on should not be
downloaded from shavar unless the infobar feature is enabled.

MozReview-Commit-ID: BjkS5vWiilg
2018-02-02 13:30:28 -08:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Narcis Beleuzu
38c352a5d5 Backed out changeset 3884f0f9f316 (bug 1435098) for xpcshell failures on /test_bug1274685_unowned_list.js. CLOSED TREE 2018-02-06 19:52:30 +02:00
Francois Marier
4c3bb9ae22 Bug 1435098 - Gate flashinfobar list on the plugins.show_infobar. r=bytesized,gcp
The list of sites to suppress flash infobars on should not be
downloaded from shavar unless the infobar feature is enabled.

MozReview-Commit-ID: BjkS5vWiilg
2018-02-02 13:30:28 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Francois Marier
39c34f8559 Bug 1431192 - Only fetch download protection lists when Safe Browsing is enabled. r=gcp
Download protection requires both the malware list as well as its
own special lists. The code therefore checks that both Safe
Browsing and download protection are enabled before checking
downloaded files.

The list manager should check the same prefs before downloading
any of the download protection lists in order to avoid connecting
to the Safe Browsing server when Safe Browsing is fully disabled.

MozReview-Commit-ID: 66vMA56T4pJ
2018-01-29 15:16:54 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Thomas Nguyen
f699e980cb Bug 1395411 - Unregister tables when they're removed from urlclassifier.*Table. r=francois
MozReview-Commit-ID: Ex1ZxMcJLep
2017-08-31 18:46:23 +08:00
Sebastian Hengst
f811dfefc1 Backed out changeset 7bb00f5e0120 (bug 1395411) for eslint failures in test_classifier_changetablepref_bug1395411.html: 'classifierHelper' is not defined. r=backout 2017-09-04 16:45:35 +02:00
Thomas Nguyen
b80ab7c3df Bug 1395411 - Unregister tables when they're removed from urlclassifier.*Table. r=francois
MozReview-Commit-ID: Ex1ZxMcJLep
2017-08-31 18:46:23 +08:00