Commit Graph

413 Commits

Author SHA1 Message Date
Mark Banner
4fc8cc8128 Bug 1422724 - Remove unused constants in Places' controller.js. r=mak
MozReview-Commit-ID: AWTTksnPUp8
2017-12-04 12:09:03 +00:00
Mark Banner
aebd86c238 Bug 1415877 - Merge transaction handling into one function for onDrop/paste. r=mak
MozReview-Commit-ID: AMhuLyc98WO
2017-11-08 14:48:45 +00:00
Mark Banner
60b83c5096 Bug 1415877 - Rework PlacesControllerDragHelper#onDrop and PlacesController#paste to make the transaction handling parts similar. r=mak
MozReview-Commit-ID: BInw5oT0Ja5
2017-11-08 12:02:30 +00:00
Mark Banner
6f15fd42c1 Bug 1415877 - Remove unused type parameter to PlacesUIUtils#getTransactionForData. r=mak
MozReview-Commit-ID: 3kZQ4vnCk3b
2017-11-08 11:25:26 +00:00
Mark Banner
ad0aef3c26 Bug 1413843 - Improve speed of operations when pasting to the left-hand library pane by getting the right-hand pane to use for batching. r=mak
MozReview-Commit-ID: 2Q1rIpIhmmM
2017-11-02 10:37:14 +00:00
Mark Banner
64f3f531c3 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm
2017-10-23 18:18:00 +01:00
Mark Banner
3003416b05 Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak
MozReview-Commit-ID: EEFizNPmKpr
2017-10-23 15:50:52 +01:00
Sebastian Hengst
bba67d8083 Backed out 2 changesets (bug 1410940) for failing browser-chrome's browser/components/places/tests/browser/browser_controller_onDrop_tagFolder.js. r=backout
Backed out changeset 1c78029ded02 (bug 1410940)
Backed out changeset 37ceb314b2b3 (bug 1410940)
2017-11-03 11:52:54 +01:00
Mark Banner
db255523a1 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm
2017-10-23 18:18:00 +01:00
Mark Banner
53150e1c61 Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak
MozReview-Commit-ID: EEFizNPmKpr
2017-10-23 15:50:52 +01:00
Mark Banner
c7f732b366 Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak
MozReview-Commit-ID: GL9nKfypie1
2017-10-26 10:14:14 +01:00
Margareta Eliza Balazs
a5635befe3 Backed out changeset e17a2bca5391 (bug 1411891) for failing xpcshell in toolkit/modules/tests/xpcshell/test_NewTabUtils.js r=backout on CLOSED TREE 2017-10-31 14:19:52 +02:00
Mark Banner
3bcdba86cd Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak
MozReview-Commit-ID: GL9nKfypie1
2017-10-26 10:14:14 +01:00
Marco Bonardo
dcbda9bca0 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8
MozReview-Commit-ID: 586IR54ggbm
2017-10-10 12:05:19 +02:00
Sebastian Hengst
7a15678a21 Backed out changeset af8fdfac66fa (bug 1405722) for failing xpcshell's browser/components/places/tests/unit/test_PUIU_livemarksCache.js, at least on OS X 10.10 opt. r=backout on a CLOSED TREE 2017-10-17 00:55:53 +02:00
Marco Bonardo
6652796654 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8
MozReview-Commit-ID: 586IR54ggbm
2017-10-10 12:05:19 +02:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Peter Van der Beken
a8401db6ec Bug 1383059 - Remove instanceof for supplemental interfaces. Part 1: add Window.isChromeWindow and switch |instanceof [nsIDOM]ChromeWindow| to use it instead. r=bz. 2017-10-06 13:47:27 +02:00
Marco Bonardo
7af44bf697 Bug 1405687 - Remove some deprecated code from Places related code. r=standard8
MozReview-Commit-ID: 411z07otlfN
2017-10-04 16:33:46 +02:00
Mark Banner
a37a0a7508 Bug 1392533 - Make the places tree view directly communicate batch notifications to the results. r=mak
MozReview-Commit-ID: HpN0v0jSwdK
2017-09-27 15:26:35 +01:00
Mark Banner
b4848d29a8 Bug 1400846 - Fix ordering of bookmarks with Async Transactions when dropping into different folders. r=mak
MozReview-Commit-ID: GjnehR5PumZ
2017-09-19 06:54:16 +01:00
Mark Banner
69f202466e Bug 1401242 - Fix removing bookmarks from tag groups - when getting the tagGuid from the node, we must get it async, rather than using the concrete guid. r=mak
MozReview-Commit-ID: 7fGS6jFNVPl
2017-09-19 20:47:26 +01:00
Michael Layzell
151bdf2f69 Bug 1398471 - Read data from DataTransfer before yielding, r=gijs
Previously the code looped and yielded between each loop. This caused the
DataTransfer to be cleared before the read completed.

This splits the loop into 2 sections such that we read all important data from
the DataTransfer before it is cleared.
2017-09-13 11:45:48 -04:00
Mark Banner
5401fe8673 Bug 1396888 - Handle async moving of bookmarks in the caller for the move dialog, to avoid going out of scope whilst async actions are happening. r=mak
MozReview-Commit-ID: JhETMnmxNOD
2017-09-05 17:15:58 +01:00
Mark Banner
4cd4cb5dc8 Bug 1391166 - Fix the order of bookmarks via drag and drop when moving a bookmark down in the list. r=mak
MozReview-Commit-ID: 7Adz2Et0NQn
2017-08-23 12:24:53 +01:00
Mark Banner
eedb2f4c4e Bug 1392189 - Fix deleting bookmark tags from the Library view with Places Transactions enabled. r=mak
MozReview-Commit-ID: unNGjPpTX6
2017-08-23 13:40:44 +01:00
Marco Bonardo
2703fb553f Bug 1382991 - Cleanup Places controller InsertionPoint. r=standard8
MozReview-Commit-ID: 2pSbYtPGtYx
2017-08-03 12:16:36 +02:00
Rajesh Kathiriya
fefc455410 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Marco Bonardo
a90abdc771 Bug 1094818 - Use Bookmarks.jsm in controller.js. r=standard8
MozReview-Commit-ID: 7vli02K19bt
2017-07-18 19:18:02 +02:00
Sebastian Hengst
1326418a49 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
0d920ece6a Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Mark Banner
ef8538e9c4 Bug 1376531 - Fix some issues when enabling async places transactions - updating bookmarks names and pasting bookmarks. r=mak
MozReview-Commit-ID: 4sqbSMtMkDD
2017-06-27 12:54:16 -07:00
Paolo Amadini
7afba17088 Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P
2017-06-19 11:32:37 +01:00
Rajesh Kathiriya
993895141d Bug 1370225 - Enabled the ESLint comma-style rule across mozilla-central. r=standard8
MozReview-Commit-ID: 9OhLgBpYS4L
2017-06-15 18:24:17 +01:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
milindl
96eb3d4985 Bug 1247201 - Run cleaners async to clear as much as possible r=mak
Amended to fix review changes
(stylistic + other)
Turns all cleaners into promises so they run asyc

MozReview-Commit-ID: DV5ug6vNXkS
2017-03-27 19:27:35 +05:30
Marco Bonardo
fdcc7c5e61 Bug 1306276 - Deprecate History RemovePage and RemovePages. r=standard8
MozReview-Commit-ID: 3NSaXKy1hP3
2017-03-22 12:44:54 +01:00
David Rajchenbach-Teller
eba4a143fb Bug 1087255 - Convert browser/components/places JS clients of RemovePage(s) to History.remove; Patch by Yoric, updated by Standard8. r=mak
MozReview-Commit-ID: GcVajWOyvkT
2014-10-31 12:39:02 +01:00
Tooru Fujisawa
da7d4444d8 Bug 1302661 - Add multiple bookmark items when multiple URLs are dropped as single item. r=mak 2014-02-06 01:38:31 +09:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Pavan
458aed5d63 Bug 1196395 - No plurals form for context menus when multiple pages are selected in Library. r=mak 2016-12-21 10:06:00 +01:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Mark Banner
0dc78b7964 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop
MozReview-Commit-ID: LdoXLniNeT7
2016-11-03 11:51:48 +00:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Pushpankar
77a14e357c Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao 2016-07-16 10:20:04 +02:00