corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
815,497 Commits 1 Branch 0 Tags
4e7e60308f7b51f4b3e54f05d7ac3c7ba92db436
Commit Graph

4166 Commits

Author SHA1 Message Date
Tom Marble
a42a175006 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D199054
 2024-01-29 17:30:48 +00:00
Sandor Molnar
778333649c Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE 2024-01-27 00:15:22 +02:00
Tom Marble
920ed4a927 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D199054
 2024-01-26 20:06:56 +00:00
Jules Simplicio
48386fea6c Bug 1872909 - Commit to deemphasized descriptive text pattern in preferences that has already been introduced under Search settings in order to improve information architecture r=settings-reviewers,desktop-theme-reviewers,dao,Gijs 
This patch makes us commit to the deemphasized color descriptive pattern throughout settings.

I also made some changes where some settings were using description and should most likely be using a label instead and vice versa.

Quick note that if the descriptive text is tied to an input such as a checkbox or toggle, as opposed to a section heading, we opt for the `.text-deemphasized` class/treatment where not only do we use the `--text-color-deemphasized` color but also shrink the font size. You'll see I opted for such treatment in the Experiments page checkbox list.

Differential Revision: https://phabricator.services.mozilla.com/D197615
 2024-01-26 04:09:59 +00:00
Stanca Serban
6bc6e24ee2 Backed out changeset 337d90568478 (bug 1872909) for causing mochitests failures in browser_experimental_features.js. CLOSED TREE 2024-01-25 04:17:13 +02:00
Jules Simplicio
10c04f95d5 Bug 1872909 - Commit to deemphasized descriptive text pattern in preferences that has already been introduced under Search settings in order to improve information architecture r=settings-reviewers,desktop-theme-reviewers,dao,Gijs 
This patch makes us commit to the deemphasized color descriptive pattern throughout settings.

I also made some changes where some settings were using description and should most likely be using a label instead and vice versa.

Quick note that if the descriptive text is tied to an input such as a checkbox or toggle, as opposed to a section heading, we opt for the `.text-deemphasized` class/treatment where not only do we use the `--text-color-deemphasized` color but also shrink the font size. You'll see I opted for such treatment in the Experiments page checkbox list.

Differential Revision: https://phabricator.services.mozilla.com/D197615
 2024-01-25 01:13:43 +00:00
Joel Maher
3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D198974
 2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-24 16:35:54 +00:00
Jaydeep Das
95cda128bf Bug 328707 - Allow only valid IP/Hostname for Proxy Config, r=mconley,necko-reviewers,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D198425
 2024-01-22 14:28:41 +00:00
Meera Murthy
fe0b7efdd1 Bug 1869830 - [translations] Add a page for Translation Setting Preferences. r=nordzilla,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,translations-reviewers,Gijs,bolsson,dao 
Differential Revision: https://phabricator.services.mozilla.com/D197048
 2024-01-22 14:19:25 +00:00
Erik Nordin
87592ba425 Bug 1875090 - Rename ContentTaskUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,sgalich 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198831
 2024-01-19 02:15:34 +00:00
Erik Nordin
399f696700 Bug 1875090 - Rename ContentTaskUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,sgalich,kpatenio 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198830
 2024-01-19 02:15:34 +00:00
Erik Nordin
5bb63471e3 Bug 1875090 - Rename BrowserTestUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,bytesized,sfoster 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198826
 2024-01-19 02:15:33 +00:00
Erik Nordin
857bffe429 Bug 1875090 - Rename BrowserTestUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,mhowell 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198825
 2024-01-19 02:15:33 +00:00
Punam Dahiya
61270d6cf0 Bug 1862023 - Update More From Mozilla product list to display Firefox Monitor r=settings-reviewers,desktop-theme-reviewers,fluent-reviewers,Gijs,flod 
Differential Revision: https://phabricator.services.mozilla.com/D197977
 2024-01-17 21:57:33 +00:00
Harshit Sohaney
3d88318d2d Bug 1856412 - (Part 1) Make all clear history entrypoints point to the new clear history dialog. r=pbz,fluent-reviewers,settings-reviewers,flod,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D192282
 2024-01-15 13:10:05 +00:00
Harshit Sohaney
e2e1067f1f Bug 1855068 - (Part 1) Added functionality to get all data sizes by time range. r=pbz,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D190862
 2024-01-15 13:10:05 +00:00
DJ
ca9f42a177 Bug 1783521 - add card preview when inactive tab hovered. r=settings-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,fluent-reviewers,flod,dao,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D184260
 2024-01-12 19:29:18 +00:00
Sandor Molnar
a571c9506e Backed out changeset 44d7819ed242 (bug 1849135) for causing bc failures at browser/components/preferences/tests/browser_search_within_preferences_2.js CLOSED TREE 2024-01-12 00:39:50 +02:00
Hanna Jones
36faabe1c0 Bug 1849135 - make about:preferences search work with moz-toggle + custom elements r=settings-reviewers,Gijs 
I started hitting search issues with my change in D196494 and with other experiments to use more reusable components in about:preferences. We'll likely have to keep adding new elements to `searchWithinNode`, but changing `textNodeDescendants` to look for text nodes in the shadow DOM seems like a generally helpful change + gets the highlighting working properly.

Differential Revision: https://phabricator.services.mozilla.com/D197120
 2024-01-11 15:03:04 +00:00
Noemi Erli
5ee98305d6 Backed out 4 changesets (bug 1855068, bug 1856412) for causing failures in test_SiteDataManager.js CLOSED TREE 
Backed out changeset dbaf2b0da226 (bug 1856412)
Backed out changeset 8d040fd73abf (bug 1856412)
Backed out changeset 645f7ed438fb (bug 1855068)
Backed out changeset be41f5296dec (bug 1855068)
 2024-01-11 03:20:27 +02:00
Harshit Sohaney
458e1863b3 Bug 1856412 - (Part 1) Make all clear history entrypoints point to the new clear history dialog. r=pbz,fluent-reviewers,settings-reviewers,flod,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D192282
 2024-01-10 13:15:01 +00:00
Harshit Sohaney
20e51c41c6 Bug 1855068 - (Part 1) Added functionality to get all data sizes by time range. r=pbz,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D190862
 2024-01-10 11:47:26 +00:00
Javier Rueda
d6535e0523 Bug 1764694 - Disable 'Remove' button when there are no accepted languages. r=Gijs,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D197635
 2024-01-04 23:50:16 +00:00
Karandeep
f11961815d Bug 1852048 - Move address bar to search preferences. r=dao,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D194895
 2024-01-04 09:11:22 +00:00
Anna Yeddi
456855d0cf Bug 1872743 - Provide an accessible name to Default and Default Private Engine comboboxes in Settings UI. r=settings-reviewers,mossop 
The [`<menulist>` with id `defaultEngine`](https://searchfox.org/mozilla-central/rev/0f39860036f9b6339e65d485aeb6b6be73d9dbda/browser/components/preferences/search.inc.xhtml#19-21) that opens for the `Default Search Engine ` selection on `Settings` > `Search` is not labelled. [The combobox pattern is expected to provide an accessible name](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/#wai-ariaroles,states,andproperties) for the control even when the listbox opened has an accessible name.

We could refer to [the `#defaultEngineGroup` container](https://searchfox.org/mozilla-central/rev/0f39860036f9b6339e65d485aeb6b6be73d9dbda/browser/components/preferences/search.inc.xhtml#15) with `aria-labelledby` to ensure the combobox is labeled, and also to include a description via `aria-describedby` referred to the [on-screen `<description>` provided for the control](https://searchfox.org/mozilla-central/rev/0f39860036f9b6339e65d485aeb6b6be73d9dbda/browser/components/preferences/search.inc.xhtml#17) - this would communicate the purpose of opened list of options to an assistive technology user.

Same pattern could apply to [the Default Private Engine `<menulist>`](https://searchfox.org/mozilla-central/rev/0f39860036f9b6339e65d485aeb6b6be73d9dbda/browser/components/preferences/search.inc.xhtml#33-35).

Since the `browser/components/preferences/tests/browser_searchDefaultEngine.js` a11y_checks will be passing with this change, we are also removing the `fail-if` notation from its test manifest.

Depends on D197535

Differential Revision: https://phabricator.services.mozilla.com/D197540
 2024-01-03 14:36:41 +00:00
Anna Yeddi
8bfb3a3e0a Bug 1872739 - Provide an accessible name to Applications richlistbox's actionsMenu comboboxes in Settings UI. r=settings-reviewers,mossop 
The [<menulist> with class `actionsMenu`](https://searchfox.org/mozilla-central/rev/0f39860036f9b6339e65d485aeb6b6be73d9dbda/browser/components/preferences/main.js#3737) that opens when a control under the `Action` header of the `Applications` richlistbox on `Settings` > `General` > `Files and Applications` is activated is not labelled. The combobox pattern is expected to provide an accessible name for the control even when the listbox opened has an accessible name.

We could refer to [the `#actionColumn` container](https://searchfox.org/mozilla-central/rev/0f39860036f9b6339e65d485aeb6b6be73d9dbda/browser/components/preferences/main.inc.xhtml#452-454) with `aria-labelledby` to ensure the combobox is labeled and the purpose of opened list of options is communicated to an assistive technology user.

Since some a11y_checks will be passing with this change, we are also removing the `fail-if` notations from the appropriate test files in the Settings UI manifest.

Differential Revision: https://phabricator.services.mozilla.com/D197535
 2024-01-03 14:36:40 +00:00
Javier Rueda
43ea78fedd Bug 1461755 - Remove app.update.service.enabled from settings UI. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D197340
 2024-01-02 13:31:30 +00:00
Karandeep
4d994d852f Bug 1868756 - For users with the search bar disabled, "Show search suggestions" should be unchecked when either browser.search.suggest.enabled or browser.urlbar.suggest.searches are false. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D195889
 2023-12-27 17:51:38 +00:00
Hanna Jones
7db3c5c689 Bug 1869827 - Fix click listeners for Language and Appearance links in about:preferences r=settings-reviewers,Gijs 
This patch moves the event click event listeners off of the nested DOM elements to a common ancestor.

I was looking around but didn't see related tests - happy to add coverage here or as part of a follow up bug.

Differential Revision: https://phabricator.services.mozilla.com/D196343
 2023-12-21 17:43:44 +00:00
Narcis Beleuzu
2028d562b3 Backed out changeset fe2ffeac3ec2 (bug 1783521) for marionette failure on test_restore_manually.py . CLOSED TREE 2023-12-20 21:20:39 +02:00
Anna Yeddi
c6219693e0 Bug 1869942 - Temporarily pass clicks on inacessible richlistbox treecol in a11y-checks while their accessibility is being fixed. r=Jamie,settings-reviewers,Gijs 
Add a temporary check in AccessibilityUtils to pass clicks on inacessible richlistbox treecol so we could remove the `fail-if` notations from the affected test manifests until the bug 1848397 is being resolved. This would allow a11y-checks to continue monitor these affected tests and to avoid unknowingly introducing new inaccessible controls because of that.

When the bug 1848397 is fixed, remove the temporary check introduced in this patch.

Differential Revision: https://phabricator.services.mozilla.com/D196376
 2023-12-20 16:05:38 +00:00
DJ
681d1ba324 Bug 1783521 - add card preview when inactive tab hovered. r=settings-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,fluent-reviewers,flod,dao,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D184260
 2023-12-20 15:56:51 +00:00
Mark Banner
0d18781645 Bug 1870644 - Remove nsISearchEngine.iconURI and replace by the new getIconURL function. r=search-reviewers,extension-reviewers,settings-reviewers,mconley,mcheang,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D196734
 2023-12-20 13:28:24 +00:00
Eliot Jacobs
5d2d217e74 Bug 1860845 - Removes unused disable_button preferences (view_cookies,change_blocklist) r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D196802
 2023-12-19 00:24:22 +00:00
Harshit Sohaney
642fccf057 Bug 1856415 - (Part 1) Updating clear data dialog UI. r=pbz,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,Gijs,dao,flod 
Differential Revision: https://phabricator.services.mozilla.com/D189947
 2023-12-18 14:41:11 +00:00
Olivia Hall
16d733113b Bug 1865727 - GeckoView Runtime Never Translate Site Option r=geckoview-reviewers,settings-reviewers,translations-reviewers,gregtatum,owlish,boek 
This patch adds an option for GeckoView to change site settings outside
of the session. These APIs should be used for global modifications to
the "never translate these sites" list.

Additionally, this patch moves some Desktop translations logic to the
toolkit for shared use.

Differential Revision: https://phabricator.services.mozilla.com/D195790
 2023-12-13 14:50:08 +00:00
Mark Banner
6288c316b3 Bug 1869613 - Remove unused function EngineStore.reloadIcons. r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D196226
 2023-12-12 21:54:42 +00:00
John Schanck
b75accc3dc Bug 1853747 - add a link to Windows settings for passkey management. r=keeler,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,bolsson,flod 
Differential Revision: https://phabricator.services.mozilla.com/D195613
 2023-12-12 20:34:39 +00:00
jneuberger
7cccf3fb15 Bug 1869300 - Remove (desktop only) from sync-engine-payment-methods r=credential-management-reviewers,fluent-reviewers,settings-reviewers,dimi,flod 
Differential Revision: https://phabricator.services.mozilla.com/D196046
 2023-12-12 16:47:26 +00:00
jneuberger
f9dc8c7ae5 Bug 1867017 - P1. Update about:preferences strings of passwords section r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D195280
 2023-12-12 16:02:07 +00:00
jneuberger
5946f0e354 Bug 1867020 - Update about:preferences strings for exceptions modal r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D195279
 2023-12-12 16:02:06 +00:00
Sandor Molnar
5e9ca11c9d Backed out 5 changesets (bug 1867017, bug 1867019, bug 1867018, bug 1867020) for causing bc failures at browser/components/preferences/tests/browser_search_subdialogs_within_preferences_5.js CLOSED TREE 
Backed out changeset 0c4bc9a698ba (bug 1867017)
Backed out changeset ea95d41995f0 (bug 1867017)
Backed out changeset 56289937eb65 (bug 1867020)
Backed out changeset 022c1f63a6fe (bug 1867019)
Backed out changeset fa5b89f2d1b6 (bug 1867018)
 2023-12-12 05:54:37 +02:00
Nipun Shukla
dd8b73c28c Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D191763
 2023-12-12 00:22:08 +00:00
Cristian Tuns
2f6520726f Backed out changeset 7351cc3d5b11 (bug 1853747) for causing failures in createcredential-abort.https.html CLOSED TREE 2023-12-11 18:17:22 -05:00
jneuberger
a3d542118c Bug 1867017 - P1. Update about:preferences strings of passwords section r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D195280
 2023-12-11 21:54:34 +00:00
jneuberger
777f61f0ec Bug 1867020 - Update about:preferences strings for exceptions modal r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D195279
 2023-12-11 21:54:34 +00:00
Sandor Molnar
2313150db4 Backed out changeset 677c3005fd69 (bug 1860271) for causing node newtab failures at browser/components/newtab CLOSED TREE 2023-12-11 23:31:08 +02:00