Commit Graph

75 Commits

Author SHA1 Message Date
gasolin
159f88a860 Bug 1361286 - add in-page messages support for Automigration module; r=Gijs
MozReview-Commit-ID: I4xK2PkuHp3
2017-05-24 16:56:00 +08:00
Sebastian Hengst
7b7ea06c4f Backed out changeset 2612892f2785 (bug 1361286) for typos in its strings. r=backout 2017-05-27 10:27:02 +02:00
gasolin
35b39a589e Bug 1361286 - add in-page messages support for Automigration module; r=Gijs
MozReview-Commit-ID: I4xK2PkuHp3
2017-05-24 16:56:00 +08:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Queze
ddf0cda8da Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
aca1103c68 Bug 1356569 - Remove appendElement's last parameter when it is false, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
4cd95d4a02 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
4189eac09e Backed out changeset e1f191aad863 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
6c119a88d3 Bug 1356569 - Remove appendElement's last parameter when it is false, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
35cd8ba883 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Gijs Kruitbosch
da2191fab2 Bug 1344759 - batch-insert bookmarks when importing from Edge, IE, Safari or Chrome, r=dao
MozReview-Commit-ID: Dhvw0Y0fm5x
2017-03-13 23:46:16 +00:00
Gijs Kruitbosch
d9c7b8ddde Bug 1341097 - part 4: misc. small optimizations, r=mak
The MigrationUtils change is because 99% of the time we will only have
1 visit per URI, and so we spend silly amounts of time doing nothing.
Time spent in composing our undo structure went from ~800ms to ~550ms
with this change.

The other change just seemed obvious - when visits aren't recent,
we shouldn't add them to 'recently visited' lists, which seem to use
'time this function was called' as the time associated with an entry,
which is incorrect.

MozReview-Commit-ID: 2I0D5ApOCI7
2017-02-20 16:06:27 +00:00
Gijs Kruitbosch
705481de09 Bug 1341097 - part 1: group frecency notifications from history notifications, r=mak
When updating a large number of places, sending runnables to the main thread
for every single one of them whose frecency we update is not conducive to a
responsive UI. This only gets worse once more observers care about these
notifications (e.g. when the library is open).

To avoid this on startup when importing from other browsers, this patch adds
and uses an option to group the frecency notifications. Later patches will
also use the option to avoid other notifications where possible.

MozReview-Commit-ID: D5KqPDu86bo
2017-02-21 20:00:24 +00:00
Dão Gottwald
112e3a6175 Bug 1338522 - Add telemetry for UI responsiveness during import of profile data from another browser. r=francois,Gijs
MozReview-Commit-ID: Cmh0rhZEPDo
2017-02-18 00:01:50 +01:00
Dão Gottwald
f0d1f68adc Bug 1338812 - Call TelemetryStopwatch only once per item (history / bookmarks / logins) rather than for each resource. r=Gijs
MozReview-Commit-ID: 7c5DgKDIFTv
2017-02-11 21:14:52 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Aman Dwivedi
aec48bf322 Bug 1323685 - Remove workarounds for bug 449811. r=mak 2016-12-22 16:33:28 +05:30
Gijs Kruitbosch
a9c9eea221 Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak
MozReview-Commit-ID: 7HCA7cKhws4
2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
7c7e220663 Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN
MozReview-Commit-ID: JZbOkmZ7ZZG
2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
e6f654cf66 Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak
MozReview-Commit-ID: 8pKlBmDVX5X
2016-11-30 11:48:03 +00:00
Sebastian Hengst
13307cb1ae Backed out changeset 12aa73f4a982 (bug 1285577) 2016-12-20 22:54:35 +01:00
Sebastian Hengst
5148a28841 Backed out changeset 78a3cd5bf313 (bug 1285577) 2016-12-20 22:54:31 +01:00
Sebastian Hengst
0d72a880f2 Backed out changeset 10388e609fe3 (bug 1285577) 2016-12-20 22:54:26 +01:00
Gijs Kruitbosch
362bb9cc96 Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak
MozReview-Commit-ID: 7HCA7cKhws4
2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
95acef5be1 Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN
MozReview-Commit-ID: JZbOkmZ7ZZG
2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
477f5615db Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak
MozReview-Commit-ID: 8pKlBmDVX5X
2016-11-30 11:48:03 +00:00
Gijs Kruitbosch
1b441533b6 Bug 1319816 - fix default browser determination on Windows 7 and below in the automigration case, r=jaws
As noted on the bug, because we call getMigratorKeyForDefaultBrowser() multiple times,
its value no longer reflects the (deleted) registry key for subsequent calls.

While we can fix this for the automigrate case by just passing the default we determined a few
lines earlier (and that seems worth doing to avoid busywork), there are 2 small problems
with this:

1) if the default browser has no data, `migratorKey` won't be set, and so we'll call the same
method again anyway, and the message reported in the error console will be that we can't
migrate from Firefox, when the real problem is that we can't migrate from the original
default browser.

2) there are other callers besides AutoMigrate. Specifically, migration.js also calls this
method.

To deal with these, I've fixed getMigratorKeyForDefaultBrowser() to return the same
registry-based value for its lifetime if we hit the 'the default is firefox, go look for an
earlier default' case.

I've verified that either the s/aMigratorKey/migratorKey/ or the change to
getMigratorKeyForDefaultBrowser() are sufficient to make this work properly in the
automigration case.

While I was here, I also updated one of the error messages to be more explicit.

MozReview-Commit-ID: GeUNTfScMMB
2016-11-23 16:06:00 +00:00
Gijs Kruitbosch
1329c154ed Bug 1319788 - fix typo in getting a telemetry histogram, r=mak
MozReview-Commit-ID: 22CFX0Ueo1q
2016-11-23 14:47:55 +00:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Gijs Kruitbosch
1eb867efaf Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak
MozReview-Commit-ID: EiZfkj6AsVL
2016-10-22 14:40:48 +01:00
Wes Kocher
5d8f248c21 Backed out changeset 77012ce07e57 (bug 1279501) a=gijs 2016-11-01 10:47:59 -07:00
Gijs Kruitbosch
cf59a894b6 Bug 1314237 - detect nightly/devedition as 'firefox' in migration code, r=mikedeboer
MozReview-Commit-ID: 6vQa59i81Gb
2016-11-01 11:57:30 +00:00
Gijs Kruitbosch
f0e91ab90a Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak
MozReview-Commit-ID: EiZfkj6AsVL
2016-10-22 14:40:48 +01:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Gijs Kruitbosch
bbf79f28ea Bug 1311043 - make eslint much more strict in browser/components/migration/, and fix issues, r=mikedeboer
MozReview-Commit-ID: RXO68w3Kv3
2016-10-18 16:03:06 +01:00
Gijs Kruitbosch
ac3e073240 Bug 1309614 - finish initializing places before we import stuff, r=mak
MozReview-Commit-ID: JucE0HjQdwC
2016-10-13 17:02:29 +01:00
Gijs Kruitbosch
529d9db2c4 Bug 1305770 - make cookies and passwords import from Chrome without locking, r=mak
MozReview-Commit-ID: CbozmZHwAgz
2016-10-03 16:17:06 +01:00
Gijs Kruitbosch
8e887a3fe8 Bug 1279240 - use registry key to deduce default browser when possible, r=jaws
MozReview-Commit-ID: 7kDMRrt5JNK
2016-09-23 16:27:20 +01:00
Wes Kocher
297b6a4a72 Backed out 3 changesets (bug 1279240) for leaks on Windows VM mochitests a=backout
Backed out changeset 4b69e32e3a83 (bug 1279240)
Backed out changeset d0d5180dc062 (bug 1279240)
Backed out changeset dc1b725b47d4 (bug 1279240)
2016-09-29 17:44:41 -07:00
Gijs Kruitbosch
27c451ade9 Bug 1279240 - use registry key to deduce default browser when possible, r=jaws
MozReview-Commit-ID: 7kDMRrt5JNK
2016-09-23 16:27:20 +01:00
Jinank Jain
7e5a9f8bcc Bug 1276701 - Remove Windows code from Safari migrator. r=Gijs
MozReview-Commit-ID: CuV2xSmXnq
2016-08-23 14:49:39 -07:00
Gijs Kruitbosch
e2e91c7669 Bug 1289436 - add telemetry for the length of time we take to import data, r=jaws,bsmedberg
MozReview-Commit-ID: CkbHJVRucr5
2016-07-26 18:05:08 +01:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Gijs Kruitbosch
be83ddb0f6 Bug 1289229 - disable automigration undo if people create/change bookmarks/logins, r=mak
MozReview-Commit-ID: DAoNV9H71Yv
2016-07-26 12:48:37 +01:00