Commit Graph

648 Commits

Author SHA1 Message Date
Glenn Watson
3329cf6c60 servo: Merge #5205 - First (and biggest) part of refactoring constellation to support iframe navigation (from glennw:iframe-nav); r=jdm
The history is now recorded per frame, but needs to be exposed in a followup PR.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1092ca10192c79b4b96c25985a2c6245d369090b
2015-03-16 17:54:50 -06:00
Zack Slayton
0635a7d127 servo: Merge #5217 - localStorage shim, fixes #5195 (from zslayton:master); r=jdm
@jdm This initial version has a few outstanding issues that I wanted to invite input on. Specifically:

1. I had some difficulty finding a home for the `StorageType` enum. Structs defined outside of the `script` module don't seem to be able to use the `#[jstraceable]` annotation and the `net` module (where `StorageTask` lives) doesn't have access to `script`. Per Simon Sapin's suggestion, I worked around this temporarily by creating a `TraceableStorageType` stand-in struct that was traceable and which could be translated into a regular `StorageType` when being sent to the `StorageTask`. Unsure of the best way to resolve this hack. Thoughts?

2. Apart from the `Storage` constructor used in `Window::SessionStorage` and the new `Window::LocalStorage`, there's also a method called `Storage::Constructor`. I'm unclear on what (if anything) will actually invoke this, so I'm not sure which variant of `StorageType` to use here. I've temporarily created an `Unknown` variant of `StorageType` as a placeholder.

3. I discovered that the web platform tests directory's localStorage tests. Many of them now pass despite the configured expectation that they fail. However, several do not pass. Is there a good way for me to add debug logging or otherwise get a sense of which assertion failed / what went wrong?

Thanks for your continued help!

Source-Repo: https://github.com/servo/servo
Source-Revision: b8e87ea020879090c931421cf3cec73d8cd1156f
2015-03-16 14:48:51 -06:00
Martin Schröder
5f93d37240 servo: Merge #5169 - Refactored optional argument "last_modified" for Document (from mschroeder:issue-4981); r=saneyuki
Fixes #4981

Source-Repo: https://github.com/servo/servo
Source-Revision: ccc6faa14787765485dae7ccd0976cd7e1764185
2015-03-16 11:03:58 -06:00
Mikko Perttunen
9d54446033 servo: Merge #5173 - Consider media attribute on link and style tags (from cyndis:media-attr); r=jdm
Don't add a stylesheet if the current device does not match the media
query specified in a link or style tag.

Cheers,
cyndis

Source-Repo: https://github.com/servo/servo
Source-Revision: 660ea05ddb3b17b0bb914cb09968cbcf7c6b1aec
2015-03-16 09:54:56 -06:00
Rohan Prinja
03166b0667 servo: Merge #5218 - make MouseEvent::new() and UIEvent::new() take enums for the bubbles and (from ajnirp:enums-for-mouse-ui-event-constructors); r=Ms2ger
... cancelable arguments

for #4807

Source-Repo: https://github.com/servo/servo
Source-Revision: f30faeadd09b7ef553df9d270abeb3c242c4ce3a
2015-03-15 03:18:49 -06:00
Ms2ger
1f6dd48edf servo: Merge #5211 - Use qitem rather than QualityItem::new in XHR (from Ms2ger:qitem); r=Manishearth
This is more future-proof.

Source-Repo: https://github.com/servo/servo
Source-Revision: 2fb5eb8747fb4189ca577cc93b056f1290876980
2015-03-14 07:54:49 -06:00
Ms2ger
87466b0156 servo: Merge #5208 - Implement USVString (from Ms2ger:USVString); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 19cd87aefc24fa153fa013b5f96ae46de9a427fd
2015-03-13 14:30:49 -06:00
Ms2ger
d8b320d8ef servo: Merge #5206 - Pre rustup codegen cleanup (from Ms2ger:pre-rustup-codegen-cleanup); r=jdm,SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: c05de08630c50446cb15e42f4948fae6039e7271
2015-03-13 08:42:49 -06:00
Patrick Walton
33d4762cb0 servo: Merge #4417 - layout: Implement border-spacing per CSS 2.1 § 17.6.1 and the legacy cellspacing attribute per HTML5 § 14.3.9 (from pcwalton:border-spacing); r=larsbergstrom
Table layout code has been refactored to push the spacing down to
rowgroups and rows; this will aid the implementation of
`border-collapse` as well.

r? @SimonSapin

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e811229bae6b338fabcd7df602079730c942889
2015-03-12 13:03:49 -06:00
Chris Double
fd7e1e9bd4 servo: Merge #5202 - Fix #2108 by renaming unwrap functions to native_from_reflector (from doublec:rename_unwrap); r=Ms2ger
Fix for issue #2108. That issue mentions an `unwrap_object` which doesn't seem to exist so I renamed `unwrap` to `native_from_reflector` and `unwrap_jsmanaged` to `native_from_reflector_jsmanaged`. The latter is a bit unweildy - maybe a shorter name might be better?

Source-Repo: https://github.com/servo/servo
Source-Revision: d7e9b8b96b77377fa37fd59cdb8c44fa866b5b2e
2015-03-12 01:51:49 -06:00
Md. Enzam Hossain
cdb0358d53 servo: Merge #5198 - Remove redundant force_relayout calls (from ienzam:force_relayout_cleanup); r=jdm
This is a cleanup for issue #3959

Do I need to inline force_relayout?

Source-Repo: https://github.com/servo/servo
Source-Revision: 7b6e314df1b93bd749eee9036927d795f26e1590
2015-03-11 14:12:50 -06:00
Glenn Watson
8deb8a8419 servo: Merge #5188 - Perform reflow if load events dirty any nodes (from glennw:reflow-events); r=jdm
This fixes some test failures that begin occurring when other events (such as resize) are fixed to only occur when needed.

Source-Repo: https://github.com/servo/servo
Source-Revision: 19827658deaf21eb811203f89c78a0f99e631ad4
2015-03-10 16:57:47 -06:00
Mátyás Mustoha
4f3961c85c servo: Merge #5185 - Canvas: added arc() support (from mmatyas:canvas_arc); r=pcwalton
This patch enables the use of `arc()` on the canvas.
I couldn't add reftest this time, as it involves some antialiasing issues, and so the reference doesn't match.

Source-Repo: https://github.com/servo/servo
Source-Revision: e8f1a046c6c704915419cb75181f6e0bc402ef98
2015-03-10 09:45:49 -06:00
Zack Slayton
13f72e057c servo: Merge #5182 - Use new if let syntax wherever possible. Fixes #4153 (from zslayton:master); r=jdm
Opening this PR to invite feedback.

Of the many `match` statement candidates for conversion to `if let`, several included `if` guards. Since `if let` doesn't support this syntax, I used nested if statements. If this is undesirable, say the word and I can revert those cases to `match`.

Source-Repo: https://github.com/servo/servo
Source-Revision: d31e80f89490afe4863574c062f34b2a0df43bae
2015-03-10 07:51:50 -06:00
Patrick Walton
707a4d89ff servo: Merge #5160 - layout: Implement ordered lists, CSS counters, and quotes per CSS 2.1 § 12.3-12.5 (from pcwalton:counters-redux); r=SimonSapin
Only simple alphabetic and numeric counter styles are supported. (This
is most of them though.)

Although this PR adds a sequential pass to layout, I verified that on
pages that contain a reasonable number of ordered lists (Reddit
`/r/rust`), the time spent in generated content resolution is dwarfed by
the time spent in the parallelizable parts of layout. So I don't expect
this to negatively affect our parallelism expect perhaps in pathological
cases.

Reconstructed from #5138 via raw diffing.

r? @SimonSapin

Source-Repo: https://github.com/servo/servo
Source-Revision: fd1bb49a65dd998c8ef9890a1576aaf62ddfdba1
2015-03-09 23:24:47 -06:00
Avi Weinstock
51fab473ef servo: Merge #5183 - Subsume ScriptMsg::WorkerDispatchErrorEvent into ScriptMsg::RunnableMsg (from aweinstock314:master); r=saneyuki
...via introduction of Worker::WorkerErrorHandler (Closes #5171).

Source-Repo: https://github.com/servo/servo
Source-Revision: f4a362725faeb41aef85631965d3a4fd6153a70d
2015-03-09 17:00:51 -06:00
Adenilson Cavalcanti
fa5089ff49 servo: Merge #5150 - Implements reflow events debugging (from Adenilson:reflowNotifications03); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 4f3feed2bea957de0910a136d33dff4fb3c07a22
2015-03-06 21:48:50 -07:00
Prabhjyot Singh Sodhi
6d37a6bb57 servo: Merge #5054 - implement missing steps from "prepare a script" algorithm (from psdh:scriptimplementation); r=jdm
Fixes #4089

Source-Repo: https://github.com/servo/servo
Source-Revision: 73e5bbec4316c2e9b83121d5127687c20e1fb796
2015-03-06 13:36:53 -07:00
Guro Bokum
14bb53fef3 servo: Merge #5139 - ScriptTask::mouse_over_targets is not traced #4985 (from JIoJIaJIu:trace); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: eda9c0c9ac29646c5b4c9ce30b97c6547345171e
2015-03-06 09:42:52 -07:00
Keith Yeung
af689579e6 servo: Merge #5127 - Added type parameter to PartialEq on JSRef (from KiChjang:partial-eq-jsref); r=Ms2ger
Fixes #5112, #3960

Source-Repo: https://github.com/servo/servo
Source-Revision: 67548a6244f0cf92f6b71507b69dceb2115d1aa2
2015-03-05 01:15:44 -07:00
Adenilson Cavalcanti
d3a7c40cba servo: Merge #5144 - Remove flush_layout() (from Adenilson:removeFlushLayout01); r=Manishearth
Due to changes on Page/Window interfaces, we no longer have use for flush_layout().

Source-Repo: https://github.com/servo/servo
Source-Revision: 34289943e354b2ac0e54fd1fe2d65c944f6c8e9d
2015-03-04 16:54:44 -07:00
Josh Matthews
e85140b16c servo: Merge #5118 - Async document loads (from jdm:pageload); r=Ms2ger
Rebased and improved version of #4967.

Source-Repo: https://github.com/servo/servo
Source-Revision: 72f8898990f06e7f505eeaf9cfa671740c60395d
2015-03-03 16:03:45 -07:00
Adenilson Cavalcanti
2bbfffa4ca servo: Merge #5124 - Cleanup compilation warning (from Adenilson:cleanupWarning01); r=Ms2ger
Source-Repo: https://github.com/servo/servo
Source-Revision: 621150db1ca2d6ac9d4ba5d2709726dbc4139883
2015-03-03 13:51:48 -07:00
Simon Sapin
e9e4453a9a servo: Revert "layout: Implement ordered lists, CSS counters, and quotes per CSS 2.1"
This reverts commit 30fd28d1077fbb3f47140f6ab1252c0d24f44d23.

Source-Repo: https://github.com/servo/servo
Source-Revision: 4c1d778ced267eeef790d4166e361d9348b933d3
2015-03-03 21:16:24 +01:00
Simon Sapin
af6daf113d servo: Merge #5133 - layout: Implement image-rendering per CSS-IMAGES-3 § 5.3 and (from servo:background-size); r=SimonSapin
`background-size` per CSS-BACKGROUNDS § 3.9.

Nearest neighbor interpolation is used for `crisp-edges`, like Firefox.
A note has been added that we could do better if we wanted to.

Multiple backgrounds are not yet supported.

Rebase of #4368. Fixes #4368.

Source-Repo: https://github.com/servo/servo
Source-Revision: e1a50c771973fe3223cf98feea5d570375d68fa9
2015-03-03 11:48:54 -07:00
Simon Sapin
b8fa8e87d7 servo: Merge #5067 - layout: Implement ordered lists, CSS counters, and quotes per CSS 2.1 § 12.3-12.5 (from servo:counters); r=SimonSapin
Only simple alphabetic and numeric counter styles are supported. (This
is most of them though.)

Although this PR adds a sequential pass to layout, I verified that on
pages that contain a reasonable number of ordered lists (Reddit
`/r/rust`), the time spent in generated content resolution is dwarfed by
the time spent in the parallelizable parts of layout. So I don't expect
this to negatively affect our parallelism expect perhaps in pathological
cases.

Moved from #4544, because Critic.

Fixes #4544.

Source-Repo: https://github.com/servo/servo
Source-Revision: 5cd6316addc1acf145ed3220719387ef6ef08d2f
2015-03-03 10:42:52 -07:00
Patrick Walton
316f1ab042 servo: Merge #5132 - layout: Implement overflow-x and overflow-y per CSS-OVERFLOW § 3 (from servo:overflow-xy); r=SimonSapin
Rebase of #4567. Fix #4567.

Source-Repo: https://github.com/servo/servo
Source-Revision: 6fcc02e92f4c519239a834dc37a2965a4993322a
2015-03-03 09:06:55 -07:00
Avi Weinstock
b869d4a8d0 servo: Merge #5131 - Replace borrow with borrow_for_gc_trace in JSTraceable::trace (Issue #47 (from aweinstock314:master); r=jdm
...78).

Source-Repo: https://github.com/servo/servo
Source-Revision: 417a932e306438b5cda7a7071412a34d3e503f94
2015-03-03 07:18:53 -07:00
Glenn Watson
8b6b859ce0 servo: Merge #5086 - Reap layout data whenever a node is removed from the tree (from glennw:reap-more-stuff); r=jdm
Also introduce a clear() function to layout data which will be used to clear items such as compositor layouts.

Clear the layout data when a node becomes display:none.

Source-Repo: https://github.com/servo/servo
Source-Revision: 65454e51c806c7d91c869a7b4afce872b4eeea57
2015-03-02 16:45:51 -07:00
Patrick Walton
b5a965f5b2 servo: Merge #4475 - layout: Implement text-shadow per CSS-TEXT-DECORATION-3 § 4 (from pcwalton:text-shadow); r=mbrubeck
r? @mbrubeck

Depends on servo/rust-geom#64.

Source-Repo: https://github.com/servo/servo
Source-Revision: 93d1f40a96df69eb9d38890df96c621e180d78cc
2015-03-02 14:54:52 -07:00
Mátyás Mustoha
0e7b910b7a servo: Merge #5089 - Canvas: added lineTo support (from mmatyas:canvas_lineto); r=jdm
This patch enables the use of `lineTo()` on the canvas.

Source-Repo: https://github.com/servo/servo
Source-Revision: 9eaa48b793de78b713e6c3a3c79c4060084d5fbe
2015-03-02 13:33:55 -07:00
Ms2ger
2c3118008d servo: Merge #5110 - Fix string default values (from Ms2ger:defaultvalue-strings); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 2f3697f5f346cac7578883f452735d50b832c986
2015-03-02 12:57:59 -07:00
Keith Yeung
a1a3646687 servo: Merge #5111 - Implementation of step 1 activation behavior of htmlanchorelement (from KiChjang:step-1-anchor); r=Manishearth
Fixes #4871

Source-Repo: https://github.com/servo/servo
Source-Revision: fed878710c5697b49ccf5185ebe08a58be27073f
2015-03-01 22:18:49 -07:00
Ms2ger
4f7ce949d0 servo: Merge #5103 - Use the correct lifetime bounds for FooCast::from_actual (from Ms2ger:from_actual); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 184d32b519f1c5daf7dda164c9179e6c8ddc0919
2015-02-28 13:33:49 -07:00
Guro Bokum
50d6ed0a28 servo: Merge #5073 - Move body of ScriptTask::handle_mouse_move_event into a method on Document (fixes #5032) (from JIoJIaJIu:handle_mouse_event); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 75060f41dbd6c9a6e8865f1c1c88f5b984b199f7
2015-02-28 12:21:51 -07:00
Ms2ger
10a40bdbd2 servo: Merge #5099 - Cleanup our exception story (from Ms2ger:exceptions); r=saneyuki
Source-Repo: https://github.com/servo/servo
Source-Revision: 5eaf1144c327272e18584db9cf047d8bb2b53eed
2015-02-28 11:09:55 -07:00
Chris Manchester
46293a5a13 servo: Merge #5094 - Add support for BinaryName attribute to servo's codegen (fixes #4435) (from chmanchester:binarynames); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 1f53d30f858a71206fce01116a3b1e5c199c1648
2015-02-28 09:57:58 -07:00
Liam Zdenek
662650a284 servo: Merge #5059 - Click event is now a MouseEvent (from saneyuki:event); r=jdm
Fix #4260

Pick up: This original commit is https://github.com/servo/servo/pull/4718.

Source-Repo: https://github.com/servo/servo
Source-Revision: b261d27ac5fc5e8a858b344087792f9b1709ee55
2015-02-28 09:21:54 -07:00
Ms2ger
4f587fd92a servo: Merge #5100 - Fix a typo in argument_type (from Ms2ger:descriptorProvdider); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: b84f620b26b5dd14cb4a92bf428c5c722a6f6eb4
2015-02-28 08:45:54 -07:00
yodalee
ee6686eed6 servo: Merge #4928 - Issue4906 fix characterdata substringdata (from yodalee:issue4906-fix-characterdata-substringdata); r=jdm
issue #4906
Fix substringData function, and add a test case for all function in characterdata.

Source-Repo: https://github.com/servo/servo
Source-Revision: 55f763654910bb3110a8853d74481290a4e591af
2015-02-27 19:39:58 -07:00
James Gilbertson
dfc038211d servo: Merge #5066 - Implemented Document.currentScript (from luniv:document-currentscript); r=jdm
Implements https://github.com/servo/servo/issues/5057 (Document.currentScript)

Source-Repo: https://github.com/servo/servo
Source-Revision: 26567ef2e62597b359c179f8665213002e05da96
2015-02-27 11:30:57 -07:00
Keith Yeung
1a961beb6b servo: Merge #5031 - Moved dispatch_key_event method from script_task.rs to document.rs (from KiChjang:refactor-dispatch-key-event); r=jdm
Fixes #4982

Source-Repo: https://github.com/servo/servo
Source-Revision: 071941da59e442ad359d97e7c36e387c0029f9aa
2015-02-26 06:15:56 -07:00
James Gilbertson
94da1ff9d9 servo: Merge #5070 - Implement 'beforescriptexecute' and 'afterscriptexecute' events (from luniv:script-before-after-events); r=Ms2ger
Spec: https://html.spec.whatwg.org/multipage/scripting.html#execute-the-script-block, sections 2.b.2 & 2.b.9

Source-Repo: https://github.com/servo/servo
Source-Revision: c1645bd10ccd9a17e149d8bec56633ac06d8529f
2015-02-26 01:06:51 -07:00
Pawel Kondzior
231cf5701f servo: Merge #4960 - Add thaw/freeze messages that can suspend/resume webcontent timers #4907 (from pkondzior:add-script-timers-suspend-resume-functionality); r=jdm
Adds free/thaw methods to script_task that let you send suspend/resume messages to web content timers. Fixes #4907

Source-Repo: https://github.com/servo/servo
Source-Revision: a3ea3eed47713a4a6faa86c575bc2ac95c5fe135
2015-02-23 21:45:46 -07:00
Josh Matthews
2878c26ae3 servo: Merge #4996 - Eagerly report errors when evaluating JS on a global scope. Fixes #4966 (from jdm:reportpending); r=Ms2ger
I believe this problem was introduced with the mozjs error reporting changes, since we don't see errors reported from `<script>` blocks any more.

Source-Repo: https://github.com/servo/servo
Source-Revision: 99617557d40504060d5162739f8ba9b962843099
2015-02-23 20:30:48 -07:00
Ms2ger
99ff272300 servo: Merge #5040 - Simplify RootCollection::unroot a bit (from Ms2ger:cleanup-unroot); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 9a5970cceacb40a742a3f34292ad6bf5fa56c01f
2015-02-23 14:51:54 -07:00
Simon Sapin
eca1a51218 servo: Merge #5010 - Move selector matching to an external library, for use outside Servo (from SimonSapin:external-selectors); r=larsberg
The new library is https://github.com/servo/rust-selectors. It’s not quite ready for other users (the API needs work), but this is a first step.

https://github.com/servo/rust-selectors/pull/2 should also be reviewed.

Fixes #3669.

Source-Repo: https://github.com/servo/servo
Source-Revision: 91abf5557b1a324d6568ce08cfb92cdffca10e41
2015-02-23 08:39:47 -07:00
Ms2ger
2312a6e9af servo: Merge #5028 - Split the 'Execute a script block' code out of prepare() (from Ms2ger:script-split); r=jdm
This also adds comments for missing steps.

The only change in behaviour should be the debug message when an external
script fails to load.

Source-Repo: https://github.com/servo/servo
Source-Revision: f0b5794e44a2a28212aaf3fac4c340a3f32a8515
2015-02-23 06:33:47 -07:00
Patrick Walton
caba5137e0 servo: Merge #5016 - script: Implement enough 2D canvas support to render basic SVGs such as (from jdm:canvas-for-svg); r=jdm
the tiger.

Rebased from #4623.

Source-Repo: https://github.com/servo/servo
Source-Revision: 2e1adb3fa670504fb0fedaa517f312ba233bf67b
2015-02-22 20:33:45 -07:00
Tetsuharu OHZEKI
c6d0a098cd servo: Merge #5023 - Introduce dom::htmlscriptelement::EventDispatcher (from saneyuki:script); r=Ms2ger
Fix #5021

Source-Repo: https://github.com/servo/servo
Source-Revision: fe7db9d8d0dbf1135cf955a0cfb7bb1405a92a6e
2015-02-22 14:57:44 -07:00