Commit Graph

94 Commits

Author SHA1 Message Date
William Durand
4cf5bc48b2 Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
Depends on D169088

Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-02-08 10:25:02 +00:00
Butkovits Atila
af64ca6493 Backed out changeset ab00cf793f29 (bug 1800417) for causing failures at browser_unified_extensions_overflowable_toolbar.js. 2023-01-30 17:34:14 +02:00
William Durand
fd0ded3d7b Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-01-30 13:36:07 +00:00
William Durand
d42c7aaa29 Bug 1811128 - Use 16/32px extension icons in toolbars. r=rpl,dao
Differential Revision: https://phabricator.services.mozilla.com/D167573
2023-01-30 10:46:12 +00:00
Tomislav Jovanovic
d378ab25a4 Bug 1805523 - Implement temporary access state and attention, r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D165490
2023-01-24 00:47:13 +00:00
William Durand
8b62e8dde9 Bug 1801540 - Clean-up unified extensions CSS after it ships by default. r=Itiel,desktop-theme-reviewers
Depends on D166934

Differential Revision: https://phabricator.services.mozilla.com/D167378
2023-01-23 21:31:18 +00:00
William Durand
7761eccedb Bug 1799009 - Remove unified extensions pref and non-unified extensions variants from test suite. r=rpl,mconley,fluent-reviewers,desktop-theme-reviewers,Itiel
This patch removes the use of the "unified extensions" pref and adjust
the existing tests. More clean-ups will be done in follow-ups, e.g. the
removal of `gUnifiedExtensions.isEnabled` and some test-only changes to
no longer create a new window in each test file.

Differential Revision: https://phabricator.services.mozilla.com/D166908
2023-01-19 10:59:25 +00:00
Marian-Vasile Laza
3f9e8980c7 Backed out changeset 1c135e14142e (bug 1805523) for causing bc failures on browser_ext_windows_create_tabId.js. 2023-01-02 16:34:38 +02:00
Tomislav Jovanovic
6716f18a49 Bug 1805523 - Implement temporary access state and attention, r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D165490
2023-01-01 21:46:00 +00:00
William Durand
0640c4da83 Bug 1803650 - Remove setAttribute() since the label is updated with Fluent. r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D163629
2022-12-02 20:31:49 +00:00
William Durand
80f9f71d60 Bug 1799694 - Avoid flickering when messages have different lengths. r=rpl,mconley,desktop-theme-reviewers,Itiel
This is a completely redesign based on mconley's idea to use `deck`.
That removes a lot of code and makes things a lot better.

Depends on D163077

Differential Revision: https://phabricator.services.mozilla.com/D162390
2022-11-27 17:07:44 +00:00
William Durand
ef7a4e1a24 Bug 1799694 - Rename action/menu button class names in unified extensions. r=Itiel,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D163077
2022-11-27 17:07:44 +00:00
William Durand
a4a9f55ee9 Bug 1802411 - Set disabled state on the action button for extension widgets. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D163100
2022-11-25 14:53:59 +00:00
Tomislav Jovanovic
ce9d450436 Bug 1801136 - Update tooltips when extensions require attention for permissions, r=willdurand,flod
Differential Revision: https://phabricator.services.mozilla.com/D162894
2022-11-24 14:16:30 +00:00
William Durand
5ff99717fb Bug 1801515 - Hover messages shouldn't be hidden by extensions in the UEP. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D162555
2022-11-22 17:49:18 +00:00
William Durand
3b920d7b92 Bug 1801142 - Add hover messages on CUI widgets in the unified extensions panel. r=rpl,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D162331
2022-11-18 12:08:19 +00:00
Mike Conley
1e8fc28499 Bug 1799947 - Update existing tests to put browser_action's into the navbar by default. r=willdurand,extension-reviewers
We had a number of tests that assumed that when adding a browser_action without
specifying the default_area, that the button would enter the navbar. The previous
patch in this series changes that assumption when the Unified Extensions UI is
enabled.

Instead of updating all of these tests to add additional steps to move the
browser_action's out to the navbar after adding them, I've gone ahead and
updated them to default their browser_action's to the navbar instead.

Differential Revision: https://phabricator.services.mozilla.com/D161721
2022-11-16 22:12:52 +00:00
Mike Conley
4d13193918 Bug 1799947 - With Unified Extensions UI, make addons panel the fallback area for browser_actions. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D161720
2022-11-16 22:12:52 +00:00
Marian-Vasile Laza
bfb43d0dc3 Backed out 2 changesets (bug 1799947) for causing browserAction bc, mochitest, devtools related failures. CLOSED TREE
Backed out changeset ff58300200c4 (bug 1799947)
Backed out changeset 517df40ddcd4 (bug 1799947)
2022-11-15 22:38:24 +02:00
Mike Conley
bbd86e3da7 Bug 1799947 - With Unified Extensions UI, make addons panel the fallback area for browser_actions. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D161720
2022-11-15 18:37:31 +00:00
Mike Conley
d4d3af9877 Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161200
2022-11-15 16:37:23 +00:00
Stanca Serban
7abed322ee Backed out 3 changesets (bug 1782203) for causing lint failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
Backed out changeset 50e57afebed3 (bug 1782203)
Backed out changeset d17ea376ed45 (bug 1782203)
Backed out changeset e91d51f1ce90 (bug 1782203)
2022-11-15 17:42:22 +02:00
Mike Conley
55af77e9ed Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161200
2022-11-15 15:02:08 +00:00
William Durand
307f9a8b0e Bug 1777484 - Enhance extension widgets in the unified extensions panel. r=rpl,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161168
2022-11-15 12:59:34 +00:00
Csoregi Natalia
1ce4bb73a7 Backed out 4 changesets (bug 1782203, bug 1777484) for failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
Backed out changeset ae47d92443a7 (bug 1782203)
Backed out changeset 0c90b1d40e9f (bug 1782203)
Backed out changeset 4b4cae098ea0 (bug 1782203)
Backed out changeset 75eba3b7a626 (bug 1777484)
2022-11-15 03:06:21 +02:00
Mike Conley
70738f0144 Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161200
2022-11-14 22:41:09 +00:00
William Durand
a5ca2f6904 Bug 1777484 - Enhance extension widgets in the unified extensions panel. r=rpl,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D161168
2022-11-14 22:41:08 +00:00
William Durand
a9884dda35 Bug 1798324 - Update style of extension widgets in the panel. r=mconley,desktop-theme-reviewers,dao,rpl
Differential Revision: https://phabricator.services.mozilla.com/D161036
2022-11-10 11:29:16 +00:00
Mike Conley
c759904dae Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
2022-11-08 14:51:40 +00:00
William Durand
fc741397c8 Bug 1799143 - Fix attention dot for MV3 extension buttons in the toolbar and overflow panel. r=dao,extension-reviewers,zombie
Differential Revision: https://phabricator.services.mozilla.com/D161299
2022-11-08 14:28:10 +00:00
Shane Caraveo
e5c4d6af38 Bug 1784947 - Make browser action a custom widget to support unified extension button. r=desktop-theme-reviewers,zombie,Itiel
Co-Authored-By: William Durand <will+git@drnd.me>

Differential Revision: https://phabricator.services.mozilla.com/D154470
2022-11-03 09:30:22 +00:00
Mike Conley
ce84c284ed Bug 1797838 - Add a webExtension property to CustomizableUI widgets for browserAction buttons. r=dao,willdurand
This property, along with the CustomizableUI.isWebExtensionWidget, will make it possible
to distinguish WebExtension-provided widgets without sniffing CSS classes, which is what
we currently do.

In the event that the widget has been destroyed or hasn't yet been created, this will
fallback to looking for the `-browser-action` suffix on the ID. This is mainly for use during
migrations which happen early during CustomizableUI startup, when it's unlikely that the
extensions have finished initializing themselves and creating their widgets yet.

Differential Revision: https://phabricator.services.mozilla.com/D160802
2022-11-02 16:52:59 +00:00
Oliver Dunk
9184ae7c67 Bug 1755763 - Update browserAction.openPopup API r=geckoview-reviewers,robwu,owlish
To align with other browsers, the user gesture requirement has
been removed and there is now an optional first argument which
can be used to provide a windowId.

Differential Revision: https://phabricator.services.mozilla.com/D139796
2022-10-31 15:22:41 +00:00
Stanca Serban
99f363367a Backed out changeset adb4eb909fc2 (bug 1755763) for causing mochitests failures on browser_ext_browserAction_click_types.js. CLOSED TREE 2022-10-25 15:53:19 +03:00
Oliver Dunk
4782921100 Bug 1755763 - Update browserAction.openPopup API r=geckoview-reviewers,robwu,owlish
To align with other browsers, the user gesture requirement has
been removed and there is now an optional first argument which
can be used to provide a windowId.

Differential Revision: https://phabricator.services.mozilla.com/D139796
2022-10-25 11:49:42 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Tomislav Jovanovic
a16d5052dd Bug 1777343 - Implement simple origin controls attention indicator, r=willdurand,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D158476
2022-10-13 22:04:52 +00:00
Shane Caraveo
c114951f8b Bug 1783972 make browser actions pop out of overflow r=zombie,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D154179
2022-08-22 18:55:59 +00:00
William Durand
68182a4ab7 Bug 1777483 - Part 4 - Add extension actions to the unified extensions context menu. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D153096
2022-07-29 20:32:16 +00:00
kernp25
1938ec1743 Bug 1654355 - Fix activeTab with middle click. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D143876
2022-04-28 08:35:41 +00:00
Luca Greco
6f2b70ed2b Bug 1748546 - Add support for persistent events to ext-browserAction.js. r=mixedpuppy
Depends on D141663

Differential Revision: https://phabricator.services.mozilla.com/D139786
2022-03-25 20:38:36 +00:00
Rob Wu
b6b78cf0cc Bug 1714846 - Really hide panels on hide, r=robwu,emilio
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-07 11:50:19 +00:00
Butkovits Atila
f90ffaea22 Backed out changeset 6e298bdd0dd8 (bug 1714846) for causing assertion failures at CompositorBridgeParent.cpp. CLOSED TREE 2021-12-03 23:30:10 +02:00
Rob Wu
68e93f997c Bug 1714846 - Really hide panels on hide, r=robwu,emilio
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-03 19:16:51 +00:00
Shane Caraveo
6105a0cf3a Bug 1706398 support action context type for context menus r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D116858
2021-06-15 14:51:13 +00:00
Shane Caraveo
647348a86c Bug 1706398 implement action support and alias browser_action to action. r=robwu,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D113461
2021-06-15 14:51:12 +00:00
Agi Sferro
b116176172 Bug 1625593 - Move activeTab functionality to toolkit. r=robwu,esawin
Differential Revision: https://phabricator.services.mozilla.com/D95420
2021-02-04 02:19:18 +00:00
Dorel Luca
5ddb1327fc Backed out changeset 100bc29bbb72 (bug 1625593) for Browser-chrome failures in gfx/layers/apz/test/mochitest/browser_test_scrollbar_in_extension_popup_window.js. CLOSED TREE 2021-01-30 01:13:18 +02:00
Agi Sferro
ac03594a01 Bug 1625593 - Move activeTab functionality to toolkit. r=robwu,esawin
Differential Revision: https://phabricator.services.mozilla.com/D95420
2021-01-29 19:07:55 +00:00
Dave Townsend
4b134e74e8 Bug 1620358: Gather telemetry on toolbar state. r=Gijs,zombie
Differential Revision: https://phabricator.services.mozilla.com/D78393
2020-06-16 21:06:15 +00:00