Commit Graph

82 Commits

Author SHA1 Message Date
Vasish Baungally
33c648d5ab Bug 1964774 - Improve Suggest Latency for Smart Tabs by preloading. r=ngrato,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D248098
2025-05-13 01:47:38 +00:00
Stephen Thompson
b7d69dd476 Bug 1963713 - add tab group ungroup metric event r=dao,tabbrowser-reviewers
Record when a user ungroups the tabs of a tab group.

We ungroup an entire group when the user selects the "Ungroup tabs" context menu item on the tab group, but we also do that if the user cancels out of tab group creation context menu. We are particularly interested in understanding when users cancel out of the creation process. This may give us a better indicator about accidental tab group creation, e.g. when the user intended to drag and drop to move a tab but ended up creating a tab group from two tabs.

Differential Revision: https://phabricator.services.mozilla.com/D247633
2025-05-07 15:05:43 +00:00
Vasish Baungally
fa152cc2f8 Bug 1962228 - Add Telemetry for Pref Changes for Smart Tab Groups. r=rrando,tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D246800
2025-05-01 21:19:51 +00:00
Vasish Baungally
9ca170316a Bug 1951374 - damp browser-toolbox.styleeditor-ready.DAMP (Windows) regression on Tue February 18 2025 r=dao,tabbrowser-reviewers,ngrato
Differential Revision: https://phabricator.services.mozilla.com/D241510
2025-04-29 15:20:17 +00:00
Vasish Baungally
11f63f2b75 Bug 1961641 - Add Telemetry when Smart Tab Model has no suggestion. r=ngrato,tabbrowser-reviewers
We were initializing two SmartTabGroupingManager instances in tabbrowser and tabgroup-menu. This was
causing issues with telemetry. This is now cleaned up.

Also, adding the model reason for no suggestion per DS request.

Differential Revision: https://phabricator.services.mozilla.com/D246113
2025-04-24 15:43:23 +00:00
Stephen Thompson
f8fe0335c0 Bug 1938401 - tab group interaction metrics r=dwalker,sessionstore-reviewers,tabbrowser-reviewers
Records counts of user interactions with tab groups:

- expand a collapsed tab group
- collapse an expanded tab group
- rename a tab group
- change a tab group's color
- save and close a tab group
- delete a tab group
- reopen a deleted tab group
- ungroup a tab group
- move a tab group to a new window
- reopen a saved and closed tab group from the list all tabs menu
- reopen a saved and closed tab group from a URL bar suggestion
- reopen a recently closed tab group from the recently closed tabs menu

Differential Revision: https://phabricator.services.mozilla.com/D246123
2025-04-24 02:20:14 +00:00
Dão Gottwald
e55da1505a Bug 1961224 - Remove bogus "panel" class from tab group panel. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D245959
2025-04-18 03:14:59 +00:00
Dão Gottwald
7f2c8ae7a1 Bug 1961150 - Add tooltips to tab group editor buttons to deal with locales that may have longer button labels. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D245911
2025-04-17 15:06:13 +00:00
Vasish Baungally
ef0b50f888 Bug 1960683 - Prevent event from being sent for Smart Tab Grouping if not opted-in. r=tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D245601
2025-04-15 16:52:05 +00:00
Dão Gottwald
157f63d52d Bug 1960296 - Account for moz-button in addition to toolbarbutton when handling the Enter key. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D245392
2025-04-14 16:00:57 +00:00
Dão Gottwald
a07bd270a0 Bug 1953179 - Fix enter key handling on toolbarbuttons in tab group menu. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D245220
2025-04-13 10:34:15 +00:00
Cristina Horotan
58439062ed Backed out changeset fa742bc59c5c (bug 1953179) for causing perma bc failures at browser_tab_groups.js. CLOSED TREE 2025-04-12 06:00:55 +03:00
Dão Gottwald
f33d1d2b0c Bug 1953179 - Fix enter key handling on toolbarbuttons in tab group menu. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D245220
2025-04-11 15:02:06 +00:00
Stephen Thompson
f2e07044ae Bug 1938424 - metrics event when tabs added to tab group r=dao,jswinarton,tabbrowser-reviewers,extension-reviewers,robwu
When using the tab context menu or drag-dropping tabs to put them into a group, record a metric for the number of tabs added to the group.

Data Science asked us to launch with this metric disabled so that they could control it using server knobs. They expect a high volume of events, so they expect to only enable this metric for some proportion of users.

I converted the existing `TabMove` event derived from `UIEvent` being fired when tabs change their tab index in the tab strip. `UIEvent` doesn't allow for attaching additional context/detail to the event. `TabMove` is now a `CustomEvent` that provides more context about the moved tab and it fires in more cases -- it's possible for the tab index not to change despite the tab having "moved" into/out of a tab group.

This approach would not capture tab movements that occur across multiple frames/event loop iterations.

Differential Revision: https://phabricator.services.mozilla.com/D244616
2025-04-11 13:52:22 +00:00
Stephen Thompson
895511dc6f Bug 1938430 - add delete tab group event r=jswinarton,tabbrowser-reviewers,sessionstore-reviewers
Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.

This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.

Differential Revision: https://phabricator.services.mozilla.com/D241884
2025-04-03 14:12:43 +00:00
Rolf Rando
830f66b654 Bug 1955955 - Handle user cancel of Smart Tab Grouping Opt-in or clustering r=ngrato,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D244086
2025-04-02 18:02:22 +00:00
Nick Grato
5d6e28533b Bug 1957708 - Add link place holder to optin message r=fluent-reviewers,tabbrowser-reviewers,firefox-ai-ml-reviewers,flod,txia
Adding additional functionality for there to be a link in the message part of the optin component. Using a place holder link to support for now. This will be updated to a new SUMO article.

Differential Revision: https://phabricator.services.mozilla.com/D244069
2025-04-02 16:28:38 +00:00
Nick Grato
9202f6836f Bug 1957777 - highlight name field when label is suggested r=dwalker,tabbrowser-reviewers
highlight text when label is suggested but also un-focus the input when a user clicks out of the input anywhere on the panel.

Differential Revision: https://phabricator.services.mozilla.com/D244096
2025-04-02 16:10:37 +00:00
Vasish Baungally
7a6a4ff8f9 Bug 1957097 - Add telemetry for empty suggestion from ML topic model. r=rrando,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D243465
2025-04-01 20:35:12 +00:00
Rolf Rando
24ded0f086 Bug 1956522 - Fix issue with private tab and smart tab grouping r=tabbrowser-reviewers,vazish
Differential Revision: https://phabricator.services.mozilla.com/D243392
2025-03-28 15:50:02 +00:00
Nick Grato
21173d07c3 Bug 1956643 - Change Select all tabs to a checkbox from a toggle button r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,sthompson,hjones
when the user is presented with the AI suggested tabs in STG, change the action button that toggles the select and deselect actions to just being a simple select all checkbox that only selects all when checked. Remove the deselect all functionality.

Differential Revision: https://phabricator.services.mozilla.com/D243221
2025-03-27 20:49:38 +00:00
Jeremy Swinarton
34d9e59418 Bug 1938426: Record telemetry event when saving a tab group r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242984
2025-03-27 15:29:19 +00:00
Cosmin Sabou
ced1f3c105 Backed out changeset 68d101b370d8 (bug 1938430) for permafailures on browser_tab_manager_groups.js (Bug 1938697). 2025-03-27 00:21:30 +02:00
Nick Grato
4113c7ce84 Bug 1956077 - Enhance STG user flow with assorted UX callouts r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,firefox-ai-ml-reviewers,sthompson,bolsson,hjones
Update strings in STG user flow. Update button styles. Add new footer paragraph and link to model optin component. Expand the panel when showing suggested tabs. Fix messaging coloring when there are no tabs to suggest.

Differential Revision: https://phabricator.services.mozilla.com/D242786
2025-03-26 17:16:39 +00:00
Vasish Baungally
2e7c7849b7 Bug 1956073 - Add Opt-in & additional telemetry for Smart Tab Grouping r=rrando,dwalker,tabbrowser-reviewers
- Telemetry for opt-in
     - For each onboarding step
- Telemetry updates for existing
     - Clicking away with ML group name without explicitly clicking "done" or "cancel"
     - When there are no suggestions for "suggest other tabs"
     - Add group id to ml telemetry
     - Move stg telemetry under tab group telemetry
     - Remove num_ from events

Differential Revision: https://phabricator.services.mozilla.com/D242784
2025-03-26 15:41:49 +00:00
Stephen Thompson
78282be03c Bug 1938430 - add delete tab group event r=jswinarton,tabbrowser-reviewers,sessionstore-reviewers
Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.

This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.

Differential Revision: https://phabricator.services.mozilla.com/D241884
2025-03-25 21:16:37 +00:00
Rolf Rando
6457c1eed4 Bug 1954648 - Smart Tab Group settings in Preferences->Tabs r=ngrato,fluent-reviewers,settings-reviewers,tabbrowser-reviewers,dwalker,flod
Differential Revision: https://phabricator.services.mozilla.com/D241922
2025-03-23 04:03:31 +00:00
Nick Grato
a637f54059 Bug 1951524 - Opt-in UI with Progress bar for Smart Tab groups r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,dwalker,hjones
adding the optin flow and progress bar

Differential Revision: https://phabricator.services.mozilla.com/D241864
2025-03-21 16:03:03 +00:00
Francesco Lodolo (:flod)
2dc7e3ee3a Bug 1955573 - Don't generate Fluent IDs at run-time for Tab Group colors, r=tabbrowser-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D242520
2025-03-21 15:33:38 +00:00
Butkovits Atila
a1232f30d3 Backed out changeset e2836c2d1f98 (bug 1951524) for causing failures at browser_all_files_referenced.js. 2025-03-21 08:37:42 +02:00
Nick Grato
2a66d14721 Bug 1951524 - Opt-in UI with Progress bar for Smart Tab groups r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,dwalker,hjones
adding the optin flow and progress bar

Differential Revision: https://phabricator.services.mozilla.com/D241864
2025-03-21 03:23:11 +00:00
Sandor Molnar
53925bf70d Backed out changeset 272d0dd8b6a7 (bug 1954648) for causing bc failures @ browser_experimental_features.js 2025-03-19 23:36:30 +02:00
Rolf Rando
07417b054d Bug 1954648 - Smart Tab Group settings in Preferences->Tabs r=ngrato,fluent-reviewers,settings-reviewers,tabbrowser-reviewers,dwalker,flod
Differential Revision: https://phabricator.services.mozilla.com/D241922
2025-03-19 17:14:19 +00:00
Nick Grato
207d8697bf Bug 1949808 - Prevent smart tab topic output from replacing group label if user starts typing r=vazish,tabbrowser-reviewers,dao
adding additional check before populating input

Differential Revision: https://phabricator.services.mozilla.com/D240223
2025-03-06 15:38:51 +00:00
Dão Gottwald
8bce10cd45 Bug 1951939 - Save and close tab group when middle clicking the group label. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240479
2025-03-06 13:18:26 +00:00
Butkovits Atila
b6264adeb4 Backed out changeset 79e3d8d9befa (bug 1949808) for causing failures at browser_tab_grouping_telemetry.js. CLOSED TREE 2025-03-06 13:53:35 +02:00
Nick Grato
be9d852d84 Bug 1949808 - Prevent smart tab topic output from replacing group label if user starts typing r=vazish,tabbrowser-reviewers,dao
adding additional check before populating input

Differential Revision: https://phabricator.services.mozilla.com/D240223
2025-03-06 10:30:44 +00:00
Nick Grato
43e8b7b8e6 Bug 1949590 - STG pref need to be watched to update UI not just on init r=vazish,tabbrowser-reviewers
adding a watcher to the lazy pref getter

Differential Revision: https://phabricator.services.mozilla.com/D239187
2025-03-04 17:49:34 +00:00
Gijs Kruitbosch
dcb8be8cff Bug 1950871 - switch browser/components/tabbrowser to use moz-src, r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239926
2025-03-03 12:47:49 +00:00
Butkovits Atila
d22beded8a Backed out changeset 130ec750949d (bug 1949590) for causing Lint failures. CLOSED TREE 2025-02-22 01:51:44 +02:00
Nick Grato
3553e3994e Bug 1949590 - STG pref need to be watched to update UI not just on init r=vazish,tabbrowser-reviewers
adding a watcher to the lazy pref getter

Differential Revision: https://phabricator.services.mozilla.com/D239187
2025-02-21 23:03:55 +00:00
Vasish Baungally
7f96278c2f Bug 1949010 - Add Glean Metrics for Smart Tab Grouping. r=rrando,ngrato,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238803
2025-02-21 21:29:47 +00:00
Vasish Baungally
45db6f6e22 Bug 1949274 - Fix default tab group actions for Smart Tab Groups r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D238818
2025-02-19 22:04:14 +00:00
Nick Grato
37d617a207 Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
2025-02-18 18:45:45 +00:00
Stanca Serban
24a38fdf6a Backed out changeset 7dac3dae07a0 (bug 1946523) for causing mochitests failures in browser_startup_images.js. 2025-02-15 23:17:28 +02:00
Nick Grato
9f4d386cb1 Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
2025-02-15 16:18:57 +00:00
Alexandru Marc
785a1b0b4c Backed out 2 changesets (bug 1946523) for causing bc failures @ browser_startup_images.js CLOSED TREE
Backed out changeset f42c3c3bcfd9 (bug 1946523)
Backed out changeset 3dae4114d6ac (bug 1946523)
2025-02-15 12:34:09 +02:00
Nick Grato
10159f4959 Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
2025-02-15 05:04:46 +00:00
Goloman Adrian
eb3e8e70f1 Backed out changeset 7bc709851769 (bug 1946523) for causing bc failures @browser_parsable_css.js. 2025-02-15 03:33:36 +02:00
Nick Grato
a80b3b326c Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
2025-02-15 00:53:01 +00:00