corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
770,208 Commits 1 Branch 0 Tags
4b170423dd9c271d8967f7a234476b45e3c1f86d
Commit Graph

837 Commits

Author SHA1 Message Date
Dão Gottwald
4b170423dd Bug 1809465 - Replace _hoveredTab with a private tab property. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D166441
 2023-01-10 17:10:30 +00:00
Oriol Brufau
ca1a72c7a6 Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu 
And make callers rely on that instead of allowInheritPrincipal when
creating lazy tabs.

Unlike allowInheritPrincipal, skipLoad sets the nodefaultsrc attribute.
This avoids a load instead of falling back to about:blank.

One consequence of that is that switching to a lazy about:blank tab will
not notify invoke listeners registered with addTabsProgressListener
(listeners registered with addProgressListener will still be invoked).

Thus test browser_open_in_lazy_tab.js needs to be updated.

Differential Revision: https://phabricator.services.mozilla.com/D166012
 2023-01-07 13:51:47 +00:00
Sandor Molnar
4f5ee6f941 Backed out changeset 2b67bd0dd255 (bug 1808615) for causing bc failures in browser/components/customizableui/test/browser_open_in_lazy_tab.js CLOSED TREE 2023-01-07 03:18:23 +02:00
Oriol Brufau
60b9a931c7 Bug 1808615 - Make addTab default skipLoad to createLazyBrowser. r=Gijs,extension-reviewers,nika,robwu 
And make callers rely on that instead of allowInheritPrincipal when
creating lazy tabs.

Differential Revision: https://phabricator.services.mozilla.com/D166012
 2023-01-07 00:37:36 +00:00
Oriol Brufau
688084c92b Bug 1808721 - Stop invalidating cached _tabs from showTab and hideTab. r=dao 
Invalidating cached _visibleTabs should be enough.

Differential Revision: https://phabricator.services.mozilla.com/D166085
 2023-01-05 16:25:59 +00:00
Gijs Kruitbosch
1113bc0e43 Bug 1475606 - remove loadOneTab and switch its callers over, r=dao,perftest-reviewers,sparky 
Depends on D165774

Differential Revision: https://phabricator.services.mozilla.com/D165775
 2023-01-03 22:24:44 +00:00
Gijs Kruitbosch
be4f0334ac Bug 1475606 - remove separate logic for tabbrowser's loadOneTab(), r=dao 
This used to do three things:
1. determine whether we're background loading
2. determine a default owner tab
3. force allowInheritPrincipal to a bool value

For the background loading, I removed the default pref check and moved the
selection action into addTab. I defaulted it to true, so that existing addTab
callers continue to open background tabs. I removed the code checking the pref:
all existing loadOneTab callsites pass an explicit value and where appropriate
check the pref themselves (sometimes doing the opposite in response to shift
keypresses etc.).
The one exception is browser_bug597218.js, but there the default of true gets
used right now, which is still the same post-patch.

For the owner tab, I moved setting the default into addTab. This shouldn't
affect existing addTab callers as they don't pass inBackground anyway, so we
default inBackground to true, in which case it just assigns null, only when
ownerTab wasn't provided in the first place.

For allowInheritPrincipal, the only reads of this in addTab use boolean negation
anyway so forcing its type to bool first made no difference.

Differential Revision: https://phabricator.services.mozilla.com/D165774
 2023-01-03 22:24:44 +00:00
Oriol Brufau
86e125812f Bug 1760460 - Turn gBrowser._removingTabs into a Set. r=Gijs 
Thus avoiding ugly things like:
this._removingTabs.splice(this._removingTabs.indexOf(aTab), 1);

Differential Revision: https://phabricator.services.mozilla.com/D165736
 2023-01-01 18:09:28 +00:00
Meg Viar
79eec33848 Bug 1805930 - Change featureCallout.mjs to featureCallout.sys.mjs and update all references to filename r=barret,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D164824
 2022-12-29 14:27:02 +00:00
Mark Banner
34d6fb8d94 Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D165068
 2022-12-27 10:08:58 +00:00
Gijs Kruitbosch
788a3ae7e4 Bug 1738190 - allow opening inline SVG background images in a new tab, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D165454
 2022-12-23 17:23:44 +00:00
Gijs Kruitbosch
2ddb749dcd Bug 1806919 - simplify loadOneTab to not unwrap and rewrap the same object, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D165453
 2022-12-23 17:23:43 +00:00
Stanca Serban
eb72a57ac6 Backed out changeset a92af276c945 (bug 1805930) for causing bustages in packager.mk. CLOSED TREE 2022-12-19 21:41:40 +02:00
Meg Viar
2cf660435c Bug 1805930 - Change featureCallout.mjs to FeatureCallout.sys.mjs and update all references to filename r=barret 
Differential Revision: https://phabricator.services.mozilla.com/D164824
 2022-12-19 18:55:05 +00:00
Jason Prickett
8dc33d0067 Bug 1804589 - Refactors pdfjs feature callout instantiation for better performance r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D164174
 2022-12-09 20:14:46 +00:00
Meg Viar
63afba9b12 Bug 1804490 - Update PDF.js callout messages' targeting to only show on PDF documents r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D164129
 2022-12-08 12:37:03 +00:00
Jason Prickett
a880490eae Bug 1803660 - Hide and show feature callout surface when tabs are changed r=mviar 
Depends on D163639

Differential Revision: https://phabricator.services.mozilla.com/D163642
 2022-12-06 23:22:50 +00:00
Noemi Erli
38df0ec770 Backed out changeset ab219eb65432 (bug 1803660) for causing failures in /browser_newtab_ping.js CLOSED TREE 2022-12-06 22:29:16 +02:00
Jason Prickett
fd2e0452f9 Bug 1803660 - Hide and show feature callout surface when tabs are changed r=mviar 
Depends on D163639

Differential Revision: https://phabricator.services.mozilla.com/D163642
 2022-12-06 19:27:40 +00:00
Meg Viar
18abc909b1 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D160503
 2022-11-30 01:47:23 +00:00
Nika Layzell
c401277cf6 Bug 1538028 - Part 4: Pass TriggeringRemoteType through the frontend, r=Gijs,emilio 
Propagate the ability to pass triggeringRemoteType through the desktop frontend
in various places, such that it is set when using the context menu or content
click handler.

Differential Revision: https://phabricator.services.mozilla.com/D161834
 2022-11-29 20:41:46 +00:00
Sandor Molnar
61f05197c3 Backed out changeset 28484915dc1b (bug 1795894) for causing mochitest failures. CLOSED TREE 2022-11-28 04:33:07 +02:00
Meg Viar
3633b07781 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D160503
 2022-11-28 00:54:14 +00:00
Neil Deakin
cbefc0ebf5 Bug 1801168, only expect the full screen exited event when the inDOMFullscreen attribute is set and select the url only in this case, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D162857
 2022-11-25 10:36:00 +00:00
Eemeli Aro
9a3c42464a Bug 1760029 - Migrate browser.properties strings used by tabbrowser.js to Fluent. r=dao,fluent-reviewers,flod 
The autorefresh blocker strings are added to `browser.ftl` as they aren't really "tab" strings.

Differential Revision: https://phabricator.services.mozilla.com/D159017
 2022-11-22 17:12:21 +00:00
Eemeli Aro
46d4e9b1a3 Bug 1760029 - Migrate tabbrowser.properties strings used by tabbrowser.js to Fluent. r=dao,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D159016
 2022-11-22 17:12:21 +00:00
Neil Deakin
a402fd4d84 Bug 1801060, fix selectURL function call so that url is selected properly, r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D162317
 2022-11-21 21:30:46 +00:00
Neil Deakin
d3b4cd4f58 Bug 1219775 , focus the url bar when opening a new tab while in fullscreen mode, r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D161517
 2022-11-15 17:15:51 +00:00
Marian-Vasile Laza
cb5a3644d1 Backed out changeset de61491bc549 (bug 1795894) for causing bc failures on browser_protocol_ask_dialog.js. CLOSED TREE 2022-11-11 01:14:04 +02:00
Meg Viar
9e1c9a7613 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D160503
 2022-11-10 21:01:22 +00:00
Marian-Vasile Laza
4582bdf7cb Backed out changeset 2023e8659017 (bug 1795894) for causing multiple bc failures on featureCallout.mjs. CLOSED TREE 2022-11-10 21:42:43 +02:00
Meg Viar
ed1f5ee2a9 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D160503
 2022-11-10 18:47:04 +00:00
Bernard Igiri
511d17c548 Bug 1790971 - Prevent Firefox View Tab from being autoselected on tab closing r=dao 
Prevent pinned Firefox View Tab from being autoselected on tab closing.

Differential Revision: https://phabricator.services.mozilla.com/D161218
 2022-11-04 13:35:13 +00:00
Shane Hughes
b5e7da0a12 Bug 1743878 - Avoid opening caret browsing dialogs when already open. r=dholbert 
Differential Revision: https://phabricator.services.mozilla.com/D160166
 2022-10-26 19:27:34 +00:00
Stanca Serban
50ec21d946 Backed out changeset d076c8363b14 (bug 1743878) for causing bc failures on browser_findbar_disabled_manual.js. CLOSED TREE 2022-10-26 13:10:37 +03:00
Shane Hughes
4a0617c8ce Bug 1743878 - Avoid opening caret browsing dialogs when already open. r=dholbert 
Differential Revision: https://phabricator.services.mozilla.com/D160166
 2022-10-26 05:42:05 +00:00
James Teow
eb0cc6713e Bug 1788953 - Part 1: Add originalURI to browser-custom-element - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D157485
 2022-10-18 13:38:49 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Tim Giles
9c4d623be8 Bug 1792680 - Fix Firefox View not being a reloadable tab. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D159212
 2022-10-13 14:28:16 +00:00
Daisuke Akatsuka
99341cf6fa Bug 1792971: Suppress popup notification while async tab switching. r=adw,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D158480
 2022-10-11 00:10:26 +00:00
Dão Gottwald
ffb77e2df1 Bug 1792607 - Use early return in showTab. r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D158229
 2022-09-28 02:20:01 +00:00
Shane Hughes
1577034f2f Bug 1791770 - Prevent add-ons from showing Fx View tab. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158009
 2022-09-26 19:33:52 +00:00
Evan
7be0d917de Bug 1788783 -Converted Picture in Picture JSM modules to ESMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D157039
 2022-09-23 18:11:48 +00:00
Dão Gottwald
308590ef34 Bug 1789022 - Insert tabs opened from Firefox View at the beginning of the tab strip. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157724
 2022-09-20 13:50:34 +00:00
Dão Gottwald
1737bdc3e8 Bug 1790593 - Exclude hidden tabs from tab multiselection. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157466
 2022-09-15 14:59:12 +00:00
Dão Gottwald
af3ddd2293 Bug 1783811 - "Move Tab" and "Open in New Container Tab" options should be disabled for the Firefox View tab (and hidden tabs in general) in the "List all tabs" menu. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D154099
 2022-09-13 08:45:47 +00:00
Emilio Cobos Álvarez
e4bcc13cb9 Bug 1789877 - Hide inactive statuspanel. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D156921
 2022-09-12 09:55:30 +00:00
Emilio Cobos Álvarez
a1107cbac0 Bug 1789892 - Simplify statuspanel a bit. r=dao 
I'm a bit baffled about bug 1789877. My best theory so far is that we're
inserting the element a bit deeper in the DOM and that causes us to
reflow slightly more stuff when tab-switching, but...

In any case while going through the code the status panel can be
simplified a bit now, so do that.

Differential Revision: https://phabricator.services.mozilla.com/D156876
 2022-09-09 19:36:21 +00:00
Emilio Cobos Álvarez
98196eb0a8 Bug 1789125 - Explicitly position statuspanel vertically. r=dao 
Right now, the vertical position of the status panel is the "auto"
position, which ends up working out, but mostly by chance, and relies on
behavior that's different from the standard flexbox, see bug 1789165.

Instead of using `position: fixed` and relying on not having any
sidebars or other content to the inline-end (otherwise the [mirror] rule
would be incorrect), explicitly position it against the
.browserContainer.

Differential Revision: https://phabricator.services.mozilla.com/D156384
 2022-09-06 19:05:54 +00:00
Daisuke Akatsuka
05818fe5ec Bug 1565751: Wait for processing needed before selecting text. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D155042
 2022-08-24 00:43:03 +00:00