corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
706,771 Commits 1 Branch 0 Tags
49f7f98cb12c59d10b51c84bb06b98e4168a1915
Commit Graph

65 Commits

Author SHA1 Message Date
Paul Bone
49f7f98cb1 Bug 1703443 - pt 4. Move the CC runner into CCGCScheduler r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118339
 2021-07-09 07:14:11 +00:00
Paul Bone
c89eb3ed69 Bug 1703443 - pt 3. Move GC scheduling code into CCGCScheduler r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118338
 2021-07-09 07:14:11 +00:00
Brindusan Cristian
f1320193b7 Backed out 13 changesets (bug 1703443) for causing GTest failures. 
CLOSED TREE

Backed out changeset 5b2b19d5a0a2 (bug 1703443)
Backed out changeset 589311f587ce (bug 1703443)
Backed out changeset e8c6a26493b4 (bug 1703443)
Backed out changeset c602e39f64fd (bug 1703443)
Backed out changeset 8e6c4e4c5429 (bug 1703443)
Backed out changeset f55e0c5e710f (bug 1703443)
Backed out changeset 251a9a597c91 (bug 1703443)
Backed out changeset 341dd4d5b370 (bug 1703443)
Backed out changeset 11ccf870e643 (bug 1703443)
Backed out changeset 39bd5b2ec9e0 (bug 1703443)
Backed out changeset 5a900829cbd1 (bug 1703443)
Backed out changeset 7e2c90da4fbb (bug 1703443)
Backed out changeset 742f1dc1612f (bug 1703443)
 2021-06-25 10:22:03 +03:00
Paul Bone
ecc970cc03 Bug 1703443 - pt 12. Move more CCGCScheduler implementation into the .cpp file r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118698
 2021-06-25 02:47:19 +00:00
Paul Bone
268950b8f5 Bug 1703443 - pt 11. Call KillAllTimersAndRunners from Shutdown() r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118697
 2021-06-25 02:47:19 +00:00
Paul Bone
97af08f07d Bug 1703443 - pt 11. Move the shrinking GC fields and logic into CCGCScheduler r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118696
 2021-06-25 02:47:19 +00:00
Paul Bone
4a09b106fb Bug 1703443 - pt 10. Make mMajorGCReason private r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118695
 2021-06-25 02:47:18 +00:00
Paul Bone
d0382920c6 Bug 1703443 - pt 8. Factor out some common code r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118343
 2021-06-25 02:47:17 +00:00
Paul Bone
810bd75ac6 Bug 1703443 - pt 7. Make GC/CC runners private to CCGCScheduler and move more code r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118342
 2021-06-25 02:47:17 +00:00
Paul Bone
50c5a8dba3 Bug 1703443 - pt 6. Move RunNextCollectorTimer() into CCGCScheduler r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118341
 2021-06-25 02:47:17 +00:00
Paul Bone
e6610777ec Bug 1703443 - pt 5. Move KillTimers code into CCGCScheduler r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118340
 2021-06-25 02:47:16 +00:00
Paul Bone
ae48f61449 Bug 1703443 - pt 4. Move the CC runner into CCGCScheduler r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118339
 2021-06-25 02:47:16 +00:00
Paul Bone
67d3b26dce Bug 1703443 - pt 3. Move GC scheduling code into CCGCScheduler r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D118338
 2021-06-25 02:47:15 +00:00
Steve Fink
d679aa98f2 Bug 1711135 - Make GC slice reasons better reflect why they were triggered. r=smaug,jonco 
Differential Revision: https://phabricator.services.mozilla.com/D115100
 2021-06-02 14:07:18 +00:00
Steve Fink
c386cf54d0 Bug 1712614 - Allow passing a GC reason through pokeGC and runNextCollectorSlice for testing, to allow removing a special case in the code r=pbone,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D115833
 2021-05-26 21:01:50 +00:00
Steve Fink
1a4ec42768 Bug 1711128 - Eliminate (rare) spurious GCs if we start and finish a new GC while waiting r=pbone,smaug 
for a response from the parent. Before this patch, when the response arrived
from the parent we would unconditionally create a GCRunner and use the GCReason...

...remembered from when we made the request to the parent.

Differential Revision: https://phabricator.services.mozilla.com/D115098
 2021-05-19 23:26:17 +00:00
Steve Fink
8db152a429 Bug 1711128 - Revert to pre-1692308 GCReason handling r=pbone,smaug 
Bug 1692308 made some changes to how GCReasons are reported.

Previously, the reasons reported for slices depended on how the GC was
triggered: internally triggered GCs would have the internal reason for their
first slice and INTER_SLICE_GC for every later slice. PokeGC-triggered GCs
would use the PokeGC reason for *all* slices. (Or if RunNextCollectorTimer was
called before the GC began, its reason would get swapped in for the PokeGC
one.)

After bug 1692308, INTER_SLICE_GC was used for all non-initial slices. This
change wasn't entirely intentional (part of it was).

This patch reverts to the previous behavior, and in so doing adjusts the use of
sScheduler.mMajorGCReason (it maintains the reason that we want to use for
later slices, rather than clearing it when we get the go-ahead from the
parent.)

Note that this handling of GCReasons is intended to be temporary. I want to fix
it properly in a later bug.

Differential Revision: https://phabricator.services.mozilla.com/D115096
 2021-05-19 23:26:17 +00:00
Steve Fink
f67d79c1e7 Bug 1711128 - Rename GCRunnerActions: <MajorGC,MajorGCReady> -> <WaitToMajorGC, StartMajorGC> r=pbone,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D115095
 2021-05-19 23:26:17 +00:00
Iulian Moraru
8edfa41b66 Backed out 4 changesets (bug 1711128) for causing bc failures on browser_gc_schedule.js. CLOSED TREE 
Backed out changeset efb23924bb9c (bug 1711128)
Backed out changeset a686a2053da4 (bug 1711128)
Backed out changeset 64242f7debd4 (bug 1711128)
Backed out changeset f555b85f8338 (bug 1711128)
 2021-05-18 21:23:55 +03:00
Steve Fink
708c706158 Bug 1711128 - Eliminate (rare) spurious GCs if we start and finish a new GC while waiting r=pbone,smaug 
for a response from the parent. Before this patch, when the response arrived
from the parent we would unconditionally create a GCRunner and use the GCReason...

...remembered from when we made the request to the parent.

Differential Revision: https://phabricator.services.mozilla.com/D115098
 2021-05-18 16:43:39 +00:00
Steve Fink
1ee36361f2 Bug 1711128 - Revert to pre-1692308 GCReason handling r=pbone,smaug 
Bug 1692308 made some changes to how GCReasons are reported.

Previously, the reasons reported for slices depended on how the GC was
triggered: internally triggered GCs would have the internal reason for their
first slice and INTER_SLICE_GC for every later slice. PokeGC-triggered GCs
would use the PokeGC reason for *all* slices. (Or if RunNextCollectorTimer was
called before the GC began, its reason would get swapped in for the PokeGC
one.)

After bug 1692308, INTER_SLICE_GC was used for all non-initial slices. This
change wasn't entirely intentional (part of it was).

This patch reverts to the previous behavior, and in so doing adjusts the use of
sScheduler.mMajorGCReason (it maintains the reason that we want to use for
later slices, rather than clearing it when we get the go-ahead from the
parent.)

Note that this handling of GCReasons is intended to be temporary. I want to fix
it properly in a later bug.

Differential Revision: https://phabricator.services.mozilla.com/D115096
 2021-05-18 16:43:38 +00:00
Steve Fink
1e626b762d Bug 1711128 - Rename GCRunnerActions: <MajorGC,MajorGCReady> -> <WaitToMajorGC, StartMajorGC> r=pbone,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D115095
 2021-05-18 16:43:38 +00:00
Paul Bone
877289c1e8 Bug 1629064 - pt 2. nsJSEnvironment will ask the parent if it can GC r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D100858
 2021-05-12 06:46:08 +00:00
Steve Fink
ec900623ef Bug 1692308 - Merge sGCTimer + sInterSliceGCRunner -> sGCRunner 
Differential Revision: https://phabricator.services.mozilla.com/D104881
 2021-04-29 23:12:04 +00:00
Steve Fink
82b70204e5 Bug 1703374 - Provide SliceBudget users with more control of when and how often time checks happen r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D111008
 2021-04-28 16:37:32 +00:00
Cosmin Sabou
ebeb705008 Backed out changeset a89d4817a3cf (bug 1703374) for causing bustages and SliceBudget related crashes. CLOSED TREE 2021-04-27 02:09:01 +03:00
Steve Fink
97955612f0 Bug 1703374 - Provide SliceBudget users with more control of when and how often time checks happen r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D111008
 2021-04-26 22:38:31 +00:00
Ryan VanderMeulen
ca9f14f8e0 Backed out changeset e1fa9dc7464b (bug 1692308) for causing bug 1700313. 2021-03-30 11:35:49 -04:00
Steve Fink
f7de6ff25f Bug 1692308 - Merge sGCTimer + sInterSliceGCRunner -> sGCRunner r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D104881
 2021-03-18 23:27:40 +00:00
Bogdan Tara
eb6d18e183 Backed out changeset 7480579b4348 (bug 1692308) for abouthomecache mochitest failures CLOSED TREE 2021-03-12 23:28:57 +02:00
Steve Fink
e8d1ae6549 Bug 1692308 - Merge sGCTimer + sInterSliceGCRunner -> sGCRunner r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D104881
 2021-03-12 18:32:07 +00:00
Sylvestre Ledru
1378c145af Bug 1519636 - Reformat recent changes to the Google coding style r=andi 
Updated with Debian clang-format version 11.0.1-1

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D100934
 2021-01-06 17:17:23 +00:00
Steve Fink
3d29e344fb Bug 1678416 - gtest for CCGCScheduler r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D95954
 2020-12-16 00:11:06 +00:00
Steve Fink
8fb7c5c091 Bug 1678416 - Create CCGCScheduler static methods to allow providing values on-demand to the scheduler, as well as provide a way to mock up the host for testing (see next patch) r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D95952
 2020-12-16 00:12:15 +00:00
Steve Fink
15b2a0f302 Bug 1662254 - Add a new Canceled state to stop overusing Inactive and thereby allow asserting that the state machine has been initialized r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D95951
 2020-12-11 19:04:58 +00:00
Steve Fink
1cffc37932 Bug 1662254 - Move bodies of large inline CCGCScheduler methods after the class declaration r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D94791
 2020-12-11 19:04:27 +00:00
Steve Fink
167f0f3d82 Bug 1662254 - Use a state descriptor table to control when to check for CC aborts and ForgetSkippable runs r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D90902
 2020-12-11 19:04:18 +00:00
Steve Fink
3659b408ce Bug 1678416 - Remove a couple of calls to TimeStamp::Now() r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D90900
 2020-12-04 16:03:13 +00:00
Steve Fink
ef22fe1176 Bug 1678416 - Merge ICCRunner and CCRunner into a single CCRunner r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D90633
 2020-12-04 16:03:07 +00:00
Steve Fink
d057014498 Bug 1678416 - Move more state to CCGCScheduler r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D97692
 2020-12-04 16:02:59 +00:00
Steve Fink
52f864b9c8 Bug 1678416 - Implement IdleTaskRunner::SetBudget() and add some comments. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D97670
 2020-12-04 16:02:52 +00:00
Razvan Maries
528c4accb5 Backed out 5 changesets (bug 1678416) for build bustages on CCGCScheduler.h. CLOSED TREE 
Backed out changeset cc5f7ecb3922 (bug 1678416)
Backed out changeset 61d9f960b80e (bug 1678416)
Backed out changeset 882f7ebe33fe (bug 1678416)
Backed out changeset e845a32a60bd (bug 1678416)
Backed out changeset 85f35f5749a0 (bug 1678416)
 2020-12-04 04:55:39 +02:00
Steve Fink
4d5026056c Bug 1678416 - Remove a couple of calls to TimeStamp::Now() r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D90900
 2020-12-04 02:40:22 +00:00
Steve Fink
b5062b7ac5 Bug 1678416 - Merge ICCRunner and CCRunner into a single CCRunner r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D90633
 2020-12-04 02:40:14 +00:00
Steve Fink
5166eb7937 Bug 1678416 - Move more state to CCGCScheduler r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D97692
 2020-12-04 02:40:13 +00:00
Simon Giesecke
46908cfb51 Bug 1660470 - Add missing include directives/forward declarations. r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D87865
 2020-11-23 16:21:38 +00:00
Brindusan Cristian
4b189b50e8 Backed out changeset 16291a47acda (bug 1662254) for causing Bug 1677764. a=backout DONTBUILD 2020-11-19 21:43:10 +02:00
Steve Fink
0e7dbfc3b7 Bug 1662254 - Merge ICCRunner and CCRunner into a single CCRunner r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D90633
 2020-11-13 19:38:02 +00:00
Bogdan Tara
a902379665 Backed out 10 changesets (bug 1662254) for lint failure on generate_static_pref_list.py CLOSED TREE 
Backed out changeset 972e63387191 (bug 1662254)
Backed out changeset 3a9d6f0aa380 (bug 1662254)
Backed out changeset 4b3ffe7fe1af (bug 1662254)
Backed out changeset 4834b1025611 (bug 1662254)
Backed out changeset ec1f7afe8a2d (bug 1662254)
Backed out changeset c7a6b927b1de (bug 1662254)
Backed out changeset 2427d85b2605 (bug 1662254)
Backed out changeset 979bf4ac97bb (bug 1662254)
Backed out changeset 3e443333c636 (bug 1662254)
Backed out changeset a5261578ebfc (bug 1662254)
 2020-11-12 23:59:07 +02:00
Steve Fink
f02cbd8fb0 Bug 1662254 - Add a new Canceled state to stop overusing Inactive and thereby allow asserting that the state machine has been initialized r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D95951
 2020-11-12 19:06:48 +00:00