corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
887,562 Commits 1 Branch 0 Tags
49993c77c26840e5d00cf5e97ed1b83a798231a5
Commit Graph

79 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
ebe0ec0cbc Bug 1388910 - Remove -moz-user-modify property. r=dshin 
We successfully unshipped it in bug 1920118.

Differential Revision: https://phabricator.services.mozilla.com/D229530
 2024-11-19 19:35:35 +00:00
Emily McMinn
803813abef Bug 1903708 - Enable about:messagepreview to preview private browsing messages r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D220289
 2024-10-30 22:10:37 +00:00
Punam Dahiya
8d7c4d95e6 Bug 1927878 - Make Attribution parameters in devtools editable r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D227263
 2024-10-29 23:26:31 +00:00
Rebecca King
d7e1907648 Bug 1916815 - Replace --in-content-accent-color variable with the --color-accent-primary token r=desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D224509
 2024-10-21 14:50:46 +00:00
Hanna Jones
99fc51fda2 Bug 1921088 - Upgrade Stylelint and related libraries to the latest version r=Standard8,devtools-reviewers,omc-reviewers,home-newtab-reviewers,nchevobbe,thecount,desktop-theme-reviewers,dao,aminomancer 
In addition to upgrding our Stylelint packages, this patch also introduces the @stylistic/stylelint-plugin to preserve a number of rules that were completely removed in v16. It also migrates the code for the custom plugin introduced in bug 1838298 to ES Modules.

Differential Revision: https://phabricator.services.mozilla.com/D224250
 2024-10-15 19:39:46 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett 
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
 2024-10-15 16:15:09 +00:00
jabram
32769d20ee Bug 1865371 - Replace --in-content-box-background with --background-color-box r=cmkm,desktop-theme-reviewers,credential-management-reviewers,omc-reviewers,aminomancer,dao,issammani 
Differential Revision: https://phabricator.services.mozilla.com/D222674
 2024-10-07 20:15:01 +00:00
Shane Hughes
e919464011 Bug 1922147 - Use only textareas for ASRouterAdmin targeting editors. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D224270
 2024-10-03 17:16:22 +00:00
Jason Prickett
2817fb56a2 Bug 1901617 - Create onboarding checklist r=mviar,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D221538
 2024-09-26 17:54:01 +00:00
kpatenio
f4e025a957 Bug 1916016 - update opt-in card for migration to Firefox sidebar r=fluent-reviewers,omc-reviewers,shopping-reviewers,fchasen,pdahiya 
- Updated `AboutWelcomeChild.sys.mjs` to a new opt-in card `FS_OPT_IN_SIDEBAR_VARIANT` that is rendered only if `browser.shopping.experience2023.integratedSidebar`
- Updated styling for the integrated RC in `aboutwelcome.css`
- Added non-exposed strings to `shopping.ftl`
- Updated tests to work for both integrated and non-integrated versions

Differential Revision: https://phabricator.services.mozilla.com/D221396
 2024-09-18 20:51:03 +00:00
Sandor Molnar
446bc20f4d Backed out changeset cf3a30d74dec (bug 1916016) for causing xpc failures @ test_sorted_alphabetically.js CLOSED TREE 2024-09-19 01:08:05 +03:00
kpatenio
9e138be518 Bug 1916016 - update opt-in card for migration to Firefox sidebar r=fluent-reviewers,omc-reviewers,shopping-reviewers,fchasen,pdahiya 
- Updated `AboutWelcomeChild.sys.mjs` to a new opt-in card `FS_OPT_IN_SIDEBAR_VARIANT` that is rendered only if `browser.shopping.experience2023.integratedSidebar`
- Updated styling for the integrated RC in `aboutwelcome.css`
- Added non-exposed strings to `shopping.ftl`
- Updated tests to work for both integrated and non-integrated versions

Differential Revision: https://phabricator.services.mozilla.com/D221396
 2024-09-18 20:51:03 +00:00
Mark Banner
aabcf18c26 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221443
 2024-09-12 21:08:44 +00:00
Sandor Molnar
b59809ee6a Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE 
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
 2024-09-12 20:45:28 +03:00
Mark Banner
e3981e1099 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221443
 2024-09-12 16:41:58 +00:00
hanna alemu
698a6834b4 Bug 1901261 - Create a remotely configurable bookmarks bar button messaging surface r=mviar,desktop-theme-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215252
 2024-07-31 15:09:21 +00:00
Tamas Szentpeteri
03b8b4ec2d Backed out changeset 8e5aa4b063cc (bug 1901261) for causing py3 failures on make-schemas.py. CLOSED TREE 2024-07-31 17:13:20 +03:00
hanna alemu
f04c2799bc Bug 1901261 - Create a remotely configurable bookmarks bar button messaging surface r=mviar,desktop-theme-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215252
 2024-07-31 13:21:47 +00:00
Shane Hughes
080905839f Bug 1905119 - Fix feature callout RTL display. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D216597
 2024-07-16 02:11:32 +00:00
negin
33463aa315 Bug 1903841 - Remove ghost shadow on feature callout r=omc-reviewers,aminomancer,mviar 
Removes additional 'ghost' shadow around the feature callout container when the feature callout repositions.

Before:
{F7346454}

After:
{F7346458}

Differential Revision: https://phabricator.services.mozilla.com/D215117
 2024-06-28 14:36:21 +00:00
Shane Hughes
8ce2ea1d0f Bug 1903697 - Slightly improve ASRouter Admin styles. r=emcminn,omc-reviewers 
- Give all bordered tables 100% width.
- Show which view is active in the sidebar by highlighting the active
  tab in blue. Adjust the sidebar styles to match about:preferences.
- Increase the space between filter columns.

Differential Revision: https://phabricator.services.mozilla.com/D214353
 2024-06-24 19:52:53 +00:00
Shane Hughes
259507acf6 Bug 1861248 - Overhaul ASRouter admin and remove its dependency on newtab. r=omc-reviewers,emcminn 
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.

Differential Revision: https://phabricator.services.mozilla.com/D213865
 2024-06-19 19:45:03 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount 
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
 2024-06-19 19:45:01 +00:00
Shane Hughes
47a7dce369 Bug 1900511 - Fix RC survey background, shadow, and transitions. r=omc-reviewers,pdahiya,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D212499
 2024-06-18 16:58:32 +00:00
negin
ea70e6fdc9 Bug 1900984 - Fix Ghost shadow on feature callout arrow when flip=slide makes the arrow disappear r=omc-reviewers,mviar 
Before:
{F7308121}

After:
{F7308122}

Notice the lack of the arrow's shadow on mac OS.

Differential Revision: https://phabricator.services.mozilla.com/D213675
 2024-06-18 15:06:03 +00:00
Emilio Cobos Álvarez
76dfae476f Bug 1902896 - Use system-ui font-family when appropriate. r=desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,dao,aminomancer,thecount 
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.

Differential Revision: https://phabricator.services.mozilla.com/D213880
 2024-06-17 14:53:04 +00:00
Shane Hughes
64ab25b51e Bug 1898346 - Fix feature callout incompatibility with transparent theme variables. r=negin,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D211275
 2024-05-28 17:59:47 +00:00
Sarah Chung
9a286a1dc8 Bug 1877512 - change feature-callout dismiss-button background color to transparent r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D209302
 2024-05-03 15:48:26 +00:00
Shane Hughes
ca7244fbbc Bug 1892402 - Make newtab feature callouts handle old themes more gracefully. r=omc-reviewers,negin 
The newtab page is styled according to a `lwt-newtab-brighttext`
attribute, which until now is only present in the newtab page, and not
exposed to the chrome. This is a problem for elements like feature
callouts, which we want to fit in with the newtab content, even though
they exist in the chrome. That's okay in many cases, because the
callouts also use theme properties, and there's usually a concordance
between `lwt-newtab-brighttext` and the content color scheme. But in a
few older (but very popular) themes, there are missing theme properties,
and it's possible for the newtab page to be very dark even though
prefers-color-scheme is not dark.

This patch resolves the issue by exposing `lwt-newtab-brighttext` to the
chrome, and using that attribute to theme newtab callouts.

Differential Revision: https://phabricator.services.mozilla.com/D208256
 2024-04-24 20:54:02 +00:00
Emily McMinn
17efb5e7e2 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D205344
 2024-03-28 16:26:14 +00:00
Cristina Horotan
55e65e2992 Backed out changeset 4577a311fab7 (bug 1886856) for causing newtab failures at asrouter CLOSED TREE 2024-03-27 23:21:01 +02:00
Emily McMinn
ecc39fdb91 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D205344
 2024-03-27 20:00:04 +00:00
Norisz Fay
f3d83af181 Backed out changeset 66d93ead16c4 (bug 1886856) for causing node newtab failure in bundles CLOSED TREE 2024-03-27 21:08:57 +02:00
Emily McMinn
6817fbac59 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D205344
 2024-03-27 17:19:10 +00:00
Jason Prickett
bb433baf3f Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D201902
 2024-03-25 23:05:05 +00:00
Emily McMinn
e2a3a80e3e Bug 1887066 - Reformat schema files in ASRouter r=barret,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D205470
 2024-03-25 15:07:52 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201867
 2024-03-21 22:05:28 +00:00
Mark Banner
1ad86cf71a Bug 1881816 - Rename ActorConstants.sys.mjs to ActorConstants.mjs. r=amy,omc-reviewers,aminomancer 
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203401
 2024-03-19 17:01:38 +00:00
Mark Banner
fb8a38fb26 Bug 1881816 - Rename Actions.sys.mjs to Actions.mjs. r=amy,omc-reviewers,aminomancer 
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203400
 2024-03-19 17:01:37 +00:00
Natalia Csoregi
4bf66df843 Backed out changeset 4707e617d389 (bug 1876173) for causing newtab failures on aboutwelcome. CLOSED TREE 2024-03-14 00:38:01 +02:00
Jason Prickett
faeefc390a Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D201902
 2024-03-13 21:28:06 +00:00
Natalia Csoregi
a6b8803582 Backed out changeset d488b0a57d95 (bug 1876173) for causing fxms failures. CLOSED TREE 2024-03-13 21:17:52 +02:00
Jason Prickett
9f76e777a7 Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D201902
 2024-03-13 18:23:44 +00:00
Punam Dahiya
bda9f1263a Bug 1877210 - Remove unused asrouter components r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D204122
 2024-03-08 23:06:14 +00:00
Dave Townsend
35c104ff31 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-03 09:09:08 +00:00
Punam Dahiya
d3035fa703 Bug 1879638 - Update Old references to asrouter and aboutwelcome files r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D203330
 2024-03-02 02:36:24 +00:00
negin
601a737f68 Bug 1877557 - Extra configurations for LinkParagraph component for about:welcome r=omc-reviewers,emcminn,pdahiya 
Adds styling for legal copy and updates above_button_config so it renders after tiles/MultiSelect but before action buttons.

Differential Revision: https://phabricator.services.mozilla.com/D200078
 2024-03-01 21:03:23 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE 
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
 2024-03-01 18:25:05 +02:00
Dave Townsend
20b5d8c60f Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-01 15:20:17 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE 
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
 2024-03-01 12:58:03 +02:00