Myk Melez
5ecc2c1225
Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
Jan de Mooij
b24421fec1
Bug 1514195 - Remove Cu.permitCPOWsInScope calls in Task.jsm and Promise-backend.js. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D14541
2018-12-14 16:18:51 +00:00
Jan de Mooij
128f1bd7fe
Bug 1512417 - Pass |this| as second argument to Cu.import calls in Promise-backend.js to fix an issue with same-compartment realms. r=kmag
...
With same-compartment-realms, the Cu.import native is a cross-realm function so
we switch to its realm and ended up defining things on the wrong global.
Differential Revision: https://phabricator.services.mozilla.com/D13905
2018-12-06 21:59:09 +00:00
Mark Banner
462116b7f9
Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
...
Automatic changes by ESLint, except for manual corrections for .xml files.
Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Florian Quèze
753d731eec
Bug 1433175 - enable the use-cc-etc eslint rule, r=Standard8.
2018-02-28 18:51:35 +01:00
Mark Banner
4fd95a27c9
Bug 1230369 - Manually fix some remaining instances of Ci/Cc/Cu definitions and switch Components.* to using the shorthand in some places. r=florian
...
MozReview-Commit-ID: 9SmoR9RlvZE
2018-02-07 09:24:15 +00:00
Florian Quèze
c5f15a4700
Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop.
2018-02-01 20:45:22 +01:00
Kris Maglione
5298bb7ac5
Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
...
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
0bb74efdf1
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d
Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
...
Backed out changeset a1eca62826a1 (bug 1431533 )
Backed out changeset 34c999fa006b (bug 1431533 )
Backed out changeset e2674287e57f (bug 1431533 )
2018-01-30 07:17:48 +02:00
Kris Maglione
5e845929cf
Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
...
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
fd67f090b2
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb
Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
...
Backed out changeset 6e56f4c8843e (bug 1431533 )
Backed out changeset 12fc4dee861c (bug 1431533 )
2018-01-30 02:32:43 +02:00
Kris Maglione
3aa3c6fff8
Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
...
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
683a97d172
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Dan Banner
5af4450327
Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
...
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Florian Queze
d3c36892fa
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0
Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout
2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Mark Banner
a54b21ce85
Bug 1335813 - Enable eslint no-undef for toolkit, apart from components/ and content/, and fix various issues. r=jaws
...
MozReview-Commit-ID: LpXm7TbwvDb
2017-01-31 13:17:03 +00:00
Jared Wein
0ec522d5b6
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
...
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jared Wein
7b6f69795f
Bug 1329012 - Enable the no-useless-call rule for eslint and fix the nine errors that it caught. r=mossop
...
MozReview-Commit-ID: 57vvfJlyvfW
2017-01-05 12:56:53 -05:00
Jared Wein
242ab87626
Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
...
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
e7b1b3284f
Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
...
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Dave Townsend
12596ced47
Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
...
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Jared Wein
5edec1c0d9
Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
...
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
Jared Wein
0c024fa9ca
Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
...
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Mike Conley
21b269ffdc
Bug 1233497 - Temporarily allow unsafe CPOWs in Promise-backend.js and Task.jsm. r=billm
2016-01-18 12:44:37 -05:00
J. Ryan Stinnett
aa386cd4c8
Bug 1237798 - Use correct Components object inside CommonJS. r=Yoric
2016-01-07 17:18:05 -06:00
Dave Townsend
7b18d60eed
Bug 1229519: Fix toolkit/modules to pass eslint checks. r=mak
2015-12-03 09:58:56 -08:00
Shu-yu Guo
37989840cd
Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff)
2015-09-15 11:19:45 -07:00
Tom Tromey
5acaf7f263
Bug 1148593 - Create async stack in callback objects. r=bz, r=fitzgen
2015-07-24 07:01:00 -04:00
Ryan VanderMeulen
99eb81305b
Backed out changesets fa9fe193778f and 3eaf867930dd (bug 1148593) for test_async_setTimeout_stack.html and test_async_setTimeout_stack_across_globals.html failures.
2015-07-17 12:37:24 -04:00
Tom Tromey
d5e041af26
Bug 1148593 - Create async stack in callback objects. r=bz, r=fitzgen
2015-07-17 07:48:00 -04:00
Jan Odvarko
d5e8f74b40
Bug 1181506 - Define Cc and Ci. r=Yoric
2015-07-09 11:30:16 +02:00
Eddy Bruël
b7c5c3b9cd
Bug 1164564 - Refactor Promise-backend.js so it can be required as a CommonJS module on the main thread;r=paolo
2015-06-11 21:24:15 +02:00
Ryan VanderMeulen
40a23d2338
Backed out changeset 0ca665e88ae5 (bug 1164564) for Linux debug test_promises_actor_onpromisesettled.js failures.
2015-06-10 12:07:07 -04:00
Eddy Bruël
6372af70e0
Bug 1164564 - Refactor Promise-backend.js so it can be loaded as a CommonJS module on the main thread;r=jlong
2015-06-10 14:25:07 +02:00
Eddy Bruël
6319593dde
Bug 1164564 - Refactor Promise-backend.js so it can be required as a CommonJS module;r=jlong
2015-05-26 17:05:07 +02:00
Tooru Fujisawa
ed4a914be2
Bug 1069416 - Part 8: Remove JS_HAS_SYMBOLS from Promise-backend.js. r=paolo
2015-01-28 13:06:38 +09:00
Paolo Amadini
38869372d1
Bug 1094208 - Part 3 of 3 - Use DOM Promise scheduling in Promise.jsm. r=Yoric
2014-11-13 11:19:08 +00:00
J. Ryan Stinnett
cf91b4416c
Bug 1093363 - Add stack to unhandled promise rejection console message. r=Yoric
2014-11-03 15:55:00 +01:00
Jason Orendorff
bcc9db0b2c
Bug 918828, part 1 - Change iteration code to call iterable[Symbol.iterator]() rather than iterable["@@iterator"](). r=Waldo with earlier review work by nbp.
2014-07-01 21:01:21 -05:00
Tomasz Kołodziejski
28bdf9b080
Bug 1033406 - Promise.jsm promise should still work after Object.freeze. r=paolo
...
Fix by moving internal properties into N_INTERNALS.
2014-08-20 10:19:00 -04:00
Paolo Amadini
1959354d90
Bug 1030714 - Clarify that unhandled rejections indicate an issue with the code. r=Yoric
2014-06-26 13:40:12 +01:00
Jim Blandy
39dc0c6097
Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
...
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):
- Never set the buffer's mode.
Years ago, Emacs did not have a good JavaScript mode, so it made sense
to use Java or C++ mode in .js files. However, Emacs has had js-mode for
years now; it's perfectly serviceable, and is available and enabled by
default in all major Emacs packagings.
Selecting a mode in the -*- file variable line -*- is almost always the
wrong thing to do anyway. It overrides Emacs's default choice, which is
(now) reasonable; and even worse, it overrides settings the user might
have made in their '.emacs' file for that file extension. It's only
useful when there's something specific about that particular file that
makes a particular mode appropriate.
- Correctly propagate settings that establish the correct indentation
level for this file: c-basic-offset and js2-basic-offset should be
js-indent-level. Whatever value they're given should be preserved;
different parts of our tree use different indentation styles.
- We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
Remove tab-width: settings, at least in files that don't contain tab
characters.
- Remove js2-mode settings that belong in the user's .emacs file, like
js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
David Rajchenbach-Teller
22462ed02b
Bug 995198 - Promise Debugging API. r=paolo
2014-04-15 12:51:19 -04:00