The "Keyed Histograms" category didn't alway have the "has-data" class although there were some data to display. "option" was compared to a string but it's a dom element, so its value should be compared instead.
MozReview-Commit-ID: 3eC0UPpJaNJ
The "Show raw stack data" button in the Browser Hangs section produced nothing but removing the "Browser Hangs" section from the about:telemetry navigation menu. I looked at the way the Late Writes section works and patched the Chrome Hangs render calls accordingly.
MozReview-Commit-ID: Gq681oVrg90
The search feature in the Late Writes section does not work, and a message claiming "Sorry there's no data available in "Late Writes" hindered the view of the data. I added the late-writes-section to the search blacklist.
MozReview-Commit-ID: 4Fqfh9zhzJZ
The search feature in the Browser Hangs section does not work, and a message claiming "Sorry there's no data available in "Browser Hangs" hindered the view of the data. I added the chrome-hangs-section to the search blacklist.
MozReview-Commit-ID: JJ4eb1fSOfg
In RTL locales, the about:telemetry page opened a JSON viewer window because hgram.buckets.reverse()
was being called in RTL mode. Since a refactor tracked in bug 1122480, histograms no longer have a 'buckets' field.
Removing the call to hgram.buckets fixed this bug.
Currently if a subsection (for the environment section) is included in the hash
on load the page breaks, because urlStateRestore ends up calling showSubSection
with no element, which then throws. Move the urlStateRestore call after the
update.
Also guard against showSubSection receiving an empty argument.
MozReview-Commit-ID: 2bYrEQlHlqN
Implementation of the search terms in the url fragment was done as concisely as possible(considering the various conditions required, with the underscore when other hash terms are present). To implement search through hashes in URL, the function urlStateRestore() was changed. To make the changes more aesthetic, another function urlSectionRestore() performs the tasks earlier performed by urlStateRestore(), and urlStateRestore() now implements the search parsing and a call to urlSectionRestore().
MozReview-Commit-ID: 9vgjNUpJkQG
We were reusing "all sections" in more than one way, which isn't a globally-
permissable language use. Embedding the substring directly takes care of it
while at the same time embedding it within its context.
MozReview-Commit-ID: CTQhFWEajRo
We were reusing "all sections" in more than one way, which isn't a globally-
permissable language use. Embedding the substring directly takes care of it
while at the same time embedding it within its context.
MozReview-Commit-ID: CTQhFWEajRo
Search would leave text in the input field when switching categories,
show a 'No search results' message on load, and show a 'No search results'
message in sections without search inputs.
Tidy those cases away.
MozReview-Commit-ID: BbkgIjq8fYD
Search would leave text in the input field when switching categories,
show a 'No search results' message on load, and show a 'No search results'
message in sections without search inputs.
Tidy those cases away.
MozReview-Commit-ID: BbkgIjq8fYD
Acceptably-structured pings should render fine in about:telemetry and not
trigger the panic mode of "Just show them the JSON!" that happens when an
exception is thrown.
Two things caught here:
1: Environment section without addon subsection
2: subsection searches
MozReview-Commit-ID: 3Z0hud23XuD
