Commit Graph

2879 Commits

Author SHA1 Message Date
Ed Lee
a535788255 Bug 1548388 - Add focus states, fill telemetry and bug fixes to Activity Stream r=r1cky
Differential Revision: https://phabricator.services.mozilla.com/D29577
2019-05-01 22:55:10 +00:00
Mike Conley
f060772432 Bug 1533955 - Show some UI to indicate that a subframe has crashed. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D29238
2019-05-01 20:05:24 +00:00
Ciure Andrei
c1f0784338 Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2019-04-24 07:30:32 +03:00
Ricky Rosario
ff586fa56a Bug 1537736 - Use HomePage.get()/set() more consistently r=nanj
MozReview-Commit-ID: 5PzW6ONmuKd

Differential Revision: https://phabricator.services.mozilla.com/D28505
2019-04-23 18:30:07 +00:00
Ryan Hunt
7144ca54c8 Bug 1534395 - Rename TabChild to BrowserChild. r=nika
This commit renames TabChild to BrowserChild.

Differential Revision: https://phabricator.services.mozilla.com/D28135
2019-04-09 17:39:01 -05:00
Ryan Hunt
c6e302039f Bug 1534395 - Rename nsITabParent to nsIRemoteTab. r=nika,mconley
nsITabParent is exposed to frontend code and is generally used as a representation of a remote tab. We could just rename the interface to nsIBrowserParent and worry about it later, but I think it's better to rename the interface to nsIRemoteTab so that we can later work on splitting the interface away from the PBrowser protocol.

Note: Some frontend code refers to a TabParentId. This commit renames this to RemoteTabId. We need to figure out the purpose of TabId with fission.

Differential Revision: https://phabricator.services.mozilla.com/D28132
2019-04-09 15:59:37 -05:00
Johann Hofmann
174018fd6a Bug 1536454 - Part 4 - Add event telemetry for permission prompt studies. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D26945
2019-04-18 13:43:29 +00:00
Johann Hofmann
bb62979031 Bug 1536454 - Part 1 - Add userHadInteractedWithDocument and documentDOMContentLoadedTimestamp attributes to nsIContentPermissionPrompt. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D26942
2019-04-18 13:43:05 +00:00
Rob Wu
5ea50ab2dd Bug 1544834 - Replace deprecated generics in test code r=evilpie
- `Array.map` becomes `Array.from`
- Array copying via `Array.slice` becomes `Array.from`.
- `Array.forEach` that did not rely on closures becomes `for`-`of` loops.
- Anything else: `Array.X` becomes `Array.prototype.X`.

Complex cases:

dom/bindings/test/TestInterfaceJS.js and
dom/bindings/test/test_exception_options_from_jsimplemented.html
use `Array.indexOf` to generate an error with a specific error message.
Switched to `Array.prototype.forEach` to generate the same error.

js/src/jit-test/tests/basic/exception-column-number.js
In this test `Array.indexOf()` is used to generate an error. Since the
exact message doesn't matter, I switched to `Array.from()`.

Intentionally not changed:

editor/libeditor/tests/browserscope/lib/richtext/richtext/js/range.js
Did not modify because this is 3rd-party code and the code uses
feature detection as a fall back when Array generics are not used.

testing/talos/talos/tests/dromaeo/lib/mootools.js
Did not modify because mootools adds the `Array.slice` method to the
`Array` object.

Not changed because they check the implementation of Array generics:
js/src/jit-test/tests/basic/arrayNatives.js
js/src/jit-test/tests/basic/bug563243.js
js/src/jit-test/tests/basic/bug618853.js
js/src/jit-test/tests/basic/bug830967.js
js/src/jit-test/tests/jaeger/recompile/bug656753.js
js/src/jit-test/tests/self-hosting/alternate-static-and-instance-array-extras.js
js/src/tests/non262/Array/generics.js
js/src/tests/non262/Array/regress-415540.js
js/src/tests/non262/extensions/regress-355497.js
js/src/tests/non262/extensions/typedarray-set-neutering.js

Depends on D27802

Differential Revision: https://phabricator.services.mozilla.com/D27803
2019-04-17 19:03:19 +00:00
Rob Wu
731bc4cb2e Bug 1544834 - Replace non-test uses of deprecated Array generics r=evilpie,dao
- `Array.forEach` becomes for-of loop or `array.forEach`.
- `Array.slice(a)` or `Array.slice(a, 0)` becomes `Array.from(a)`.
- `Array.map` becomes `Array.from`
- `Array` copy + concatenation becomes Array literal + spread syntax.
- All other `Array.X(a, ...)` become `Array.prototype.X.call` or `Array.from(a).X(...)`

Differential Revision: https://phabricator.services.mozilla.com/D27802
2019-04-17 19:03:17 +00:00
Mike de Boer
4685c831da Bug 1518545 - Remove the superfluous 'engine-current' Search Service observer topic in favour of 'engine-default'. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D27857
2019-04-17 09:45:24 +00:00
Dale Harvey
bc022faecf Bug 1544077 - Remove unused recordSearchURLTelemetry idl definition. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D27725
2019-04-16 15:50:50 +00:00
Nihanth Subramanya
2fa01149f7 Bug 1416163 - Implement EveryWindow.jsm to run arbitrary per-window code. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D26947
2019-04-16 16:17:25 +00:00
Drew Willcoxon
c2c5a74a3a Bug 1541929 - Don't autofill the first result in some cases. r=mak
We need to handle autofilling the first result separately from autofilling results in general (which happens in UrlbarInput.setValueFromResult), so add a new UrlbarInput.autofillFirstResult method. The controller calls it instead of setValueFromResult. I ported the logic from nsAutoCompleteController, as described in the bug.

Other changes are related to the new test for this.

As part of this work, I was interested in learning how awesomebar handles browser_autoFill_typed.js, so I added it to the legacy tests, with a small tweak in the test for awesomebar.

Differential Revision: https://phabricator.services.mozilla.com/D26852
2019-04-15 13:15:30 +00:00
Dão Gottwald
c3265ab5bb Bug 1541910 - Use the chrome/content separator color for the urlbar results popup's top and bottom borders consistently across platforms and remove left and right borders. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D26192
2019-04-11 11:47:18 +00:00
Shane Caraveo
b371837b78 Bug 1532165 use prefs to support extension newtab and homepage on startup. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D25808
2019-04-08 22:36:26 +00:00
Trushita
19b14883c7 Bug 1494948: Removed FX_PREFERENCES_OPENED_VIA probe and origin parameter for openPreferences r=jaws,chutten
Removed FX_PREFERENCES_OPENED_VIA probe as it expired in 63.Origin parameter for openPreferences has also been removed.

Differential Revision: https://phabricator.services.mozilla.com/D26795
2019-04-09 20:40:26 +00:00
Paul Zuehlcke
57df58d518 Bug 1492668 - Store temporary site permissions by base domain to mitigate permission notification spam r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D26704
2019-04-09 12:56:47 +00:00
Cosmin Sabou
a17a660a85 Backed out changeset 1839a68aea95 (bug 1492668) for assertion failures on GMPParent.cpp. CLOSED TREE 2019-04-09 17:11:28 +03:00
Paul Zuehlcke
746afa6194 Bug 1492668 - Store temporary site permissions by base domain to mitigate permission notification spam r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D26704
2019-04-09 12:56:47 +00:00
Andrea Marchesini
9085a39964 Bug 1532948 - Sanitize principal on shutdown should behave like 'Manage cache and Site Data' cleanup, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D23825
2019-04-05 10:35:54 +00:00
phoenixabhishek
a23497b040 Bug 1521919 - SitePermissions.get should check for nsIURI. r=johannh
functions now throw an error if the uri parameter is not an nsIURI.

Differential Revision: https://phabricator.services.mozilla.com/D23672
2019-03-27 05:40:23 +00:00
Johann Hofmann
4ceeeaa755 Bug 1508961 - Show a notification icon after automatically dismissing permission prompts. r=MattN
This adds support for a "post-prompt" that appears dismissed (only the icon showing) when
the browser decides to automatically deny a permission request from a site (either based on
internal heuristics or because the user prefers not to receive permission prompts).

In order to move quickly and not overload the patch I have only implemented the post-prompting
for desktop-notification so far, however, implementing it for other permissions should be
a trivial follow-up.

Differential Revision: https://phabricator.services.mozilla.com/D25415
2019-04-05 10:22:19 +00:00
Ed Lee
c6b22007bf Bug 1541502 - Add Pocket menu, triggering improvements and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D25984
2019-04-04 14:32:55 +00:00
Jan-Erik Rediger
5fec79a3f4 Bug 1529696 - Rename DATASET_RELEASE_CHANNEL_OPTOUT/OPTIN to DATASET_ALL/PRERELEASE_CHANNELS everywhere r=chutten
Depends on D25934

Differential Revision: https://phabricator.services.mozilla.com/D25935
2019-04-03 17:12:11 +00:00
Gijs Kruitbosch
d494028419 Bug 1539757 - fix trying to initialize XBL bindings while the prompt is still hidden, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D25390
2019-04-01 13:37:49 +00:00
Andrea Marchesini
56334d4bf2 Bug 1524200 - Add more debugging message to Sanitizer.jsm, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D25289
2019-04-01 13:46:56 +00:00
Johann Hofmann
bbd5f57a5b Bug 1540088 - Require user interaction for push notification permission prompts in Nightly. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D25418
2019-03-29 18:08:20 +00:00
Ciure Andrei
1ba5b77433 Backed out changeset de24b08ddc37 (bug 1539757) for causing browser_hidden_document_autofill.js, browser_httpauth.js, test_bug_627616.html to permafail CLOSED TREE 2019-03-30 03:13:58 +02:00
Gijs Kruitbosch
8e91bd9302 Bug 1539757 - fix trying to initialize XBL bindings while the prompt is still hidden, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D25390
2019-03-29 23:11:37 +00:00
Erica Wright
1722b64562 Bug 1524883 - Clear storageAccessAPI permissions when history is cleared. r=johannh,Ehsan
When history is cleared, clear the flag that indicates a user has visited the domain.

Differential Revision: https://phabricator.services.mozilla.com/D24404
2019-03-28 18:44:08 +00:00
Mark Banner
d5029e0dae Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850
2019-03-28 09:38:14 +00:00
Luca Greco
6b3a652409 Bug 1538546 - Check AddonManager PERM_CAN_CHANGE_PRIVATEBROWSING_ACCESS permission instead of the incognito manifest property. r=kmag,mixedpuppy
Depends on D24719

Differential Revision: https://phabricator.services.mozilla.com/D24720
2019-03-26 19:04:01 +00:00
Luca Greco
1fbc5265f5 Bug 1538546 - Hide incognito checkbox in addon-installed notification for not_allowed extensions. r=mixedpuppy,kmag
Differential Revision: https://phabricator.services.mozilla.com/D24719
2019-03-26 18:31:57 +00:00
Felipe Gomes
cedb6b741e Bug 1539311 - Fix incorrect parameter in the Windows Taskbar Previews code. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D25013
2019-03-27 10:26:53 +00:00
Andrei Oprea
fb7908fabd Bug 1505535 - Add tab usage probes for pinned tabs r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D24031
2019-03-26 09:12:10 +00:00
Dale Harvey
3e809c2739 Bug 1534219 - Only clear globally blocked permission on navigation. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D23844
2019-03-22 10:57:16 +00:00
akshitha
ad2f595b56 Bug 1511416 -Screen sharing preview pops up in Camera permission prompt . r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D21976
2019-03-18 12:12:29 +00:00
Luca Greco
a5fc6ba66b Bug 1533172 - Show post install notification when enabling sideload extensions. r=mixedpuppy,kmag
Differential Revision: https://phabricator.services.mozilla.com/D22700
2019-03-22 19:19:35 +00:00
Ciure Andrei
7af9823905 Backed out changeset 01cdf8342a49 (bug 1521919) for test_SitePermissions.js perma failures CLOSED TREE 2019-03-22 18:01:27 +02:00
phoenixabhishek
d68fd26f1f Bug 1521919 - SitePermissions.get should check for nsIURI. r=johannh
functions now throw an error if the uri parameter is not an nsIURI.

Differential Revision: https://phabricator.services.mozilla.com/D23672
2019-03-22 10:32:30 +00:00
Tom Tung
9a1040c326 Bug 1529301 - P3 - Use the listInitializedOrigins on Sanitizer.jsm; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D21725
2019-03-22 06:04:50 +00:00
Coroiu Cristina
f4fa8d2cb0 Merge inbound to mozilla-central a=merge 2019-03-21 23:59:53 +02:00
Ian Moody
cac3a5f1e2 Bug 1536653 - browser/ automated ESLint no-throw-literal fixes. r=Gijs
Result of running:
$ mach eslint -funix browser/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24110
2019-03-20 10:17:42 +00:00
Gijs Kruitbosch
a4db9e0510 Bug 1353013 - create preloaded newtab browser from an idle task, only in top window(s), r=dthayer
This limits us to 1 preloaded browser per window, in the top 3 normal windows + top 3 private windows.
If we try to create additional browsers beyond that, we instead move a pre-existing browser across.

Differential Revision: https://phabricator.services.mozilla.com/D21129
2019-03-19 17:29:48 +00:00
Gijs Kruitbosch
866709f525 Bug 1353013 - move new tab preload browser tracking into a separate module, r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D21126
2019-03-19 17:29:14 +00:00
shindli
244d2d9547 Backed out 3 changesets (bug 1353013) for a11y failures in accessible/tests/mochitest/relations/test_tabbrowser.xul CLOSED TREE
Backed out changeset af8bce2330e9 (bug 1353013)
Backed out changeset a3d1302b06c0 (bug 1353013)
Backed out changeset 976afd1adf84 (bug 1353013)
2019-03-18 18:21:16 +02:00
Gijs Kruitbosch
f46c2a4254 Bug 1353013 - create preloaded newtab browser from an idle task, only in top window(s), r=dthayer
This limits us to 1 preloaded browser per window, in the top 3 normal windows + top 3 private windows.
If we try to create additional browsers beyond that, we instead move a pre-existing browser across.

Differential Revision: https://phabricator.services.mozilla.com/D21129
2019-03-12 14:34:39 +00:00
Gijs Kruitbosch
6a19ff891f Bug 1353013 - move new tab preload browser tracking into a separate module, r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D21126
2019-03-12 14:34:04 +00:00
Shane Caraveo
85cfdb3344 Bug 1534714 handle checkbox state when appmenu refreshed across windows r=Gijs
This adds an onRefresh option for app menus so we can update custom controls
in any opened window.  In this case, we need to refresh the checkbox state in the
addon-installed panel.  We test this using the theme install test and verify both
windows do not have the checkbox.

Differential Revision: https://phabricator.services.mozilla.com/D23224
2019-03-14 18:31:07 +00:00