Commit Graph

55 Commits

Author SHA1 Message Date
Kris Maglione
24ba837d39 Bug 1481021: Part 1 - Fix tests that rely on permissive COWs or SpecialPowers side-effects in frame script scopes. r=bz
Right now, a lot of test code relies on side-effects of SpecialPowers being
loaded into frame script globals. In particular:

- It forces permissive COWs from those scopes, which allows frame scripts to
  pass objects from those scopes to unprivileged content that they otherwise
  wouldn't.
- It imports a bunch of helper modules and WebIDL globals which would
  otherwise not be available.

Fortunately, this seems to only impact test code at this point. But there's a
real down-the-road risk of it impacting shipping code, which ends up working
in automation due to the side-effects of SpecialPowers, but failing in real
world use.

MozReview-Commit-ID: G27eSSOHymX
2018-08-07 14:13:06 -07:00
Brindusan Cristian
58f4e50cdc Backed out 2 changesets (bug 1481021) for bc failures on security/sandbox/test/browser_bug1393259.js.
Backed out changeset c53c7b0249ad (bug 1481021)
Backed out changeset 41bedc526dd6 (bug 1481021)
2018-08-08 03:22:16 +03:00
Kris Maglione
a155d43da2 Bug 1481021: Part 1 - Fix tests that rely on permissive COWs or SpecialPowers side-effects in frame script scopes. r=bz
Right now, a lot of test code relies on side-effects of SpecialPowers being
loaded into frame script globals. In particular:

- It forces permissive COWs from those scopes, which allows frame scripts to
  pass objects from those scopes to unprivileged content that they otherwise
  wouldn't.
- It imports a bunch of helper modules and WebIDL globals which would
  otherwise not be available.

Fortunately, this seems to only impact test code at this point. But there's a
real down-the-road risk of it impacting shipping code, which ends up working
in automation due to the side-effects of SpecialPowers, but failing in real
world use.

MozReview-Commit-ID: G27eSSOHymX
2018-08-07 14:13:06 -07:00
Neil Deakin
ddc248eb52 Bug 1446961, remove obsolete calls to showPopup and replace usages of the popup box object with the same methods defined on popups, r=paolo 2018-04-27 11:04:36 -04:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Bill McCloskey
142c9a9dbb Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-07 12:55:24 -08:00
Andreea Pavel
26ac595cba Backed out 9 changesets (bug 1412456) for crashing talos g2 and unexpected network connections in browser-chrome's browser_searchEngine_behaviors.js r=backout a=backout on a CLOSED TREE
Backed out changeset 0c01a98f4fd5 (bug 1412456)
Backed out changeset 27077db47231 (bug 1412456)
Backed out changeset f35ec2a884f8 (bug 1412456)
Backed out changeset 602b30ac3c69 (bug 1412456)
Backed out changeset b1ff1050c589 (bug 1412456)
Backed out changeset f100d953f9eb (bug 1412456)
Backed out changeset d85af60fe259 (bug 1412456)
Backed out changeset 736f38486832 (bug 1412456)
Backed out changeset 13a637602dc2 (bug 1412456)
2017-12-07 12:20:21 +02:00
Bill McCloskey
427710d960 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 21:17:05 -08:00
Dorel Luca
81b4b85d01 Backed out 8 changesets (bug 1412456) for ESlint failure on browser_urlbarKeepStateAcrossTabSwitches.js:13:49 r=backout on a CLOSED TREE
Backed out changeset 0e88de036c55 (bug 1412456)
Backed out changeset 49b93f807db0 (bug 1412456)
Backed out changeset 039e980b7dc6 (bug 1412456)
Backed out changeset c7698410ddbd (bug 1412456)
Backed out changeset e56a1ba26b7c (bug 1412456)
Backed out changeset 0c4506e124ac (bug 1412456)
Backed out changeset a7aec2ce903b (bug 1412456)
Backed out changeset 3e9fb71f1e8e (bug 1412456)
2017-12-07 07:09:33 +02:00
Bill McCloskey
a0f07d3df7 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 20:46:58 -08:00
Fischer Liu
ec0d69bec5 Bug 1382579 - Part 3: Tests, r=Gijs
This commit
- adds 2 utility functions to the uitour's head.js

- adds the browser_UITour4.js

- moves the tests in the browser_showMenu_controlCenter.js into the newly added the browser_showMenu.js

- deletes the browser_showMenu_urlbar.js because it's test has been modified and moved into the browser_showMenu.js

- adds one test case for the page action panel in the browser_showMenu.js

- updates the browser_UITour_availableTargets.js test because we have more targets right now.

MozReview-Commit-ID: CydEAkqAl3V
2017-08-02 13:53:05 +08:00
Florian Quèze
c0468168f5 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Christoph Kerschbaumer
5452a95b49 Bug 1362993 - Rewrite gBrowser.addTab() to use BrowserTestUtils.addTab(). r=florian 2017-05-15 21:49:50 +02:00
Florian Quèze
15feaa278a Bug 1362882 - script-generated patch to switch from Promise.defer() to new Promise() where it's straightforward, rs=Mossop. 2017-05-12 14:55:27 +02:00
Florian Quèze
38c24463e4 Bug 1353542 - Cleanup the script output and fix tests, r=Mossop. 2017-05-12 14:54:05 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Mark Banner
25c75db032 Bug 1342459 - Add a rule to automatically detect ContentTask.spawn and inject the relevant globals. r=mossop
This reduces the amount of places where we need to specify the mozilla/frame-script environment. It does have
the side effect of allowing those globals in the whole file, but that is what specifying the environment would
do, and this is also for mochitest test files only.

MozReview-Commit-ID: 1LLFbn6fFJR
2017-04-05 10:00:25 +01:00
Mark Banner
7d691acb44 Bug 1344027 - Fix most of the remaining ESLint no-undef issues in browser/components. r=jaws
MozReview-Commit-ID: DUnxVITvZgh
2017-03-03 09:29:14 +00:00
Florian Quèze
91f7a2ef3a Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Florian Quèze
45647c4570 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Pushpankar
77a14e357c Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao 2016-07-16 10:20:04 +02:00
Alessio Placitelli
55c05f3181 Bug 1262368 - Fix browser_UITour_heartbeat.js to work on e10s. r=MattN
MozReview-Commit-ID: 6DtCPx9wa1r
2016-04-08 23:50:00 +02:00
Dave Townsend
17d8a23b3f Bug 1257246: Update browser for eslint 2. r=felipe
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: DEskVIjiKDM
2016-04-05 11:33:33 -07:00
Gijs Kruitbosch
8bbf5fc398 Bug 1256625 - enable function parameters to gContentAPI wrappers to fix UITour tests in e10s mode, r=MattN
MozReview-Commit-ID: 6A4X8bmgaun
2016-03-15 11:47:49 +00:00
Matthew Noorenberghe
a706591b71 Bug 1248849 - UITour: showInfoPromise: Add panel event listener before having content call showInfo. r=felipe
MozReview-Commit-ID: Cv5gkmfrTsI
2016-02-22 16:33:42 -08:00
Matthew Noorenberghe
44caa1ca3e Bug 1073247 - UITour: Proxy gContentAPI method calls to the content process via ContentTask and fix tests for e10s. r=felipe
This gets us to 414 / 917 checks passing with e10s compared to non-e10s on my OS X machine.
2016-02-01 14:29:11 -08:00
Matthew Noorenberghe
0e14f13c91 Bug 1200488 - browser_UITour_heartbeat.js: requestLongerTimeout(2) and add logging to see where/if the test is hanging. r=test-only 2015-09-25 15:50:20 -07:00
Matthew Noorenberghe
650e836854 Bug 1206943 - UITour: Remove the event listener in promisePanelElementEvent upon timeout. r=bgrins
The event listener wasn't getting removed in the reject case.
2015-09-21 16:34:27 -07:00
Matthew Noorenberghe
6615b0ceb1 Bug 1196104 - Heartbeat: Support prompts that target private windows. r=bgrins 2015-08-28 15:13:59 -07:00
Ryan VanderMeulen
fdf47e6ff0 Backed out 2 changesets (bug 1196105, bug 1196104) for frequent OSX browser_UITour_heartbeat.js failures.
Backed out changeset e2ac20d24cb2 (bug 1196105)
Backed out changeset 52b8ae99625a (bug 1196104)
2015-08-26 14:02:52 -04:00
Matthew Noorenberghe
0103b33772 Bug 1196104 - Heartbeat: Support prompts that target private windows. r=bgrins 2015-08-25 15:33:26 -07:00
Matthew Noorenberghe
e54063c3ac Bug 1185579 - UITour: Make the "accountStatus" target use the FxA avatar when logged in. r=markh 2015-08-04 22:55:21 -07:00
Wes Kocher
8c99676459 Backed out changeset 1376c328fbb3 (bug 1185579) for browser_fxa.js test failures 2015-08-05 13:50:59 -07:00
Matthew Noorenberghe
2288539687 Bug 1185579 - UITour: Make the "accountStatus" target use the FxA avatar when logged in. r=markh 2015-08-04 22:55:21 -07:00
Carsten "Tomcat" Book
1513fb8c45 Backed out changeset 7f106466e9ad (bug 1185579) for memory leaks on a CLOSED TREE 2015-08-05 16:57:20 +02:00
Matthew Noorenberghe
544a2a76cc Bug 1185579 - UITour: Make the "accountStatus" target use the FxA avatar when logged in. r=markh 2015-08-04 22:55:21 -07:00
Paolo Amadini
3e38200c8c Bug 1177175 - Add a UITour target inside the TP panel. r=MattN 2015-07-20 13:44:32 +01:00
Michael Layzell
a91e81b778 Bug 1165263 - Part 6: Update browser tests to support new permissions semantics, r=ehsan 2015-07-16 14:50:01 -04:00
Wes Kocher
c06754ff70 Backed out 24 changesets (bug 1173523, bug 1172080, bug 817007, bug 1165263) for android reftest bustage CLOSED TREE
Backed out changeset 84fe04b2e7d1 (bug 1172080)
Backed out changeset 0ff004760a1f (bug 1172080)
Backed out changeset af147585ad55 (bug 1165263)
Backed out changeset c3af8ebb6db0 (bug 1165263)
Backed out changeset cd3f33a888fe (bug 1165263)
Backed out changeset e5db39044a1e (bug 1165263)
Backed out changeset c01c9ed77061 (bug 1165263)
Backed out changeset fb723aaa4267 (bug 1165263)
Backed out changeset f754e52e74dc (bug 1165263)
Backed out changeset c6bda3a0afd6 (bug 817007)
Backed out changeset bfa100253349 (bug 817007)
Backed out changeset b787b3f9aadc (bug 1173523)
Backed out changeset 4a0676b73f77 (bug 1173523)
Backed out changeset 82034a4560c5 (bug 1173523)
Backed out changeset 4bdb91114c7a (bug 1173523)
Backed out changeset 72406261eccc (bug 1173523)
Backed out changeset 541b6faf7196 (bug 1173523)
Backed out changeset 1caac4569616 (bug 1173523)
Backed out changeset 0d4f9f9e1b4e (bug 1173523)
Backed out changeset 2d5661eb966c (bug 1173523)
Backed out changeset 89833c0bb0cd (bug 1173523)
Backed out changeset ea64d70eacfe (bug 1173523)
Backed out changeset a8e4f1c0c445 (bug 1173523)
Backed out changeset cf498d466b85 (bug 1173523)
2015-07-14 14:00:32 -07:00
Michael Layzell
05997f40bf Bug 1165263 - Part 6: Update browser tests to support new permissions semantics, r=ehsan 2015-07-14 15:06:39 -04:00
Matthew Noorenberghe
f3a89c5848 Bug 1177162 - Don't delete the UITour variable from the browser window as it breaks later tests. r=bgrins 2015-07-10 17:38:30 -04:00