Commit Graph

30 Commits

Author SHA1 Message Date
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Brian Grinstead
3097f96e03 Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs
Before this change, we accessed the browser URL in the following ways:

- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js

MozReview-Commit-ID: I5vtRke1x9t
2018-07-24 08:12:50 -07:00
Marco Bonardo
899632d5f6 Bug 1475276 - Remove some no more necessary usage of promiseItemGuid. r=lina
Some code is unnecessarily using promiseItemGuid

Differential Revision: https://phabricator.services.mozilla.com/D2100
2018-07-12 21:38:21 +00:00
Mark Banner
efb967ef3e Bug 1453667 - Remove BrowserUITelemetry from other parts of browser/ r=Gijs
MozReview-Commit-ID: FG1PiVPBY5U
2018-06-06 19:42:19 +01:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja
2018-02-21 14:28:48 +00:00
Tooru Fujisawa
2f66e44fee Bug 1435910 - Part 0.1: Move PlacesUIUtils.confirmOpenInTabs into new OpenInTabsUtils.jsm and add promiseConfirmOpenInTabs. r=Gijs,dao 2018-02-28 10:36:42 +09:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Rajesh Kathiriya
7c0507b30e Bug 1370232 - Enabled the ESLint no-unneeded-ternary rule across mozilla-central. r=standard8
MozReview-Commit-ID: AH9ArRkjh78
2017-06-13 00:23:54 +05:30
Christoph Kerschbaumer
436065ccac Bug 1363977 - Have loadTabs() provide the correct triggeringPrincipal. r=gijs,smaug 2017-05-29 21:32:21 +02:00
Carsten "Tomcat" Book
1d3abb096a Backed out changeset 2b92af4575ae (bug 1357386) 2017-05-30 08:51:22 +02:00
Christoph Kerschbaumer
3bf6e7c868 Bug 1357386: Have loadTabs() provide the correct triggeringPrincipal. r=gijs,smaug 2017-05-30 08:31:08 +02:00
Kit Cambridge
390ec1bcc4 Bug 1322408 - Use gBrowser.loadTabs to open all tabs when middle-clicking a client in Synced Tabs. r=markh
MozReview-Commit-ID: 6phgHjAAXUs
2016-12-07 11:46:36 -10:00
Edouard Oger
d2392f97e8 Bug 1288247 - Open synced tabs in a new tab on middle click. r=markh
MozReview-Commit-ID: LTE5NolY8V3
2016-08-19 17:10:45 -07:00
Sebastian Hengst
e4b461b181 Backed out changeset bbe3a00528ed (bug 1288247) for failing test_TabListComponent.js. r=backout 2016-08-24 18:22:40 +02:00
Sebastian Hengst
d2968bc779 Backed out changeset f976df7f1eba (bug 1288247) 2016-08-24 18:21:44 +02:00
Sebastian Hengst
91d8c8cd01 Bug 1288247 - Open synced tabs in a new tab on middle click: Add whitespace after 'if' to make eslint happy. r=eslint-fix 2016-08-24 16:43:12 +02:00
Edouard Oger
a48f5cedf3 Bug 1288247 - Open synced tabs in a new tab on middle click. r=markh
MozReview-Commit-ID: LTE5NolY8V3
2016-08-19 17:10:45 -07:00
Mark Hammond
a26eeefd75 Bug 1241571 - Collect synced tabs and sidebar ui telemetry. r=Gijs
Adds UI telemetry for sidebar opening and closing and actions taken in the
SyncedTabs menu and side. Also adds a "sync-state" object so that analysis
of the Synced Tabs data can determine if the user has Sync configured at the
time.

MozReview-Commit-ID: JDxFmlNMi7n
2016-05-18 10:39:14 +10:00
Kit Cambridge
e9b39583ec Bug 1257008 - Don't collapse the tab list when right-clicking on a device in the Synced Tabs sidebar. r=markh
MozReview-Commit-ID: JsaWLfMOYyC
2016-03-15 16:56:52 -07:00
Kit Cambridge
7229c73ac8 Bug 1262310 - Fix opening synced tabs from the sidebar. r=markh
MozReview-Commit-ID: 8VHbEqsyuF2
2016-04-05 17:06:00 -07:00
Kit Cambridge
8b7ad60498 Bug 1246156 - Show additional link options in the synced tabs sidebar context menu. r=markh
MozReview-Commit-ID: 44KlEasJiLc
2016-03-10 15:56:25 -08:00
Edouard Oger
51083b86ca Bug 1246160 - Fix tab bookmarking action in synced tabs sidebar. r=zaach 2016-02-05 07:53:00 -05:00
Zachary Carter
de74e8bcb6 Bug 1210586 - Create a Synced tabs sidebar r=markh 2016-01-27 14:40:30 -08:00