Commit Graph

44 Commits

Author SHA1 Message Date
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Carol Ng
968dd8ac11 Bug 1417577 - Support locale direction changes in sync sidebar r=eoger,gandalf
MozReview-Commit-ID: 2pHSjoOhW9o
2018-05-30 14:12:24 -04:00
Brindusan Cristian
ecfa398ee2 Backed out changeset 3cb69bac2eac (bug 1417577) at eoger's request. 2018-05-30 01:39:37 +03:00
Carol Ng
0250684065 Bug 1417577 - Support intl.uidirection pref in sync sidebar r=eoger
MozReview-Commit-ID: HumZg9nGZtW
2018-05-29 15:24:30 -04:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Edouard Oger
e6d4206df4 Bug 1439194 - Implement a separate state for login failed in the sidebar. r=markh
MozReview-Commit-ID: B9hY8mpPEMw
2018-02-20 09:58:05 +08:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Edouard Oger
cd7496e3c6 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn
2017-11-30 16:01:40 -05:00
Edouard Oger
3077a82016 Bug 1421905 - Listen to service start notification in Synced Tabs sidebar. r=markh
MozReview-Commit-ID: JE1U1ZFFq99
2017-11-30 11:29:18 -05:00
Dorel Luca
a124b68f6f Backed out changeset 1ca98c1618a6 (bug 1422106) for failing browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE 2017-12-02 02:37:38 +02:00
Edouard Oger
f5fa7dc767 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn
2017-11-30 16:01:40 -05:00
Dorel Luca
7f5a8af5d3 Backed out changeset 3aff028846c0 (bug 1422106) for failing syncedtabs/test/xpcshell/test_SyncedTabsDeckComponent.js and browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE 2017-12-02 00:33:41 +02:00
Edouard Oger
0bfd63cd24 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn
2017-11-30 16:01:40 -05:00
Edouard Oger
b37abdbbae Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
MozReview-Commit-ID: 5vBKH9NejVV
2017-11-17 16:48:17 -05:00
Noemi Erli
beae1b7e61 Backed out changeset 932a77d8fbae (bug 1418466) for ES failures in /builds/worker/checkouts/gecko/browser/base/content/browser-sync.js r=backout on a CLOSED TREE 2017-11-30 18:44:16 +02:00
Edouard Oger
1ad5b3de66 Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
MozReview-Commit-ID: 5vBKH9NejVV
2017-11-17 16:48:17 -05:00
Edouard Oger
a0cee0d6b8 Bug 1417520 p1 - Show message to unverified users in synced tabs sidebar. r=markh
MozReview-Commit-ID: KYlbWLg2Kj0
2017-11-16 15:29:23 -05:00
Edouard Oger
bf97626bd8 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv
2017-04-18 14:15:43 -04:00
Sebastian Hengst
6471972ae8 Backed out changeset 0a0138825fb5 (bug 1353571) 2017-05-03 21:56:44 +02:00
Edouard Oger
c9a99ae676 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv
2017-04-18 14:15:43 -04:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Edouard Oger
434f3e3c75 Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh
MozReview-Commit-ID: LK9akz4chd1
2017-01-27 13:31:57 -05:00
Wes Kocher
092fa0f3bc Backed out 13 changesets (bug 1296767) for xpcshell failures a=backout CLOSED TREE
Backed out changeset 41ed77788333 (bug 1296767)
Backed out changeset 1c0c9289b532 (bug 1296767)
Backed out changeset 50294db1d871 (bug 1296767)
Backed out changeset 26c065f79c54 (bug 1296767)
Backed out changeset 0362a78d6978 (bug 1296767)
Backed out changeset 4e71cf94e4ee (bug 1296767)
Backed out changeset f6f59447d22a (bug 1296767)
Backed out changeset 6c9b792cc296 (bug 1296767)
Backed out changeset 46a52b10a868 (bug 1296767)
Backed out changeset 5d70d87d2a8f (bug 1296767)
Backed out changeset 8219686be6a2 (bug 1296767)
Backed out changeset 0a989b0cea67 (bug 1296767)
Backed out changeset 9f59a0b75c1f (bug 1296767)

MozReview-Commit-ID: 2XBNsd8JrZL
2017-01-26 11:16:12 -08:00
Edouard Oger
28c8fa59f2 Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh
MozReview-Commit-ID: LK9akz4chd1
2017-01-18 17:39:11 -05:00
Edouard Oger
87c8240500 Bug 1298011 - Update the Synced Tabs sidebar UI when account password changed. r=markh
MozReview-Commit-ID: 2cJK8ZAQH5R
2017-01-05 16:54:12 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Kit Cambridge
390ec1bcc4 Bug 1322408 - Use gBrowser.loadTabs to open all tabs when middle-clicking a client in Synced Tabs. r=markh
MozReview-Commit-ID: 6phgHjAAXUs
2016-12-07 11:46:36 -10:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Kit Cambridge
8b7ad60498 Bug 1246156 - Show additional link options in the synced tabs sidebar context menu. r=markh
MozReview-Commit-ID: 44KlEasJiLc
2016-03-10 15:56:25 -08:00
Sebastian Hengst
29a093922f Bug 1245377 - Avoid use of Object.values in SyncedTabs sidebar as it only exists on nightly: eslint fix followup. r=eslint-fix 2016-02-06 00:00:50 +01:00
Mark Hammond
9432edd30b Bug 1245377 - Avoid use of Object.values in SyncedTabs sidebar as it only exists on nightly. r=zaach 2016-02-04 17:43:00 -05:00
Dave Townsend
a215a4a95a Bug 1245649: Turn on no-extra-semi. r=markh 2016-02-03 17:27:36 -08:00
Zachary Carter
500cd6f5e7 Bug 1210586 - add entrypoint when opening Sync setup from tabs sidebar r=markh 2016-01-27 14:55:02 -08:00
Zachary Carter
de74e8bcb6 Bug 1210586 - Create a Synced tabs sidebar r=markh 2016-01-27 14:40:30 -08:00