This simply removes the content blocking section when TP is not enabled to avoid overpromising.
We may update this UI to alert the user that TP is off after the UX team comes back with a new design.
Differential Revision: https://phabricator.services.mozilla.com/D10071
Before this patch, default home page of private sessions didn't inform about saving clipboard text. Now it informs that "copied text" will be saved in private session.
Differential Revision: https://phabricator.services.mozilla.com/D5941
This makes the about:privatebrowsing display "Content Blocking" instead
of "Tracking Protection" and makes the toggle flip the TP setting for PB
mode as well as the CB pref if it's turned off.
Differential Revision: https://phabricator.services.mozilla.com/D4395
There are 3 issues here:
- the runtime changing of the title causes issues where the content title is
not set. This is fixed by setting it to the private title by default;
there is very little (if any) UI that allows users to even open
about:privatebrowsing in 'normal' windows so we care a lot less about
flicker there. To be able to include this title in the markup, we switched
to a dtd.
- the 'empty tab' title we set on the tab initially is set when the tab is
created. This has been updated to check for private windows, and default to
'Private Browsing' instead. This will obviously also affect other new tabs
in private browsing, but that seems desirable/consistent.
- Likewise, we use this title when updating a tab's title that we don't yet
have a content title for (which can still happen while about:privatebrowsing
is loading because e10s), and so that is updated, too.
MozReview-Commit-ID: nVfXD2M6UZ
There are 3 issues here:
- the runtime changing of the title causes issues where the content title is
not set. This is fixed by setting it to the private title by default;
there is very little (if any) UI that allows users to even open
about:privatebrowsing in 'normal' windows so we care a lot less about
flicker there. To be able to include this title in the markup, we switched
to a dtd.
- the 'empty tab' title we set on the tab initially is set when the tab is
created. This has been updated to check for private windows, and default to
'Private Browsing' instead. This will obviously also affect other new tabs
in private browsing, but that seems desirable/consistent.
- Likewise, we use this title when updating a tab's title that we don't yet
have a content title for (which can still happen while about:privatebrowsing
is loading because e10s), and so that is updated, too.
MozReview-Commit-ID: nVfXD2M6UZ
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.
It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)
MozReview-Commit-ID: DeSHcClQ7cG
This was initially removed when we added support for setting the favicon
ahead of parsing the page for newtab-like pages. Turns out we need it in
some scenarios, such as navigating back and forth or duplicating the tab.
MozReview-Commit-ID: HuMeEnqpLLB
We apply a custom workaround to show about:home and about:newtab favicons
as early as possible for perceived performance, but didn't previously consider
the about:privatebrowsing page (which can act as both about:home and about:newtab).
MozReview-Commit-ID: gPiV08h0j0
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.
MozReview-Commit-ID: ANyg2qfo3Qx
This patch is generated by the following sed script:
find . ! -wholename '*/.hg*' -type f \( -iname '*.html' -o -iname '*.xhtml' -o -iname '*.xul' -o -iname '*.js' \) -exec sed -i -e 's/\(\(text\|application\)\/javascript\);version=1.[0-9]/\1/g' {} \;
MozReview-Commit-ID: AzhtdwJwVNg
