Commit Graph

738 Commits

Author SHA1 Message Date
Ehsan Akhgari
9f92463607 Bug 1548432 - Part 2: Ignore cookie name-value-pair strings without a "=" character; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29619
2019-05-02 17:12:55 +00:00
Ehsan Akhgari
6697653052 Bug 1481771 - Fix a race condition in browser_privatebrowsing_favicon.js by ensuring the promises that wait on conditions that happen during opening a tab are created before starting to open the tab; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D29717
2019-05-02 21:26:11 +00:00
Brian Grinstead
3dd68e7775 Bug 1546501 - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags r=mossop
This is an autogenerated commit, generated with https://bug1546501.bmoattachments.org/attachment.cgi?id=9060222

Differential Revision: https://phabricator.services.mozilla.com/D28559
2019-04-24 19:43:57 +00:00
Arpit
bf94575434 Bug 1483077 - Replaced reference to getBrowser with gBrowser r=robwu,dao
Differential Revision: https://phabricator.services.mozilla.com/D27418
2019-04-17 00:04:54 +00:00
Mark Banner
d5029e0dae Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850
2019-03-28 09:38:14 +00:00
Mark Banner
ae56adafc5 Bug 1531693 - For the PrivateBrowsing about page test, ensure we wait for autocomplete to finish. r=mak
This ensures test stability, and avoids leaking browser windows when we're closing the private browsing window in the test.

Differential Revision: https://phabricator.services.mozilla.com/D24530
2019-03-26 18:01:05 +00:00
Oana Pop Rus
34b0baeede Backed out 2 changesets (bug 1531693) for bc failures browser_privatebrowsing_about.js on a CLOSED TREE
Backed out changeset 4d2429507163 (bug 1531693)
Backed out changeset bf5460df1909 (bug 1531693)
2019-03-25 12:16:46 +02:00
Mark Banner
7c5ebdb9c2 Bug 1531693 - For the PrivateBrowsing about page test, ensure we wait for autocomplete to finish. r=mak
This ensures test stability, and avoids leaking browser windows when we're closing the private browsing window in the test.

Depends on D24529

Differential Revision: https://phabricator.services.mozilla.com/D24530
2019-03-22 22:40:33 +00:00
Nicholas Cowles
94116cd22a Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=Gijs,jaws,zbraniecki,flod
Differential Revision: https://phabricator.services.mozilla.com/D19250
2019-03-18 18:05:13 +00:00
Ian Moody
3593cdee69 Bug 1536653 - browser/ manual ESLint no-throw-literal fixes. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D24111
2019-03-20 10:15:03 +00:00
Gurzau Raul
3f297c10a6 Backed out changeset f73f629e8cca (bug 1517528) on request from jaws, CLOSED TREE. 2019-03-14 07:54:17 +02:00
Nicholas Cowles
57897e15c2 Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=Gijs,jaws,zbraniecki,flod
Differential Revision: https://phabricator.services.mozilla.com/D19250
2019-03-11 17:56:36 +00:00
Sebastian Hengst
9f08b58bcc Backed out changeset 40ddf7d53eaa (bug 1517528) for flake8 failures 2019-03-01 11:42:02 +01:00
Nicholas Cowles
0bb840cf56 Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=Gijs,jaws,zbraniecki,flod
Differential Revision: https://phabricator.services.mozilla.com/D19250
2019-03-01 09:41:07 +00:00
Coroiu Cristina
9e46da4c33 Backed out changeset f4094fd9e1df (bug 1517528) for mochitest failures on a CLOSED TREE 2019-02-19 22:25:55 +02:00
Nicholas Cowles
e9044819da Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=jaws,zbraniecki,flod
Differential Revision: https://phabricator.services.mozilla.com/D19250
2019-02-19 19:17:14 +00:00
Mark Banner
44835be526 Bug 1522516 - Port browser_privatebrowsing_about.js to QuantumBar. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D20128
2019-02-18 14:45:50 +00:00
Myk Melez
5ecc2c1225 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Ricky Rosario
90c8748e44 Bug 1522486 - Perma-failing TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Test timed out when Gecko 66 merges to Beta on 2019-01-21 r=nanj
MozReview-Commit-ID: EuTmKnnYZtr

Differential Revision: https://phabricator.services.mozilla.com/D17513
2019-01-24 20:35:24 +00:00
Ricky Rosario
ae66bdf9d0 Bug 1521984 - Can't drag downloaded PDF into about:privatebrowsing r=andreio
MozReview-Commit-ID: FQvRmltnss7

Differential Revision: https://phabricator.services.mozilla.com/D17304
2019-01-23 18:21:26 +00:00
Ricky Rosario
8feb24c93c Bug 1508364 - New UI for Private Browsing with Search r=andreio
MozReview-Commit-ID: 4WSGpL5Gvde

Differential Revision: https://phabricator.services.mozilla.com/D16854
2019-01-21 20:14:26 +00:00
arthur.iakab
8809d06ba4 Backed out changeset 13f379946829 (bug 1508364) for functional ui test failures on private_browsing/test_about_private_browsing.py CLOSED TREE 2019-01-21 21:38:29 +02:00
Ricky Rosario
02438f79cc Bug 1508364 - New UI for Private Browsing with Search r=andreio
MozReview-Commit-ID: 4WSGpL5Gvde

Differential Revision: https://phabricator.services.mozilla.com/D16854
2019-01-21 17:05:08 +00:00
Florens Verschelde
36f18e347c Bug 1505687 - Visual tweaks to about:privatebrowsing; r=johannh
- Fix bullet list margins.
- Improve :hover:active style for links.
- Improve narrow width layout: flexible list item width, more reasonable line-heights, move content blocking icon inline.

Differential Revision: https://phabricator.services.mozilla.com/D11579
2018-11-12 13:35:38 +00:00
Ehsan Akhgari
3f3dbf9eba Remove an unused variable, no bug 2018-10-30 20:29:40 -04:00
Johann Hofmann
3f718177eb Bug 1502361 - Remove Content Blocking toggle from about:privatebrowsing. r=Ehsan
This simply removes the content blocking section when TP is not enabled to avoid overpromising.
We may update this UI to alert the user that TP is off after the UX team comes back with a new design.

Differential Revision: https://phabricator.services.mozilla.com/D10071
2018-10-29 17:10:24 +01:00
Ehsan Akhgari
034add9c87 Bug 1501286 - Part 3: Remove support for tracking protection UI in about:privatebrowsing r=johannh
Depends on D9520

Differential Revision: https://phabricator.services.mozilla.com/D9521
2018-10-25 16:46:49 +00:00
Dorel Luca
6839d2a276 Backed out 5 changesets (bug 1501286) for browser-chrome failures in browser/components/uitour/test/browser_trackingProtection.js
Backed out changeset cac0d4aa79d1 (bug 1501286)
Backed out changeset 578d395f555e (bug 1501286)
Backed out changeset d9940451c373 (bug 1501286)
Backed out changeset ca6c3139bdd2 (bug 1501286)
Backed out changeset 93d6f4d54f78 (bug 1501286)
2018-10-25 17:52:59 +03:00
Ehsan Akhgari
b069db45c8 Bug 1501286 - Part 3: Remove support for tracking protection UI in about:privatebrowsing r=johannh
Depends on D9520

Differential Revision: https://phabricator.services.mozilla.com/D9521
2018-10-25 13:35:22 +00:00
vinoth
e1766674ba Bug 1498885 - Assertion added in ContentSecurityPolicyPermitsJSAction() to not allow eval with SystemPrincipal r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D8683
2018-10-15 08:02:04 +00:00
Bogdan Tara
8cb53316d7 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-20 01:03:35 +03:00
savvysiddharth
6a102ac040 Bug 1442845 - Added firefox will save clipboard in private browsing r=jdm
Before this patch, default home page of private sessions didn't inform about saving clipboard text. Now it informs that "copied text" will be saved in private session.

Differential Revision: https://phabricator.services.mozilla.com/D5941
2018-09-17 20:48:28 +00:00
Jonathan Kingston
6505a47818 Bug 1485305 - browser/ tests Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4552
2018-08-29 15:44:56 +01:00
Brindusan Cristian
6c0094d53f Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
2018-09-19 18:47:27 +03:00
Jonathan Kingston
a857075e73 Bug 1485305 - browser/ tests Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4552
2018-08-29 15:44:56 +01:00
Johann Hofmann
85ab6ab952 Bug 1490729 - Ensure that we send variation=0 for the TP UI on about:privatebrowsing. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D5680
2018-09-12 18:12:45 +00:00
Jason Chapin
f9f37dc5d2 Bug 1457786 - Remove question-32.png. r=dao 2018-09-10 16:54:18 +02:00
Gijs Kruitbosch
55a5f53593 Bug 1488412 - make sure we wait for the right loads in browser_privatebrowsing_concurrent.js, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D5173
2018-09-07 14:27:27 +00:00
Johann Hofmann
370572fdd2 Bug 1488933 - Link to the new content blocking onboarding from about:privatebrowsing when the CB UI is enabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D5090
2018-09-06 13:30:40 +00:00
Soeren Hentzschel
cc4238aa02 Bug 1486915 - Use the "hidden" attribute instead of a "hide" class in aboutPrivateBrowsing.js r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D4821
2018-09-05 09:28:17 +00:00
Gijs Kruitbosch
d1b0a5c647 Bug 1486824 - review comment follow-up: change params for openNewBrowserWindow to explicitly check for URL, r=nhnt11 2018-09-03 15:16:55 +01:00
Gijs Kruitbosch
fb25f8415a Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466
2018-09-03 14:43:38 +01:00
Margareta Eliza Balazs
c9b513d70b Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-08-31 12:27:44 +03:00
Margareta Eliza Balazs
e835f67a30 Backed out changeset 96b5a88ac004 (bug 1486824) for causing frequent failures e.g: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js a=backout 2018-08-31 12:17:27 +03:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Gijs Kruitbosch
fa5a2cb49a Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466
2018-08-30 15:07:36 +00:00
Johann Hofmann
2ea7b2eb2b Bug 1484586 - Update about:privatebrowsing for content blocking. r=Gijs
This makes the about:privatebrowsing display "Content Blocking" instead
of "Tracking Protection" and makes the toggle flip the TP setting for PB
mode as well as the CB pref if it's turned off.

Differential Revision: https://phabricator.services.mozilla.com/D4395
2018-08-28 21:01:19 +00:00
arthur.iakab
f36e6bf3d0 Backed out 10 changesets (bug 1485305)for failing browser chrome tests on browser_loadDisallowInherit.js
Backed out changeset 138b8596a9cd (bug 1485305)
Backed out changeset d9f04aeeeef7 (bug 1485305)
Backed out changeset cd063d8afe4e (bug 1485305)
Backed out changeset 2f8a5a03ccb5 (bug 1485305)
Backed out changeset 8085d1eefd7c (bug 1485305)
Backed out changeset 3aaccb374a59 (bug 1485305)
Backed out changeset 3a111e9e5c9c (bug 1485305)
Backed out changeset 61aa1cfb0b01 (bug 1485305)
Backed out changeset bca973d90acc (bug 1485305)
Backed out changeset 4eb33bf25d6f (bug 1485305)
2018-09-18 20:30:07 +03:00
Jonathan Kingston
628310b33c Bug 1485305 - browser/ tests Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4552
2018-08-29 15:44:56 +01:00