Commit Graph

110 Commits

Author SHA1 Message Date
Carolina Jimenez Gomez
06fbf600a9 Bug 1510960 - Fix the problem when the user removes all permissions from cookies permission and then try to add the same before clicking on "Save Changes". r=johannh
The problem was that it only apply changes when the user clicks on save button, so, some times there is a permission that has to be added but is also in the permissions to delete, so, the solution is just delete all the permissions it has to delete first and then add the permissions that has to be added. r=johannh

Differential Revision: https://phabricator.services.mozilla.com/D23952
2019-04-01 12:41:51 +00:00
Noor Afshan Fathima
3f00203b70 Bug 1537535 - Changed the string replace method with trim() method. r=johannh
Summary:
Changed the string replace method with trim() method

Issue fixed

Reviewers: johannh

Reviewed By: johannh

Bug #: 1537535

Differential Revision: https://phabricator.services.mozilla.com/D24344
2019-03-23 04:32:17 +02:00
Ian Moody
cac3a5f1e2 Bug 1536653 - browser/ automated ESLint no-throw-literal fixes. r=Gijs
Result of running:
$ mach eslint -funix browser/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24110
2019-03-20 10:17:42 +00:00
Carolina Jimenez Gomez
b362f6bd9a Bug 1442179 - If the user enters something that can not be parsed as a URL, appends http:// and https:// and adds permission for both of them. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D21138
2019-03-19 14:14:03 +00:00
Jared Wein
2bf63868db Bug 1524258 - Sort the permission capabilities based on their localization ID so we don't have to wait for the asynchronous localization. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18372
2019-02-05 21:01:08 +00:00
Dorel Luca
75b40e10cd Backed out changeset 5983bd842b52 (bug 1524258) for Browser-chrome failures in browser/components/preferences/in-content/tests/browser_cookies_exceptions.js. CLOSED TREE 2019-02-05 01:40:16 +02:00
Jared Wein
0f1db458ae Bug 1524258 - Localized strings need to be applied on the permission rows before we can sort them by their values. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18372
2019-02-04 21:54:54 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Andrea Marchesini
cf02f13836 Bug 1521051 - Get rid of nsICookiePermission.ACCESS_ALLOW_FIRST_PARTY_ONLY, r=johannh, r=flod 2019-01-23 19:19:19 +01:00
Razvan Maries
8623470adb Backed out 2 changesets (bug 1521051) for xpcshell fails on extensions/cookie/test/unit/test_cookies_thirdparty.js. CLOSED TREE
Backed out changeset 90bb620dd870 (bug 1521051)
Backed out changeset 483fa314e45e (bug 1521051)
2019-01-23 22:09:32 +02:00
Andrea Marchesini
24a313869c Bug 1521051 - Get rid of nsICookiePermission.ACCESS_ALLOW_FIRST_PARTY_ONLY, r=johannh, r=flod 2019-01-23 19:19:19 +01:00
Paolo Amadini
c6bd36fe27 Bug 1516442 - Move "listheader" outside of "richlistbox". r=bgrins
The only uses of "listheader" are part of in-content preferences, and they are updated to use adjacent elements. This is in preparation for the removal of the inner scrollbox in the "richlistbox" binding.

Differential Revision: https://phabricator.services.mozilla.com/D15387
2018-12-26 17:00:31 +00:00
Paolo Amadini
e30a6b76de Bug 1466817 - The "Edit Pop-up Blocker Options/Preferences" command should open the in-content preferences. r=jaws
Instead of opening the pop-up permissions dialog with the origin already populated, this command now highlights the pop-up permission row in the preferences. This doesn't remove any functionality because the only action that would be available for the origin in the permissions dialog is "Allow", which is equivalent to the "Allow pop-ups for" command in the notification bar menu.

Differential Revision: https://phabricator.services.mozilla.com/D15066
2018-12-23 20:52:15 +00:00
Jack Smith
4fcd8caec6 Bug 1491676 - Moves permissions strings r=flod,Gijs,zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D9917
2018-11-14 23:11:24 +00:00
Cosmin Sabou
728f4df779 Backed out 4 changesets (bug 1491676) for causing browser chrome failures on browser_storagePressure_notification. CLOSED TREE
Backed out changeset 08cbaa2f9183 (bug 1491676)
Backed out changeset fae949de1ed5 (bug 1491676)
Backed out changeset aeb045b90321 (bug 1491676)
Backed out changeset e75c59f129ea (bug 1491676)
2018-11-07 20:53:48 +02:00
Jack Smith
01b9af673d Bug 1491676 - Moves permissions strings r=flod,Gijs,zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D9917
2018-11-07 18:06:42 +00:00
Ciure Andrei
474054f58c Backed out 4 changesets (bug 1491676) for browser-chrome permissions failures CLOSED TREE
Backed out changeset e860d0d115d0 (bug 1491676)
Backed out changeset 04b83b7977c4 (bug 1491676)
Backed out changeset eb19b384d908 (bug 1491676)
Backed out changeset 76ea995336dc (bug 1491676)
2018-11-07 13:44:26 +02:00
Jack Smith
7c338cfcba Bug 1491676 - Moves permissions strings r=flod,Gijs,zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D9917
2018-11-07 10:21:50 +00:00
Michael Kohler
a3c2786e34 Bug 1496244 - Change 'Tracking Protection' to 'Content Blocking' in Exceptions Dialog under Content Blocking r=flod,johannh
Differential Revision: https://phabricator.services.mozilla.com/D8791
2018-10-17 14:56:13 +00:00
Dorel Luca
9a05b701f7 Backed out changeset 5aff488dd9e9 (bug 1496244) for Browser chrome failures in browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js 2018-10-15 16:10:00 +03:00
Michael Kohler
cb19d323c4 Bug 1496244 - Change 'Tracking Protection' to 'Content Blocking' in Exceptions Dialog under Content Blocking r=flod,johannh
Differential Revision: https://phabricator.services.mozilla.com/D8430
2018-10-15 10:56:36 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Brendan Dahl
532fe1f6b0 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265
2018-08-25 00:16:27 +00:00
Kris Maglione
f6a4413b4c Bug 1484496: Part 5a - Convert browser/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3729
2018-08-18 19:27:33 -07:00
Dale Harvey
7a359ffd55 Bug 1484188 - Rephrase title for autoplay exceptions prompt. r=flod
MozReview-Commit-ID: HmFoCcD6P9p
2018-08-20 15:16:01 +01:00
Dale Harvey
3f5adfbd25 Bug 1476889 - Update autoplay copy. r=flod
MozReview-Commit-ID: D8Ss2U2gZ9q
2018-07-23 12:20:30 +01:00
Paolo Amadini
a80747f919 Bug 1446362 - Part 2 - Remove "tree" from the permission preferences. r=johannh
MozReview-Commit-ID: 9IYpH8SvsCw
2018-06-22 14:13:53 +01:00
Paolo Amadini
0e3a908119 Bug 1467713 - Part 4 - Replace "var" with "let" and remove the parameter prefix. r=jaws
MozReview-Commit-ID: 61k7xS2MlKr
2018-06-05 17:30:43 +01:00
Paolo Amadini
84bead32a3 Bug 1467713 - Part 3 - Remove the unused setOrigin function. r=jaws
MozReview-Commit-ID: 3CpU7zY9JFJ
2018-06-05 15:27:24 +01:00
Paolo Amadini
a1972ba359 Bug 1467713 - Part 2 - Reorder "permissions.js" to match "sitePermissions.js". r=jaws
Reordering the functions makes it easier to port the implementation across the files and merge them eventually.

MozReview-Commit-ID: EkVbTA0YEQ5
2018-06-05 15:26:14 +01:00
Paolo Amadini
a445520767 Bug 1467713 - Part 1 - Rename functions in "permissions.js" to match "sitePermissions.js". r=jaws
MozReview-Commit-ID: KeF5mcVvVHl
2018-06-05 15:12:39 +01:00
Dale Harvey
708beed985 Bug 1458249 - Add autoplay item to about:preferences. r=flod,johannh
MozReview-Commit-ID: AldNoElwH1O
2018-05-03 07:55:53 +01:00
Trisha Gupta
d422ac88ed Bug 1442303 - The arrow for sort is missing in Exceptions dialogues r=johannh
MozReview-Commit-ID: CntCTeVC91U
2018-05-25 22:53:43 +08:00
Zibi Braniecki
25701066bc Bug 1461048 - Convert Fluent API calls to FluentDOM 0.3.0. r=mossop
MozReview-Commit-ID: K3eA8blcP2x
2018-05-14 12:37:41 -07:00
Zibi Braniecki
3d0703ba49 Bug 1457021 - Fix a mangled message ID order in a Preferences::Permissions JS dialog. r=Gijs
MozReview-Commit-ID: JeAxaSTWllA
2018-04-27 15:38:22 -07:00
Zibi Braniecki
674fbdf08d Bug 1457948 - Migrate in-content/privacy.js to Fluent. r=flod,jaws
MozReview-Commit-ID: 7K7Wgm5ahTL
2018-04-30 10:29:18 -07:00
Dorel Luca
995f173383 Backed out changeset fba5e06d6365 (bug 1457948) for Browser-chrome failures on multipe files. CLOSED TREE 2018-05-08 10:54:13 +03:00
Zibi Braniecki
c71bdde78e Bug 1457948 - Migrate in-content/privacy.js to Fluent. r=flod,jaws
MozReview-Commit-ID: 7K7Wgm5ahTL
2018-04-30 10:29:18 -07:00
Trisha
e49c83f92f Bug 1444868 - use .textContent to override the intro text directly in permissions.js. r=johannh 2018-03-14 00:59:35 +08:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Tim Nguyen
0f11886f22 Bug 1430374 - Remove support for progressmeter tree cells. r=bz,dao
MozReview-Commit-ID: 3hydkeoneC0
2018-01-18 10:36:05 +00:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Andrea Marchesini
a8517d8f9f Bug 1347817 - Principal must always have a valid origin - part 6 - fixing tests, r=ehsan 2017-03-29 15:28:46 +02:00