Commit Graph

146 Commits

Author SHA1 Message Date
Brian Grinstead
90f864cbfe Bug 1545962 - Use <template> instead of CDATA for about:preferences r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D28280
2019-04-22 22:38:57 +00:00
Jared Wein
6dc2d40d43 Bug 1533294 - Changing categories should hide the search-headers. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D25188
2019-03-28 10:59:44 +00:00
Brian Grinstead
b161be4615 Bug 1536752 - Remove sync pane from about:preferences when identity.fxaccounts.enabled is false r=Gijs
This fixes a bug in where we render out the text content of the template when searching.

Differential Revision: https://phabricator.services.mozilla.com/D24544
2019-03-22 20:49:53 +00:00
Ian Moody
cac3a5f1e2 Bug 1536653 - browser/ automated ESLint no-throw-literal fixes. r=Gijs
Result of running:
$ mach eslint -funix browser/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24110
2019-03-20 10:17:42 +00:00
Zibi Braniecki
669ebda920 Bug 1532712 - Fix tests to await for gotoPref. r=gijs
Differential Revision: https://phabricator.services.mozilla.com//D23377
2019-03-13 19:43:50 +00:00
Zibi Braniecki
4d4ee7c580 Bug 1532712 - Optimize Preferences translation. r=gijs
Differential Revision: https://phabricator.services.mozilla.com//D23245
2019-03-13 00:27:31 +00:00
Gurzau Raul
2ac5ded756 Backed out 2 changesets (bug 1532712) for mochitest failures at browser_policy_set_homepage.js on a CLOSED TREE.
Backed out changeset 1af088f5fc34 (bug 1532712)
Backed out changeset 5fb5272aec8e (bug 1532712)
2019-03-13 21:18:53 +02:00
Zibi Braniecki
7d1a7ca6ee Bug 1532712 - Optimize Preferences translation. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D23245
2019-03-13 16:39:43 +00:00
Mark Striemer
1869f7ad8c Bug 1506102 - Don't count lastFallbackLocale as installed when just fluent is included r=zbraniecki,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18386
2019-02-12 23:28:27 +00:00
Brindusan Cristian
d3fb35a085 Backed out changeset e785008a884f (bug 1506102) for bc failures at browser_browser_languages_subdialog.js. 2019-02-11 19:32:16 +02:00
Mark Striemer
00471a799e Bug 1506102 - Don't count lastFallbackLocale as installed when just fluent is included r=zbraniecki,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18386
2019-02-11 15:24:55 +00:00
Mark Striemer
cc69c6822f Bug 1500147 - Part 1: Record telemetry for about:addons pages r=rpl,janerik
Differential Revision: https://phabricator.services.mozilla.com/D13154
2019-02-07 16:47:45 +00:00
Cosmin Sabou
bf63534551 Merge mozilla-inbound to mozilla-central. a=merge 2019-01-29 12:01:56 +02:00
Timothy Guan-tin Chien
aabcb0d2fc Bug 1520350 - Lazily load about:preferences markups from hidden panes r=jaws
Because custom elements will be constructed when DOM is constructed,
construct the DOM in the hidden panels will be expensive as we move
more and more widgets to custom elements from XBL.

This patch attempts to counter that by moving all the pane markups
into comment nodes, and use MozXULElement.parseXULToFragment() to
insert it when it is being asked.

They will be loaded lazily from an requestIdleCallback() in findInPage.js.

Differential Revision: https://phabricator.services.mozilla.com/D16787
2019-01-29 00:27:29 +00:00
Andreea Pavel
f475dbf8d0 Backed out changeset ad9834d2b44e (bug 1520350) for failing browser_aboutPrefs_fc_check_otherInstance.js on a CLOSED TREE 2019-01-28 22:21:21 +02:00
Timothy Guan-tin Chien
4df4231bc8 Bug 1520350 - Lazily load about:preferences markups from hidden panes r=jaws
Because custom elements will be constructed when DOM is constructed,
construct the DOM in the hidden panels will be expensive as we move
more and more widgets to custom elements from XBL.

This patch attempts to counter that by moving all the pane markups
into comment nodes, and use MozXULElement.parseXULToFragment() to
insert it when it is being asked.

They will be loaded lazily from an requestIdleCallback() in findInPage.js.

Differential Revision: https://phabricator.services.mozilla.com/D16787
2019-01-28 18:21:59 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Kris Maglione
f498964d86 Bug 1519596: Part 1 - Remove several unnecessary/unused ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16377
2019-01-11 16:59:23 -08:00
Paolo Amadini
0e017d1371 Bug 1429940 - Part 2 - Use HTML headings inside the "label" element for labeling "groupbox" elements in Preferences, instead of the "caption" element. r=MarcoZ,dao,jaws,flod
This makes it possible to navigate by headings when using accessibility technology.

Information labels displayed when removing the master password are also restored.

Differential Revision: https://phabricator.services.mozilla.com/D11792
2018-11-20 15:14:18 +00:00
Mike Conley
1709e07744 Bug 1502019 - Remove expired FX_PREFERENCES_CATEGORY_OPENED and FX_PREFERENCES_CATEGORY_OPENED_V2 probes. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D9791
2018-10-26 16:57:03 +00:00
Jared Wein
35d146c7ad Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D8892
2018-10-18 03:42:59 +00:00
Dorel Luca
16c60821e4 Backed out changeset eb2a83cba95a (bug 1497039) for XPCshell failures in browser/extensions/formautofill/test/unit/test_reconcile.js. CLOSED TREE 2018-10-18 01:33:07 +03:00
Jared Wein
96c853ec97 Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D8892
2018-10-17 19:36:46 +00:00
Mark Striemer
6c7e52bccd Bug 1483335 - Link between preferences and add-on manager r=flod,jaws
Differential Revision: https://phabricator.services.mozilla.com/D8099
2018-10-13 04:59:59 +00:00
Jared Wein
6ee3964cf7 Bug 1470184 - Update the Preferences text and layout for Web Payments. r=flod,MattN
Differential Revision: https://phabricator.services.mozilla.com/D6937
2018-09-28 08:29:01 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Zibi Braniecki
25701066bc Bug 1461048 - Convert Fluent API calls to FluentDOM 0.3.0. r=mossop
MozReview-Commit-ID: K3eA8blcP2x
2018-05-14 12:37:41 -07:00
k88hudson
de81b7c4f7 Bug 1451006 - Send correct category for about:preferences#home telemetry r=jaws
MozReview-Commit-ID: 4B9RqNhyjUo
2018-04-03 16:42:02 -04:00
Jared Wein
d0b4fed665 Bug 1449658 - Don't set hidden=true on items that are already visually-hidden when they don't match the search query since it is causing unnecessary layout changes. r=Gijs
MozReview-Commit-ID: 2HqpinGyuKw
2018-03-29 15:05:57 -07:00
k88hudson
8f426ef6fa Bug 1417155 - Add Home section to about:preferences for Activity Stream preferences r=flod,gandalf,jaws
MozReview-Commit-ID: FobtLGbqf6m
2018-03-05 19:52:07 -05:00
Edouard Oger
196afc24ca Bug 1443593 - Remove FxA preferences from search results when FxA is disabled. r=markh
MozReview-Commit-ID: 3x5wuJLDVWN
2018-03-09 14:36:59 -05:00
Felipe Gomes
db353634cb Bug 1432906 - Display notice in about:preferences when Policies are in use. r=gandalf,jaws
MozReview-Commit-ID: 83UUY9DmK2K
2018-03-05 14:18:44 -03:00
Edouard Oger
1a12c1fce4 Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s
2018-02-15 11:24:44 +08:00
Gregory Wlodarek
9fb48cb92c Bug 1434427 - Replace string for preferences confirmRestartPrompt to use "cancel" instead of "revert". r=flod
* Removed the revertNoRestartButton entry from the migration script as this no longer exists after this change

MozReview-Commit-ID: AGJ2OfYVPok
2018-02-16 13:34:18 -05:00
Csoregi Natalia
5f4a31b802 Backed out changeset 22901b9f9199 (bug 1434706) for browser-chrome failures browser_contextmenu_sendtab.js. CLOSED TREE 2018-02-26 21:16:01 +02:00
Edouard Oger
cf78f22e8e Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s
2018-02-15 11:24:44 +08:00
Cosmin Sabou
bb25b037bd Backed out changeset a2147499c437 (bug 1434706) for frequent mochitest browser chrome failures on browser_contextmenu_sendpage.js 2018-02-23 22:15:08 +02:00
Edouard Oger
23fa89126c Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s
2018-02-15 11:24:44 +08:00
shindli
4f93afdfba Backed out changeset 6e3058771f18 (bug 1434706) for bc6 and X failures in browser/base/content/test/general/browser_contextmenu_input.js and services/fxaccounts/tests/xpcshell/test_accounts.js respectively on a CLOSED TREE 2018-02-23 10:25:56 +02:00
Edouard Oger
b7ef270fb8 Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s
2018-02-15 11:24:44 +08:00
Zibi Braniecki
85527f89ee Bug 1424682 - Migrate the chrome of Preferences to the new Localization API. r=flod,jaws
MozReview-Commit-ID: ALnFUmnJMDB
2017-12-18 23:19:13 -08:00
Bob Silverberg
2777c6ca53 Bug 1429593 - Part 2: Show that a WebExtension is managing the proxy config setting, r=jaws,mstriemer
Update the general page of about:preferences, as well as the Connection Settings panel, to show
when an extension is controlling proxy settings, and allow a user to disable the extension to
regain control.

MozReview-Commit-ID: HKYPkg78IOK
2018-01-22 11:49:42 -05:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Gurzau Raul
82749346c0 Backed out 2 changesets (bug 1429593) for l10n issues
Backed out changeset 9dfaa0724a42 (bug 1429593)
Backed out changeset 20829d727fdf (bug 1429593)
2018-02-06 22:03:23 +02:00
Bob Silverberg
e9b15452db Bug 1429593 - Part 1: Extract functions for dealing with extensions into a separate file, r=jaws,mstriemer
This moves all the functions that manage/change the UI because of extensions being in
control of certain preferences to a separate file, so it can be included in SubDialogs.

MozReview-Commit-ID: 7OkEn478Pus
2018-01-22 14:40:20 -05:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00