Commit Graph

57 Commits

Author SHA1 Message Date
Andrew Swan
365b36f208 Bug 1538983 Rework highlightable buttons r=jaws
Our standard <button> binding has been carrying around an extra <label>
just to support search highlighting in about:preferences.  This patch
removes that overhead by moving the tweaks that about:preferences needs
into a custom element used only within about:preferences.

Differential Revision: https://phabricator.services.mozilla.com/D28511
2019-04-19 14:08:33 -07:00
Andrew Swan
a21c1c9924 Bug 1538983 Convert button xbl binding to a custom element r=bgrins
As of this change, instances of xul <button> use a custom element.
The button-base xbl binding remains for now, since it is still used
by toolbarbutton, it will be removed soon.

Differential Revision: https://phabricator.services.mozilla.com/D27742
2019-04-15 14:27:32 -07:00
nidhi
14b3bd6010 Bug 1534329 - Filter <script> <stringbundle> in the prefs' findInPage code. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D23787
2019-03-21 12:07:35 +00:00
Zibi Braniecki
669ebda920 Bug 1532712 - Fix tests to await for gotoPref. r=gijs
Differential Revision: https://phabricator.services.mozilla.com//D23377
2019-03-13 19:43:50 +00:00
danielleleb
2cbb29c7db Bug 1532931 - Adds condition to prevent unexpected results when searching 'true' or 'false' in about:preferences. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D23012
2019-03-11 18:18:15 +00:00
Neil Deakin
6bf9671461 Bug 1530015, remove box object usage from preferences page find, and instead iterate over anonymous nodes, r=jaws 2019-03-01 12:27:01 -05:00
Paolo Amadini
0e017d1371 Bug 1429940 - Part 2 - Use HTML headings inside the "label" element for labeling "groupbox" elements in Preferences, instead of the "caption" element. r=MarcoZ,dao,jaws,flod
This makes it possible to navigate by headings when using accessibility technology.

Information labels displayed when removing the master password are also restored.

Differential Revision: https://phabricator.services.mozilla.com/D11792
2018-11-20 15:14:18 +00:00
prathiksha
623321336d Bug 1468320 - Fix preferences search to work well with tooltips. r=johannh
Fix preferences search to work well with tooltips.

Differential Revision: https://phabricator.services.mozilla.com/D9486
2018-10-24 15:21:42 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Brendan Dahl
532fe1f6b0 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265
2018-08-25 00:16:27 +00:00
Boris Zbarsky
df1e81934e Bug 1446940 part 2. Stop getting docshells from windows via getInterface in browser. r=gijs 2018-08-01 13:07:10 -04:00
Zibi Braniecki
25701066bc Bug 1461048 - Convert Fluent API calls to FluentDOM 0.3.0. r=mossop
MozReview-Commit-ID: K3eA8blcP2x
2018-05-14 12:37:41 -07:00
Zibi Braniecki
fbfe048391 Bug 1453480 - Update Preferences to use fluent-dom 0.2.0 API. r=stas
MozReview-Commit-ID: 4CFnjf9VFLz
2018-04-12 22:45:02 -07:00
Coroiu Cristina
bc4362f863 Backed out 4 changesets (bug 1453480) for failing browser-chrome at browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_site_data.js on a CLOSED TREE
Backed out changeset 623b37fe0fe8 (bug 1453480)
Backed out changeset a3c36fa7ac0c (bug 1453480)
Backed out changeset 46a634d6853c (bug 1453480)
Backed out changeset 658fedb903d0 (bug 1453480)
2018-04-13 19:49:14 +03:00
Zibi Braniecki
908f690ce4 Bug 1453480 - Update Preferences to use fluent-dom 0.2.0 API. r=stas
MozReview-Commit-ID: 4CFnjf9VFLz
2018-04-12 22:45:02 -07:00
Zibi Braniecki
554ad7961f Bug 1451992 - Spawn errors when encountering missing/empty search l10n ids. r=jaws
MozReview-Commit-ID: 7WbtaNqO1Dg
2018-04-05 15:41:12 +02:00
Jared Wein
d0b4fed665 Bug 1449658 - Don't set hidden=true on items that are already visually-hidden when they don't match the search query since it is causing unnecessary layout changes. r=Gijs
MozReview-Commit-ID: 2HqpinGyuKw
2018-03-29 15:05:57 -07:00
Jared Wein
96e01fcbc8 Bug 1449658 - Elements that are already showing don't need their bindings force-applied since they're already applied. This removes the flicker when backspacing in the preference searchbox. r=Gijs
MozReview-Commit-ID: 5MxhMLAHJlJ
2018-03-28 10:41:02 -07:00
Zibi Braniecki
2c4260c996 Bug 1420761 - Handle new localization API in Preferences Search. r=jaws
MozReview-Commit-ID: 8J1siQtFn1t
2018-03-19 21:17:45 -07:00
Jared Wein
beaec0d652 Bug 1446657 - Refactor preferences search code to remove flickering and scrollbar appearing/disappearing. r=sfoster
MozReview-Commit-ID: 2o4ySs88DQB
2018-03-19 17:11:18 -04:00
Zibi Braniecki
c65f393e26 Bug 1445084 - Migrate search results pane of Preferences to Fluent. r=flod,Gijs
MozReview-Commit-ID: BNeocrSY5Fa
2018-03-12 16:27:32 -07:00
Csoregi Natalia
b84ab3ed54 Backout commit 32f45689f033 (bug 1445084) for frequently failing browser-chrome's browser_search_within_preferences_1.js (bug 1446186) a=backout 2018-03-16 14:51:38 +02:00
Zibi Braniecki
eaa72923c7 Bug 1445084 - Migrate search results pane of Preferences to Fluent. r=flod,Gijs
MozReview-Commit-ID: BNeocrSY5Fa
2018-03-12 16:27:32 -07:00
Bob Silverberg
2777c6ca53 Bug 1429593 - Part 2: Show that a WebExtension is managing the proxy config setting, r=jaws,mstriemer
Update the general page of about:preferences, as well as the Connection Settings panel, to show
when an extension is controlling proxy settings, and allow a user to disable the extension to
regain control.

MozReview-Commit-ID: HKYPkg78IOK
2018-01-22 11:49:42 -05:00
Coroiu Cristina
1affbb39f9 Backed out 2 changesets (bug 1429593) for for mass failing browser-chrome, e.g. browser/components/preferences/in-content/tests/browser_extension_controlled.js on a CLOSED TREE
Backed out changeset 9ce1b89f8744 (bug 1429593)
Backed out changeset fa845d221e7a (bug 1429593)
2018-02-07 16:03:58 +02:00
Bob Silverberg
bef60f3f6e Bug 1429593 - Part 2: Show that a WebExtension is managing the proxy config setting, r=jaws,mstriemer
Update the general page of about:preferences, as well as the Connection Settings panel, to show
when an extension is controlling proxy settings, and allow a user to disable the extension to
regain control.

MozReview-Commit-ID: HKYPkg78IOK
2018-01-22 11:49:42 -05:00
Gurzau Raul
82749346c0 Backed out 2 changesets (bug 1429593) for l10n issues
Backed out changeset 9dfaa0724a42 (bug 1429593)
Backed out changeset 20829d727fdf (bug 1429593)
2018-02-06 22:03:23 +02:00
Bob Silverberg
66f573d494 Bug 1429593 - Part 2: Show that a WebExtension is managing the proxy config setting, r=jaws,mstriemer
Update the general page of about:preferences, as well as the Connection Settings panel, to show
when an extension is controlling proxy settings, and allow a user to disable the extension to
regain control.

This also updates some of the strings to use the phrase "is controlling" rather than "controls".

MozReview-Commit-ID: HKYPkg78IOK
2018-01-22 11:49:42 -05:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Gijs Kruitbosch
57a7dfb2e1 Bug 1431428 - use DOM instead of innerHTML for extension messaging in prefs, r=jaws
MozReview-Commit-ID: JkG6zT8ADDU
2018-01-18 18:19:10 +00:00
Gijs Kruitbosch
b573a74932 Bug 1431471 - fix regexes for l10n parameter replacement in two places, r=flod
MozReview-Commit-ID: 3zQrmMmyrxV
2018-01-18 18:21:04 +00:00
Gijs Kruitbosch
0c0c685899 Bug 1430511, r=jaws 2018-01-17 00:08:32 +00:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Sebastian Hengst
0504876a9f merge mozilla-central to autoland. r=merge a=merge 2017-10-04 11:15:12 +02:00
Evan Tseng
3f6f918a23 Bug 1397737 - Show a "…" ellipsis if the width of search tooltip is over 150px to match visual design spec. r=mconley
The visual design suggestion is from https://bugzilla.mozilla.org/show_bug.cgi?id=1397737#c2.

MozReview-Commit-ID: 91iciz52s5d
2017-09-28 16:18:31 +08:00
Jared Wein
9f9da51c53 Bug 1405009 - Show a critters postcard when searching for firefox-emoji. r=mconley
This patch doesn't perform any transitions or animations on the postcard. Those could be handled in a follow-up, though I tried to implement it transitioning background-size but that isn't possible using 'contain' (or any keywords for that matter).

MozReview-Commit-ID: 4fpGaLK3oFK
2017-10-02 15:29:13 -04:00
Ricky Chien
f5476d5344 Bug 1397723 - Correct Preferences search matching approach for search feature r=mconley
MozReview-Commit-ID: 1t8oXYvwHbl
2017-09-11 21:50:20 +08:00
Ricky Chien
6bbcb028a8 Bug 1349689 - Remove old preferences fork r=jaws
MozReview-Commit-ID: GNPcQGUTUKJ
2017-08-21 17:48:18 +08:00
Sebastian Hengst
c97c631ff5 Backed out changeset df8215261c7e (bug 1349689) on request from rchien. r=backout 2017-08-31 16:58:32 +02:00
Ricky Chien
4dd95d9a6c Bug 1349689 - Remove old preferences fork r=jaws
MozReview-Commit-ID: GNPcQGUTUKJ
2017-08-21 17:48:18 +08:00
Timothy Guan-tin Chien
3a021a04eb Bug 1363850 - Part I, Move new about:preferences from in-content/ to in-content-new/, r=jaws,mconley
MozReview-Commit-ID: ButUfsGP7lS
2017-05-25 18:31:41 +08:00
Evan Tseng
5527d17651 Bug 1366252 - Include the URL of the support page in the error message of the no-results-found view of about:preferences search. r=jaws,mconley
MozReview-Commit-ID: 8WkMtMhN74B
2017-05-22 15:26:16 +08:00
Sebastian Hengst
79191790bd merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: CEadD9RweN4
2017-05-27 10:00:59 +02:00
Ricky Chien
5095deba28 Bug 1366148 - Making menulist and menupopup highlightable r=jaws,mossop
MozReview-Commit-ID: 14HG16oPb0g
2017-05-20 00:09:25 +08:00
Evan Tseng
e561ae7f80 Bug 1352481 - Add searchkeywords attributes for subdialog buttons and search the keywords in the searchWithinNode method. r=jaws
MozReview-Commit-ID: HM6HPLM5wPj
2017-05-09 17:00:45 -04:00
Evan Tseng
03baded465 Bug 1366214 - Add a new result not found string for Windows. r=jaws,mconley
MozReview-Commit-ID: pSICMLRDPS
2017-05-19 19:48:41 +08:00
Ricky Chien
6526d61612 Bug 1351867 - Show search tooltip on top of button r=mconley
MozReview-Commit-ID: HKbcs0kXLGq
2017-05-09 22:32:26 +08:00
Evan Tseng
b758e96b06 Bug 1365259 - Update the result not found message. r=mconley
MozReview-Commit-ID: 3vmUP0GVbgy
2017-05-17 18:36:54 +08:00
Timothy Guan-tin Chien
5c98b75f03 Bug 1360500 - Allow custom colors on find selection type selections. r=jaws,masayuki,smaug
This patch implements chrome-only Selection#setColors and
Selection#resetColors methods, and use it to set the background color of
the preferences search highlight.

MozReview-Commit-ID: 2U92aBCAyeh
2017-05-10 10:48:50 -04:00
Wes Kocher
9400d843cd Merge m-c to autoland, a=merge 2017-05-09 14:59:18 -07:00