Commit Graph

47 Commits

Author SHA1 Message Date
Diego Pino Garcia
18ddf70c69 Bug 1429198 - Account for supportedNetworks in payment modifiers. r=MattN 2018-12-20 07:24:00 +02:00
Margareta Eliza Balazs
0fc8f9feae Backed out changeset 3fcc7597cd8d (bug 1429198) for ES lint failure in builds/worker/checkouts/gecko/browser/components/payments/res/paymentRequest.js. CLOSED TREE 2018-12-18 15:50:33 +02:00
Diego Pino Garcia
28e3196dab Bug 1429198 - Account for supportedNetworks in payment modifiers. r=MattN 2018-12-17 22:15:00 +02:00
Jared Wein
31ab1285a6 Bug 1477113 - Dispatch paymentmethodchange event from the front-end. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D13740
2018-12-13 18:48:54 +00:00
Narcis Beleuzu
1cc9bcfe4d Backed out changeset 3fa420b71260 (bug 1477113) for bc failures on browser_total.js. CLOSED TREE 2018-12-13 09:53:39 +02:00
Jared Wein
aa27d08ad7 Bug 1477113 - Dispatch paymentmethodchange event from the front-end. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D13740
2018-12-13 06:35:30 +00:00
Matthew Noorenberghe
524f79da6b Bug 1495549 - Clear merchant payer errors when the payer address changes. r=jaws
Depends on D12605

Differential Revision: https://phabricator.services.mozilla.com/D12606
2018-12-11 18:17:31 +00:00
Sam Foster
7328d3a035 Bug 1481481 - Create separate forms for shipping, payer and billing address r=MattN
* New AddressForm instances for each address type
* Move selected-state-key out of state for the address forms, and into an attribute
* Remove passing form title via state, just use data-title-edit and data-title-add on the element
* Remove shippingOption form title logic from address picker, just set the right attribute values from PaymentDialog
* Move setting the extraRequiredFields data attribute the payer form needs out to the payment-dialog's render.
* Amend onboarding logic to direct to billing address form when necessary
* Fix-up tests

Differential Revision: https://phabricator.services.mozilla.com/D11545
2018-11-21 19:23:27 +00:00
Matthew Noorenberghe
f58782ffe4 Bug 1435880 - Send temporary records in paymentDialogWrapper.initializeFrame. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D11345
2018-11-15 15:04:24 +00:00
Marcos Cáceres
2e3d3f3d23 Bug 1504032 - Remove concept of card types, supportedTypes, BasicCardType enum r=MattN,baku
The concept of card types, supportedTypes, BasicCardType enum, were removed from the Basic Card spec.

Differential Revision: https://phabricator.services.mozilla.com/D10646
2018-11-10 06:59:26 +00:00
Matthew Noorenberghe
6e2f8bf159 Bug 1482689 - Don't import payment-dialog.js from other elements. r=sfoster
Importing payment-dialog.js ends up importing every other element because it imports the elements needed to render the full dialog.
We don't want all of our elements to depend on every other payment one so we shouldn't import payment-dialog.js anywhere in non-test code.

Differential Revision: https://phabricator.services.mozilla.com/D10576
2018-11-06 00:19:10 +00:00
Cosmin Sabou
a752eeafc6 Backed out 2 changesets (bug 1482689) for browser chrome failures on browser_address_edit.js
Backed out changeset 61b49da4b9cb (bug 1482689)
Backed out changeset c810cab5dbdb (bug 1482689)
2018-11-05 18:28:15 +02:00
Matthew Noorenberghe
9660687fde Bug 1482689 - Don't import payment-dialog.js from other elements. r=sfoster
Importing payment-dialog.js ends up importing every other element because it imports the elements needed to render the full dialog.
We don't want all of our elements to depend on every other payment one so we shouldn't import payment-dialog.js anywhere in non-test code.

Differential Revision: https://phabricator.services.mozilla.com/D10576
2018-11-01 22:01:50 +00:00
Matthew Noorenberghe
a163a3d254 Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D7934
2018-10-20 03:39:32 +00:00
Gurzau Raul
85dbd96c60 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-10-20 01:09:52 +03:00
Diego Pino Garcia
342c880959 Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN
Also require basicCardPage has a selectedStateKey
2018-10-18 23:56:00 +03:00
Noemi Erli
4114fb4906 Backed out changeset 8b3b53341da2 (bug 1497514) for failures in browser/components/payments/test/mochitest/test_basic_card_form.html 2018-10-19 03:50:32 +03:00
Diego Pino Garcia
edba6d8e8e Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN
Also require basicCardPage has a selectedStateKey
2018-10-18 15:25:49 -07:00
Jared Wein
d99da117e9 Bug 1494551 - Sort the formautofill data by the last used time. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D9174
2018-10-19 17:00:31 +00:00
Brindusan Cristian
9d31304003 Backed out 2 changesets (bug 1435871) for multiple browser-chrome failures on payments. CLOSED TREE
Backed out changeset 0f7592b662e2 (bug 1435871)
Backed out changeset 039f6d65036e (bug 1435871)
2018-10-19 12:36:13 +03:00
Matthew Noorenberghe
ec5cf1bb78 Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D7934
2018-10-19 05:06:22 +00:00
Dorel Luca
4d4a327178 Backed out 3 changesets (bug 1435871) for mochitest crashes. CLOSED TREE
Backed out changeset 8eab3320b8c5 (bug 1435871)
Backed out changeset 29777ddd9def (bug 1435871)
Backed out changeset afdc3066f12c (bug 1435871)
2018-10-17 23:06:14 +03:00
Matthew Noorenberghe
a92837e447 Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D7934
2018-10-17 18:46:27 +00:00
Matthew Noorenberghe
6e28c07425 Bug 1435163 - Show the summary page after the processing page when retry() is called. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D7159
2018-09-29 00:17:50 +00:00
Sam Foster
fef72bdc39 Bug 1477102 - Toggle accepted cards list on add/edit cards. Add stub for using AppConstants.MOZILLA_OFFICIAL to fallback for non-branded builds. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D7025
2018-09-28 16:53:37 +00:00
Matthew Noorenberghe
3b00cb1745 Bug 1432939 - Link to Firefox Options/Preferences from the PaymentRequest dialog. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D6724
2018-09-25 17:26:38 +00:00
Sam Foster
4b5fb70b7e Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824
2018-09-19 18:15:11 +00:00
Bogdan Tara
c104128b3d Backed out changeset 7351a4c8d1a1 (bug 1429181) for multiple payment-related failures CLOSED TREE 2018-09-15 00:58:48 +03:00
Sam Foster
579931d05b Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824
2018-09-14 20:28:41 +00:00
Matthew Noorenberghe
ef8f325b1c Bug 1476204 - Handle autofill record update state changes in the unpriv. PR forms. r=jaws
This is easier to understand as we don't have to round-trip the whole success and error states to the privileged wrapper which could potentially lead to stale state changes.
This is also much simpler for the basic-card-form as it doesn't need a lot of the complexity of the previous implementation.

* Move selectedStateKey from page to address-page since it doesn't apply to basic-card-page

MozReview-Commit-ID: B4kiZNWElGI
2018-07-25 12:37:51 -07:00
Cosmin Sabou
4d1b71eee6 Backed out 5 changesets (bug 1476204) for browser chrome failures on browser_editCreditCardDialog. CLOSED TREE
Backed out changeset 10f3d1014592 (bug 1476204)
Backed out changeset a88879ea32e8 (bug 1476204)
Backed out changeset 001f13f2dd21 (bug 1476204)
Backed out changeset f0f464e3c27c (bug 1476204)
Backed out changeset ed92000eca20 (bug 1476204)
2018-07-26 04:12:56 +03:00
Matthew Noorenberghe
9e3276d213 Bug 1476204 - Handle autofill record update state changes in the unpriv. PR forms. r=jaws
This is easier to understand as we don't have to round-trip the whole success and error states to the privileged wrapper which could potentially lead to stale state changes.
This is also much simpler for the basic-card-form as it doesn't need a lot of the complexity of the previous implementation.

* Move selectedStateKey from page to address-page since it doesn't apply to basic-card-page

MozReview-Commit-ID: B4kiZNWElGI
2018-07-25 12:37:51 -07:00
Sam Foster
b0eaf62f75 Bug 1447777 - Add completion fail and timeout error pages. r=MattN
* A new CompletionErrorPage / completion-error-page element which represents the content of the completion error
* Leave the dialog open when complete() results in a 'fail' or 'timeout'.
* The 'done' button on the fail & timeout error page closes the dialog by sending a message up to the paymentDialogWrapper.
* Rewrite the pay button rendering logic to ensure it is disabled when it should be
* Retry handling and UI not addressed here. Will need a new bug when the DOM support has landed.
* Extend completeStatus support in debugging.html and group like actions to tidy up a bit

MozReview-Commit-ID: GDhJqrj14uT

* Add tests to verify that the dialog stays open when completion fails or times out
* Add tests to verify that complete() throws after the timeout
* Rework completeStatus mochitest for PaymentDialog

MozReview-Commit-ID: 4ZNVEYMp7h5
2018-07-20 15:51:52 -07:00
prathiksha
5d1a79ec4d Bug 1462779 - Auto-select appropriate addresses in select dropdowns in on-boarding forms. r=MattN
MozReview-Commit-ID: 5Lm3djwSeuG
2018-05-23 16:24:58 -07:00
prathiksha
d0213418ea Bug 1462779 - Show the billing address page during on-boarding if requestShipping is false and there are no saved addresses. r=MattN
MozReview-Commit-ID: E7KM4cIielG
2018-05-18 16:44:25 -07:00
prathiksha
516cc3b7a1 Bug 1461886 - Pass appropriate properties to the FTU onboarding address page. r=MattN
MozReview-Commit-ID: Fn8beZELyFG
2018-05-17 17:41:25 -07:00
Jared Wein
33bb7942c7 Bug 1429180 - Option to use a new billing address when adding a new payment method. r=MattN
MozReview-Commit-ID: 5LrpUw1LdT3
2018-05-10 15:12:01 -04:00
Sam Foster
f37f93e022 Bug 1427960 - Add temporary addresses to state, add toggle to enable saving/not new addresses. r=MattN
* Implement store in paymentDialogWrapper for temporary addresses & creditCards
* Add the persist checkbox to the add/edit address form. Defaults to unchecked when adding an address in a private session.
* The union of saved and temporary addresses can be retrieved from paymentRequest.getAddresses(). References to state.savedAddresses updated to use this when appropriate
* New tests for adding and editing addresses from a private window


MozReview-Commit-ID: KyD2BPNFYtZ
2018-04-26 15:05:10 -07:00
prathiksha
68910b7193 Bug 1432927 - Show a payment card input form before the summary view for users without a saved payment card. r=MattN
MozReview-Commit-ID: BmGG8OFzCjJ
2018-05-17 19:37:17 -07:00
Csoregi Natalia
39a4f8dda5 Backed out changeset 3aa4ee6077c5 (bug 1432927) for failing on payments/test/mochitest/test_basic_card_form.html. CLOSED TREE 2018-05-18 05:26:12 +03:00
prathiksha
cb46300df5 Bug 1432927 - Show a payment card input form before the summary view for users without a saved payment card. r=MattN
MozReview-Commit-ID: BmGG8OFzCjJ
2018-05-11 12:26:54 -07:00
prathiksha
d844caead1 Bug 1432921 - Show an address input form before the summary view for users without a saved address.r=MattN
MozReview-Commit-ID: 3T25SXyIiGI
2018-05-09 13:26:47 -07:00
Cosmin Sabou
e90f819219 Backed out changeset 75ba8129c687 (bug 1432921) for mochitest e10s permafailures on browser_new_tab_insert_position.js (bug 1455882). 2018-05-15 06:30:17 +03:00
prathiksha
9723da33ec Bug 1432921 - Show an address input form before the summary view for users without a saved address.r=MattN
MozReview-Commit-ID: 3T25SXyIiGI
2018-05-09 13:26:47 -07:00
Cosmin Sabou
6919a38df5 Backed out changeset 513a4aafc42a (bug 1432921) for mochitest e-10s failures on test_address_form.html. CLOSED TREE 2018-05-14 21:23:07 +03:00
prathiksha
d2b566c8df Bug 1432921 - Show an address input form before the summary view for users without a saved address. r=MattN
MozReview-Commit-ID: 3T25SXyIiGI
2018-05-09 13:26:47 -07:00
Matthew Noorenberghe
0c8c81240e Bug 1457287 - Move Payment Request UI code to browser/. r=jaws
MozReview-Commit-ID: LjrRXr1thc8
2018-04-27 07:20:32 -07:00