Commit Graph

223 Commits

Author SHA1 Message Date
Trushita
19b14883c7 Bug 1494948: Removed FX_PREFERENCES_OPENED_VIA probe and origin parameter for openPreferences r=jaws,chutten
Removed FX_PREFERENCES_OPENED_VIA probe as it expired in 63.Origin parameter for openPreferences has also been removed.

Differential Revision: https://phabricator.services.mozilla.com/D26795
2019-04-09 20:40:26 +00:00
Brian Grinstead
4323ff9bed Bug 1495861 - Lazify panic panel and convert it to use FTL r=flod,Gijs
This is the only <radiogroup> and <radio> consumer in browser.xul.
By making the DOM get constructed on demand, we can avoid connecting
radios at startup, and it also gives us a chance to migrate the
strings to Fluent.

Differential Revision: https://phabricator.services.mozilla.com/D24914
2019-04-05 21:16:26 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Gijs Kruitbosch
5cf14463b7 Bug 1491243 - remove subscribe button, menu items and subscription section out of feed previews, r=florian
This removes subscribe UI and functionality from the main browser window,
the page info window, and from feed previews. It may leave some stray strings
in subscribe.properties/dtd, which will be removed in bug 1477669 when the
preview code goes away completely.

Differential Revision: https://phabricator.services.mozilla.com/D5982
2018-09-18 06:06:27 +00:00
Coroiu Cristina
7711c0dc3c Backed out changeset d61965849528 (bug 1491243) for en-US failures at testing\firefox-ui\tests\puppeteer\test_page_info_window.py 2018-09-17 22:23:58 +03:00
Gijs Kruitbosch
8b64dcadcd Bug 1491243 - remove subscribe button, menu items and subscription section out of feed previews, r=florian
This removes subscribe UI and functionality from the main browser window,
the page info window, and from feed previews. It may leave some stray strings
in subscribe.properties/dtd, which will be removed in bug 1477669 when the
preview code goes away completely.

Differential Revision: https://phabricator.services.mozilla.com/D5982
2018-09-17 18:06:05 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Tim Nguyen
37a93bb3d3 Bug 1485996 - Fix library panel with MOZ_BROWSER_XHTML on. r=bgrins 2018-08-24 15:21:28 +01:00
Brian Grinstead
c8b3483e82 Bug 1479538 - Rewrite non-test callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...);r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3275
2018-08-14 16:22:44 +00:00
Brian Grinstead
1c86f46ecd Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw
2018-08-08 15:22:53 -07:00
Mark Banner
efb967ef3e Bug 1453667 - Remove BrowserUITelemetry from other parts of browser/ r=Gijs
MozReview-Commit-ID: FG1PiVPBY5U
2018-06-06 19:42:19 +01:00
Kris Maglione
b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Andrea Marchesini
64b59e9bf0 Bug 1252998 - StorageActivityService - part 5 - nsIStorageActivityService::getActiveOrigins, r=asuth 2018-04-18 18:19:13 +02:00
Jonathan Kingston
ba541a6372 Bug 1453528 - Fix opening of synced tabs with correct principal. r=markh
MozReview-Commit-ID: 6MGXjsg3HmV
2018-04-12 18:06:13 +01:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja
2018-02-21 14:28:48 +00:00
Felipe Gomes
eada08dc14 Bug 1429161. Policy follow-up: hide instead of disabling the Forget button. r=jaws 2018-04-04 16:22:24 -03:00
Felipe Gomes
c476ab108d Bug 1429161 - Policy: Disable Forget Button. r=jaws 2018-04-03 15:39:35 -03:00
Edouard Oger
8578b6545b Bug 1184265 - Make last sync date be relative. r=markh
MozReview-Commit-ID: 2hB9F7Elynh
2018-03-20 17:08:16 -04:00
Gijs Kruitbosch
0ca6e1b639 Bug 1358815 - remove sync reflow from find bar initialization, r=jaws
This removes the sync reflow from almost all cases. The only case where we keep it is when a keypress
caught in content triggers a sync message to the parent process. We should clean this up in bug 1371523.

I've tried to fix the tests, but a lot of them seem to be disabled anyway...

MozReview-Commit-ID: 9k36p7q8MKy
2018-03-12 14:01:44 +00:00
Brindusan Cristian
a6e62d8ce3 Backed out 2 changesets (bug 1358815) for bc failures on browser_pdfjs_main.js CLOSED TREE
Backed out changeset 880736d97de3 (bug 1358815)
Backed out changeset a2a0a0990e1a (bug 1358815)
2018-03-15 21:23:12 +02:00
Gijs Kruitbosch
54e2568278 Bug 1358815 - remove sync reflow from find bar initialization, r=jaws
This removes the sync reflow from almost all cases. The only case where we keep it is when a keypress
caught in content triggers a sync message to the parent process. We should clean this up in bug 1371523.

I've tried to fix the tests, but a lot of them seem to be disabled anyway...

MozReview-Commit-ID: 9k36p7q8MKy
2018-03-12 14:01:44 +00:00
Mark Banner
75e89108e3 Bug 1442377 - Move fillSubviewFromMenuItems/clearSubview to CustomizableUI.jsm. r=Gijs
MozReview-Commit-ID: BQ8V39C68WO
2018-03-01 19:53:07 +00:00
Michael Kaply
97e2f5fdd4 Bug 1432355 - Add a policy to disable private browsing. r=Gijs
MozReview-Commit-ID: AprbL6usEv5
2018-03-01 10:20:38 -06:00
Edouard Oger
1a12c1fce4 Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s
2018-02-15 11:24:44 +08:00
Csoregi Natalia
5f4a31b802 Backed out changeset 22901b9f9199 (bug 1434706) for browser-chrome failures browser_contextmenu_sendtab.js. CLOSED TREE 2018-02-26 21:16:01 +02:00
Edouard Oger
cf78f22e8e Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s
2018-02-15 11:24:44 +08:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Gijs Kruitbosch
46574a4a0f Bug 1437486 - don't reset the forget button duration when the popup is visible, r=johannh
MozReview-Commit-ID: 6TWGSSuZxsa
2018-02-12 11:33:17 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Johann Hofmann
0013a2e800 Bug 1167238 - Part 3 - Clean up usage of sanitize.js to properly use Sanitizer.jsm. r=mak
This replaces all non-test usage of sanitize.js or legacy Sanitizer.jsm
to use the new Sanitizer.jsm module which does not hold internal state
and instead receives all configuration through function arguments (or by reading prefs).

MozReview-Commit-ID: KitMVptuIG3
2018-01-18 16:02:04 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Paolo Amadini
2f84510771 Bug 1432016 - Part 2 - Move descriptionHeightWorkaround and some other methods to the PanelView class. r=Gijs
MozReview-Commit-ID: 59fUuB35Ygy
2018-01-25 15:35:45 +00:00
Kris Maglione
1046270983 Backed out 3 changesets (bug 1431533) for Android mochitest bustage. CLOSED TREE
MozReview-Commit-ID: 5ubE9EMQpZ9
2018-01-24 22:04:59 -08:00
Kris Maglione
50ace7f99d Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
MozReview-Commit-ID: 8V1ZT53ReiP
2018-01-24 15:48:47 -08:00
Edouard Oger
b37abdbbae Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
MozReview-Commit-ID: 5vBKH9NejVV
2017-11-17 16:48:17 -05:00
Noemi Erli
beae1b7e61 Backed out changeset 932a77d8fbae (bug 1418466) for ES failures in /builds/worker/checkouts/gecko/browser/base/content/browser-sync.js r=backout on a CLOSED TREE 2017-11-30 18:44:16 +02:00
Edouard Oger
1ad5b3de66 Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
MozReview-Commit-ID: 5vBKH9NejVV
2017-11-17 16:48:17 -05:00
Gijs Kruitbosch
f4281f60f4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
MozReview-Commit-ID: L017kRfHfOv
2017-11-07 12:15:18 +00:00
Gijs Kruitbosch
fd9bc93522 Bug 1388029 - remove notion of 'wide' widget and panel columns from the tree, r=jaws
MozReview-Commit-ID: IrCB3zn1BIT
2017-11-07 12:00:18 +00:00
Thom Chiovoloni
62e7d64f8e Bug 1411794 - Fix bug where sync tabs panel would become permanently empty. r=eoger
MozReview-Commit-ID: 2mRAPhABCXA
2017-11-01 21:58:55 -04:00
Felipe Gomes
0f344c77d4 Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 2qNWebBpsMY
2017-10-17 13:39:50 -02:00
Ryan VanderMeulen
99112e9931 Backed out 5 changesets (bug 1407351) for causing bug 1409395 and breaking nightlies.
Backed out changeset e6ee25ad6a9f (bug 1407351)
Backed out changeset 8e04412824b5 (bug 1407351)
Backed out changeset effeee94316e (bug 1407351)
Backed out changeset a53f34a45f9b (bug 1407351)
Backed out changeset 86a360e12b8a (bug 1407351)
2017-10-17 10:07:55 -04:00
Felipe Gomes
3f29526da6 Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 8wbjdYIC3gb
2017-10-16 14:00:30 -02:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
c140faca84 Bug 1405377 - remove trailing separator in recently closed tabs/windows subviews, r=mikedeboer
The third param of 'getTabsFragment' and 'getWindowsFragment' toggles whether the 'restore all' item
gets prefixed (true) or suffixed (false). The prefixed version doesn't get a separator, so this
seems like the simplest fix.

MozReview-Commit-ID: BzKWvndWUMp
2017-10-03 19:29:36 +01:00
Jonathan Kingston
1406b7ee6f Bug 1400812 - Removal of containers drawer icon. r=baku,dao
MozReview-Commit-ID: JK2tB0ITRqY
2017-09-21 16:26:26 +01:00