Commit Graph

47 Commits

Author SHA1 Message Date
Paolo Amadini
34d57ee19b Bug 1527395 - Reduce timeout and don't search automatically until enough characters have been typed. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19546
2019-02-15 15:19:56 +00:00
Paolo Amadini
83c1e84553 Bug 1524779 - Use a separate button to show all preferences. r=mconley,flod
This allows interacting with the page without using the keyboard in the rare cases where this may be necessary. The button is ghosted because search is the preferred interaction.

Pressing ESC allows resetting the input field without the performance impact of showing all preferences.

Differential Revision: https://phabricator.services.mozilla.com/D19162
2019-02-18 13:30:31 +00:00
Paolo Amadini
05b8cf763a Bug 1524787 - Part 5 - Optimize incremental filtering and work around bug 1480477 in the new "about:config" page. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19515
2019-02-12 14:15:13 +00:00
Paolo Amadini
eb1c4bc37f Bug 1524787 - Part 4 - Sort the preferences list only when it changes. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19514
2019-02-12 14:08:04 +00:00
Paolo Amadini
32a0569bd1 Bug 1524787 - Part 3 - Only set the class name once when the state changes. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19513
2019-02-12 14:09:25 +00:00
Paolo Amadini
7870c1804b Bug 1524787 - Part 2 - Use an expando property instead of a WeakMap. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19512
2019-02-12 14:07:07 +00:00
Paolo Amadini
7f85244331 Bug 1524787 - Part 1 - Reduce calls to getElementById. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D19511
2019-02-12 14:05:27 +00:00
Paolo Amadini
7c3f058efe Bug 1526426 - Fix name and value cell padding in the new "about:config" page. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D19184
2019-02-11 16:01:30 +00:00
Paolo Amadini
d0633cc1c8 Bug 1524957 - Part 2 - Prevent autocomplete suggestions from other pages in the search field. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D18564
2019-02-04 15:58:47 +00:00
Paolo Amadini
1d1c9d9575 Bug 1524957 - Part 1 - Move the main content to a template. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D18563
2019-02-04 15:15:52 +00:00
Paolo Amadini
fe8561e7fd Bug 1524372 - Localize the preference type in the new "about:config" page. r=flod
Differential Revision: https://phabricator.services.mozilla.com/D18509
2019-02-04 15:13:14 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Paolo Amadini
4378d428ce Bug 1522115 - Prevent the new "about:config" search field from moving slightly when the page is scrolled. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D17392
2019-01-24 18:58:26 +00:00
Paolo Amadini
079664a5d3 Bug 1522168 - Part 2 - Reduce the number of calls to the preferences service. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D17505
2019-01-24 18:34:13 +00:00
Paolo Amadini
6fa2b6581d Bug 1522168 - Part 1 - Lazify the creation of table row elements. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D17504
2019-01-24 18:33:57 +00:00
Paolo Amadini
091d5c3366 Bug 1506382 - Make the new "about:config" page more easily navigable with accessibility technology. r=Jamie,flod
Differential Revision: https://phabricator.services.mozilla.com/D17125
2019-01-21 14:23:21 +00:00
Paolo Amadini
0bea314ea1 Bug 1520484 - Don't observe preference changes before the first search. r=mak
This fixes an intermittent failure due to preferences being added in the background.

Differential Revision: https://phabricator.services.mozilla.com/D16703
2019-01-16 15:00:45 +00:00
Paolo Amadini
c0518c4f6d Bug 1503540 - Don't show all values until the list is filtered. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D16693
2019-01-16 12:08:43 +00:00
Paolo Amadini
e1cae80e10 Bug 1501417 - Part 2 - Don't wait for the Enter key in the new "about:config" search field. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D16310
2019-01-15 14:37:30 +00:00
Paolo Amadini
92c704c70e Bug 1501417 - Part 1 - Use the search string set in previous sessions. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D16309
2019-01-15 14:22:16 +00:00
Paolo Amadini
08fd213a75 Bug 1501411 - Make sure that copying preference values from the new "about:config" page preserves whitespace. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D16056
2019-01-15 14:21:07 +00:00
Paolo Amadini
0866942da0 Bug 1501410 - Part 4 - Make the filter case insensitive. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15947
2019-01-08 15:08:04 +00:00
Paolo Amadini
eeeaba5787 Bug 1501410 - Part 3 - Detect changes in preferences. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15946
2019-01-08 15:26:11 +00:00
Paolo Amadini
3195240677 Bug 1501410 - Part 2 - Add support for recovering deleted preferences. r=bgrins
This updates the user interface for adding new preferences to be closer to the mockup, and makes deleted preferences more similar to rows that are not added yet. This will later make it simpler to react to external changes in the underlying data.

Differential Revision: https://phabricator.services.mozilla.com/D15945
2019-01-15 23:48:11 +00:00
Paolo Amadini
8b048e9f8f Bug 1501410 - Part 1 - Optimize the variables containing the global state. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15944
2019-01-08 15:25:49 +00:00
Paolo Amadini
1ff6dc860b Bug 1517507 - Part 4 - Move the editing code to the PrefRow class. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15665
2019-01-08 11:48:41 +00:00
Paolo Amadini
7ba2a00337 Bug 1517507 - Part 3 - Share the table row creation and update code. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15664
2019-01-08 11:48:29 +00:00
Paolo Amadini
da293fae2c Bug 1517507 - Part 2 - Improve validation of numeric input. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15663
2019-01-08 11:48:18 +00:00
Paolo Amadini
761fac9452 Bug 1517213 - Part 3 - Display the correct value when resetting a localized preference. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15567
2019-01-02 11:54:17 +00:00
Margareta Eliza Balazs
2e1ba73e8d Backed out 3 changesets (bug 1517213) for ES lint failure in /browser/components/aboutconfig/test/browser/browser_edit.js CLOSED TREE
Backed out changeset 798c09311606 (bug 1517213)
Backed out changeset 8dcd5d5e815d (bug 1517213)
Backed out changeset f0489fc1ef50 (bug 1517213)
2019-01-03 13:47:33 +02:00
Paolo Amadini
06fbd3a56d Bug 1517213 - Part 3 - Display the correct value when resetting a localized preference. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D15567
2019-01-02 11:54:17 +00:00
matthias
1d836e1ff7 Bug 1500542 - Added ability to disable the disclaimer page of the new about:config. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D13870
2018-12-13 14:26:20 +00:00
matthias
af8454d9ae Bug 1500536 - Added disclaimer page for the new about:config. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D13867
2018-12-13 14:25:28 +00:00
Luke Schwalfenberg
7ad57683e3 Bug 1502856 - Display locked preferences in a different style. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D12871
2018-11-29 14:19:29 +00:00
Vincent Cote
0256ace27c Bug 1497727 - Add ability to add prefs on new "about:config" page. r=paolo CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D12719
2018-11-28 22:09:16 +00:00
Csoregi Natalia
780940c566 Backed out changeset 4deb028f32d6 (bug 1497727) for eslint failure on browser_edit.js:44. CLOSED TREE 2018-11-29 00:00:08 +02:00
Vincent Cote
8ef9ea68fa Bug 1497727 - Add ability to add prefs on new "about:config" page. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D12719
2018-11-28 21:35:30 +00:00
matthias
b4838da124 Bug 1497726 - Add ability to modify prefs on new "about:config" page. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D12620
2018-11-28 20:40:01 +00:00
matthias
12693bf33c Bug 1501423 - Add ability to reset a modified pref on new "about:config" page. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D12230
2018-11-26 10:26:20 +00:00
Vincent Cote
af4ed376ec Bug 1501649 - Add ability to delete a user-created pref on new "about:config" page. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D11804
2018-11-22 22:07:05 +00:00
Luke Schwalfenberg
ab29370382 Bug 1497725 - Add a search field to the new "about:config" page. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D11843
2018-11-19 13:52:08 +00:00
matthias
6126f0b3f9 Bug 1500548 - Start to implement the design from the mockup. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D10930
2018-11-11 11:02:14 +00:00
Luke Schwalfenberg
a2d6c5543d Bug 1500162 - Display the default values of "localized" preferences. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D10326
2018-11-08 13:31:28 +00:00
Vincent Cote
13d797dc62 Bug 1497637 - Pull and display all settings into the new "about:config" page. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D8469
2018-10-30 09:48:32 +00:00
Vincent Cote
448f8dfd7f Bug 1493446 - Create a skeleton of the new internal settings HTML page. r=paolo,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D6573
2018-10-09 15:45:39 +01:00
Daniel Varga
50443c6a44 Backed out changeset e994da668be6 (bug 1493446) for ES linting failure. 2018-10-05 15:07:25 +03:00
Vincent Cote
f9429a5309 Bug 1493446 - Create a skeleton of the new internal settings HTML page. r=bgrins,paolo
Differential Revision: https://phabricator.services.mozilla.com/D6573
2018-10-05 10:41:49 +00:00