Commit Graph

14 Commits

Author SHA1 Message Date
L. David Baron
36f5fdb632 Bug 914253 patch 10 - Two more comment tweaks. No review.
DONTBUILD
2014-10-15 14:50:58 -07:00
Nicholas Nethercote
ca7b761d18 Bug 1062709 (part 2, attempt 2) - Clean up stack printing and fixing. r=dbaron. 2014-09-01 22:56:05 -07:00
Ed Morley
e379fd79fc Backed out changeset 7a1b7d7eba12 (bug 1062709) 2014-10-03 15:05:26 +01:00
Nicholas Nethercote
0d0952d622 Bug 1062709 (part 2) - Clean up stack printing and fixing. r=dbaron. 2014-09-01 22:56:05 -07:00
Nicholas Nethercote
f30e108c5e Bug 1050601 - Remove fix-linux-stack.pl. r=ted. 2014-09-03 09:24:38 -07:00
L. David Baron
224807e91d Bug 914253 patch 9 - Implement CRC checking for .gnu_debuglink section. No review.
This is needed to avoid regressions relative to the perl version because
the perl version failed, due to a missing /, to properly examine two of
the paths, one of which often yields the same filename as the original
file (but whose CRC will fail).

I've tested that this CRC calculation succeeds in cases where it should
succeed.

The observed CRC check failures (so far) on my Ubuntu 14.04 system are
the following links:
  /lib/x86_64-linux-gnu/libc.so.6 -> /lib/x86_64-linux-gnu/libc-2.19.so
  /lib/x86_64-linux-gnu/libpthread.so.0 -> /lib/x86_64-linux-gnu/libpthread-2.19.so
  /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 -> /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0.2400.23
  /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 -> /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0.2400.23
which succeed on a later possibility in /usr/lib/debug/.  But optimizing
to check f != file before checking the CRC wouldn't help because of the
naming differences due to symlinks, so I didn't bother.  If we ever want
to optimize away the time doing the CRC checks for these failures, we
could do so by checking if the files are the same path *after* resolving
symlinks.

DONTBUILD
2014-08-06 19:21:44 -07:00
L. David Baron
85cae8fd5e Bug 914253 patch 8 - Ignore useless results from addr2line and keep what we had before, like fix-linux-stack.pl does. No review.
DONTBUILD
2014-08-06 19:21:43 -07:00
L. David Baron
31f139b455 Bug 914253 patch 7 - Remove some debugging code and the remnants of the old address adjustment code. No review.
DONTBUILD
2014-08-06 19:21:43 -07:00
L. David Baron
8f4bac4625 Bug 914253 patch 6 - Linux stacks are lowercase hexidecimal (although this was temporarily not true due to bug 939610, which is probably when mccr8 started fix_linux_stack.py). No review. 2014-08-06 15:52:49 -07:00
L. David Baron
a469e9fd63 Bug 914253 patch 5 - Implement caching of addr2line results, like bug 812070 did for fix-linux-stack.pl. No review. 2014-08-06 15:52:49 -07:00
L. David Baron
b7b9ca6f7f Bug 914253 patch 4 - Implement address adjustment for fix_linux_stack.py. No review. 2014-08-06 15:52:48 -07:00
L. David Baron
fdce96913d Bug 914253 patch 3 - Implement separate debug info for fix_linux_stack.py, including the addition of support for .note.gnu.build-id sections that fix-linux-stack.pl did not support. No review. 2014-08-06 15:52:48 -07:00
L. David Baron
484085004b Bug 914253 patch 2 - Pull opening comment from fix-linux-stack.pl. No review. 2014-08-06 15:52:48 -07:00
Andrew McCreight
2231e505ed Bug 914253 patch 1 - Initial version of fix_linux_stack.py, based on slightly old version of fix_macosx_stack.py. No review. 2014-08-06 15:52:48 -07:00