Commit Graph

14 Commits

Author SHA1 Message Date
Patrick Brosset
6e4f4ac7bd Bug 1147826 - Remove deprecated TabActor reference in runAt:server GCLI commands; r=jwalker; r=miker
We used to rely on the TabActor a lot in
/toolkit/devtools/server/actors/highlighter.
This object was being passed around to various highlighter classes, helper
classes and functions.
It was a useful way to get access to the window the highlighters are shown,
listen to DOM events in that window, and also listen to tabActor's will-navigate
events.

Using this object isn't the best idea because it assumes the debugger server is
started and attached to a tab, which makes re-using highlighters outside of this
context impossible (or harder).
Plus we wanted to get rid of the tabActor reference in gcli command contexts.

This change introduces a HighlighterEnvironment that fulfills the requirements
above without relying on a tabActor.
It needs to be initialized either with a tabActor, when we have one (when using
the highlighter from the inspector panel), or with a window (which is what gcli
commands will use).

This change also fixes the highlight command and the rulers command (which
didn't work well with e10s either).
2015-06-01 14:41:12 +02:00
Tom Tromey
a4d7a5bc76 Bug 1168088 - Remove SpiderMonkey-specific syntax from toolkit/devtools. r=pbrosset 2015-05-28 11:54:00 -04:00
J. Ryan Stinnett
c82b924e48 Bug 1160361 - Move commands-index to the server. r=bgrins 2015-05-06 12:34:27 -05:00
J. Ryan Stinnett
acdd29b779 Bug 1157906 - Can't return arrays as a root response, fixes inspect button. r=bgrins 2015-04-27 15:13:00 -04:00
Joe Walker
cb03960f98 Bug 1128988 - runAt support for commands/converters; r=bgrins 2015-04-23 10:24:49 +01:00
Alexandre Poirot
f3185733bc Bug 988237 - Convert all protocol.js actors to lazy loading. r=past 2014-09-16 06:00:00 -04:00
Jan Keromnes
11cf04de29 Bug 1009312 - Remove duplicate calls to addActorPool. r=dcamp 2014-07-02 10:46:00 +02:00
Vikneshwar
ee78456672 Bug 1003546 - Use Arrow function instead of bind(). r=fitzgen 2014-06-14 06:49:00 -04:00
643eb1e985 Bug 859372 - Refactor Services.jsm;r=past 2014-03-13 16:01:32 +01:00
Joe Walker
c034c93275 Bug 933727 - Split gcli.jsm and use JS directly from gcli project; r=mratcliffe
* * *
Bug 933727 - Update Developer Toolbar to use promises and split out GCLI; r=mratcliffe
* * *
Bug 933727 - Update GCLI tests to use Task.spawn; r=mratcliffe
* * *
Bug 933727 - Update the Inspector to use split out GCLI; r=pbrosset
* * *
Bug 933727 - Update style editor to use split out GCLI; r=harth
* * *
Bug 933727 - Update Debugger to use split out GCLI; r=past
* * *
Bug 933727 - Update Profiler/Tilt/Scratchpad to use split out GCLI; r=valueof
2013-09-03 12:20:27 +01:00
Philipp Kewisch
494fbfe095 Fix bug 880930 - JS debugger: RootActor needs its own definition of windowMediator. r=past 2013-09-21 11:38:32 +02:00
Jim Blandy
258117e2e6 Bug 914753: Remove 'Mode: js2' markers from DevTools JavaScript files. Emacs has better ways to select the file's mode. DONTBUILD r=dcamp 2013-09-10 18:43:44 -07:00
Joe Walker
d9434ec7a0 Bug 874821 - Enable better remote gcli testing; r=mratcliffe 2013-05-25 09:51:31 +01:00
Dave Camp
a855b97cb8 Bug 872091 - Rename files in the debugger server. r=past,r=jimb 2013-05-21 16:39:13 -07:00