Commit Graph

7 Commits

Author SHA1 Message Date
Patrick Brosset
6e4f4ac7bd Bug 1147826 - Remove deprecated TabActor reference in runAt:server GCLI commands; r=jwalker; r=miker
We used to rely on the TabActor a lot in
/toolkit/devtools/server/actors/highlighter.
This object was being passed around to various highlighter classes, helper
classes and functions.
It was a useful way to get access to the window the highlighters are shown,
listen to DOM events in that window, and also listen to tabActor's will-navigate
events.

Using this object isn't the best idea because it assumes the debugger server is
started and attached to a tab, which makes re-using highlighters outside of this
context impossible (or harder).
Plus we wanted to get rid of the tabActor reference in gcli command contexts.

This change introduces a HighlighterEnvironment that fulfills the requirements
above without relying on a tabActor.
It needs to be initialized either with a tabActor, when we have one (when using
the highlighter from the inspector panel), or with a window (which is what gcli
commands will use).

This change also fixes the highlight command and the rulers command (which
didn't work well with e10s either).
2015-06-01 14:41:12 +02:00
J. Ryan Stinnett
74a55bb480 Bug 1160361 - Move gclicommands.properties to toolkit. r=bgrins 2015-05-06 12:34:27 -05:00
Joe Walker
cb03960f98 Bug 1128988 - runAt support for commands/converters; r=bgrins 2015-04-23 10:24:49 +01:00
Matteo Ferretti
2911ff72d8 Bug 1127238 - Remove the hard-coded list of highlighters; r=pbrosset CLOSED TREE 2015-02-03 13:03:33 +01:00
Vikneshwar
e29c882fbc Bug 1043896 - Use proper plural form for highlightOutputConfirm. r=pbrosset r=jwalker 2014-10-16 09:28:00 +02:00
Patrick Brosset
39f6247a54 Bug 985597 - Tests for the new highlighter implementation using the AnonymousContent API; r=miker r=jwalker 2014-11-06 13:04:37 +01:00
Patrick Brosset
d0fc045adb Bug 971662 - part 1 - GCLI command that highlights all nodes that match a selector; r=jwalker 2014-06-25 16:40:43 +02:00