Commit Graph

60 Commits

Author SHA1 Message Date
Birunthan Mohanathas
a29151dc87 Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
2015-07-13 08:25:42 -07:00
Daniel Holbert
1e9f98ed0f Bug 1158290 part 1: Use AvailableBSize instead of AvailableHeight, throughout flex layout. r=mats
This patch was auto-generated, with the following command:
  sed -i "s/vailableHeight/vailableBSize/g" nsFlexContainerFrame.*
2015-05-12 13:34:22 -07:00
Ehsan Akhgari
ea41d8de48 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Daniel Holbert
d2806a679f Bug 1054010: Skip final reflow for flex items that receive an earlier 'measuring reflow' with the right size. r=mats 2015-01-23 14:15:11 -08:00
Daniel Holbert
3d22b12f29 Bug 1054054 part 2: Add "a" prefix to args which were formerly local variables, in ReflowFlexItem. r=mats 2015-01-23 10:25:59 -08:00
Daniel Holbert
0462ecf681 Bug 1054054 part 1: Split out code for doing final reflow of each flex item into its own helper-function, "ReflowFlexItem". r=mats 2015-01-23 10:25:58 -08:00
Ehsan Akhgari
8bb87f8a27 Bug 1060985 - Fix more bad implicit constructors in layout; r=roc 2014-08-31 23:36:37 -04:00
Jonathan Kew
c7e5b8d9dc bug 1031241 pt 1 - Rename Get{Min,Pref}Width to Get{Min,Pref}ISize throughout layout. r=dbaron,smontagu 2014-07-24 18:03:25 +01:00
Daniel Holbert
c491e60cd0 Bug 1015474 part 1: Update behavior of "min-width:auto"/"min-height:auto" to match current spec text. r=mats
This updates min-width:auto / min-height:auto to now take several more things
into account, beyond just a flex item's min-content size. Now we'll also
consider its used 'flex-basis', its main max-size property ('max-width' or
'max-height'), and its intrinsic ratio & any constraints in the other
dimension.
2014-07-22 08:24:37 -07:00
Daniel Holbert
d8c8198b57 Bug 1037177 part 5: Update documentation for GenerateFlexItemForChild & helpers. (comment-only, no review) 2014-07-22 08:24:36 -07:00
Daniel Holbert
a7518880cb Bug 1037177 part 3: Split out flexbox's auto-height-measuring code into its own dedicated function. r=mats 2014-07-22 08:24:36 -07:00
Daniel Holbert
606dbe7c7a Bug 1037177 part 2: Rename ResolveFlexItemMaxContentSizing to ResolveAutoFlexBasisAndMinSize. r=mats 2014-07-22 08:24:36 -07:00
Birunthan Mohanathas
aa6d74fac6 Bug 1026535 - Fix mismatched class/struct tags. r=ehsan 2014-06-18 17:57:51 -07:00
Daniel Holbert
ad9e4a6eed Bug 1024875: Make reflow-related functions in nsFlexContainerFrame return void, now that Reflow returns void. r=mats 2014-06-13 08:37:02 -07:00
Mats Palmgren
a26b4d368e Bug 508665 - part 4, Make nsCSSFrameConstructor use nsContainerFrame* for frames used as parent frames. r=roc 2014-05-24 22:20:40 +00:00
Mats Palmgren
84ce46d68c Bug 1008917 - part 2,3,4, make Reflow() return type 'void', and make a few reflow related helper methods 'void' too. r=roc 2014-05-13 00:47:52 +00:00
Wes Kocher
2669e87017 Backed out 11 changesets (bug 1008917) for apparently introducing an intermittent failure of B2G Crashtest-2 on a CLOSED TREE
Backed out changeset e2ab653f688a (bug 1008917)
Backed out changeset b52154d8d900 (bug 1008917)
Backed out changeset 2ab5b01da4de (bug 1008917)
Backed out changeset f7a38df1d44f (bug 1008917)
Backed out changeset 80304bb9a572 (bug 1008917)
Backed out changeset 10ed89a302e9 (bug 1008917)
Backed out changeset 161c41991d46 (bug 1008917)
Backed out changeset 25b2475d2368 (bug 1008917)
Backed out changeset b8000b31277c (bug 1008917)
Backed out changeset 9afa5e7715e1 (bug 1008917)
Backed out changeset 5c380c21351f (bug 1008917)
2014-05-12 15:47:41 -07:00
Mats Palmgren
4a79e08cae Bug 1008917 - part 2,3,4, make Reflow() return type 'void', and make a few reflow related helper methods 'void' too. r=roc 2014-05-12 17:40:28 +00:00
Daniel Holbert
16289b589e Bug 983434 part 2: Store FlexLines and FlexItems in MFBT LinkedLists instead of nsTArrays. r=mats 2014-03-18 09:23:23 +08:00
Daniel Holbert
241b2ff854 Backed out c5dc2de8d224 (Bug 983434 part 2) for Linux static-analysis build bustage
CLOSED TREE
2014-03-18 07:27:52 +08:00
Daniel Holbert
52e72cbc5f Bug 983434 part 2: Store FlexLines and FlexItems in MFBT LinkedLists instead of nsTArrays. r=mats 2014-03-18 06:09:41 +08:00
Kyle Huey
d2629a316e Bug 981150: Use nsTArrayForwardDeclare.h more. r=ehsan 2014-03-15 12:00:17 -07:00
Daniel Holbert
cdc41fd5d4 Bug 981116: Convert nsFlexContainerFrame boolean member-var into frame state bit. r=heycam 2014-03-07 15:58:38 -08:00
Daniel Holbert
4831ca068a Bug 919806 followup: Reindent method declarations affected by NS_IMETHOD-removal. (whitespace-only; no review) DONTBUILD 2014-02-18 00:36:33 -08:00
Arnaud Sourioux
c55abda61c Bug 919806: Get rid of NS_IMETHOD in nsIFrame.h and its implementations r=dholbert 2014-02-17 23:47:48 -08:00
Daniel Holbert
d92d1282ec Bug 969147: Compute (and sum) the cross sizes of flex lines as we go, to make pagination easier. r=mats 2014-02-06 17:04:52 -08:00
Daniel Holbert
5a213feb80 Bug 962267: Move nsFlexContainerFrame.h's forward-decls into the class's scope. r=mats 2014-01-21 17:05:07 -08:00
Daniel Holbert
2e91b802d2 Bug 783470 part 3: Use the strut metadata we've saved to actually build special "strut" FlexItems on our second pass through reflow. r=mats 2014-01-21 14:52:27 -08:00
Daniel Holbert
be46fc6d33 Bug 783470 part 2: Create an array with information about each visibility:collapse "strut" that we need to build. r=mats 2014-01-21 14:51:58 -08:00
Daniel Holbert
3169f97bdf Bug 783470 part 1: Split most of flex reflow into a helper-function, so that we can easily restart it by reinvoking that helper. r=mats 2014-01-21 14:51:57 -08:00
Mats Palmgren
a56486443d Bug 956447 - Make it possible to get frame dumps in non-DEBUG builds. r=roc 2014-01-05 23:31:14 +00:00
Daniel Holbert
45747d24e3 Bug 946269: Rename nsFlexContainerFrame::ComputeFlexContainerCrossSize to ComputeCrossSize. implicit-rs=mats 2013-12-06 13:38:49 -08:00
Daniel Holbert
d2313386a2 Bug 939901 part 4: Make the flexbox reflow code loop over the FlexLines, rather than just working with one FlexLine. r=mats 2013-12-05 10:57:51 -08:00
Daniel Holbert
c6bf822085 Bug 939901 part 3: When generating FlexLines, wrap at page-breaks and at max-main-size. r=mats 2013-12-05 10:57:51 -08:00
Daniel Holbert
6ea4ab68f1 Bug 939901 part 2: Convert GenerateFlexItems into GenerateFlexLines, wrapping new FlexItems to new FlexLines when we run out of space in container's main axis. r=mats 2013-12-05 10:57:51 -08:00
Daniel Holbert
46c88102a1 Bug 939896 part 7: Move ResolveFlexibleLengths() to live on FlexLine. r=mats 2013-11-26 10:27:52 -08:00
Daniel Holbert
cf7a70cfbe Bug 939896 part 6: Make ComputeFlexContainerMainSize take a FlexLine. r=mats 2013-11-26 10:27:52 -08:00
Daniel Holbert
ed50b5c4c2 Bug 939896 part 5: Move PositionItemInMainAxis to live on FlexLine, and make it position all the line's items. r=mats 2013-11-26 10:27:52 -08:00
Daniel Holbert
17fe5f28aa Bug 939896 part 4: Move PositionItemInCrossAxis to live on FlexLine, and make it position all the line's items. r=mats 2013-11-26 10:27:52 -08:00
Daniel Holbert
c4903654ec Bug 939896 part 3b: Keep track of line cross-size and baseline-alignment offset in FlexLine instead of in (more ephemeral) SingleLineCrossAxisPositionTracker. r=mats 2013-11-26 10:27:51 -08:00
Daniel Holbert
3f3b41c6d7 Bug 939896 part 1: Introduce a FlexLine object, which manages a nsTArray of FlexItems on a single line in a flex container. r=mats 2013-11-26 10:27:50 -08:00
Daniel Holbert
623bdff49b Bug 811024 part 3: Split horizontal flex containers whose cross size (height) is larger than available height (and refactor cross-size computation). r=mats 2013-11-21 10:20:01 -08:00
Daniel Holbert
508bbd02b3 Bug 811024 part 2: Split vertical flex containers whose main size (height) is larger than available height. r=mats 2013-11-21 10:20:01 -08:00
Daniel Holbert
aa25acef99 (no bug) Fix a few whitespace issues in nsFlexContainerFrame.*
DONTBUILD because whitespace-only
2013-11-12 18:50:39 -08:00
Daniel Holbert
f3c99c7367 Bug 903880 part 2: Resolve the flex base size produced by "height:auto" *after* we create a FlexItem object. r=dbaron 2013-10-31 19:39:02 -07:00
Daniel Holbert
e85e587fb4 Bug 914937: Remove nsFlexContainerFrame::GetSkipSides, now that we can inherit a useful impl from nsSplittableFrame. r=mats 2013-09-11 13:54:44 -07:00
Ehsan Akhgari
06d49ffd4d Bug 907883 - Minimize #includes in layout/generic; r=roc 2013-08-22 14:32:52 -04:00
Scott Johnson
4006c68438 Bug 743402, Part 4: Refactor ApplySkipSides() and GetSkipSides() to return the correct value during reflow by adding an optional nsHTMLReflowState parameter. [r=roc] 2013-07-25 10:34:27 -05:00
Ryan VanderMeulen
12fbc93e27 Backed out 6 changesets (bug 743402) for reftest failures on a CLOSED TREE.
Backed out changeset 19848fff857e (bug 743402)
Backed out changeset 049168537ae0 (bug 743402)
Backed out changeset 3098fea37f2d (bug 743402)
Backed out changeset ada93e976dca (bug 743402)
Backed out changeset c7907c54187f (bug 743402)
Backed out changeset 2edbbf6440c4 (bug 743402)
2013-07-24 15:14:04 -04:00
Scott Johnson
1c74186f48 Bug 743402, Part 4: Refactor ApplySkipSides() and GetSkipSides() to return the correct value during reflow by adding an optional nsHTMLReflowState parameter. [r=roc] 2013-07-24 12:47:17 -05:00