Birunthan Mohanathas
a29151dc87
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
Timothy Nikkel
e657109f88
Bug 1159772. Don't let nsContainerFrame::SyncWindowProperties make widget calls that can result in synchronous painting during reflow or frame construction. r=mats
...
Specifically on Windows nsIWidget::SetTransparencyMode can result in sync painting.
So we give nsContainerFrame::SyncWindowProperties a sync or async option and use the view manager post pending update infrastructure to flush SyncWindowProperties calls async.
2015-05-04 14:29:19 -05:00
Jonathan Kew
3bdc0a8e35
Bug 1028716 part 2 - Handle the new orient values in <progress> and <meter> layout. r=smontagu
2014-06-27 11:25:11 +01:00
Jonathan Kew
3ab64637e3
Bug 1153140 - Include borderPadding width in the containerWidth for grid item placement. r=mats
2015-04-10 16:56:23 +01:00
Mats Palmgren
3f92be8fe8
Bug 1148833 part 3 - Remove nsIFrame::WillReflow and add a non-virtual MarkInReflow method instead that sets NS_FRAME_IN_REFLOW. Call it at the start of Reflow(). r=roc
2015-03-29 22:38:40 +00:00
Ehsan Akhgari
ea41d8de48
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Simon Montagu
a12bf47984
Bug 1079154 patch 4: Logical versions of ReflowChild and FinishReflowChild, r=jfkthame
2015-01-06 23:10:07 -08:00
Ehsan Akhgari
360626e7bf
Bug 1109705 - Fix more bad implicit constructors in layout; r=roc
2014-12-10 17:47:09 -05:00
Xidorn Quan
866c49eb53
Bug 1093998 - Make nsContainerFrame::CreateNextInFlow return the new frame instead of using an our param. r=dbaron
2014-12-01 22:03:57 -08:00
Xidorn Quan
71052dfdb0
Bug 1052924 - Implement basic line breaking for ruby. r=dbaron
...
Known problem:
It would cause infinite loop if there is any line break happens inside
ruby base or annotation, or the width of container is not enough for
the widest pair/span. This might be fixed in bug 1098272.
2014-11-26 15:52:50 +11:00
Jonathan Kew
423a0e9db5
bug 1046950 pt 3 - convert ComputeAutoSize to use logical-coordinate parameters. r=smontagu
2014-08-24 15:34:51 +01:00
Ehsan Akhgari
17f80c37f2
Bug 1048246 - Fix more bad implicit constructors in layout; r=roc
2014-08-07 19:48:38 -04:00
Jonathan Kew
fe8090d7de
bug 1031241 pt 3 - Also rename Intrinsic{Width,Height} to Intrinsic{I,B}Size. r=smontagu
2014-07-24 18:03:26 +01:00
Jonathan Kew
711a2298a4
bug 1031241 pt 2 - More renaming, e.g. where {Min,Pref}Width occurs within longer type and function names. r=smontagu
2014-07-24 18:03:25 +01:00
Mats Palmgren
6a38f78c53
Bug 1015781 - part 3, Fix whitespace and comments, and move some SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods so that they are together in the file. r=roc
2014-05-28 19:36:58 +00:00
Mats Palmgren
a43fc7a0a3
Bug 1015781 - part 1+2, Make the SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods return void (scripted change). Remove code handling the return values. r=roc
2014-05-28 19:36:58 +00:00
Mats Palmgren
cc70168e62
Bug 508665 - part 8, Move child frame insertion/removal methods from nsIFrame to nsContainerFrame. r=roc
2014-05-24 22:20:40 +00:00
Mats Palmgren
bebbaf8351
Bug 508665 - part 5, Make nsIFrame::Init require a nsContainerFrame* for the parent frame param. r=roc
2014-05-24 22:20:40 +00:00
Mats Palmgren
93a6cff703
Bug 508665 - part 3, Change GetContentInsertionFrame() to return a nsContainerFrame*, and return null for leaf frames. Deal with GetContentInsertionFrame() returning null in a couple of places. r=roc
2014-05-24 22:20:39 +00:00
Mats Palmgren
9018085f47
Bug 1008917 - part 13, make nsContainerFrame::ReflowOverflowContainerChildren() return type 'void'. r=roc
2014-05-13 00:47:53 +00:00
Mats Palmgren
e03220a2e3
Bug 1008917 - part 5,6,7, make ReflowChild() and FinishReflowChild() return type 'void', and make a few related helper methods 'void' too. r=roc
2014-05-13 00:47:53 +00:00
Wes Kocher
2669e87017
Backed out 11 changesets (bug 1008917) for apparently introducing an intermittent failure of B2G Crashtest-2 on a CLOSED TREE
...
Backed out changeset e2ab653f688a (bug 1008917)
Backed out changeset b52154d8d900 (bug 1008917)
Backed out changeset 2ab5b01da4de (bug 1008917)
Backed out changeset f7a38df1d44f (bug 1008917)
Backed out changeset 80304bb9a572 (bug 1008917)
Backed out changeset 10ed89a302e9 (bug 1008917)
Backed out changeset 161c41991d46 (bug 1008917)
Backed out changeset 25b2475d2368 (bug 1008917)
Backed out changeset b8000b31277c (bug 1008917)
Backed out changeset 9afa5e7715e1 (bug 1008917)
Backed out changeset 5c380c21351f (bug 1008917)
2014-05-12 15:47:41 -07:00
Mats Palmgren
01f0ccc901
Bug 1008917 - part 13, make nsContainerFrame::ReflowOverflowContainerChildren() return type 'void'. r=roc
2014-05-12 17:40:29 +00:00
Mats Palmgren
88bd1a0a98
Bug 1008917 - part 5,6,7, make ReflowChild() and FinishReflowChild() return type 'void', and make a few related helper methods 'void' too. r=roc
2014-05-12 17:40:29 +00:00
Tom Hindle
142520bca1
Bug 970363 - Make PeekOffset* methods return continue reason. r=roc
2014-03-13 08:14:37 -06:00
Simon Montagu
89f7fee0ce
Use logical text layout API in nsLineLayout. Bug 789096, r=jfkthame
2014-03-11 13:23:50 -07:00
Carsten "Tomcat" Book
db3b507cf9
Backed out changeset aeff4052ef00 (bug 789096)
2014-03-11 09:22:52 +01:00
Simon Montagu
c3baf9cc3b
Use logical text layout API in nsLineLayout. Bug 789096, r=jfkthame
2014-03-10 22:19:03 -07:00
Daniel Holbert
4831ca068a
Bug 919806 followup: Reindent method declarations affected by NS_IMETHOD-removal. (whitespace-only; no review) DONTBUILD
2014-02-18 00:36:33 -08:00
Arnaud Sourioux
c55abda61c
Bug 919806: Get rid of NS_IMETHOD in nsIFrame.h and its implementations r=dholbert
2014-02-17 23:47:48 -08:00
Daniel Holbert
e23dc237da
Bug 967287 part 2: Adjust indentation after removal of nsPresContext* args. r=mats
2014-02-06 14:07:48 -08:00
Daniel Holbert
ab988302aa
Bug 967287 part 1: Remove unnecessary nsPresContext* argument from functions defined in nsContainerFrame.h. r=mats
2014-02-06 14:07:47 -08:00
Timothy Nikkel
6d096d724f
Bug 962443. Make layout frame tree dumping code work better for Fennec and b2g. r=mats
2014-01-26 16:07:02 -06:00
Peiyong Lin
db78ce129a
Bug 959874 - Reorder two parameters in nsContainerFrame::FinishReflowChild(), for consistency with nsContainerFrame::ReflowChild(). r=dholbert
2014-01-16 17:34:44 -08:00
Mats Palmgren
a56486443d
Bug 956447 - Make it possible to get frame dumps in non-DEBUG builds. r=roc
2014-01-05 23:31:14 +00:00
Ehsan Akhgari
04b201052a
Bug 938849 - Build layout/generic in unified mode; r=roc
2013-11-15 08:19:02 -05:00
Mats Palmgren
d23a6f68b8
Bug 863935. r=roc
2013-06-10 18:31:59 +00:00
Arnaud Sourioux
8830d86fd4
Bug 870516: Annotate ~600 more methods with MOZ_OVERRIDE in /layout r=dholbert
2013-05-14 09:33:23 -07:00
Mats Palmgren
377ee51cc1
Bug 866785 - Move repeated nsIFrame::List implementations code to a new method, ListGeneric, for re-use. Cleanup and improve the code a bit. r=roc
...
Specifically:
* move all the frame dump methods to nsIFrame. Especially nsFrame::ListTag
was annoying, often requiring a cast to nsFrame*.
* print common values in the same order for all types of frames
* print fluid continuations as "next-in-flow=%p" and non-fluid as
"next-continuation=%p" (as before)
* print the style-context more compactly, e.g.
"[sc=0x7faa6b60e0a0] pst=:first-line" becomes
"[sc=0x7faa6b60e0a0:first-line]"
* suppress printing visual/scroll-overflow rects when they are identical
to mRect and do the same for nsLineBox::List where it was especially
hard to see which lines actually had real overflow
* fix a bug that printed the child list name at the far right when the
principal list was empty (making it hard to see)
* print the address of child lists (other than the principal list) to
help debug frame list property bugs
* s/NS_IMETHODIMP/void/
2013-04-30 20:38:52 +02:00
Mats Palmgren
868d2c33cd
Bug 729519 - Allocate heap nsFrameLists from the shell arena. r=bzbarsky
...
"new nsFrameList()" becomes "new (shell) nsFrameList()".
"delete list" becomes "if (list) list->Delete(shell)" - note also that
an additional assertion was added that list is empty when deleted.
"nsAutoPtr<nsFrameList> list(StealSomeFrames())" becomes
"AutoFrameListPtr list(aPresContext, StealSomeFrames())"
2013-04-01 17:26:02 +02:00
Mats Palmgren
0a2dd498d0
Bug 729519 - Make frames destroy all child frames and remove their nsFrameList properties when destroyed. r=bzbarsky
...
Specifically, this wasn't done for the OutsideBullet list which was
destroyed by the property destructor, potentially after the entire
frame tree was gone. Now we'll assert that the property destructor
isn't called.
Use SafelyDestroyFrameListProp when destroying PushedFloat and
OverflowOutOfFlows frame lists since it's more robust.
Destroy [Excess]OverflowContainers frame lists if they exist, regardless
of the IsFrameOfType(nsIFrame::eCanContainOverflowContainers) bit
(since the oveflow continuation tracker doesn't check that before
creating these lists -- this was the source of crash bugs before
that bit was added to ColumnSetFrame).
Assert in SetPropTableFrames that the property doesn't exist, because
if it does the property destructor will run, which isn't supported.
2013-04-01 17:26:02 +02:00
Mats Palmgren
9b9ada1410
Bug 729519 - Simplify DestroyOverflowList() by requiring that the list is empty. r=bzbarsky
2013-04-01 17:26:02 +02:00
Mats Palmgren
ae9655d975
Bug 852670 - Make nsContainerFrame::SetPropTableFrames return void since it's infallible. r=bzbarsky
2013-03-23 21:10:33 +01:00
Boris Zbarsky
c0d4537026
Bug 852428 part 2. Make nsIFrame::Init infallible. r=dholbert
2013-03-19 21:47:48 -04:00
Boris Zbarsky
227171bc03
Bug 852428 part 1. Make CreateViewForFrame infallible. r=dholbert
2013-03-19 21:47:47 -04:00
Mats Palmgren
02efff6847
Bug 850964 - Remove obsolete NS_FRAME_INVALIDATE_ON_MOVE flag. r=roc
2013-03-15 23:32:35 +01:00
Scott Johnson
57693da492
Bug 762902: Add a new ReflowChild flag within nsContainerState to disable deletion of next-in-flow children to prevent crash. [r=mats]
2013-03-15 13:36:30 -05:00
Ed Morley
7b377d8510
Backed out changeset 4bfe5e636d68 (bug 850964) for assertions on a CLOSED TREE
2013-03-14 15:19:06 +00:00
Mats Palmgren
f8e24f4117
Bug 850964 - Remove obsolete NS_FRAME_INVALIDATE_ON_MOVE flag. r=roc
2013-03-14 14:39:26 +01:00
Mats Palmgren
0dbc280f77
Bug 838642 - Remove nsContainerFrame::RemovePropTableFrame which is now unused. r=bzbarsky
2013-02-28 00:05:45 +01:00