Commit Graph

18 Commits

Author SHA1 Message Date
Nathan Froyd
92a8124fef Bug 1161627 - part 2 - machine-convert TemporaryRef<T> to already_AddRefed<T>; r=ehsan
This conversion was done with the script:

  find . -name '*.cpp' -o -name '*.h' -o -name '*.mm' -o -name '*.idl' | \
    egrep -v 'cairo-win32-refptr.h|RefPtr.h|TestRefPtr.cpp' | \
    xargs sed -i -e 's/mozilla::TemporaryRef</already_AddRefed</g' \
                 -e 's/TemporaryRef</already_AddRefed</g'

Manual fixups were performed in the following instances:

- We handled mfbt/RefPtr.h manually so as to not convert TemporaryRef itself
  into already_AddRefed.

- The following files had explicit Move() calls added to make up for the lack
  of a copy constructor on already_AddRefed:

  dom/base/ImageEncoder.cpp
  dom/media/MediaTaskQueue.{h,cpp}
  dom/media/webaudio/PannerNode.cpp

- A redundant overload for MediaTaskQueue::Dispatch was deleted.

- A few manual fixups were required in mfbt/tests/TestRefPtr.cpp.

- Comments, using declarations, and forward declarations relating to
  TemporaryRef in dom/canvas/ and gfx/layers/ were changed to refer to
  already_AddRefed.
2015-06-17 10:00:52 -04:00
Nathan Froyd
43cddcfc0d Bug 1160485 - remove implicit conversion from RefPtr<T> to TemporaryRef<T>; r=ehsan
Having this implicit conversion means that we can silently do extra
refcounting when it's completely unnecessary.  It's also an obstacle to
making RefPtr more nsRefPtr-like, so let's get rid of it.
2015-05-01 09:14:16 -04:00
Dave Hylands
c3c4d6b413 Bug 1119907 - Cleanup some errors when USE_DEBUG is enabled in the AutoMounter. 2015-01-09 15:29:15 -08:00
Botond Ballo
b1497e9c1d Bug 1073003 - Fix -Wunused-variable / -Wunused-but-set-variable warnings. r=ehsan 2014-12-31 16:49:13 -05:00
CHUANG CHENYU
6056969a81 Bug 1033952 - Implement "Removable" and "HotSwappable" APIs for device storage. r=dhylands, r=bzbarsky 2014-12-22 10:33:33 +08:00
Dave Hylands
b884060207 Bug 1085743 - MTP doesn't work on Nexus 4/5. r=alchen 2014-11-13 17:42:38 -08:00
Ehsan Akhgari
d92ab797b1 Bug 1072701 - Build some Firefox OS specific DOM code in unified mode; r=baku 2014-09-25 10:10:42 -04:00
Birunthan Mohanathas
87889c27b7 Bug 784739 - Switch from NULL to nullptr in dom/ (2/2); r=ehsan 2013-10-28 10:04:47 -04:00
Dave Hylands
4c68e4054e Bug 785124 - Pt 4 - Whitespace only change. Change "type &var" to "type& var" and ptrs. r=dougt 2013-01-07 17:43:02 +01:00
Phil Ringnalda
d137321fea Back out 6737ce4d3ce6:599c37ed628c (bug 785124) for b2g Arm xpcshell orange in update tests 2013-01-07 22:59:32 -08:00
Dave Hylands
d2c7d9fdc4 Bug 785124 - Pt 4 - Whitespace only change. Change "type &var" to "type& var" and ptrs. r=dougt 2013-01-07 17:43:02 +01:00
Steven Lee
661fa5cc55 Bug 805478 - NetdClient and VolumeManager inherit MessageLoopForIO::LineWatcher. r=dhylands 2012-11-08 14:35:02 -05:00
Justin Lebar
1d73f1ec9c Bug 792940 - Minor cleanups in VolumeManager.{h,cpp} (remove unused variable and use StaticRefPtr instead of |static nsRefPtr|). r=dhylands 2012-09-20 15:15:22 -04:00
Dave Hylands
76f178a2cd Bug 777259 - Launch VolumeService earlier to prevent races on retrieving Volume information 2012-08-09 20:40:05 -07:00
Dave Hylands
3e91a07c92 Bug 766324 - Add a volume IDL to make volumes scriptable r=qdot 2012-07-16 12:38:18 -04:00
Dave Hylands
0c508515b1 Bug 766296 - Make AutoMounter notice SD Card insertion and removal r=qdot 2012-07-16 12:38:18 -04:00
Dave Hylands
4464a50878 Bug 764228: Add Volume event notifications r=qDot 2012-07-16 12:38:18 -04:00
Dave Hylands
a7dad82b08 Bug 737153 - Enable mounting storage through USB from a host machine - Add the VolumeManager, sr=cjones r=qDot 2012-05-24 21:03:07 -07:00